Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2146085/?format=api
{ "id": 2146085, "url": "http://patchwork.ozlabs.org/api/patches/2146085/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20251006101057.4172248-3-anshuld@ti.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251006101057.4172248-3-anshuld@ti.com>", "list_archive_url": null, "date": "2025-10-06T10:10:50", "name": "[-next,v3,2/7] spl: mmc: split spl_mmc_do_fs_boot into regular/os_boot", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "97a6e98229cce45649318b5c34df663908fcf1c0", "submitter": { "id": 90324, "url": "http://patchwork.ozlabs.org/api/people/90324/?format=api", "name": "Anshul Dalal", "email": "anshuld@ti.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20251006101057.4172248-3-anshuld@ti.com/mbox/", "series": [ { "id": 476383, "url": "http://patchwork.ozlabs.org/api/series/476383/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=476383", "date": "2025-10-06T10:10:48", "name": "Add support for secure falcon mode: disable fallback", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/476383/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2146085/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2146085/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=ti-com-17Q1 header.b=eSSmH7u3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"eSSmH7u3\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de; spf=pass smtp.mailfrom=anshuld@ti.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4cgFRN3Lq8z1yGb\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 6 Oct 2025 21:11:28 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 682C783693;\n\tMon, 6 Oct 2025 12:11:11 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 65A3283655; Mon, 6 Oct 2025 12:11:10 +0200 (CEST)", "from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4B44C835FE\n for <u-boot@lists.denx.de>; Mon, 6 Oct 2025 12:11:08 +0200 (CEST)", "from fllvem-sh03.itg.ti.com ([10.64.41.86])\n by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTP id 596AB4LG3977151;\n Mon, 6 Oct 2025 05:11:04 -0500", "from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23])\n by fllvem-sh03.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 596AB4Vn3234369\n (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL);\n Mon, 6 Oct 2025 05:11:04 -0500", "from DFLE206.ent.ti.com (10.64.6.64) by DFLE102.ent.ti.com\n (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Mon, 6\n Oct 2025 05:11:04 -0500", "from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE206.ent.ti.com\n (10.64.6.64) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Mon, 6 Oct 2025 05:11:04 -0500", "from localhost (dhcp-172-24-233-105.dhcp.ti.com [172.24.233.105])\n by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 596AB3ks3511627;\n Mon, 6 Oct 2025 05:11:03 -0500" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;\n s=ti-com-17Q1; t=1759745464;\n bh=A6+XXdfRXAxrnyC4HoLyFsSzpfFtHPZdrwDLqJ+kWDs=;\n h=From:To:CC:Subject:Date:In-Reply-To:References;\n b=eSSmH7u3RL+dRjecxAKgw7H8O2cWImC/+mlkJT00LgyD14dpsWQ48P6FHW0EGSxRd\n /hf9EMQUunr5li+8YbVKv6YwH++Jx9wCV3r1ECtWkMutIrYLZnzPkAQo7reYp3e1q+\n pI+oVWZd9wsfuOQs3FXTbjm2G7heLtXqeMt+bqac=", "From": "Anshul Dalal <anshuld@ti.com>", "To": "<u-boot@lists.denx.de>", "CC": "Anshul Dalal <anshuld@ti.com>, <vigneshr@ti.com>, <trini@konsulko.com>,\n <afd@ti.com>, <m-chawdhry@ti.com>, <n-francis@ti.com>, <b-liu@ti.com>,\n <nm@ti.com>, <bb@ti.com>, <kever.yang@rock-chips.com>,\n <hl@rock-chips.com>, <tim@feathertop.org>,\n <marek.vasut+renesas@mailbox.org>", "Subject": "[PATCH -next v3 2/7] spl: mmc: split spl_mmc_do_fs_boot into\n regular/os_boot", "Date": "Mon, 6 Oct 2025 15:40:50 +0530", "Message-ID": "<20251006101057.4172248-3-anshuld@ti.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251006101057.4172248-1-anshuld@ti.com>", "References": "<20251006101057.4172248-1-anshuld@ti.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-C2ProcessedOrg": "333ef613-75bf-4e12-a4b1-8e3623f5dcea", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Currently the logic to handle falcon mode as well as the regular boot is\ninside spl_mmc_do_fs_boot, this prevents us from cleanly extending\nfalcon mode functionality like toggleable fallback to U-Boot proper.\n\nTherefore this patch splits the logic into spl_mmc_fs_load and\nspl_mmc_fs_load_os to handle the regular boot and falcon mode use case.\n\nSigned-off-by: Anshul Dalal <anshuld@ti.com>\n---\n common/spl/spl_mmc.c | 80 +++++++++++++++++++++++++++-----------------\n 1 file changed, 50 insertions(+), 30 deletions(-)", "diff": "diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c\nindex cd56cf71055..c5585d8e0d2 100644\n--- a/common/spl/spl_mmc.c\n+++ b/common/spl/spl_mmc.c\n@@ -193,6 +193,46 @@ int spl_start_uboot(void)\n }\n #endif\n \n+static int spl_mmc_fs_load_os(struct spl_image_info *spl_image,\n+\t\t\t struct spl_boot_device *bootdev,\n+\t\t\t struct blk_desc *blk_dev, int part)\n+{\n+\tint err = -ENOSYS;\n+\n+\tif (CONFIG_IS_ENABLED(FS_FAT)) {\n+\t\terr = spl_load_image_fat_os(spl_image, bootdev, blk_dev, part);\n+\t\tif (!err)\n+\t\t\treturn 0;\n+\t}\n+\tif (CONFIG_IS_ENABLED(FS_EXT4)) {\n+\t\terr = spl_load_image_ext_os(spl_image, bootdev, blk_dev, part);\n+\t\tif (!err)\n+\t\t\treturn 0;\n+\t}\n+\n+\treturn err;\n+}\n+\n+static int spl_mmc_fs_load(struct spl_image_info *spl_image,\n+\t\t\t struct spl_boot_device *bootdev,\n+\t\t\t struct blk_desc *blk_dev, int part, const char *file)\n+{\n+\tint err = -ENOENT;\n+\n+\tif (CONFIG_IS_ENABLED(FS_FAT)) {\n+\t\terr = spl_load_image_fat(spl_image, bootdev, blk_dev, part, file);\n+\t\tif (!err)\n+\t\t\treturn 0;\n+\t}\n+\tif (CONFIG_IS_ENABLED(FS_EXT4)) {\n+\t\terr = spl_load_image_ext(spl_image, bootdev, blk_dev, part, file);\n+\t\tif (!err)\n+\t\t\treturn 0;\n+\t}\n+\n+\treturn err;\n+}\n+\n #ifdef CONFIG_SYS_MMCSD_FS_BOOT\n static int spl_mmc_do_fs_boot(struct spl_image_info *spl_image,\n \t\t\t struct spl_boot_device *bootdev,\n@@ -225,42 +265,22 @@ static int spl_mmc_do_fs_boot(struct spl_image_info *spl_image,\n \t}\n #endif\n \n-#ifdef CONFIG_SPL_FS_FAT\n \tif (!spl_start_uboot()) {\n-\t\tret = spl_load_image_fat_os(spl_image, bootdev, mmc_get_blk_desc(mmc),\n-\t\t\t\t\t partition);\n+\t\tret = spl_mmc_fs_load_os(spl_image, bootdev,\n+\t\t\t\t\t mmc_get_blk_desc(mmc), partition);\n \t\tif (!ret)\n \t\t\treturn 0;\n+\t\tprintf(\"%s, Failed to load falcon payload: %d\\n\", __func__,\n+\t\t ret);\n+\t\tprintf(\"Fallback to U-Boot\\n\");\n \t}\n-#ifdef CONFIG_SPL_FS_LOAD_PAYLOAD_NAME\n-\tret = spl_load_image_fat(spl_image, bootdev, mmc_get_blk_desc(mmc),\n-\t\t\t\t partition,\n-\t\t\t\t filename);\n-\tif (!ret)\n-\t\treturn ret;\n-#endif\n-#endif\n-#ifdef CONFIG_SPL_FS_EXT4\n-\tif (!spl_start_uboot()) {\n-\t\tret = spl_load_image_ext_os(spl_image, bootdev, mmc_get_blk_desc(mmc),\n-\t\t\t\t\t partition);\n-\t\tif (!ret)\n-\t\t\treturn 0;\n-\t}\n-#ifdef CONFIG_SPL_FS_LOAD_PAYLOAD_NAME\n-\tret = spl_load_image_ext(spl_image, bootdev, mmc_get_blk_desc(mmc),\n-\t\t\t\t partition,\n-\t\t\t\t filename);\n-\tif (!ret)\n-\t\treturn 0;\n-#endif\n-#endif\n-\n-#if defined(CONFIG_SPL_FS_FAT) || defined(CONFIG_SPL_FS_EXT4)\n-\tret = -ENOENT;\n-#endif\n \n+#ifdef CONFIG_SPL_FS_LOAD_PAYLOAD_NAME\n+\treturn spl_mmc_fs_load(spl_image, bootdev, mmc_get_blk_desc(mmc),\n+\t\t\t partition, filename);\n+#else\n \treturn ret;\n+#endif\n }\n #endif\n \n", "prefixes": [ "-next", "v3", "2/7" ] }