Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2140915/?format=api
{ "id": 2140915, "url": "http://patchwork.ozlabs.org/api/patches/2140915/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250923124639.667718-3-anshuld@ti.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250923124639.667718-3-anshuld@ti.com>", "list_archive_url": null, "date": "2025-09-23T12:46:36", "name": "[v3,2/4] spl: ext: load kernel image before args in falcon", "commit_ref": "50953dd5cd8063e0902335c1588997e3ce12994c", "pull_url": null, "state": "accepted", "archived": false, "hash": "55311a8fbebc53b50987ec29326ffecccc0ba5d7", "submitter": { "id": 90324, "url": "http://patchwork.ozlabs.org/api/people/90324/?format=api", "name": "Anshul Dalal", "email": "anshuld@ti.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250923124639.667718-3-anshuld@ti.com/mbox/", "series": [ { "id": 474844, "url": "http://patchwork.ozlabs.org/api/series/474844/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=474844", "date": "2025-09-23T12:46:35", "name": "Add support for secure falcon mode: load kernel image before args", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/474844/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2140915/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2140915/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=ti-com-17Q1 header.b=F+Ej0KgO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"F+Ej0KgO\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de; spf=pass smtp.mailfrom=anshuld@ti.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4cWKW215VZz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 23 Sep 2025 22:47:10 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id CE1468353A;\n\tTue, 23 Sep 2025 14:46:53 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 4ADC78350A; Tue, 23 Sep 2025 14:46:52 +0200 (CEST)", "from lelvem-ot01.ext.ti.com (lelvem-ot01.ext.ti.com [198.47.23.234])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 38DF68344E\n for <u-boot@lists.denx.de>; Tue, 23 Sep 2025 14:46:49 +0200 (CEST)", "from fllvem-sh04.itg.ti.com ([10.64.41.54])\n by lelvem-ot01.ext.ti.com (8.15.2/8.15.2) with ESMTP id 58NCkkGk1004647;\n Tue, 23 Sep 2025 07:46:46 -0500", "from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21])\n by fllvem-sh04.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 58NCkkTN2782641\n (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL);\n Tue, 23 Sep 2025 07:46:46 -0500", "from DFLE206.ent.ti.com (10.64.6.64) by DFLE100.ent.ti.com\n (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Tue, 23\n Sep 2025 07:46:45 -0500", "from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE206.ent.ti.com\n (10.64.6.64) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Tue, 23 Sep 2025 07:46:45 -0500", "from localhost (dhcp-172-24-233-105.dhcp.ti.com [172.24.233.105])\n by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 58NCkiV2313799;\n Tue, 23 Sep 2025 07:46:45 -0500" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;\n s=ti-com-17Q1; t=1758631606;\n bh=gEPMYIQPvJPcMomoi6xYSu4MZnL2bO93PnPVCmAvbMI=;\n h=From:To:CC:Subject:Date:In-Reply-To:References;\n b=F+Ej0KgOzMU5TCts4/r9F0LbMWm6iC2xx4355VAUY00uWRZGAe6nkweLnh2VvgBYw\n lVV6rFJ1h4Hsmr0/PBTj0e0qHvg4jpZUvTWl2PCa3MmRZsV9Mgj7GJZw+spG63oF4W\n m6udcBS2WFNVjMoNh0T4nJ1sjrF06fnq5A0EYwJk=", "From": "Anshul Dalal <anshuld@ti.com>", "To": "<u-boot@lists.denx.de>", "CC": "Anshul Dalal <anshuld@ti.com>, <vigneshr@ti.com>, <trini@konsulko.com>,\n <afd@ti.com>, <m-chawdhry@ti.com>, <n-francis@ti.com>, <b-liu@ti.com>,\n <nm@ti.com>, <bb@ti.com>, <kever.yang@rock-chips.com>,\n <hl@rock-chips.com>, <tim@feathertop.org>,\n <marek.vasut+renesas@mailbox.org>", "Subject": "[PATCH v3 2/4] spl: ext: load kernel image before args in falcon", "Date": "Tue, 23 Sep 2025 18:16:36 +0530", "Message-ID": "<20250923124639.667718-3-anshuld@ti.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20250923124639.667718-1-anshuld@ti.com>", "References": "<20250923124639.667718-1-anshuld@ti.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-C2ProcessedOrg": "333ef613-75bf-4e12-a4b1-8e3623f5dcea", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Load the kernel image before args in falcon mode to be consistent with\nthe load order for other boot media.\n\nReviewed-by: Tom Rini <trini@konsulko.com>\nSigned-off-by: Anshul Dalal <anshuld@ti.com>\n---\n common/spl/spl_ext.c | 56 +++++++++++++++++++++++++++-----------------\n 1 file changed, 34 insertions(+), 22 deletions(-)", "diff": "diff --git a/common/spl/spl_ext.c b/common/spl/spl_ext.c\nindex 7e0274a3058..80bd084db4e 100644\n--- a/common/spl/spl_ext.c\n+++ b/common/spl/spl_ext.c\n@@ -96,40 +96,53 @@ int spl_load_image_ext_os(struct spl_image_info *spl_image,\n #endif\n \t\treturn -1;\n \t}\n-#if defined(CONFIG_SPL_ENV_SUPPORT)\n-\tfile = env_get(\"falcon_args_file\");\n+\n+\tif (!CONFIG_IS_ENABLED(ENV_SUPPORT))\n+\t\tgoto defaults;\n+\n+\tfile = env_get(\"falcon_image_file\");\n \tif (file) {\n-\t\terr = ext4fs_open(file, &filelen);\n-\t\tif (err < 0) {\n-\t\t\tputs(\"spl: ext4fs_open failed\\n\");\n-\t\t\tgoto defaults;\n-\t\t}\n-\t\terr = ext4fs_read((void *)CONFIG_SPL_PAYLOAD_ARGS_ADDR, 0, filelen, &actlen);\n-\t\tif (err < 0) {\n-\t\t\tprintf(\"spl: error reading image %s, err - %d, falling back to default\\n\",\n-\t\t\t file, err);\n+\t\terr = spl_load_image_ext(spl_image, bootdev, block_dev,\n+\t\t\t\t\t partition, file);\n+\t\tif (err != 0) {\n+\t\t\tputs(\"spl: falling back to default\\n\");\n \t\t\tgoto defaults;\n \t\t}\n-\t\tfile = env_get(\"falcon_image_file\");\n+\n+\t\text4fs_set_blk_dev(block_dev, &part_info);\n+\t\text4fs_mount();\n+\t\tfile = env_get(\"falcon_args_file\");\n \t\tif (file) {\n-\t\t\terr = spl_load_image_ext(spl_image, bootdev, block_dev,\n-\t\t\t\t\t\t partition, file);\n-\t\t\tif (err != 0) {\n-\t\t\t\tputs(\"spl: falling back to default\\n\");\n+\t\t\terr = ext4fs_open(file, &filelen);\n+\t\t\tif (err < 0) {\n+\t\t\t\tputs(\"spl: ext4fs_open failed\\n\");\n+\t\t\t\tgoto defaults;\n+\t\t\t}\n+\t\t\terr = ext4fs_read((void *)CONFIG_SPL_PAYLOAD_ARGS_ADDR,\n+\t\t\t\t\t 0, filelen, &actlen);\n+\t\t\tif (err < 0) {\n+\t\t\t\tprintf(\"spl: error reading args %s, err - %d, falling back to default\\n\",\n+\t\t\t\t file, err);\n \t\t\t\tgoto defaults;\n \t\t\t}\n-\n \t\t\treturn 0;\n \t\t} else {\n-\t\t\tputs(\"spl: falcon_image_file not set in environment, falling back to default\\n\");\n+\t\t\tputs(\"spl: falcon_args_file not set in environment, falling back to default\\n\");\n \t\t}\n \t} else {\n-\t\tputs(\"spl: falcon_args_file not set in environment, falling back to default\\n\");\n+\t\tputs(\"spl: falcon_image_file not set in environment, falling back to default\\n\");\n \t}\n \n defaults:\n-#endif\n \n+\terr = spl_load_image_ext(spl_image, bootdev, block_dev, partition,\n+\t\t\t\t CONFIG_SPL_FS_LOAD_KERNEL_NAME);\n+\n+\tif (err)\n+\t\treturn err;\n+\n+\text4fs_set_blk_dev(block_dev, &part_info);\n+\text4fs_mount();\n \terr = ext4fs_open(CONFIG_SPL_FS_LOAD_ARGS_NAME, &filelen);\n \tif (err < 0)\n \t\tputs(\"spl: ext4fs_open failed\\n\");\n@@ -143,8 +156,7 @@ defaults:\n \t\treturn -1;\n \t}\n \n-\treturn spl_load_image_ext(spl_image, bootdev, block_dev, partition,\n-\t\t\tCONFIG_SPL_FS_LOAD_KERNEL_NAME);\n+\treturn 0;\n }\n #else\n int spl_load_image_ext_os(struct spl_image_info *spl_image,\n", "prefixes": [ "v3", "2/4" ] }