Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2124265/?format=api
{ "id": 2124265, "url": "http://patchwork.ozlabs.org/api/patches/2124265/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250806-phy-cadence-sierra-v2-2-f2d309b170e2@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250806-phy-cadence-sierra-v2-2-f2d309b170e2@linaro.org>", "list_archive_url": null, "date": "2025-08-18T10:44:29", "name": "[v2,2/2] phy: cadence: torrent: Set an error code for return", "commit_ref": "c4526c390a3c4ea1c4f244b6436ebbb74902769a", "pull_url": null, "state": "accepted", "archived": false, "hash": "07d8146cfa84652a7abd1a9cb7dd934ac7648566", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250806-phy-cadence-sierra-v2-2-f2d309b170e2@linaro.org/mbox/", "series": [ { "id": 469646, "url": "http://patchwork.ozlabs.org/api/series/469646/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=469646", "date": "2025-08-18T10:44:27", "name": "phy: cadence: Fix two Smatch reported issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/469646/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2124265/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2124265/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=cUaQrS2r;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"cUaQrS2r\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4c58VT3wNGz1xv2\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 18 Aug 2025 20:44:49 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 9C806801DD;\n\tMon, 18 Aug 2025 12:44:35 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 1BC6D82BCD; Mon, 18 Aug 2025 12:44:34 +0200 (CEST)", "from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n [IPv6:2a00:1450:4864:20::32a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 48AC78211F\n for <u-boot@lists.denx.de>; Mon, 18 Aug 2025 12:44:31 +0200 (CEST)", "by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-45a1b00e4a1so26091495e9.0\n for <u-boot@lists.denx.de>; Mon, 18 Aug 2025 03:44:31 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:69b5:38a0:910b:c9c8])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3bb652f75aesm12293643f8f.23.2025.08.18.03.44.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 18 Aug 2025 03:44:30 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1755513871; x=1756118671; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=MYkTfxUaNShseXoYhFDZefL1wRCTEwkg8adkAlfhu/4=;\n b=cUaQrS2rPgIqFewai+iZkRs9m6Z4Q3UwKTUZveDbIaT0zo7yDTZEQBzlPi8cwq6G6P\n 0APIZ3BZQ7Ra+0M2ALxkYmf4qIDPPnnFY/wECkQUlKUPQcw+lv+6VheANZ2XXZyvTtqb\n iZtPWxV4Z+LtcVgdXui84nvqI1ZhfyDHv7qa3X3PkEuhkLmfzSm4QFT0BTZaVw9KX/Br\n PE/w/JGaeukbAof78WWka4C1zDj3OIBwwJOYaLLRLN9yh/Jfh/k3RiL5Wt7RVIa77qCM\n BFF3PSKLwbn9b5D70q6Vv2721HCbbHkhEi1yxJS6XmWfz0gc9ifpX0BxXre4oUAhp/Ov\n hVgQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1755513871; x=1756118671;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=MYkTfxUaNShseXoYhFDZefL1wRCTEwkg8adkAlfhu/4=;\n b=kiMglgOjFi1fedXcoHCgZIBEOa5TZTm/qtJQQt04hl0Z6LttNZ1HHuYDRAZQkRW/F4\n HYcfd+hZ1lZgxp0zHRbKO07nOrMDsmbfnYdcW1oaFmNxVy2vy72odXzdHbdyLuOxwRy3\n dvqP7X8ZqKIoCd2uzRhwJWM7fc39ggth1TKX5UY/a6TadPOV9vJuFJLdGXbhrCYw7Q0x\n dUnFl3rU9rStE/O6lquWosByfcnY96wlxwHSvZfYfn+YfuZYUHjddWxEhO+UhOACPz4y\n B34GqKjmrvtCWxvX+i9EtKKD2qiaWgMD2cbnFBncavBVxneTzoSSoFXihFpYG4hi5p4F\n eFng==", "X-Gm-Message-State": "AOJu0Yz+I7ElY2qtO0ZMTrk/qe0kh/3P26FQLrtQc2qPFFqn6KZMCPa4\n +vv1FzChIDI+UatlwspR+BHMLFOTSeXKfU22tMqKqazowQ7KsO3GD0QGKEzJyyjbBVWUzLavM/u\n sbeQF", "X-Gm-Gg": "ASbGnctg5F+9PV5Wrz5Tv01ocx+LnxALwaIYG+wBfPpg5foZ/cI9K0w+qQ8m1XZ4MEN\n BRHjPnt+S8y9JRLD2rzvBHmRzXv5WMmhWWG/MXmuIqjAsKv6jh2GFaQuQiWzAsdnvJXMAdUgk+0\n BBB8EnVyt4kSUp4TEEJu+k+i1hXTFikpznK4WB/REmYbl3uLoERyfG8V1bmomiJYbDFqsfwSPzi\n emOZTyCGgOV4HDMawgkPdd79va9i0TZOn2d/yHdV5r6WjFqcbufgtkDEBmlTHPRXs6SOdyXrsb2\n yqqkjRSpPcryMg8Wj0dXVVaco58WTyOeR1w7goFYg2WhRu5Ubb4gILTkohPJGiAmn84GR4zpERy\n 7rOM+B1WqrvuJmeIJavCXOrzZpidoWid41JIqi1qXDcphy0tySME=", "X-Google-Smtp-Source": "\n AGHT+IE3Lk/N0QfVy3riWjZPufDpe8HPHJZgdQRu9SrFpyx7vmycZgyg1OhhlmVuiH8T9FpW3rR1cA==", "X-Received": "by 2002:a05:600c:19d3:b0:458:b01c:8f with SMTP id\n 5b1f17b1804b1-45a217fd389mr75755505e9.8.1755513870580;\n Mon, 18 Aug 2025 03:44:30 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Mon, 18 Aug 2025 11:44:29 +0100", "Subject": "[PATCH v2 2/2] phy: cadence: torrent: Set an error code for return", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250806-phy-cadence-sierra-v2-2-f2d309b170e2@linaro.org>", "References": "<20250806-phy-cadence-sierra-v2-0-f2d309b170e2@linaro.org>", "In-Reply-To": "<20250806-phy-cadence-sierra-v2-0-f2d309b170e2@linaro.org>", "To": "Tom Rini <trini@konsulko.com>,\n Jerome Forissier <jerome.forissier@linaro.org>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In cdns_torrent_phy_probe the test for too many lanes configured does\nnot set an error code before taking the error path. This could lead to a\nsilent failure if the calling code does not detect the error. Add the\ncode to return -EINVAL in this case.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/phy/cadence/phy-cadence-torrent.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c\nindex 1f566d082f9..28fe026223c 100644\n--- a/drivers/phy/cadence/phy-cadence-torrent.c\n+++ b/drivers/phy/cadence/phy-cadence-torrent.c\n@@ -719,6 +719,7 @@ static int cdns_torrent_phy_probe(struct udevice *dev)\n \n \tif (total_num_lanes > MAX_NUM_LANES) {\n \t\tdev_err(dev, \"Invalid lane configuration\\n\");\n+\t\tret = -EINVAL;\n \t\tgoto put_lnk_rst;\n \t}\n \n", "prefixes": [ "v2", "2/2" ] }