Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2124264/?format=api
{ "id": 2124264, "url": "http://patchwork.ozlabs.org/api/patches/2124264/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250806-phy-cadence-sierra-v2-1-f2d309b170e2@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250806-phy-cadence-sierra-v2-1-f2d309b170e2@linaro.org>", "list_archive_url": null, "date": "2025-08-18T10:44:28", "name": "[v2,1/2] phy: cadence: sierra: Remove variable that is not assigned to", "commit_ref": "783ea37c7b52ae088e8c64581fbe412b5dc9a878", "pull_url": null, "state": "accepted", "archived": false, "hash": "7db0bfece0c9339cba19dce10a00e01f0b196c86", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250806-phy-cadence-sierra-v2-1-f2d309b170e2@linaro.org/mbox/", "series": [ { "id": 469646, "url": "http://patchwork.ozlabs.org/api/series/469646/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=469646", "date": "2025-08-18T10:44:27", "name": "phy: cadence: Fix two Smatch reported issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/469646/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2124264/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2124264/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=DDUdoK0M;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"DDUdoK0M\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4c58VB6rxxz1xv2\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 18 Aug 2025 20:44:34 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 52E1382A53;\n\tMon, 18 Aug 2025 12:44:33 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 4429880107; Mon, 18 Aug 2025 12:44:32 +0200 (CEST)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n [IPv6:2a00:1450:4864:20::42c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 56E4F81D5D\n for <u-boot@lists.denx.de>; Mon, 18 Aug 2025 12:44:30 +0200 (CEST)", "by mail-wr1-x42c.google.com with SMTP id\n ffacd0b85a97d-3b9edf4cf6cso3749010f8f.3\n for <u-boot@lists.denx.de>; Mon, 18 Aug 2025 03:44:30 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:69b5:38a0:910b:c9c8])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3bb652f75aesm12293643f8f.23.2025.08.18.03.44.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 18 Aug 2025 03:44:29 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1755513870; x=1756118670; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=iqh+eeI/lw+ZZbK/vCKSTtUpOtrwC5RdyH+LMCAk/Tk=;\n b=DDUdoK0MG+5i1u7zhCxKspXeLjHXr6LZpayOPFHLe8jD+1u63Ce7qq5xuyd+86zVEd\n k41Gb3RWJv6cwaE4vZJFV4OCAuXnGTeIRimmpTyCrbPqkxeXetvGKNMajG6tZ00v13hJ\n wVeeHmfXXatZavieOGmfF8NNop2HdMi+X9+1iHkhv1dH1jJHI1GXw0Fib4HXgtql3eyl\n L1kKx46UlVvNiIiJz1xw9rhV1TQtUNVNGWFv/J1hjMBI0obrECYgt5LcaWqaff6zDo34\n o6id4EtQoe7s3DhKktLDtoCL6fKSOSayrRvrKKBaH3nLW+22sr5Qw0VDVky7GuIMVEW/\n Iq0g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1755513870; x=1756118670;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=iqh+eeI/lw+ZZbK/vCKSTtUpOtrwC5RdyH+LMCAk/Tk=;\n b=dXCfz601iv7JaiCuWeJwrl6Dzrt1ft4l8kEPrDun0OW/xcisJ8iByd+ukuC5gkFNHM\n NEq7KBcL6aeybw576Dee5BQmNFhe9s24G5BdV+ni0CD/7V3lPdk89KrBZ61qsEWyRVxd\n ZCqWGv3XRDkSDL7n8z4lvYzAWNw9SP+oU1RAxJBkOJCaJb4ROLVd2AfV3uGGDFu71saX\n VsshsmTBaRfLuNgaRFJZkn2gdW8ljBbTGoAnB43JzxBjZ/ignt9a4CSKNVViaM9vZgaO\n Z0091o4mvtAPIft6gvac3RfGY7D7Kce/DxUVOqndXnAa3sYnAqfI5ZSn90GxYb9rHz5t\n a0ug==", "X-Gm-Message-State": "AOJu0Yx4XqktQwV2Sl9jZai3zqIzR92F7scdBjWk8/yOxvhhIibcSyqg\n Pe5Q/HcGZeOFa9dXStbDRLinBeOog9yQO5RFEZolaRXSiN3D/mtbhaQupeee4PNh+h4=", "X-Gm-Gg": "ASbGncu8f3qHXxXhpiTdiTrcFoG0ezzAFY1lUP0iA3qhUqcMPUevzZH73diZp5B7H5Y\n Denq1Q3MbumK63qzhhWcbjLElZPbQTRA2UzrlgFcz9WjZsm1vDHeimQr4AoHjWnn3ZtFE7xkOsq\n jHFcSXOXyBZpqPDERBBrncNk/Cx3lC3os3qRcnn5yz8iHUkGQxfsOwLE+3RD5PAurW8T8hN/2Af\n dYpG69/mwAZSzJT0o7afOxtBJwoo6VSq2aZDCxxpDkLjPRD4M9HUDZo2SlG4xR+X4DqjVBQWIIF\n 0L/5Q4uxQFvbuHWGsTT3+R8bMrklyhf7rcpiSwbWboYthT/H5XI+t3+ERiIR1h2yv9wJiJVnYVj\n 0bsJ90CA9qYhLrh4e8GbNliFMWSfDNBmmDAlwhHtoV4e0n/Foko73DTKJTEUMIA==", "X-Google-Smtp-Source": "\n AGHT+IEXZX3bHvb2AAJBjoUKEs++73S/S2Zc6AagT7owV643um7pB49DGQupcGjAVz5LgjfUXHDEwg==", "X-Received": "by 2002:a05:6000:2409:b0:3b9:7c00:b6a9 with SMTP id\n ffacd0b85a97d-3bb68a1649amr8946782f8f.28.1755513869788;\n Mon, 18 Aug 2025 03:44:29 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Mon, 18 Aug 2025 11:44:28 +0100", "Subject": "[PATCH v2 1/2] phy: cadence: sierra: Remove variable that is not\n assigned to", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250806-phy-cadence-sierra-v2-1-f2d309b170e2@linaro.org>", "References": "<20250806-phy-cadence-sierra-v2-0-f2d309b170e2@linaro.org>", "In-Reply-To": "<20250806-phy-cadence-sierra-v2-0-f2d309b170e2@linaro.org>", "To": "Tom Rini <trini@konsulko.com>,\n Jerome Forissier <jerome.forissier@linaro.org>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In cdns_sierra_pll_bind_of_clocks the variable 'i' is declared but never\nassigned to before its value is used in a dev_err. There is nothing\nobvious to assign to 'i' so remove its use and just put a default of 0\nin the dev_err call in its place.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/phy/cadence/phy-cadence-sierra.c | 13 +++----------\n 1 file changed, 3 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c\nindex 2c9d5a12127..bd7ab9d1b77 100644\n--- a/drivers/phy/cadence/phy-cadence-sierra.c\n+++ b/drivers/phy/cadence/phy-cadence-sierra.c\n@@ -225,11 +225,6 @@ static const struct reg_field pllctrl_lock =\n static const struct reg_field phy_iso_link_ctrl_1 =\n \t\t\t\tREG_FIELD(SIERRA_PHY_ISO_LINK_CTRL, 1, 1);\n \n-static const char * const clk_names[] = {\n-\t[CDNS_SIERRA_PLL_CMNLC] = \"pll_cmnlc\",\n-\t[CDNS_SIERRA_PLL_CMNLC1] = \"pll_cmnlc1\",\n-};\n-\n enum cdns_sierra_cmn_plllc {\n \tCMN_PLLLC,\n \tCMN_PLLLC1,\n@@ -602,7 +597,7 @@ static int cdns_sierra_pll_bind_of_clocks(struct cdns_sierra_phy *sp)\n \tstruct udevice *dev = sp->dev;\n \tstruct driver *cdns_sierra_clk_drv;\n \tstruct cdns_sierra_pll_mux_sel *data = pll_clk_mux_sel;\n-\tint i, rc;\n+\tint rc;\n \n \tcdns_sierra_clk_drv = lists_driver_lookup_name(\"cdns_sierra_mux_clk\");\n \tif (!cdns_sierra_clk_drv) {\n@@ -612,10 +607,8 @@ static int cdns_sierra_pll_bind_of_clocks(struct cdns_sierra_phy *sp)\n \n \trc = device_bind(dev, cdns_sierra_clk_drv, \"pll_mux_clk\",\n \t\t\t data, dev_ofnode(dev), NULL);\n-\tif (rc) {\n-\t\tdev_err(dev, \"cannot bind driver for clock %s\\n\",\n-\t\t\tclk_names[i]);\n-\t}\n+\tif (rc)\n+\t\tdev_err(dev, \"cannot bind driver for clock pll_mux_clk\\n\");\n \n \treturn 0;\n }\n", "prefixes": [ "v2", "1/2" ] }