Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2122108/?format=api
{ "id": 2122108, "url": "http://patchwork.ozlabs.org/api/patches/2122108/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250812124331.1464879-2-jerome.forissier@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250812124331.1464879-2-jerome.forissier@linaro.org>", "list_archive_url": null, "date": "2025-08-12T12:43:18", "name": "[v2,1/2] lwip: icmp: allow reporting ICMP destination unreachable", "commit_ref": "fbd79b493d943a2f41a78408cc99ca4ee4392b07", "pull_url": null, "state": "accepted", "archived": false, "hash": "38a1a0bb4fb8a334aea64fb5605d130a381a5304", "submitter": { "id": 69192, "url": "http://patchwork.ozlabs.org/api/people/69192/?format=api", "name": "Jerome Forissier", "email": "jerome.forissier@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250812124331.1464879-2-jerome.forissier@linaro.org/mbox/", "series": [ { "id": 468862, "url": "http://patchwork.ozlabs.org/api/series/468862/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=468862", "date": "2025-08-12T12:43:17", "name": "lwip: add Kconfig to decode and print ICMP unreachable messages", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/468862/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2122108/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2122108/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=mqNELplv;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"mqNELplv\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=jerome.forissier@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4c1WRp1zCnz1xvJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 12 Aug 2025 22:44:54 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id F3E6D8341A;\n\tTue, 12 Aug 2025 14:43:58 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id D0980834BC; Tue, 12 Aug 2025 14:43:57 +0200 (CEST)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n [IPv6:2a00:1450:4864:20::32d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D5F4C834BC\n for <u-boot@lists.denx.de>; Tue, 12 Aug 2025 14:43:54 +0200 (CEST)", "by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-458b49c98a7so34837535e9.1\n for <u-boot@lists.denx.de>; Tue, 12 Aug 2025 05:43:54 -0700 (PDT)", "from builder.. ([2a01:e0a:3cb:7bb0:6b34:4d0b:774a:130d])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-459e585430csm297745475e9.11.2025.08.12.05.43.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 12 Aug 2025 05:43:53 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1755002634; x=1755607434; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=QmTICOtbxOLqMqNjTmAurXfrYwegSaEIJnaXp/ivb/M=;\n b=mqNELplv7+0sGiZ3VIKHjHK0+QzDkSh20fNvPGLFD4ALNFcvFRlokyIRKL92eFQ1g+\n onVoNwc+1QGffjGd8x15rQar/vMBbt6tWqVPgabyULjeurslJz0xvZgeTBI1tPHqXdeO\n Jxabk//IglNaSvjeCGvw6W7EDf0AGP/DC+BsgK/X3JknpqxvblrD5DUcq3ViF/wtow49\n T9RULjBeqiAOtcNrDu7wXXDnnQzUkgejtS2BHV1Iqw/i0RGmJHgqMLOBkPR395Q8oyCp\n WkE0Un4mt+WGHtfSwRrO+dL90lkzfVd4994lJQHSvI0OBU+YhDJtVYH+MTkfQUTPIbS9\n P+ig==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1755002634; x=1755607434;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=QmTICOtbxOLqMqNjTmAurXfrYwegSaEIJnaXp/ivb/M=;\n b=KEUt0HRdpCjaCh2QDuA+jEpcaGiuFax8viw9GS5txIwuuQcR7FKLUZH42u4YT+EgV7\n C0PiaRpe4aYZuFwrPtyR2Z3/ZSE4tHj0dgXMfutqiGkNul2C6YCXQUj5OnQrBp+sMp/A\n w7aCULx0o2xkGSWKdfpYz+M8RonqGzy9vRNKdJSvuBxUjTWaibS3YTlQGySGhyo5fld4\n 3bvy9pBAvBUFkFzGaLqbyXuT5T/R8+ur/LyvBtIfXg3YIP/eqaWZpW4dBO2djN9dIMn0\n ZbU1VcUtDDvzraYld6Bv5jL4Bn8q3zLtM5bQsQ5BqSZi9QLoCncW1PhmQcDTShSjxhIn\n itiw==", "X-Gm-Message-State": "AOJu0Yx45O7xxUEiGAv+7Z3NgUn+Pssrl30bNrnK2rvMpwOYhK6p802/\n D1J8o12Gg2KtsEw6kZx7ctBoV2jHCZdeavcQM7MKRzPNhzc4hGJ90Zaj6CoWYuB4pJxSk6OT2iX\n RkTjyReXamA==", "X-Gm-Gg": "ASbGnct1eFrxWs4njLNEKGUGGTQDCrIr7XZgpfBEgYGl57Kw8CKNNsUGkdsm7MI5m3+\n Ji1TYdUATZT8U1qorOpIpfHU2ild29WAZeKSPWooH8bQstH4Sb3ancKoo4iFuqdsZlCvid3mBGj\n 3RxfAsshbRbCbG1qd7N8ZByZiL36sCmMDF6FdGpj92gS5ayzkLWR+j6g2wGx5bbe7HmnRPLWFrV\n HaaxPk55KZ1svjxvYvO7MbJbwkUuGkzUSnaePKjI/rc6TVYMcrlK5Q+xdLNY+XLemS1DrY3+ieV\n E8myBLPMUGBMl/XeKQGR3djfcxU4/T9qP8Dj7/wP/PqOeWoX7dKJJOCQyTm8YxQch1rStzjaSNi\n NxYQXPjKk0XJHvwqsO2LaC3nhGQfW/rk=", "X-Google-Smtp-Source": "\n AGHT+IHK9ploDm1BFHf34kEO7S2Ueyot1qsP3Vhsm/vMe0MiDPOckzUPJ8rDBNMbVH1q1I3TpdgjRA==", "X-Received": "by 2002:a05:600c:4f86:b0:459:da89:b06 with SMTP id\n 5b1f17b1804b1-45a10bef8bfmr31331765e9.16.1755002633954;\n Tue, 12 Aug 2025 05:43:53 -0700 (PDT)", "From": "Jerome Forissier <jerome.forissier@linaro.org>", "To": "U-Boot mailing list <u-boot@lists.denx.de>", "Cc": "Jerome Forissier <jerome.forissier@linaro.org>,\n Tom Rini <trini@konsulko.com>", "Subject": "[PATCH v2 1/2] lwip: icmp: allow reporting ICMP destination\n unreachable", "Date": "Tue, 12 Aug 2025 14:43:18 +0200", "Message-ID": "<20250812124331.1464879-2-jerome.forissier@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250812124331.1464879-1-jerome.forissier@linaro.org>", "References": "<20250812124331.1464879-1-jerome.forissier@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Allow reporting ICMP destination unreachable messages via a user-defined\ncallback.\n\nSigned-off-by: Jerome Forissier <jerome.forissier@linaro.org>\n---\n\nChanges in v2:\n- Fix typo in subject (s/detination/destination)\n\n lib/lwip/lwip/src/core/ipv4/icmp.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/lwip/lwip/src/core/ipv4/icmp.c b/lib/lwip/lwip/src/core/ipv4/icmp.c\nindex 9a82a67aa93..6d588349c4a 100644\n--- a/lib/lwip/lwip/src/core/ipv4/icmp.c\n+++ b/lib/lwip/lwip/src/core/ipv4/icmp.c\n@@ -80,9 +80,9 @@ void\n icmp_input(struct pbuf *p, struct netif *inp)\n {\n u8_t type;\n-#ifdef LWIP_DEBUG\n+#if defined(LWIP_DEBUG) || defined(ICMP_DEST_UNREACH_CB)\n u8_t code;\n-#endif /* LWIP_DEBUG */\n+#endif\n struct icmp_echo_hdr *iecho;\n const struct ip_hdr *iphdr_in;\n u16_t hlen;\n@@ -103,11 +103,11 @@ icmp_input(struct pbuf *p, struct netif *inp)\n }\n \n type = *((u8_t *)p->payload);\n-#ifdef LWIP_DEBUG\n+#if defined(LWIP_DEBUG) || defined(ICMP_DEST_UNREACH_CB)\n code = *(((u8_t *)p->payload) + 1);\n /* if debug is enabled but debug statement below is somehow disabled: */\n LWIP_UNUSED_ARG(code);\n-#endif /* LWIP_DEBUG */\n+#endif\n switch (type) {\n case ICMP_ER:\n /* This is OK, echo reply might have been parsed by a raw PCB\n@@ -257,6 +257,15 @@ icmp_input(struct pbuf *p, struct netif *inp)\n default:\n if (type == ICMP_DUR) {\n MIB2_STATS_INC(mib2.icmpindestunreachs);\n+#ifdef ICMP_DEST_UNREACH_CB\n+ /*\n+ * The callback receives the IP packet (not the ICMP message) so that\n+ * it can extract the source address for example\n+ */\n+ pbuf_add_header(p, IP_HLEN);\n+ ICMP_DEST_UNREACH_CB(code, p);\n+ pbuf_remove_header(p, IP_HLEN);\n+#endif\n } else if (type == ICMP_TE) {\n MIB2_STATS_INC(mib2.icmpintimeexcds);\n } else if (type == ICMP_PP) {\n", "prefixes": [ "v2", "1/2" ] }