Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2119910/?format=api
{ "id": 2119910, "url": "http://patchwork.ozlabs.org/api/patches/2119910/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250806-phy_marvell_comphy-v1-2-ad9f4e789d5b@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250806-phy_marvell_comphy-v1-2-ad9f4e789d5b@linaro.org>", "list_archive_url": null, "date": "2025-08-06T16:43:25", "name": "[2/2] phy: marvell: Cannot test unsigned field to be negative", "commit_ref": "2e9155cb9f366a6b9191af0850efad1948b4c785", "pull_url": null, "state": "accepted", "archived": false, "hash": "f9e4c320974bb32bd75613b8949885504677e02e", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250806-phy_marvell_comphy-v1-2-ad9f4e789d5b@linaro.org/mbox/", "series": [ { "id": 468138, "url": "http://patchwork.ozlabs.org/api/series/468138/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=468138", "date": "2025-08-06T16:43:24", "name": "phy: marvell: Fix two Smatch reported issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/468138/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2119910/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2119910/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=tSU08Qcm;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"tSU08Qcm\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bxx2D3RXcz1xvm\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 7 Aug 2025 02:43:48 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6AC86842C7;\n\tWed, 6 Aug 2025 18:43:45 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 4DC28842C7; Wed, 6 Aug 2025 18:43:36 +0200 (CEST)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n [IPv6:2a00:1450:4864:20::32d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id DDF2D84370\n for <u-boot@lists.denx.de>; Wed, 6 Aug 2025 18:43:28 +0200 (CEST)", "by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-458ba079338so1002215e9.1\n for <u-boot@lists.denx.de>; Wed, 06 Aug 2025 09:43:28 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:6501:9a0d:7129:a02b])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-459e5868fd7sm61287685e9.18.2025.08.06.09.43.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 06 Aug 2025 09:43:27 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1754498608; x=1755103408; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=k3P61qDEuwnqRZZrLjZ9m7z2BgW5uq3c4fG1F0Uce1c=;\n b=tSU08Qcma/dHdQxuBz/C3fs1YDRXkNxnzUQM3cRdXeNmO6MBbSmDneXdo/Auw+163A\n 0lOqujasgeCA1In15zAjDzmJNB7EBdxjOlOxF4ZbkLiX1qsRVi1+f3+XREhIt2MURbKG\n XiLfgTgjvCZN8B9/jfmf19h8KLF6wwAJGXTx4vvqJR0fVJ6SUblL+fnjInVwRIGQX4h+\n Jxfx7v7PdENQLolPDO68ka1rvcJ2vCu1VVdavjHOQxKFLbZ+XZr6I9PzwVKXS1t7iq1p\n Lx+ZZng6k6nKmZMEQ3XvAcqgI0qLqxc79KJNnd3x1a7RBq40D5URPstTkXcRGt15TPHY\n G6EQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1754498608; x=1755103408;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=k3P61qDEuwnqRZZrLjZ9m7z2BgW5uq3c4fG1F0Uce1c=;\n b=ZZLnlYtOKn03b4AFV0fnxYIFPMN6nqtojTAhOV4UhNb1RU/9V2EArUBI4QVMmVrT1h\n xCFD5KfFAmrO+g3jxj4af0wkpJxoEbiwuD0RSBpP+zGUZN3MOihsYe9opkvUefTnVbzb\n VJoXUrBfxw/k6L9xAFeWSvEH8dxHS+MAj3IExGp19CcQcZYq0yyMFVJOX7E3CehYslp0\n RwTniA4VIc9K5ydc3G+J2kWA1bW+qk9JgK/CSlZeKs0aHz/8farVMnAiBrq+rDUCd5k5\n BBiKPyqogbNYfV7Yvo3DftQwvkxQ/GuTp0IsD+USLLUJLadchd7ppoZ2FcP7do1ugd8V\n XsRA==", "X-Gm-Message-State": "AOJu0YyYw9sGcwFTlUjDDf9QEnMBb+0Px/y7SJJkVs55bKoOIPxuWomw\n CwZOSUrHoM43hAhZmBlRBrjsp884O8v6qvyHsO6TFSjcRL9dl7VnFwLus/16D2onrUUz2ZOZtu+\n Hmkcv", "X-Gm-Gg": "ASbGnctdQ7sZjXXtq814+KhNBV+9N1RjlzLjS1DPriDyvVDjHGxMF9odbQajfUwd00M\n RWBrsd6zO463mbix5pQdk8Vq9NB0ZD754bv2EnO5f3RKXkXBYTgo7E9vAlVdNyWYiuXcEpl6gIL\n imAm1vqShg0aNUJSzHuSFmhFzhf9mw6VmuBzaknWnTxZmgV68BFoq+hHfJA+igUJXcXdg/MUsN9\n 7YXvN5v3Wf3nZY6n2byaCoGvDNKfeObNMEtqnQagq84Unoz2aEW3DI12PgDUG7tgY2Abvwrnc00\n khp/1SaKG89tzQ+FZ7Em60HC7RFvX7LYTl9Wn7ivrvnlIr+Tcz5hwjSo4uSbygIYWxxWJf+rcmx\n 3SV5cXOS+xdyF85wDmXK+MbDh3msr4sZbyYRufQ5HygbLl2YjhTE=", "X-Google-Smtp-Source": "\n AGHT+IHCLjOxwsf0dY34DXiWSxKU9cjHC2uhgqP89UOYe1RsTRYTCRz3pg+iFR+xX3EksFIntcUSsQ==", "X-Received": "by 2002:a05:600c:358b:b0:459:dd1d:2ee0 with SMTP id\n 5b1f17b1804b1-459ede03686mr2685875e9.0.1754498608257;\n Wed, 06 Aug 2025 09:43:28 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Wed, 06 Aug 2025 17:43:25 +0100", "Subject": "[PATCH 2/2] phy: marvell: Cannot test unsigned field to be\n negative", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250806-phy_marvell_comphy-v1-2-ad9f4e789d5b@linaro.org>", "References": "<20250806-phy_marvell_comphy-v1-0-ad9f4e789d5b@linaro.org>", "In-Reply-To": "<20250806-phy_marvell_comphy-v1-0-ad9f4e789d5b@linaro.org>", "To": "Stefan Roese <stefan.roese@mailbox.org>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In comphy_cp110_init_serdes_map in comphy_cp110.c there are two fields\nin cfg, comphy_lanes_count and comphy_mux_bitcount, which are fetched\nfrom the FDT blob with fdtdec_get_int which returns an int. These two\nfields are then tested for being negative. However the fields are\ndeclared as unsigned so those tests must always fail. Change the\ndeclaration of those fields to be int instead of u32 and the code will\nwork as expected.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/phy/marvell/comphy_core.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/phy/marvell/comphy_core.h b/drivers/phy/marvell/comphy_core.h\nindex f3d04939387..086a4d82f26 100644\n--- a/drivers/phy/marvell/comphy_core.h\n+++ b/drivers/phy/marvell/comphy_core.h\n@@ -47,8 +47,8 @@ struct chip_serdes_phy_config {\n \tint (*rx_training)(struct chip_serdes_phy_config *, u32);\n \tvoid __iomem *comphy_base_addr;\n \tvoid __iomem *hpipe3_base_addr;\n-\tu32 comphy_lanes_count;\n-\tu32 comphy_mux_bitcount;\n+\tint comphy_lanes_count;\n+\tint comphy_mux_bitcount;\n \tconst fdt32_t *comphy_mux_lane_order;\n \tu32 cp_index;\n \tstruct comphy_map comphy_map_data[MAX_LANE_OPTIONS];\n", "prefixes": [ "2/2" ] }