Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2119771/?format=api
{ "id": 2119771, "url": "http://patchwork.ozlabs.org/api/patches/2119771/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250806-net_vitesse-v1-1-47f5a923d586@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250806-net_vitesse-v1-1-47f5a923d586@linaro.org>", "list_archive_url": null, "date": "2025-08-06T09:37:26", "name": "net: phy: vitesse: Fix incorrect test for timeout", "commit_ref": "4b2d64f3885a83fd001993785f74f70cc6045acc", "pull_url": null, "state": "accepted", "archived": false, "hash": "bdf79ea8eaeea6dedd214689bd2ce0956dcdfd26", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250806-net_vitesse-v1-1-47f5a923d586@linaro.org/mbox/", "series": [ { "id": 468074, "url": "http://patchwork.ozlabs.org/api/series/468074/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=468074", "date": "2025-08-06T09:37:26", "name": "net: phy: vitesse: Fix incorrect test for timeout", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/468074/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2119771/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2119771/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=L7OQZP1j;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"L7OQZP1j\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bxlZQ5Nmkz1xvm\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 6 Aug 2025 19:37:34 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4FE738398B;\n\tWed, 6 Aug 2025 11:37:36 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id B08978399A; Wed, 6 Aug 2025 11:37:35 +0200 (CEST)", "from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n [IPv6:2a00:1450:4864:20::42d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6058683981\n for <u-boot@lists.denx.de>; Wed, 6 Aug 2025 11:37:30 +0200 (CEST)", "by mail-wr1-x42d.google.com with SMTP id\n ffacd0b85a97d-3b786421e36so3663239f8f.3\n for <u-boot@lists.denx.de>; Wed, 06 Aug 2025 02:37:30 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:6501:9a0d:7129:a02b])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-458be70c5f7sm162055445e9.26.2025.08.06.02.37.28\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 06 Aug 2025 02:37:28 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1754473049; x=1755077849; darn=lists.denx.de;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=Xnau7gjRKcNqd0UtmZZrVxR5/pbtLHStEN7gL2VzPws=;\n b=L7OQZP1jP6KsB8u41fXrtxXP5Dp1djsOr/UXL0t/hMAPbjtiRLTa4+fLo++FIqD0ei\n 3UOM9sxm2kGRSgULSAHoFdBrl0Q6/pEvqUr6PILz3hirvCCcDxVowdPFy+IbfkzqaprD\n zHTiRuMihVSkPiFbvnsl4GN2dkLDNOsH7FNnbtnu8FLO6lpYym6KEtwfeIzw1iniloGt\n zTPD3weydQJJG/grCX8cuSmHb4DEj0Fog3W5mZIpQgXJNSZ5RKF/fUig92w4La4ayaAQ\n GKvj1HeHTMok4n50Ixl/yFieBsZuQd5tBMr7Sp4VmXRp68MG6UBWqY0ksoo3w7SC+3yC\n YK5A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1754473049; x=1755077849;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Xnau7gjRKcNqd0UtmZZrVxR5/pbtLHStEN7gL2VzPws=;\n b=suQn6GhqcuRCe6bNCgwkrWMgKeDXN9/uAmJyDbv3LH2YNGzVrCePzxA5fq5+birzyD\n jn2PV306sn5jta888q6X2LYz+0HNTHj2HP7IglaioGliZEeMUo1DKxK7av89fZidth2y\n HCqghJADDgnXulxKMBAMFtT9YnwI9+teQDOWl7T8Mgk75/IqVz2xPuswM8x/Z1y7X8dX\n jAXUebqUqLobSJn160shG4WPmZLQWrEevzb7vd64trSmghefJDM69wE6bubG+pStmoqq\n lJAfExZdHRyfuJeS+FeG23Xhv9LIKmdXIRtVaBqDvopi04k6kl9WCe/ApUzEtxsyuNVK\n KY1g==", "X-Gm-Message-State": "AOJu0YwoQb6lDCfJyYYosCpCY/kgttm4xgGJCYMCfL9QttsvvJwC5F+9\n FBo/dz/c28hE6AyCL7AXLC3Q7HCwMMAxkMhPBOD8bcwqp1ZXBpz+bCbPO0DkyNiqWbI=", "X-Gm-Gg": "ASbGncuvpdiXpGjZgHLOiJTtrarxW8xL8QlpZa9GInlPxt72TqIuV1LxKVrkr92OK+n\n NC3dSJWzIJOJSMNx08yRxucZybNk3orC7L4taA6sQJ8MVoFhizenWGVqrYSLQhQCwf4FLERNZNj\n GTqLjajuOBVaSgK3osINMHl7j18biEbSGAxZzK5kSG7/XgUhL2Y4aMA5GRlLJvQ6lPT+TY7G0wL\n 7RgwZz0PudHfPwhEjWFeX4h2/skGhq4WhLUrZ6qIRB/Jnin1pkcgZ87cJaU07qIX0qFZZ/iAZXo\n wxmVa86EHuEcKX0HadTt0Fx89sykU3FZvrp2hh8O4wyWYXnG/7gEfx0JpzD6IhKiBWMQUOVQ1fn\n X2aGJh6lwvzmhVLzvqEXZKvKzNMZIw3KKPOmwmt2V6ihBADBp54M=", "X-Google-Smtp-Source": "\n AGHT+IFekwl2gpD5zw/Mlk2+3n6fw3iYz0yJjMQbFAI7HA6n/pUrWJpJTDcaQoLhhl81sL3TloMIjw==", "X-Received": "by 2002:a05:6000:1ac8:b0:3b8:d893:5230 with SMTP id\n ffacd0b85a97d-3b8f421058amr1796911f8f.47.1754473049340;\n Wed, 06 Aug 2025 02:37:29 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Wed, 06 Aug 2025 10:37:26 +0100", "Subject": "[PATCH] net: phy: vitesse: Fix incorrect test for timeout", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250806-net_vitesse-v1-1-47f5a923d586@linaro.org>", "X-B4-Tracking": "v=1; b=H4sIAFUik2gC/x2N0QqDMBAEf0XuuYEomBZ/pUi56FrvwVTughTEf\n 2/Sx5ll2JMMKjAampMUh5h8UoH21tC0cnrDyVyYOt/1/uGDS8ivQzLM4GIbQrjH2S/cUykiV6m\n cprU2G1uG1mFXLPL93zzH6/oBoioalnYAAAA=", "To": "Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In vsc8514_config there is a while loop for detecting a config failure\nusing a timeout counter with a post-decrement. In the case of a timeout\nthis will result in the loop exiting with timeout == -1 so use that as\nthe test below the loop to detect that the timeout occurred.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/net/phy/vitesse.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\n---\nbase-commit: 007610da2cca405ea7739fc120d90085be4b6ac2\nchange-id: 20250806-net_vitesse-b16667bd0fa5\n\nBest regards,", "diff": "diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c\nindex 4867d1931b4..821d3878236 100644\n--- a/drivers/net/phy/vitesse.c\n+++ b/drivers/net/phy/vitesse.c\n@@ -239,7 +239,7 @@ static int vsc8514_config(struct phy_device *phydev)\n \twhile ((val & MIIM_VSC8514_18G_CMDSTAT) && timeout--)\n \t\tval = phy_read(phydev, MDIO_DEVAD_NONE, MIIM_VSC8514_GENERAL18);\n \n-\tif (0 == timeout) {\n+\tif (timeout == -1) {\n \t\tprintf(\"PHY 8514 config failed\\n\");\n \t\treturn -1;\n \t}\n", "prefixes": [] }