Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2119288/?format=api
{ "id": 2119288, "url": "http://patchwork.ozlabs.org/api/patches/2119288/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-net_octeontx-v1-3-637095d82265@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250805-net_octeontx-v1-3-637095d82265@linaro.org>", "list_archive_url": null, "date": "2025-08-05T15:45:49", "name": "[3/3] net: octeontx: Free allocated memory on error", "commit_ref": "0ce7fef9e2154d188bd50ae687fb666faac8fe7b", "pull_url": null, "state": "accepted", "archived": false, "hash": "b36f160d16a437aad1c074d1bfdb826a4300e53c", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-net_octeontx-v1-3-637095d82265@linaro.org/mbox/", "series": [ { "id": 467976, "url": "http://patchwork.ozlabs.org/api/series/467976/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=467976", "date": "2025-08-05T15:45:46", "name": "net: octeontx: Fix some Smatch reported issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/467976/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2119288/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2119288/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=es28/GlR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"es28/GlR\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bxHpJ51xLz1xpj\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 6 Aug 2025 01:46:16 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D3E4D838E3;\n\tTue, 5 Aug 2025 17:45:55 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 7DB72838BB; Tue, 5 Aug 2025 17:45:54 +0200 (CEST)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n [IPv6:2a00:1450:4864:20::336])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9095B83890\n for <u-boot@lists.denx.de>; Tue, 5 Aug 2025 17:45:52 +0200 (CEST)", "by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-458bc3ce3beso20625285e9.1\n for <u-boot@lists.denx.de>; Tue, 05 Aug 2025 08:45:52 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:60bc:24e3:6dcd:9f35])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-459e5852e28sm9007255e9.9.2025.08.05.08.45.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 Aug 2025 08:45:51 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1754408752; x=1755013552; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=rTDtydKcFfxkI3Uby9QQTHXJD+LfMkwpBnwxc9BxGC8=;\n b=es28/GlRKn92CcpZTUIxMw3A+dA9jPEuWRL+CploybVEXrWaUxSa9yIkEwKWVEfT0x\n ijhGdPbV7jXuAhlry+ZEjsGfDauzjeF7Y/LpsnVlpVDsFkyxsfG9StLTAmkXFS6vDRe1\n 4tntxKyXfOlB18O/AD92LPQxHobKj3MRr3o275yJp/nngkNtCNwzffBN+AbKEyrhZXW0\n 6MOjqRzgobV1znfyFH8DgFZ3z5W61uIAaLac7Q9BeaFzXuyI18uXpqyxxFRVkcbTJEjD\n H7M84pZlkRaCid5QnQHAECTry2Mh6QOWMfuLQAa42xIcfI7PV3ma/lKiIYaEjxVE06Q7\n bckA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1754408752; x=1755013552;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=rTDtydKcFfxkI3Uby9QQTHXJD+LfMkwpBnwxc9BxGC8=;\n b=HYlHkEPrj74Mfl64G4Pwf/6o67E7WhiTAYWfOro4lfoXjpgseF5mkLdjzMi+jpulta\n aScwVyfEyjrvWtgSB47fmODjCa9V8SE4+3o4/aw6XOYo5/rKUSYV/+BH9JspLEiHaEtL\n w06CZ0WbhnCsYD1xe1en6/HkJCgZb7w+ZecZPuiRCG/36jTt5u1iKuPr8AX4UiWzATU1\n Dyuy12iuogK8ifGfMX6o1s/lA0aeU0ebMm4ehtuw54/mqyUYk+LWdTXJbS8qkrw8QQ55\n EmNTVGIY7mogJCoKDJdXFJCi+YccYVWb0XYFF9skPP1weZbsomTHc5XoeMMmN4khBG6B\n zgdg==", "X-Gm-Message-State": "AOJu0Yy1u9dT7yIW281RtyKbv1mgUx/jyRcJbhZABUSuCVJlw5USZptW\n Z+4n5rVRlWJdmCkSulYftJMNhA8A0mLrIklQ2adh2gS6uNtIjUT8UIjac04pc/PDsQs=", "X-Gm-Gg": "ASbGncu2p1xhdLOXrdHQgwC7eWfy8RBdh7hXvJ3XJadzrKXZC8LskY2wrby8KciQxxi\n cVR4kgaVGGhUO4jRhbIL+eMEXzyo8XPF51tr2NoYq+AxkVwHRu5F7lNXQxndqKTgezmSfP3f2hc\n 26XcKZ29tbVOnUgqaIVNjxioNq7C+UqBNIBFkvP1uiTPJCDqmxrL/c6Pm5nZ7De2gxyX6nABQGP\n 9j7e63ta0brdW4MtT01WkXDa69JJpT90IRtXkrQYPXPbUHglyi2ksL1oEL8yBoQyPlDXBzAVJEN\n 6d+0LwXoketLFciJ/nuGavsbCuSrjrSseNLpUROd4uX72HU8EWC2Rw0XCI98gNREVUNM+G8vAGh\n u0rjF112cbhVPlbNOlycOSoJw2+rD9jfYoMfQ+Tv41XlCwIVAFjA=", "X-Google-Smtp-Source": "\n AGHT+IGEz2LhLM7nGhpTY30X1zxqL0zjghKDKE1F3bWStGfMILyuNymaIRTcIAmJXOlYMqh8HVmR3A==", "X-Received": "by 2002:a05:600c:1f16:b0:456:1e5a:885e with SMTP id\n 5b1f17b1804b1-458b69cbde5mr120960575e9.3.1754408751994;\n Tue, 05 Aug 2025 08:45:51 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Tue, 05 Aug 2025 16:45:49 +0100", "Subject": "[PATCH 3/3] net: octeontx: Free allocated memory on error", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250805-net_octeontx-v1-3-637095d82265@linaro.org>", "References": "<20250805-net_octeontx-v1-0-637095d82265@linaro.org>", "In-Reply-To": "<20250805-net_octeontx-v1-0-637095d82265@linaro.org>", "To": "Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In octeontx_smi_probe if an error is detected then memory that was\nallocated is not freed. Small refactor of the code to use a common\nreturn and free memory. Also return -ENOMEM for an allocation failure.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/net/octeontx/smi.c | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/octeontx/smi.c b/drivers/net/octeontx/smi.c\nindex 233c26f7319..217bcac2ce2 100644\n--- a/drivers/net/octeontx/smi.c\n+++ b/drivers/net/octeontx/smi.c\n@@ -338,7 +338,8 @@ int octeontx_smi_probe(struct udevice *dev)\n \t\tif (!bus || !priv) {\n \t\t\tprintf(\"Failed to allocate OcteonTX MDIO bus # %u\\n\",\n \t\t\t dev_seq(dev));\n-\t\t\treturn -1;\n+\t\t\tret = -ENOMEM;\n+\t\t\tgoto error_ret;\n \t\t}\n \n \t\tbus->read = octeontx_phy_read;\n@@ -355,9 +356,16 @@ int octeontx_smi_probe(struct udevice *dev)\n \n \t\tret = mdio_register(bus);\n \t\tif (ret)\n-\t\t\treturn ret;\n+\t\t\tgoto error_ret;\n \t}\n \treturn 0;\n+\n+error_ret:\n+\tif (bus)\n+\t\tfree(bus);\n+\tif (priv)\n+\t\tfree(priv);\n+\treturn ret;\n }\n \n static const struct udevice_id octeontx_smi_ids[] = {\n", "prefixes": [ "3/3" ] }