Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2119287/?format=api
{ "id": 2119287, "url": "http://patchwork.ozlabs.org/api/patches/2119287/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-net_octeontx-v1-2-637095d82265@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250805-net_octeontx-v1-2-637095d82265@linaro.org>", "list_archive_url": null, "date": "2025-08-05T15:45:48", "name": "[2/3] net: octeontx: Remove unneeded test", "commit_ref": "62b4a482b943bc8173ac10a6c783e84d939b88bf", "pull_url": null, "state": "accepted", "archived": false, "hash": "1882b329b3ceb10e3bbf76308cccdc0cda3801f9", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-net_octeontx-v1-2-637095d82265@linaro.org/mbox/", "series": [ { "id": 467976, "url": "http://patchwork.ozlabs.org/api/series/467976/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=467976", "date": "2025-08-05T15:45:46", "name": "net: octeontx: Fix some Smatch reported issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/467976/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2119287/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2119287/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=xIRYkOgU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"xIRYkOgU\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bxHp72p4Wz1xpj\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 6 Aug 2025 01:46:07 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 85B23838D5;\n\tTue, 5 Aug 2025 17:45:55 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id E7FAC838BB; Tue, 5 Aug 2025 17:45:53 +0200 (CEST)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n [IPv6:2a00:1450:4864:20::32f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D80F3838C5\n for <u-boot@lists.denx.de>; Tue, 5 Aug 2025 17:45:51 +0200 (CEST)", "by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-458bdde7dedso23543225e9.0\n for <u-boot@lists.denx.de>; Tue, 05 Aug 2025 08:45:51 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:60bc:24e3:6dcd:9f35])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-459e5852e28sm9007255e9.9.2025.08.05.08.45.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 Aug 2025 08:45:50 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1754408751; x=1755013551; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=IK3BEPYH5OOu4Mxmw1dUh9/vd9j0VXhDt2Ge91sl5qM=;\n b=xIRYkOgUtTSjL2iMoS+wA2JrvQcebjZjCn3NOxn52RpbpA2fu2plJgtZt7jJ0uFV9y\n AO+RVzCuuJS2JI18i/og7ZlPEmq3Yk9T1EFYZ1EoAtNIIlZj53+AqnS4808j9XwBWyiT\n lol4WWtffXuIYQPWAHahOpcrtfiKPec1QdXnVUuKIrgiThGbgGEWV7Mo9KumE5r3GzdR\n l1vyvjXPvKSmtqBF+7S4H/jCXT6/uA25gZmgdmcFRGDLNmDQzSKusWfG4qBPnTADKdz/\n EJ14TrnhwBQkcjUZEkkJjTXza/UjERXZBAo9asZR2Nf0edzZhJMw1HqICR6bbq2ewttS\n bEaA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1754408751; x=1755013551;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=IK3BEPYH5OOu4Mxmw1dUh9/vd9j0VXhDt2Ge91sl5qM=;\n b=OH2tari3sR4pnNhu0PwD09n4CguEvSkkikL48AvmazmmhpdZme6HqFLI8PdTk3c91u\n lihMKBgAsTq2YK2DeEsAkaAFnM6/1H45mgxPVdO16MRWZcnFS+Wl9ijlIrpReKMbdAsj\n HswHkVBYA74uk30/rE2dDUcpzB6utnVMW3Bx9kIUdokYBdcJmv9/Rlqg3ygFzcumDw2Q\n TS1JE3OI4xCL/VcTHaX9vQWr19b8Cqe0iOZIQ+T9Cw6dhOKgHH50HM+JMvfQc5b/GVtm\n DVIo2Lhdz8xlorQgK3a24fPDcqB7mwDam6BLjm+b8RazTv4E2r2HcyKs9efmLeyElNwD\n lXmg==", "X-Gm-Message-State": "AOJu0Yy41oNBv0ufL4OiY92kfoWRZKPFfGnvE5ga4Eutm73bRfPBhMjm\n teQ0FGVvyWvUN+hNneqJ4fJdWwwm3pTaYWhUkyaR7QgP5PzitCMj7Yfzm+0w0+ZH97c=", "X-Gm-Gg": "ASbGncuy4IguyHUtb8VrPHYv2Wslfbo/XbS959w1WGEUpyfsod4/ihnShyTP7yntnxw\n LwPo6ZYOcuYQyZ9IvvXEcSjavwwhpRUZXH7DSY4zG1jQ8YCYHVjcKARH3/AjV8fcEmiATZ8Pp0+\n ZlRt2nbyWapkEoIKnwmtIKJuEj6uisrECK9ELTuGSAupdGyylYLfZt9bazw5pGCocrEdpu+9FJB\n L3asCP63S8AgZ+3mYmdF6voxnh5YwqCRD+rbj3ee2bvrQT9gv7aZ3qEFUZ0ZuhGfMTMHDcwmFor\n oXI17gCEQS3+Dmklzj1FPUXQ992KjfbROCsUmkDOoUyPNw+3jwCVaApoGcpKmswLhB2nmd+L6GT\n 1cWQNRonBcPnciQdDvxe0MpYqP2qR/+UuLK5zJ0W8RWjLnG87bDo=", "X-Google-Smtp-Source": "\n AGHT+IFmHZr6z96xKRDY5E7aIaiKTPKP5Tld1aBuDemo6VdoknxhxSQAtOK2+e1YfyCB4irM17dJrQ==", "X-Received": "by 2002:a05:600c:3591:b0:456:161c:3d6f with SMTP id\n 5b1f17b1804b1-458b95b7ca2mr104063925e9.11.1754408751173;\n Tue, 05 Aug 2025 08:45:51 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Tue, 05 Aug 2025 16:45:48 +0100", "Subject": "[PATCH 2/3] net: octeontx: Remove unneeded test", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250805-net_octeontx-v1-2-637095d82265@linaro.org>", "References": "<20250805-net_octeontx-v1-0-637095d82265@linaro.org>", "In-Reply-To": "<20250805-net_octeontx-v1-0-637095d82265@linaro.org>", "To": "Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In nicvf_cq_handler there is a test for !cqe_count which will return if\ntrue so it is guaranteed that cqe_count will true after that point. This\nmakes the later test for cqe_count redundant so it can be removed.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/net/octeontx/nicvf_main.c | 46 +++++++++++++++++++--------------------\n 1 file changed, 22 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/octeontx/nicvf_main.c b/drivers/net/octeontx/nicvf_main.c\nindex 8021cd752b5..94e5d827614 100644\n--- a/drivers/net/octeontx/nicvf_main.c\n+++ b/drivers/net/octeontx/nicvf_main.c\n@@ -273,31 +273,29 @@ int nicvf_cq_handler(struct nicvf *nic, void **ppkt, int *pkt_len)\n \tcqe_head >>= 9;\n \tcqe_head &= 0xFFFF;\n \n-\tif (cqe_count) {\n-\t\t/* Get the CQ descriptor */\n-\t\tcq_desc = (struct cqe_rx_t *)GET_CQ_DESC(cq, cqe_head);\n-\t\tcqe_head++;\n-\t\tcqe_head &= (cq->dmem.q_len - 1);\n-\n-\t\tswitch (cq_desc->cqe_type) {\n-\t\tcase CQE_TYPE_RX:\n-\t\t\tdebug(\"%s: Got Rx CQE\\n\", nic->dev->name);\n-\t\t\t*pkt_len = nicvf_rcv_pkt_handler(nic, cq, cq_desc,\n-\t\t\t\t\t\t\t ppkt, CQE_TYPE_RX);\n-\t\t\tprocessed_rq_cqe++;\n-\t\t\tbreak;\n-\t\tcase CQE_TYPE_SEND:\n-\t\t\tdebug(\"%s: Got Tx CQE\\n\", nic->dev->name);\n-\t\t\tnicvf_snd_pkt_handler(nic, cq, cq_desc, CQE_TYPE_SEND);\n-\t\t\tprocessed_sq_cqe++;\n-\t\t\tbreak;\n-\t\tdefault:\n-\t\t\tdebug(\"%s: Got CQ type %u\\n\", nic->dev->name,\n-\t\t\t cq_desc->cqe_type);\n-\t\t\tbreak;\n-\t\t}\n-\t\tprocessed_cqe++;\n+\t/* Get the CQ descriptor */\n+\tcq_desc = (struct cqe_rx_t *)GET_CQ_DESC(cq, cqe_head);\n+\tcqe_head++;\n+\tcqe_head &= (cq->dmem.q_len - 1);\n+\n+\tswitch (cq_desc->cqe_type) {\n+\tcase CQE_TYPE_RX:\n+\t\tdebug(\"%s: Got Rx CQE\\n\", nic->dev->name);\n+\t\t*pkt_len = nicvf_rcv_pkt_handler(nic, cq, cq_desc,\n+\t\t\t\t\t\t ppkt, CQE_TYPE_RX);\n+\t\tprocessed_rq_cqe++;\n+\t\tbreak;\n+\tcase CQE_TYPE_SEND:\n+\t\tdebug(\"%s: Got Tx CQE\\n\", nic->dev->name);\n+\t\tnicvf_snd_pkt_handler(nic, cq, cq_desc, CQE_TYPE_SEND);\n+\t\tprocessed_sq_cqe++;\n+\t\tbreak;\n+\tdefault:\n+\t\tdebug(\"%s: Got CQ type %u\\n\", nic->dev->name,\n+\t\t cq_desc->cqe_type);\n+\t\tbreak;\n \t}\n+\tprocessed_cqe++;\n \n \t/* Dequeue CQE */\n \tnicvf_queue_reg_write(nic, NIC_QSET_CQ_0_7_DOOR,\n", "prefixes": [ "2/3" ] }