Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2119286/?format=api
{ "id": 2119286, "url": "http://patchwork.ozlabs.org/api/patches/2119286/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-net_octeontx-v1-1-637095d82265@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250805-net_octeontx-v1-1-637095d82265@linaro.org>", "list_archive_url": null, "date": "2025-08-05T15:45:47", "name": "[1/3] net: octeontx: Remove unneeded code", "commit_ref": "45eedb7b8097793242c542b68bc5d37b298808b7", "pull_url": null, "state": "accepted", "archived": false, "hash": "daf54f72cc07bb7c0fcaf34ebb8e0baf46473b09", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-net_octeontx-v1-1-637095d82265@linaro.org/mbox/", "series": [ { "id": 467976, "url": "http://patchwork.ozlabs.org/api/series/467976/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=467976", "date": "2025-08-05T15:45:46", "name": "net: octeontx: Fix some Smatch reported issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/467976/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2119286/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2119286/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=eQFLBo2E;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"eQFLBo2E\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bxHny03hRz1xpj\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 6 Aug 2025 01:45:57 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D8C3B83890;\n\tTue, 5 Aug 2025 17:45:54 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id E2D85838D2; Tue, 5 Aug 2025 17:45:53 +0200 (CEST)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n [IPv6:2a00:1450:4864:20::32d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E3771838BB\n for <u-boot@lists.denx.de>; Tue, 5 Aug 2025 17:45:50 +0200 (CEST)", "by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-459ddada9b1so19227815e9.0\n for <u-boot@lists.denx.de>; Tue, 05 Aug 2025 08:45:50 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:60bc:24e3:6dcd:9f35])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-459e5852e28sm9007255e9.9.2025.08.05.08.45.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 Aug 2025 08:45:49 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1754408750; x=1755013550; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=6SVVu3jW0hlLAN/LZLapahGE3amVARgUKFHuGAONITk=;\n b=eQFLBo2EOtWA8zcOGGiGiS5VHUsGDWqk1mdAYjUqpj72bebgXbJcCGIkVH9DNVJKLU\n cBtmvld8jJuPpe6s9zWb25InpAxV9GKy+mkp+bSXqsBd1T9lt5fF1wkk4+itCZJ8oPW+\n 3j/nlix1bgeYh1IcaTe8V/6VBsWVG1W5bEDDCDCureHO0GDBK6YW0DrtINArY5KVZkqD\n CqVmNCK74bOQN4x/JtuPs1JenbMH/l1mCtfKfrBHfFzHXHl+uZu1dIssdirrysxV+pAN\n NAbHBRgYheNfMZgftLdUkkc/pV0h6YR8xeiZcoK1ECL2gZI5FNELSePglrELnK+Vuai8\n WLOg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1754408750; x=1755013550;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=6SVVu3jW0hlLAN/LZLapahGE3amVARgUKFHuGAONITk=;\n b=iUyoU50REIykKTzE1NzF4MD6qkmfwM5co6MnZAxYrx+7WUqYtUxePQwuOnWybezRrA\n OIPT8WPTIoesgPyiOqS2wbL9w6FQvRxiu1E1QbSSml1nMEvdSPtzF9Ga2ssksVTsbT5h\n GhNKILI/cVBBDlY1rI41WU6cFENb7ifILxkNbajsexXNm/C3xgiEvHRiQPi4aARrSq69\n DhUZgGZjtYszksH4oYX/H07Z/I6jfSZGgO+0syy9Hm/AItP7768LiU6Vb41LYHiTuqnf\n JfwGWmixECWM8tK/ObIfLULMbyCUrNz49uALJc5qHYvYPV4nUSdauM7fW5ms3mYio11D\n sR9g==", "X-Gm-Message-State": "AOJu0YxrjRBA/v7Y/jsLNZ7k557siruhhvrg+O7gHkDDzhuFHTUTI9vT\n i1NGk1eZ/YmYC8QVnMerSWOjqv1Yr9y88Dh2ozd5D+YBjWHyK/HD5B3W7LZK57yCeIk=", "X-Gm-Gg": "ASbGncv7rIcP31K8ZFRWG8Ofji3jWbBunE3qzgunbmVvjwPi73Fb8/jK4JFy8Fo+Aqo\n O3iNcmpJmjagH0wTvh7cSuVL0EzT3N37+MUPltcsnLeG4ZOY/zydrRoMSQpC9s8EaxBu4OSPa1h\n teJGDjORJrjKCtOx2QXQWytl/BBh+DK2XhwlquEC8cLGHuyl7Oj60OOhDsq8bHaPX1vPaHcCnCi\n q1lgI3Wr+tU/+hzIkoqANvpBZjf1f3z6TfoWbdHyf9N5bvcV904ZWwU7hWJGXt8ZdaKBAwCyfEZ\n hxIdO8OkcIKETQib/X2ukseFueyt675WCVpPKkbgteZY6XW9ERhcdjN20xnl4zgXkkTsj1zkxCZ\n 4NSZ/gWvpHRZPx5ei7nfo/7gR1BjtVImjY1PEpKLwQOo+51Uj1uVR3vBqJvQ6UA==", "X-Google-Smtp-Source": "\n AGHT+IEuqZRYrGTGKB8eJNjDKcrP+ZgyZPXMuOh1cerEXB40ULus2at47tmWmf49dYKlbIOUluKoqQ==", "X-Received": "by 2002:a05:600c:354b:b0:459:e094:92c2 with SMTP id\n 5b1f17b1804b1-459e0949526mr36245615e9.27.1754408750340;\n Tue, 05 Aug 2025 08:45:50 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Tue, 05 Aug 2025 16:45:47 +0100", "Subject": "[PATCH 1/3] net: octeontx: Remove unneeded code", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250805-net_octeontx-v1-1-637095d82265@linaro.org>", "References": "<20250805-net_octeontx-v1-0-637095d82265@linaro.org>", "In-Reply-To": "<20250805-net_octeontx-v1-0-637095d82265@linaro.org>", "To": "Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In nicvf_rcv_pkt_handler there is no need to initialise err as it is\nassigned to immediately after. Also the test for !pkt will return if\ntrue meaning that pkt is guaranteed to be true after that code block and\nso no need to test for it and the redundant test can be removed.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/net/octeontx/nicvf_main.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/octeontx/nicvf_main.c b/drivers/net/octeontx/nicvf_main.c\nindex 27d0327c88a..8021cd752b5 100644\n--- a/drivers/net/octeontx/nicvf_main.c\n+++ b/drivers/net/octeontx/nicvf_main.c\n@@ -232,7 +232,7 @@ static int nicvf_rcv_pkt_handler(struct nicvf *nic,\n \n \tsize_t pkt_len;\n \tstruct cqe_rx_t *cqe_rx = (struct cqe_rx_t *)cq_desc;\n-\tint err = 0;\n+\tint err;\n \n \t/* Check for errors */\n \terr = nicvf_check_cqe_rx_errs(nic, cq, cq_desc);\n@@ -245,8 +245,7 @@ static int nicvf_rcv_pkt_handler(struct nicvf *nic,\n \t\treturn -1;\n \t}\n \n-\tif (pkt)\n-\t\t*ppkt = pkt;\n+\t*ppkt = pkt;\n \n \treturn pkt_len;\n }\n", "prefixes": [ "1/3" ] }