Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2119208/?format=api
{ "id": 2119208, "url": "http://patchwork.ozlabs.org/api/patches/2119208/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-net_mvpp2-v1-3-624ef87cadb9@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250805-net_mvpp2-v1-3-624ef87cadb9@linaro.org>", "list_archive_url": null, "date": "2025-08-05T14:18:18", "name": "[3/4] net: mvpp2: Cannot test unsigned variable to be negative", "commit_ref": "3aa3d37282414ea5c19ea415f46d214f4c80d8b6", "pull_url": null, "state": "accepted", "archived": false, "hash": "3b6a5b82745f82187b7585c4867ad5fd7ffcf4cc", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-net_mvpp2-v1-3-624ef87cadb9@linaro.org/mbox/", "series": [ { "id": 467962, "url": "http://patchwork.ozlabs.org/api/series/467962/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=467962", "date": "2025-08-05T14:18:19", "name": "net: mvpp2: Fix some Smatch reported issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/467962/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2119208/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2119208/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ROQthXjv;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"ROQthXjv\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bxFzy18Lsz1xv2\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 6 Aug 2025 00:24:30 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 13969831E0;\n\tTue, 5 Aug 2025 16:24:37 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 1F3BF83753; Tue, 5 Aug 2025 16:24:35 +0200 (CEST)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n [IPv6:2a00:1450:4864:20::432])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C2C7483045\n for <u-boot@lists.denx.de>; Tue, 5 Aug 2025 16:24:30 +0200 (CEST)", "by mail-wr1-x432.google.com with SMTP id\n ffacd0b85a97d-3b7920354f9so5060448f8f.2\n for <u-boot@lists.denx.de>; Tue, 05 Aug 2025 07:24:30 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:60bc:24e3:6dcd:9f35])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3b79c4534b3sm19307801f8f.47.2025.08.05.07.18.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 Aug 2025 07:18:20 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1754403870; x=1755008670; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=GVK9yNm3ETpSJwi5V0nueDR3ygaM4iTSg7aFz+36fJc=;\n b=ROQthXjv7GYrXVuFY+/abyo6WzYxm0LH0r2eyQykl2FVD2mtyoiKwgpDTR3EcYGs9v\n sLodR5JSEuZjdR0BcOM6cFrnSeLLVhk0VqZoGSRCJNmwvPOmQUqTIbPak2U4afPACgVo\n 0PMFoOU1Pm70pqtqRLXjujLvkY2T16G2YZUDNyhawZzg4VVOGz+7AfypEYBa6PCRbmav\n TAK4kKojTqOSXByXlPG0/1Sp0bc2BkyI3uo3KSyLobHGYaMgQzlgUtl8QdSsqYI61ZLl\n jI4HxUMpzPde8EBW+n4IUbQJnHvRZbOg5ivON8LlfBI4Sjvkh2VoBMrW4un6HOuGGiCC\n 8ICA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1754403870; x=1755008670;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=GVK9yNm3ETpSJwi5V0nueDR3ygaM4iTSg7aFz+36fJc=;\n b=CHRN+ei8GgFvNtF7xJ3MYVWhalYtj5IPJGIR6cZMegHLanSKPHWIy6UwFFdUnAIcdF\n +DmeswqHs9nTcozSmyf8noJCDats1QZUePVkEgYmSZy6d1sn5imT1ZFtyvxZqzQBPXNN\n xkmqOskAw4UTGnBlHq2ujDvO6C8738dUWH5Q8RhK5syWESGe50QAWWrsbRV+YgMJctxZ\n E39enPYySpmKf7kv42o6Zfc+q8ZknIYkfCfmGJIZRfETLVyhN6qI1y4vzCRcN8xZjP+E\n v+TO+m5hdIKYEXDG648pFEFj2h1i6eEa+RUrg3zWHh3kFoO/pkYQrehthDrkMOLQ1WRD\n CI4w==", "X-Gm-Message-State": "AOJu0YwWygOo/NXojY9TPOn+yNoLV2kbCE3wjvYJusflfk89eLh+7SHU\n WJX/L9Eq9YmPQ56rxbIHxdYfVIvQU10XTtaLQIs6Y0LnwedP+QJ3Wo3HbFmhSya8GzU=", "X-Gm-Gg": "ASbGncsMIiHVPv/1obGUyLhpa1ZkpJtWEoreBKBljYD5jt+C5JCvbe/LqnjnwOTtjQm\n yfxIU7+zi4ny9X1PiB58ruRQU2KwDYqIq24xNy4OmqyC3DB0YmQkMxOBxyxtKdwUPgSEBIY2Ux3\n YSozAWOZGY6irIBotC5SLpbYqodvqYJrG3wlmqM9DLm8Cv3cHn7KZrFot4rWjlqfTplD9qOMLQW\n VICrxbMYNfgfpkQ9FpgdDA+xfuBFHssgdJhm0TAo6quqaqchURGZvxgusQrotpiKKPBwDyi9ZDP\n fePtTqh+j2E43s1fmKpB9jMOOGeVZe445ct4AL/2asGIPhek64U7EIpCxsbrB//JdhILelzZ/nc\n kEVp0GYKsTOa6wCa3bLYYtBxRYWaU115/OnNR2G9Oj0vudENIx6s=", "X-Google-Smtp-Source": "\n AGHT+IEsPg5ylfYhdRIlX0NoIjbFnVImwJOOz7B8+vLz/gk8KN5gT1I1iJAMqyFZRDYUxBMdv47HEA==", "X-Received": "by 2002:a05:6000:430a:b0:3b7:88f5:f0ad with SMTP id\n ffacd0b85a97d-3b8d947248dmr10703887f8f.16.1754403500532;\n Tue, 05 Aug 2025 07:18:20 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Tue, 05 Aug 2025 15:18:18 +0100", "Subject": "[PATCH 3/4] net: mvpp2: Cannot test unsigned variable to be negative", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250805-net_mvpp2-v1-3-624ef87cadb9@linaro.org>", "References": "<20250805-net_mvpp2-v1-0-624ef87cadb9@linaro.org>", "In-Reply-To": "<20250805-net_mvpp2-v1-0-624ef87cadb9@linaro.org>", "To": "Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In phy_info_parse all uses of the variable phyaddr are as an int so\ndeclaring as u32 is not useful and prevents the test for an error return\nfrom fdtdec_get_int ever detecting an error. Change phyaddr to be an\nint.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/net/mvpp2.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c\nindex b68d305a0dc..3a3510f603a 100644\n--- a/drivers/net/mvpp2.c\n+++ b/drivers/net/mvpp2.c\n@@ -4734,7 +4734,7 @@ static int phy_info_parse(struct udevice *dev, struct mvpp2_port *port)\n \tint port_node = dev_of_offset(dev);\n \tint phy_node;\n \tu32 id;\n-\tu32 phyaddr = 0;\n+\tint phyaddr = 0;\n \tint fixed_link = 0;\n \tint ret;\n \n", "prefixes": [ "3/4" ] }