Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2119205/?format=api
{ "id": 2119205, "url": "http://patchwork.ozlabs.org/api/patches/2119205/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-net_mvpp2-v1-4-624ef87cadb9@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250805-net_mvpp2-v1-4-624ef87cadb9@linaro.org>", "list_archive_url": null, "date": "2025-08-05T14:18:19", "name": "[4/4] net: mvpp2: Use field just assigned in error test", "commit_ref": "c6561a467c9f9a77717ddc2ef296866a4d8a6843", "pull_url": null, "state": "accepted", "archived": false, "hash": "a22ff044041002eb8a6b01bb89dcf81e3068299d", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-net_mvpp2-v1-4-624ef87cadb9@linaro.org/mbox/", "series": [ { "id": 467962, "url": "http://patchwork.ozlabs.org/api/series/467962/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=467962", "date": "2025-08-05T14:18:19", "name": "net: mvpp2: Fix some Smatch reported issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/467962/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2119205/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2119205/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=W/4GZlTK;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"W/4GZlTK\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bxFyq2B9lz1xv2\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 6 Aug 2025 00:23:31 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2F2AF831E0;\n\tTue, 5 Aug 2025 16:23:38 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 4306C83744; Tue, 5 Aug 2025 16:23:37 +0200 (CEST)", "from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n [IPv6:2a00:1450:4864:20::62f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C17A8831E0\n for <u-boot@lists.denx.de>; Tue, 5 Aug 2025 16:23:31 +0200 (CEST)", "by mail-ej1-x62f.google.com with SMTP id\n a640c23a62f3a-af958127df5so506031466b.2\n for <u-boot@lists.denx.de>; Tue, 05 Aug 2025 07:23:31 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:60bc:24e3:6dcd:9f35])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3b79c4534b3sm19307801f8f.47.2025.08.05.07.18.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 Aug 2025 07:18:20 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1754403811; x=1755008611; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=CUOurUed+yID5ceKlFVVfCLElow+9pvlvCPmdYk8HeI=;\n b=W/4GZlTK2A7BSh6UafclDpCbd+2j0n3+7ReBOjAflmFOws07BvmuWkN3bCYK0u3YBK\n q2aB7dLy9hP8cJ5t/0I+9p+f8w6ou6E3Xb/lop3/8S5gZeGU9MEPgkJKsGRymWnqBQnK\n 1Na7GPtqi38p+B28Zd4pf8z/6BppkGF+ZyX1lZhBEJhw0X0jVuBqXlM206Erufc6TE7w\n 6aXQkvaphyqhJmNlHfXq+kNX5cAG16TSdf/WXJJSq2g1A/+KD3ebieOOXYe+AYYS/+gn\n iIUnCBT3fJxZ5GPuKUdA3DAIHN0tbfuwn45T31OrXfjyxOg7ABzxjf41bJWAnOYaGcw6\n Bf+Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1754403811; x=1755008611;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=CUOurUed+yID5ceKlFVVfCLElow+9pvlvCPmdYk8HeI=;\n b=trpX+9FPyk8wIAUbv+0JaGRuMYNxbmsP3MWpw5aHDMbqbDcR9nL40/58rp1v+XCQEr\n ttY+pa3ziENWK3uGu4WQagRZM2GXuqescht2Ci19qAqBCgXcfIL++5/pJ1rw6vzlDQu3\n aseEYGOMhgfumVneFG+tcMHTtJu1P/X4vettNgn7OYcgZPzrM+o3iaOWPgauKiFL+49+\n /CNfjEl1yHgrWme74vbxzYO/akp6C+adAlwXiAApyS6zCW0f7JA3rUeZfFQ5xWWlcySZ\n kwPsGNXudm6JK4paKOYDHvDNgLRqHo85mms2QwBF94LsoFPJWmpprRaXQDk5IFKAHPfo\n jNQg==", "X-Gm-Message-State": "AOJu0Yy4VKipyBEkPjCICwfkI/ocEKB7ibfkiR0kkFj89TlY0G8Jassz\n bpvXI6ekIc30zPqe8kEvL5cVb1jzAqw2icTBfZnPlwRSRkjmBg4nSO2uCWL52khFQKPgWFXTWNt\n U6lek", "X-Gm-Gg": "ASbGncsfO6vpZte4uH1AtfFFnThI4bVlV/1Nq1ZDQ6YfI6Yz13lohmHBsYL4BF9Pj+5\n xmb/5Z7k2KrErWB73jTTiaFhGFi4e7h3YlJrD4P2qwwwt3/ge57fooISf0kiJYKriclyXajt8d3\n deMH/mlO6jAwZwSrYH/WAngcGWQuFriuRhAK0sDlgkxNT6ulOwi3+e331Dcks/5MOqSnNxeAqUP\n LJX+I8cy969/q+qsqROES1in4v6cSUNl+F0aRYMKKSPoykhmoI3YzVWv6ZU+c7Y6YJ7m6iXrcS0\n m7qyKR3G9Hm4uIAIuSdjwzNlyZSlLBdQBOFjDdGUro1cZMLqZ5IDXTlZ3G5ZnXXjPfen2Lz0h1b\n YKjV5pUGr9x/pKStZkJf6sC+qS495WxgdqyEABeBox54UcUoPQw4=", "X-Google-Smtp-Source": "\n AGHT+IGEaj/lN+0lFsLRV/kZjIJkBbaGolVqJLK+sFoB4awTDCHx395t+xTFz/1334EU2CIhQq4m8g==", "X-Received": "by 2002:a05:6000:2313:b0:3b7:8e91:fd7e with SMTP id\n ffacd0b85a97d-3b8d94bb1b1mr10519983f8f.49.1754403501287;\n Tue, 05 Aug 2025 07:18:21 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Tue, 05 Aug 2025 15:18:19 +0100", "Subject": "[PATCH 4/4] net: mvpp2: Use field just assigned in error test", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250805-net_mvpp2-v1-4-624ef87cadb9@linaro.org>", "References": "<20250805-net_mvpp2-v1-0-624ef87cadb9@linaro.org>", "In-Reply-To": "<20250805-net_mvpp2-v1-0-624ef87cadb9@linaro.org>", "To": "Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In mvpp2_probe the code attempts to get a value for \"gop-port-id\" and\nassigns it to port->gop_id but it then tests port->id for being equal to\n-1. That is an impossible test as port->id is a field of type u8 so\ncannot be negative. Change the test to port->gop_id.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/net/mvpp2.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c\nindex 3a3510f603a..f9e979c4d58 100644\n--- a/drivers/net/mvpp2.c\n+++ b/drivers/net/mvpp2.c\n@@ -5353,7 +5353,7 @@ static int mvpp2_probe(struct udevice *dev)\n \t} else {\n \t\tport->gop_id = fdtdec_get_int(gd->fdt_blob, dev_of_offset(dev),\n \t\t\t\t\t \"gop-port-id\", -1);\n-\t\tif (port->id == -1) {\n+\t\tif (port->gop_id == -1) {\n \t\t\tdev_err(dev, \"missing gop-port-id value\\n\");\n \t\t\treturn -EINVAL;\n \t\t}\n", "prefixes": [ "4/4" ] }