Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2119152/?format=api
{ "id": 2119152, "url": "http://patchwork.ozlabs.org/api/patches/2119152/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-ldpaa_eth-v1-1-7b5708536351@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250805-ldpaa_eth-v1-1-7b5708536351@linaro.org>", "list_archive_url": null, "date": "2025-08-05T10:52:00", "name": "net: ldpaa_eth: Fix buffer overflow in memset", "commit_ref": "ed3b08874f4c47e287a1f0eb36fc61ff7d778cc9", "pull_url": null, "state": "accepted", "archived": false, "hash": "fbe66b8aea85599d503d410ac609e9bb2f733411", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-ldpaa_eth-v1-1-7b5708536351@linaro.org/mbox/", "series": [ { "id": 467934, "url": "http://patchwork.ozlabs.org/api/series/467934/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=467934", "date": "2025-08-05T10:52:00", "name": "net: ldpaa_eth: Fix buffer overflow in memset", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/467934/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2119152/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2119152/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=qoPFHztD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"qoPFHztD\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bx9Gm4jS5z1xpj\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 5 Aug 2025 20:52:00 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8CA93835C7;\n\tTue, 5 Aug 2025 12:52:06 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 424C6835EA; Tue, 5 Aug 2025 12:52:05 +0200 (CEST)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n [IPv6:2a00:1450:4864:20::330])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 5941C835AA\n for <u-boot@lists.denx.de>; Tue, 5 Aug 2025 12:52:03 +0200 (CEST)", "by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-459e210bd2dso1981655e9.1\n for <u-boot@lists.denx.de>; Tue, 05 Aug 2025 03:52:03 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:60bc:24e3:6dcd:9f35])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-459dfa64da0sm49988875e9.3.2025.08.05.03.52.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 Aug 2025 03:52:01 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1754391122; x=1754995922; darn=lists.denx.de;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=y0O5D+coKNAIZaHWowBvFGyxvBU/CbD9hrIJNYXQ+0w=;\n b=qoPFHztDlyD3i3rcxbIaPEm5SUuAO5VrCZWZxU1d9J/jHoCdUOOXPA9XrwZn5RxHuy\n DG5HKzzXH0xe9PjuNcUI3G0o54Vu9ae8S+Jh8BBo7+T8fwj86Ti9pfg6gOS7/CQnHDcd\n 04KVHMp3v8ED5MWHyNVMLmf09Kl9014Tin9/0B3MVf70xFy68/Ee+dY+tpqrpthk27K+\n LrEBjw9WMWqJ6xugOum1JYSX9CNeHFGHOotUXSV0yfXOFiNGnJexgEutHHJlbKZeIXJJ\n aHr25kd5u4O0RJD+9+I+bI+aOm2nORgkcXK7U3rxOqxSelw01sqViPKTyMC+2N1sRCRH\n ebAg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1754391122; x=1754995922;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=y0O5D+coKNAIZaHWowBvFGyxvBU/CbD9hrIJNYXQ+0w=;\n b=PLKQcDWjvnMjUPxoZi1bFcYSWWmDk5W91QBAiVhEij8sMWyw/bODKrE2wBcwB1nahp\n j3M+aweMDIW2rusnInYV+uTjc3uJOAP3wH5NGd8FHktHcwEp6iPzicr9J2P8hVosQrG6\n U2UlF4dzMoQtrzcsYvvtzMdt8Wp9uK/xBe4a1pRY7K3i3bsipobstBbeW1JDFtpPtl7o\n YkH7lxHyc3Gl4Ovrs0F9VE7gQJo4eUiuic/fooxLhe14vWHJUfKZLOKrbIUFb00+5tUt\n gaa8oTOEqKt4lnUXgN7yormmJJ/wSwNucdQo5V5BNKuMd09sKhlC65sZXrdqJ5mN169Y\n J+nw==", "X-Gm-Message-State": "AOJu0YyGIIYTnSS4k7gUuTb+l9gr+SuzpoYMx8RRTJRsQzVp132WZqQy\n +donWLRU9ivj8M7Bd1HaDwBXOcxcPmqAkaPUBYAxXATnaOmxL8J6ilOqHSvtJ7ppI8wTm4sJn3K\n o+iXn", "X-Gm-Gg": "ASbGnctLyLkIhy9VpfNutyyZ7RMbawI4eY3Fc3Z1+S6W5Tsqnaeu3kRw6lO6L5Quc2t\n lyreCJxU0lMqzuQytPg23i0Cxa9Pmr+CX4mi2rig7q8Q7FDvl+sibMwKJoGNjBdA+8EnV3ekMRU\n QZWYqeUdReJ4iCNZbCBNIvQwn1FuuhJj+Ym4YrFSkZHqDYttKIE3l1fPQpOtsqMOyXabUQAuVGJ\n CB0B90jEaI4EYLcFJu7UL9vPARIEzzoNP7Uo2P9Byf8HHngvOG38d/wOA1dRnic1W+YWYSLh342\n 3h3/to/QebcrkySNuTBncTEVBm5Tz144T/qMnfSYGu8yT3SJ0oUKRhlxlEXHqBHY+rWWQ2iIQFM\n datPI68rr4CJ3569nXeCBLyYIQ5gU8lsUdHgq75RZXxx7uqIwkH0=", "X-Google-Smtp-Source": "\n AGHT+IFCW/pPrD8h2HH/BIX+LgnQnZwr5uvE0Zz4T6YCriGIQzqIUPC3uqJ7UM56seG8r9t0pU4ZDA==", "X-Received": "by 2002:a05:600c:5009:b0:458:bf15:689c with SMTP id\n 5b1f17b1804b1-459e0cbf62bmr27120075e9.2.1754391122449;\n Tue, 05 Aug 2025 03:52:02 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Tue, 05 Aug 2025 11:52:00 +0100", "Subject": "[PATCH] net: ldpaa_eth: Fix buffer overflow in memset", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250805-ldpaa_eth-v1-1-7b5708536351@linaro.org>", "X-B4-Tracking": "v=1; b=H4sIAE/ikWgC/x2N0QqDMAxFf0XyvEItKM5fkTGSGteAdpLIGIj/b\n vXxcM/l7GCswgZ9tYPyT0y+uUD9qCAmzB92MhaG4EPjO9+4eVwR37wlFyMRhe5Zt+ih+ITGjhR\n zTNdjQdtYr2FVnuR/R4bXcZxoDE6sdAAAAA==", "To": "Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In ldpaa_eth_open a memset is used to initialise a struct to 0 but the\nsize passed is that of a different struct. Correct to pass the sizeof\nthe struct that is being initialised.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/net/ldpaa_eth/ldpaa_eth.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\n---\nbase-commit: 007610da2cca405ea7739fc120d90085be4b6ac2\nchange-id: 20250805-ldpaa_eth-ccbbb28916a0\n\nBest regards,", "diff": "diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.c b/drivers/net/ldpaa_eth/ldpaa_eth.c\nindex b72198ca530..94e62748239 100644\n--- a/drivers/net/ldpaa_eth/ldpaa_eth.c\n+++ b/drivers/net/ldpaa_eth/ldpaa_eth.c\n@@ -458,7 +458,7 @@ static int ldpaa_eth_open(struct udevice *dev)\n \tlink_state.up == 1 ? printf(\"up\\n\") : printf(\"error state\\n\");\n #endif\n \n-\tmemset(&d_queue, 0, sizeof(struct dpni_queue));\n+\tmemset(&d_queue, 0, sizeof(struct dpni_queue_id));\n \terr = dpni_get_queue(dflt_mc_io, MC_CMD_NO_FLAGS,\n \t\t\t dflt_dpni->dpni_handle, DPNI_QUEUE_RX,\n \t\t\t 0, 0, &d_queue_cfg, &d_queue);\n", "prefixes": [] }