Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2119150/?format=api
{ "id": 2119150, "url": "http://patchwork.ozlabs.org/api/patches/2119150/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-ks8851_mll-v1-1-011a2a310641@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250805-ks8851_mll-v1-1-011a2a310641@linaro.org>", "list_archive_url": null, "date": "2025-08-05T10:34:29", "name": "net: ks8851_mll: Remove unreachable code", "commit_ref": "5deb50f749659746233e08060b457c9cf9986f9c", "pull_url": null, "state": "accepted", "archived": false, "hash": "b644f86ad77b6a1f7d42844ed52c70ca5454c57a", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250805-ks8851_mll-v1-1-011a2a310641@linaro.org/mbox/", "series": [ { "id": 467933, "url": "http://patchwork.ozlabs.org/api/series/467933/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=467933", "date": "2025-08-05T10:34:29", "name": "net: ks8851_mll: Remove unreachable code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/467933/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2119150/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2119150/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=subob61D;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"subob61D\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bx8tn1bMBz1xv2\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 5 Aug 2025 20:34:41 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 86C1D834BC;\n\tTue, 5 Aug 2025 12:34:38 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 245FB834D4; Tue, 5 Aug 2025 12:34:37 +0200 (CEST)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n [IPv6:2a00:1450:4864:20::330])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A144D82E52\n for <u-boot@lists.denx.de>; Tue, 5 Aug 2025 12:34:31 +0200 (CEST)", "by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-459d4d7c745so22450085e9.1\n for <u-boot@lists.denx.de>; Tue, 05 Aug 2025 03:34:31 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f9e:3c01:60bc:24e3:6dcd:9f35])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-459e2a28bfasm19165305e9.21.2025.08.05.03.34.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 Aug 2025 03:34:30 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1754390071; x=1754994871; darn=lists.denx.de;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=N6g82YYA6+RYbdImKsThWTuBXLARtwNTH2i4F0a9vH8=;\n b=subob61D1iIlf7Ga8OlDw8zCK/j9HpYlgzRxJbXqdnUGiepx6M/jA4QHaW02bonFE8\n VAU7Y5zNizScOsd/n2zemlojHD2rrwRTtbzILrjvD70lQ3LkXD+lo8BCTCut1uTe2QQo\n YakU5EecAOsQc059R/0TljngNs/USYEoh5BAX9D7uwd6/+wTZa3/kunytI7+9Zt4JM2U\n WpNGDcK6DVoBjVQ10k0/1z2nnvc5cRskCe8kCk3lT27ORKw3X90y+UB5Fx8+jb9e/xTl\n Hh0IeN6IM2o90IA1FOx7JbWoj0JM6huzzGKd8zlJ4rHlGHj5nE0SCKoXlDsCUybwCIeL\n xkrA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1754390071; x=1754994871;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=N6g82YYA6+RYbdImKsThWTuBXLARtwNTH2i4F0a9vH8=;\n b=ZloNrS9lNi7z5hxBsK5OlqTuwG9Ch4qI5V/uRBiYw9cZtnRxqNv1soHWzmHYMCOpCA\n 109YrB8oBjx4s587nSz8mqcOp9bIUVH3qEfKZ7qs6A+yDm/4SKFZQueHCB+PCrXzamX2\n IFwP64atOnSe4yWyB7b3TaDecrxUXyVIY2lhGWRezTs2h0Ec/o2NyDMx6ShixwHG36UR\n 9lW4eBJ1xUNYd631Y0NvMc9P3MJbW85rqvNnnZ/8+Npv2qW8PR/5gciU2EhbU7MO7RRL\n VnvVFv31G2Ma+tf6i0pe3i7C/vGPNVx065MgvvuL7doZ9D3y/lrGybwFj4YNcZh/Yjms\n GYOw==", "X-Gm-Message-State": "AOJu0YwVguex9Fe6y9HhS0F4Jc9T8y3b9wHT/Pj10RPWEbzonB4qV/uh\n aKcdmSVWE9ZVCvFh4HBksZ53IZINdpnZc7rMt2A6X826Ux+eR4F+t+6RlL786BiTSUcOycSEJh6\n fh/lu", "X-Gm-Gg": "ASbGncu8jJoG0C+VgcRTEJdM2CnVFiKuJ4Jnu8dX+pk+kvSjxxhqFvlGFapJJYtZIxJ\n wF9lvhQD8ssoTotz8eXiCz+iKBNQXOdPPgLridSrXkpBvRtzeLDHNSp5B9K3dL2b0Bui6dyC3Qq\n fEiD2C1grZW4poERH5tONqOi4Ngtc4nh8GIwvaDpH7p+rw8kEahQl7zyfPly4Z96XaAQNMJ3t9E\n EQAawcfnxDuq794wm7KRGePrK95+RcK1sTOdQ7NV2478jNFOVIcbOn2cVZsBzriP/V0BTxi75t0\n xFOlbvAT2rI5juy7kZD0rNgswpsygTzfm9MxdtmH7c2lZu/xvM5+j+tCN9cl+NSpFlmqvwM1cZY\n Lw5+4k4bb2TKLrlpYEM1YmjDLTZ1EdogktQm2xHI7oL1F73rbhrs=", "X-Google-Smtp-Source": "\n AGHT+IHRZ4h64TX+2mZGYuiHC7hvylvJO6Y4pk7emoSFW0riRU8PDwjuHVFoXRE7CvcLW94OnB8nlA==", "X-Received": "by 2002:a05:600c:630c:b0:456:dc0:7d4e with SMTP id\n 5b1f17b1804b1-458b6b3327cmr108378985e9.18.1754390070959;\n Tue, 05 Aug 2025 03:34:30 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Tue, 05 Aug 2025 11:34:29 +0100", "Subject": "[PATCH] net: ks8851_mll: Remove unreachable code", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250805-ks8851_mll-v1-1-011a2a310641@linaro.org>", "X-B4-Tracking": "v=1; b=H4sIADTekWgC/x2N0QqDMAwAf0XybKGtFrr9yhBJazbDtBvJGIL47\n 6t7PI7jdlASJoVrs4PQl5VfpYJrG8gzlgcZniqDtz7YaIN5aozBjeuymMvkKHfY+0w91CChkkm\n CJc9nsqJ+SE7xFrrz9r/chuP4AcCHSVd1AAAA", "To": "Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In ks8851_mll_detect_chip the if..else code detects the case of (val &\n0xfff0) != CIDER_ID and returns if found. So testing for this again will\nalways fail and the code is unreachable. Just remove the test and code\nblock.\n\nThis issue was found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n drivers/net/ks8851_mll.c | 5 -----\n 1 file changed, 5 deletions(-)\n\n\n---\nbase-commit: 007610da2cca405ea7739fc120d90085be4b6ac2\nchange-id: 20250805-ks8851_mll-9d1ec3a42ce4\n\nBest regards,", "diff": "diff --git a/drivers/net/ks8851_mll.c b/drivers/net/ks8851_mll.c\nindex cc2e826257a..2c956154d09 100644\n--- a/drivers/net/ks8851_mll.c\n+++ b/drivers/net/ks8851_mll.c\n@@ -347,11 +347,6 @@ static int ks8851_mll_detect_chip(struct ks_net *ks)\n \n \tdebug(\"Read back KS8851 id 0x%x\\n\", val);\n \n-\tif ((val & 0xfff0) != CIDER_ID) {\n-\t\tprintf(DRIVERNAME \": Unknown chip ID %04x\\n\", val);\n-\t\treturn -1;\n-\t}\n-\n \treturn 0;\n }\n \n", "prefixes": [] }