Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2108402/?format=api
{ "id": 2108402, "url": "http://patchwork.ozlabs.org/api/patches/2108402/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250708-net_fix-v1-3-292b9aa20f31@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250708-net_fix-v1-3-292b9aa20f31@linaro.org>", "list_archive_url": null, "date": "2025-07-08T16:51:18", "name": "[3/3] net: wget: Fix comparison of unsigned variable", "commit_ref": "9104267e676bfe254f742b56329e7c3442a2b144", "pull_url": null, "state": "accepted", "archived": false, "hash": "3816c252e65b54bb9ff8190ac3d88db7f294bee9", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250708-net_fix-v1-3-292b9aa20f31@linaro.org/mbox/", "series": [ { "id": 464249, "url": "http://patchwork.ozlabs.org/api/series/464249/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=464249", "date": "2025-07-08T16:51:15", "name": "net: Address some issues reported by Smatch", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/464249/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2108402/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2108402/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ix2CEGtt;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"ix2CEGtt\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bc6Zk4XFQz1xqF\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 9 Jul 2025 02:51:42 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 10F57833F6;\n\tTue, 8 Jul 2025 18:51:25 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 3852F832F0; Tue, 8 Jul 2025 18:51:22 +0200 (CEST)", "from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n [IPv6:2a00:1450:4864:20::329])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4A30E832F0\n for <u-boot@lists.denx.de>; Tue, 8 Jul 2025 18:51:20 +0200 (CEST)", "by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-4538bc1cffdso39973175e9.0\n for <u-boot@lists.denx.de>; Tue, 08 Jul 2025 09:51:20 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:e07:801:a08:6480:3e01:6cde])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3b47030ba29sm13232481f8f.2.2025.07.08.09.51.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 08 Jul 2025 09:51:19 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1751993480; x=1752598280; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=saLc7Ttr2rKUA03E3pXnBlxHwNEFejMn26nVse0aVcI=;\n b=ix2CEGtt5DRCB/ybUBMnvp2NAYlyApBYDn88QYFnKspXp/2GqhDYyp3GLIFetH1W4R\n zj4rC5YUX+2aaE+nJUOyNY6LwYxxYkRDXj/TOloIGSbpBo+95MLmX/TvszKXo1F0d9dS\n 3ZI+MpN4lk/jXjHwaveCOOgaONJl5RNlqkg6ayR6NS9WnaYT+Jh1g0rR9GjavJeIvpd/\n 0OFr6XYAbP4+tBc7Scruj+rse/rYxmDOWsyHOvwaN5GLpUfqxRNb/KuFhFyHVUaCnUeN\n uMUwTPvFUeRUxjJVfie4IpdUVQkazTir1sy2pAMvjSOxsa4v0DTcBn+pb81BvJX/UTfc\n viWg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1751993480; x=1752598280;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=saLc7Ttr2rKUA03E3pXnBlxHwNEFejMn26nVse0aVcI=;\n b=is+86tsHCDKh1xVs2ZuM5jCn2bV7LR+e7+1Jyf6HZwg/DRmeCowHVNYaXqj796x/oL\n b9qYIlTbwDamAHlNqts+tRmo5CnEF4ezzBcXdFQEmCYt0HOAizPq8HBWGjqcJFxHT4Ze\n i7B37dLhqam3KbUPflp7S1cG49BbWefG6pIV+hafyd3BW/KHX8v2Exb3exF0W9eS1lLG\n HLZJTNLMAtDmNWdttjP5zJKqtg2V9IFvfAiHQb2D5kySCRh0gnqMXs2DX2kzHhshWG9Q\n mNQfAnpeHCXmg2/OzR4ncjvoruY5ncM3YX4mxKVAM0EUz1CXRdesnynuQpENOsK08xZa\n C3eQ==", "X-Gm-Message-State": "AOJu0YwHiMf1jZxu6guDNd/nJAtz+fz5LS5LfubuZG0iroELXFTeFp4d\n LWrOLVnLlJgV2fkYOFOc4Lr23ZXinJ/2JLb960IQFyyktCmQKQJxXF5m4KptXqXI1X4=", "X-Gm-Gg": "ASbGncsELqYp3vd6c3ypxLAzUdAsPGyx58TKtY7yD2823z6ZB17z996iKvpsbzBzUex\n WBBXEN2RnhZD5JBh6yB7Smh/gt0aCKKLobhnloJNL2JdHII+KSR7cbBFZdokYJkP44L2C9/3Mwn\n GI8b02QX9WUuy5bQFxO70y6dGV6DaC9JT/yDUCMOsmT+6GKAs2ra+dE+S5cJLZdnuGmr7UAaDsH\n L6lcQN6Cy1OV2Xuy1qeQvhxCUehUhBZQLkKJ2YqWJUyTTErsZdZhw3wAPQ6171T+5lMRc+kRs5v\n 7X68jm8nkV7J33I3BnIHiMwtZeg/ROZTq8Fr2Vt841DpnRSxOt6GxGY+o6gjHHyovxduBvUR9sm\n JvSnyrcFPSNBH", "X-Google-Smtp-Source": "\n AGHT+IHubuIufltS3+W25BbtDO2bc1Q2AWSL9JD6H7vkPnzgG9C0o9+oMT1NiLrZqMJNZtEl5pNZbg==", "X-Received": "by 2002:a05:600c:6383:b0:453:8ab5:17f3 with SMTP id\n 5b1f17b1804b1-454b4ead145mr126490295e9.22.1751993479632;\n Tue, 08 Jul 2025 09:51:19 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Tue, 08 Jul 2025 17:51:18 +0100", "Subject": "[PATCH 3/3] net: wget: Fix comparison of unsigned variable", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250708-net_fix-v1-3-292b9aa20f31@linaro.org>", "References": "<20250708-net_fix-v1-0-292b9aa20f31@linaro.org>", "In-Reply-To": "<20250708-net_fix-v1-0-292b9aa20f31@linaro.org>", "To": "Tom Rini <trini@konsulko.com>, Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "content_length is an unsigned long and so testing that it is >= 0 will\nalways be true. Instead test that it is != -1 as that is the condition\nset on error.\n\nThis issue found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n net/wget.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/net/wget.c b/net/wget.c\nindex 3c0fff488eb..428ee072330 100644\n--- a/net/wget.c\n+++ b/net/wget.c\n@@ -214,7 +214,7 @@ static void tcp_stream_on_rcv_nxt_update(struct tcp_stream *tcp, u32 rx_bytes)\n \t\t\tcontent_length = -1;\n \t}\n \n-\tif (content_length >= 0) {\n+\tif (content_length != -1) {\n \t\tdebug_cond(DEBUG_WGET,\n \t\t\t \"wget: Connected Len %lu\\n\",\n \t\t\t content_length);\n", "prefixes": [ "3/3" ] }