Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2108401/?format=api
{ "id": 2108401, "url": "http://patchwork.ozlabs.org/api/patches/2108401/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250708-net_fix-v1-2-292b9aa20f31@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250708-net_fix-v1-2-292b9aa20f31@linaro.org>", "list_archive_url": null, "date": "2025-07-08T16:51:17", "name": "[2/3] net: Incorrect NOP macro used for test", "commit_ref": "c29c5ed2966425a14aab6794e739a78ab46178a5", "pull_url": null, "state": "accepted", "archived": false, "hash": "02307b96466156f0e4c1369c50ebc3aa112b8a9f", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250708-net_fix-v1-2-292b9aa20f31@linaro.org/mbox/", "series": [ { "id": 464249, "url": "http://patchwork.ozlabs.org/api/series/464249/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=464249", "date": "2025-07-08T16:51:15", "name": "net: Address some issues reported by Smatch", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/464249/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2108401/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2108401/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=a4MUhV5O;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"a4MUhV5O\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bc6Zc0dmtz1xqF\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 9 Jul 2025 02:51:36 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C17EC833E9;\n\tTue, 8 Jul 2025 18:51:24 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 0E4C68331D; Tue, 8 Jul 2025 18:51:22 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n [IPv6:2a00:1450:4864:20::335])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 70D4683394\n for <u-boot@lists.denx.de>; Tue, 8 Jul 2025 18:51:19 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-451e2f0d9c2so770285e9.1\n for <u-boot@lists.denx.de>; Tue, 08 Jul 2025 09:51:19 -0700 (PDT)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:e07:801:a08:6480:3e01:6cde])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3b47030ba29sm13232481f8f.2.2025.07.08.09.51.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 08 Jul 2025 09:51:18 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1751993479; x=1752598279; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=hr9t4HxaAXdbN5CkVvOLZHlW1UzXzKlmhNm8IvngZW8=;\n b=a4MUhV5OMpO1bMWXprbB+R2PsPqzZ0bbSMHU/ua0Y1aw9xfj5rVdYi+A7a6Mh9dtJ3\n VgK234/4SSC8tCVUDFpDBff6GmBE19NmFGc6yCdUZpUMVrhFzpHstDU6GGUKAzo2ERs2\n 3NwHNMX3BelKKjyC5kO96p4ZR1CAf/NsWcfopQ5MAsHgjXDanKcBwQnoChXhQYDIyG1S\n HTHbb1F79KkVHVTj4y/IOk55rcr71GiygaXNH5EYg/nPyAQ+Ln6yzxu7l8q8p0b8vn3K\n edtS34GsMFG+VuyrZBZsixJuDCDZYRpv8aS297wKjr4tuqXK3aVvxchkx4BNo6BGvSC9\n drpA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1751993479; x=1752598279;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=hr9t4HxaAXdbN5CkVvOLZHlW1UzXzKlmhNm8IvngZW8=;\n b=B8F8Q0/ST84gr+MMBDaXGZzAyOH+yNQojdcg0BAtEM+a6teu08wJgMf70Mj2PCfPJr\n e3LDTadfiW3qmLeutlViANco3UXekbf24fxlLJwLP2nNsBRTeq49Fd1yjUeO00+FY6+p\n mWoDvnHGoIcCymoKZflkm2VrbjRfe/IW06GxqtlHOMKnEwxIMmJAYIU8N6IAavyikra2\n HhGWkuXvqxYeobUTsc0M0r8+kAzllFZvnLkiTGsNWFMwzKE16Mruz5qaV5MHBVT7MVeb\n LMb4drx7heWJq+w2v7AQ0tsdSUpY2+IlRhEtSqYzdJxpdEnHgU7npRz6C6b+se32TFDZ\n +0aw==", "X-Gm-Message-State": "AOJu0YxhCSG3zSL7KtzwdFvXYs617SA8PgIVKg2hhA8lW7YoKnfoPyqF\n yb2USJu1pqxk1tst76Sti9koBvdH+FeACSWq4tQ2kvjWWSGf5oCFPDc4pvtkzqigJ84=", "X-Gm-Gg": "ASbGncu1KVu7sRcUbx+kunj6f9GGxa8plpBBrq8csxZjgptVsTVw4DgdFGlJLCz/SkW\n HgXL+dQoUJhqL5PaVe8ANFAbjIhUTqutb/qTCMPdERgKRvRdSncHKz1Y7k07ZarEcmFW0bdMUE1\n VL53dP1rmJnHiji8N9w0RfL0cPVfdd3BLVIov/kaXWnPw29/lMNVujSiIELg/0BG8ks8/USoJas\n Bck0fk6yxKJxNuriahGO6xOnbBMrWRGotR3vbuqJTKEl8uh4uvf+GAxWC1oEks/g3ogbAoF2E50\n CCqBIdoOxBnp3gRne6tYYvX9uZ0bg+iPI3iG7kPGgFNmpDbAz3scvU8J4imYWh2PfCDMVcCsm7/\n vUy0PIh4d1+zT", "X-Google-Smtp-Source": "\n AGHT+IHvQ7nT4bZHAwI7Bpz+zrVAD9sYLpoorCc3yei1zzicnh0BnHnbj/o6Q6GFNvZvB7ugpa9g6g==", "X-Received": "by 2002:a05:600c:3e10:b0:439:4b23:9e8e with SMTP id\n 5b1f17b1804b1-454cebf6f21mr37191235e9.3.1751993478878;\n Tue, 08 Jul 2025 09:51:18 -0700 (PDT)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Tue, 08 Jul 2025 17:51:17 +0100", "Subject": "[PATCH 2/3] net: Incorrect NOP macro used for test", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250708-net_fix-v1-2-292b9aa20f31@linaro.org>", "References": "<20250708-net_fix-v1-0-292b9aa20f31@linaro.org>", "In-Reply-To": "<20250708-net_fix-v1-0-292b9aa20f31@linaro.org>", "To": "Tom Rini <trini@konsulko.com>, Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>", "Cc": "u-boot@lists.denx.de, Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.12.0", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In tcp_parse_options the uchar p[0] is attempted to test for a match\nwith the 32bit macro TCP_0_NOP which can never be true. Instead test\nagainst the 8bit macro TCP_1_NOP.\n\nThis issue found by Smatch.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n net/tcp.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/net/tcp.c b/net/tcp.c\nindex 2635727f47d..8740150365f 100644\n--- a/net/tcp.c\n+++ b/net/tcp.c\n@@ -804,7 +804,7 @@ void tcp_parse_options(struct tcp_stream *tcp, uchar *o, int o_len)\n \t\t}\n \n \t\t/* Process optional NOPs */\n-\t\tif (p[0] == TCP_O_NOP)\n+\t\tif (p[0] == TCP_1_NOP)\n \t\t\tp++;\n \t\telse\n \t\t\tp += p[1];\n", "prefixes": [ "2/3" ] }