Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2102550/?format=api
{ "id": 2102550, "url": "http://patchwork.ozlabs.org/api/patches/2102550/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250625132108.3292932-5-jerome.forissier@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250625132108.3292932-5-jerome.forissier@linaro.org>", "list_archive_url": null, "date": "2025-06-25T13:19:12", "name": "[v4,04/13] lwip: split cmd/net-lwip.c into one file per command", "commit_ref": "ba814b8b5a74d1bc0cecd3f6031eecb025f28f15", "pull_url": null, "state": "accepted", "archived": false, "hash": "c86f9c62acbce6b452886dd3f8debaec84103f3b", "submitter": { "id": 69192, "url": "http://patchwork.ozlabs.org/api/people/69192/?format=api", "name": "Jerome Forissier", "email": "jerome.forissier@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250625132108.3292932-5-jerome.forissier@linaro.org/mbox/", "series": [ { "id": 462405, "url": "http://patchwork.ozlabs.org/api/series/462405/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=462405", "date": "2025-06-25T13:19:11", "name": "sntp for NET_LWIP", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/462405/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2102550/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2102550/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=HsbK6Jkw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"HsbK6Jkw\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=jerome.forissier@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4bS2XP6cC2z1ydW\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Jun 2025 23:21:41 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id BE61082E05;\n\tWed, 25 Jun 2025 15:21:39 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id B666B82E40; Wed, 25 Jun 2025 15:21:36 +0200 (CEST)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n [IPv6:2a00:1450:4864:20::336])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 75B6082CBC\n for <u-boot@lists.denx.de>; Wed, 25 Jun 2025 15:21:31 +0200 (CEST)", "by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-450cfb790f7so11691565e9.0\n for <u-boot@lists.denx.de>; Wed, 25 Jun 2025 06:21:31 -0700 (PDT)", "from builder.. ([2a01:e0a:3cb:7bb0:af71:dfb2:66ef:80c3])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3a6e8068fd0sm4760042f8f.38.2025.06.25.06.21.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Jun 2025 06:21:30 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,SPF_PASS,\n T_SPF_HELO_TEMPERROR autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1750857691; x=1751462491; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=DBQHf69ZLJLZrVJvTLOhTYZYwmNTkk9oVoGrpZ1NPn4=;\n b=HsbK6Jkws0aIUJ5LDlUR5X1gG62T6ZLrC05MkOMAYc33fPZwy7QnsRNDS1guH6W7re\n zB1QQLtYXcbND+x9ewuIvpztbOVKhTW3mlHWpVpbpvfE+ScUW1CUZQXNROV1Ex1OkDGX\n wioflZ49ALkXe6REMhNYwddJ9VzTEzk5s/h9k8h3omgBGUjRKJvgoPa2W/i46ePb5qjB\n +1RsDGUqP++5YNc7GszM3GaDIIEYsm511NVTPXiYogRHuJRWX4QVVugNIxepz2Ye5veP\n txqhuVvH5LPDohFh9G0CBfB6FJKLcy2lYYYoCe58WPWGl6VXBfMIZT4XFiv7o8If99vx\n XRGA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1750857691; x=1751462491;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=DBQHf69ZLJLZrVJvTLOhTYZYwmNTkk9oVoGrpZ1NPn4=;\n b=rBemIXVfWCS1ETMQiGlfrfX/VCn+pAbcF0i38UhQu2C3Nm+rkABWiJGabwWLtuKVbw\n k1Ng/fgiuvCL1VPYkAJ60GGy0q5JCo7WDRIkhcIGpRI62hTenWp4iihBcx2BLMe0YTGI\n tDDBHNuoUZr5494APaXaLAeG47cU6VZYCpnfp05ktxpcFWIT1NvH1rRx2h/84znobekz\n 0YXQT83uXo/sKNwLsFp6KYmUKeryGeakzBNrc5RKZJJsR0vvz9540N3MhiAbzTXi5CAD\n SsbBc4FeHUOsEKnV46IdtP/CEWa+mKJO5T91pY4C1toaBzPPk4O5UjbDif8eo7d2rg8s\n SX4g==", "X-Gm-Message-State": "AOJu0YzCPAR5KyTWcuI6+Hb6hnOqp3XJjBJxJtL2MZ4IcnL9mF2wLKXm\n s/2uDToHPYCgWxM7fdrjHjA8XMQIjcEi09qiiNGdcpOZ2OaON+NHUNElpdpdAp/i26GXklyQPMb\n uM7afls8=", "X-Gm-Gg": "ASbGncsmz33amNsoVN8FS1HRXdYi+JUgKkrd5dIMZgmR3VPY70zKQVDkkeFPsxic9jX\n eWH9GhFvP03jIHWNXo7XJlyH1mkqeiukDONNxblkgyQaOEa1iu9m+f/HTnUTiX+HxKm/sDRB8C1\n +oxnEvB4hWPbCv1o3k/XPYKwL0Y/XSz6r1MFtRSSdwAGObnn9CP43vOJzSmygZfOHVTrwZ6Bn/w\n pJuWIk8cKYtlNg5cPCME5FwMsbz1k2/cztT2b1ahH5rkXnZ0Q5ApC5USQkTF9+4v7SF0GCFhRP4\n kJUkv8Ic2Kht7B3GfHfMUHS/iuVKrjndMPMk//hf564z1ySXdsCL4fK9y1N1nHIfL/25RJw=", "X-Google-Smtp-Source": "\n AGHT+IF1OvFEhhJystEO0Fi+tHNj3Shw4dOb7rGHPvFZuW7xA6ZcSj2eT9KbGfmEFdPnGWHQ6a6mYA==", "X-Received": "by 2002:a05:6000:2889:b0:3a4:f430:2547 with SMTP id\n ffacd0b85a97d-3a6ed5b8846mr2287099f8f.6.1750857690551;\n Wed, 25 Jun 2025 06:21:30 -0700 (PDT)", "From": "Jerome Forissier <jerome.forissier@linaro.org>", "To": "U-Boot mailing list <u-boot@lists.denx.de>", "Cc": "Jerome Forissier <jerome.forissier@linaro.org>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Casey Connolly <casey.connolly@linaro.org>,\n Dmitry Rokosov <ddrokosov@salutedevices.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>,\n Michael Walle <mwalle@kernel.org>, Simon Glass <sjg@chromium.org>,\n Tom Rini <trini@konsulko.com>", "Subject": "[PATCH v4 04/13] lwip: split cmd/net-lwip.c into one file per command", "Date": "Wed, 25 Jun 2025 15:19:12 +0200", "Message-ID": "<20250625132108.3292932-5-jerome.forissier@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250625132108.3292932-1-jerome.forissier@linaro.org>", "References": "<20250625132108.3292932-1-jerome.forissier@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Move each command in cmd/net-lwip.c into its own file\n(cmd/lwip/${cmd}.c).\n\nSuggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\nSigned-off-by: Jerome Forissier <jerome.forissier@linaro.org>\n---\n\n(no changes since v3)\n\nChanges in v3:\n- Patch moved after \"lwip: move net/lwip/ping.c to cmd/lwip\"\nand \"lwip: move net/lwip/dns.c to cmd/lwip\".\n\nChanges in v2:\n- New patch\n\n cmd/Makefile | 2 +-\n cmd/lwip/Makefile | 3 +++\n cmd/lwip/dhcp.c | 9 +++++++++\n cmd/lwip/dns.c | 3 +++\n cmd/lwip/ping.c | 3 +++\n cmd/lwip/tftp.c | 9 +++++++++\n cmd/{net-lwip.c => lwip/wget.c} | 26 +-------------------------\n 7 files changed, 29 insertions(+), 26 deletions(-)\n create mode 100644 cmd/lwip/dhcp.c\n create mode 100644 cmd/lwip/tftp.c\n rename cmd/{net-lwip.c => lwip/wget.c} (51%)", "diff": "diff --git a/cmd/Makefile b/cmd/Makefile\nindex 9c5bfc91659..34fa73d64fc 100644\n--- a/cmd/Makefile\n+++ b/cmd/Makefile\n@@ -133,7 +133,7 @@ obj-$(CONFIG_CMD_NAND) += nand.o\n ifdef CONFIG_NET\n obj-$(CONFIG_CMD_NET) += net.o net-common.o\n else ifdef CONFIG_NET_LWIP\n-obj-$(CONFIG_CMD_NET) += net-lwip.o net-common.o\n+obj-$(CONFIG_CMD_NET) += net-common.o\n obj-y += lwip/\n endif\n obj-$(CONFIG_ENV_SUPPORT) += nvedit.o\ndiff --git a/cmd/lwip/Makefile b/cmd/lwip/Makefile\nindex da79b64b5c2..4c28d2b28e5 100644\n--- a/cmd/lwip/Makefile\n+++ b/cmd/lwip/Makefile\n@@ -1,2 +1,5 @@\n+obj-$(CONFIG_CMD_DHCP) += dhcp.o\n obj-$(CONFIG_CMD_DNS) += dns.o\n obj-$(CONFIG_CMD_PING) += ping.o\n+obj-$(CONFIG_CMD_TFTPBOOT) += tftp.o\n+obj-$(CONFIG_CMD_WGET) += wget.o\ndiff --git a/cmd/lwip/dhcp.c b/cmd/lwip/dhcp.c\nnew file mode 100644\nindex 00000000000..3894d71f654\n--- /dev/null\n+++ b/cmd/lwip/dhcp.c\n@@ -0,0 +1,9 @@\n+// SPDX-License-Identifier: GPL-2.0+\n+/* Copyright (C) 2024-2025 Linaro Ltd. */\n+\n+#include <command.h>\n+#include <net.h>\n+\n+U_BOOT_CMD(dhcp, 3, 1, do_dhcp,\n+\t \"boot image via network using DHCP/TFTP protocol\",\n+\t \"[loadAddress] [[hostIPaddr:]bootfilename]\");\ndiff --git a/cmd/lwip/dns.c b/cmd/lwip/dns.c\nindex 19172ac959a..13da52b59b9 100644\n--- a/cmd/lwip/dns.c\n+++ b/cmd/lwip/dns.c\n@@ -8,6 +8,9 @@\n #include <net.h>\n #include <time.h>\n \n+U_BOOT_CMD(dns, 3, 1, do_dns, \"lookup the IP of a hostname\",\n+\t \"hostname [envvar]\");\n+\n #define DNS_RESEND_MS 1000\n #define DNS_TIMEOUT_MS 10000\n \ndiff --git a/cmd/lwip/ping.c b/cmd/lwip/ping.c\nindex d8042ceecf9..21a30228642 100644\n--- a/cmd/lwip/ping.c\n+++ b/cmd/lwip/ping.c\n@@ -13,6 +13,9 @@\n #include <net.h>\n #include <time.h>\n \n+U_BOOT_CMD(ping, 2, 1, do_ping, \"send ICMP ECHO_REQUEST to network host\",\n+\t \"pingAddress\");\n+\n #define PING_DELAY_MS 1000\n #define PING_COUNT 5\n /* Ping identifier - must fit on a u16_t */\ndiff --git a/cmd/lwip/tftp.c b/cmd/lwip/tftp.c\nnew file mode 100644\nindex 00000000000..6bb7a3733a2\n--- /dev/null\n+++ b/cmd/lwip/tftp.c\n@@ -0,0 +1,9 @@\n+// SPDX-License-Identifier: GPL-2.0+\n+/* Copyright (C) 2024-2025 Linaro Ltd. */\n+\n+#include <command.h>\n+#include <net.h>\n+\n+U_BOOT_CMD(tftpboot, 3, 0, do_tftpb,\n+\t \"boot image via network using TFTP protocol\",\n+\t \"[loadAddress] [[hostIPaddr:]bootfilename]\");\ndiff --git a/cmd/net-lwip.c b/cmd/lwip/wget.c\nsimilarity index 51%\nrename from cmd/net-lwip.c\nrename to cmd/lwip/wget.c\nindex cecf8d02555..3f5b9952c93 100644\n--- a/cmd/net-lwip.c\n+++ b/cmd/lwip/wget.c\n@@ -1,32 +1,9 @@\n // SPDX-License-Identifier: GPL-2.0+\n-/* Copyright (C) 2024 Linaro Ltd. */\n+/* Copyright (C) 2024-2025 Linaro Ltd. */\n \n #include <command.h>\n #include <net.h>\n \n-#if defined(CONFIG_CMD_DHCP)\n-U_BOOT_CMD(dhcp, 3, 1, do_dhcp,\n-\t \"boot image via network using DHCP/TFTP protocol\",\n-\t \"[loadAddress] [[hostIPaddr:]bootfilename]\");\n-#endif\n-\n-#if defined(CONFIG_CMD_PING)\n-U_BOOT_CMD(ping, 2, 1, do_ping, \"send ICMP ECHO_REQUEST to network host\",\n-\t \"pingAddress\");\n-#endif\n-\n-#if defined(CONFIG_CMD_TFTPBOOT)\n-U_BOOT_CMD(tftpboot, 3, 0, do_tftpb,\n-\t \"boot image via network using TFTP protocol\",\n-\t \"[loadAddress] [[hostIPaddr:]bootfilename]\");\n-#endif\n-\n-#if defined(CONFIG_CMD_DNS)\n-U_BOOT_CMD(dns, 3, 1, do_dns, \"lookup the IP of a hostname\",\n-\t \"hostname [envvar]\");\n-#endif\n-\n-#if defined(CONFIG_CMD_WGET)\n U_BOOT_CMD(wget, 4, 1, do_wget,\n \t \"boot image via network using HTTP/HTTPS protocol\"\n #if defined(CONFIG_WGET_CACERT)\n@@ -47,4 +24,3 @@ U_BOOT_CMD(wget, 4, 1, do_wget,\n #endif\n #endif\n );\n-#endif\n", "prefixes": [ "v4", "04/13" ] }