Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2092512/?format=api
{ "id": 2092512, "url": "http://patchwork.ozlabs.org/api/patches/2092512/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250530153826.1057407-1-tharvey@gateworks.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250530153826.1057407-1-tharvey@gateworks.com>", "list_archive_url": null, "date": "2025-05-30T15:38:22", "name": "[v2,1/5] net: lwip: call sys_check_timeouts and schedule on rx", "commit_ref": "08a8d1455a0f5f3ac7c2692a0b9ae6e98aea0291", "pull_url": null, "state": "accepted", "archived": false, "hash": "ff4ba11eb1a0e5b736a9b8b4f80e6fb8ac96fef6", "submitter": { "id": 41730, "url": "http://patchwork.ozlabs.org/api/people/41730/?format=api", "name": "Tim Harvey", "email": "tharvey@gateworks.com" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250530153826.1057407-1-tharvey@gateworks.com/mbox/", "series": [ { "id": 459049, "url": "http://patchwork.ozlabs.org/api/series/459049/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=459049", "date": "2025-05-30T15:38:23", "name": "[v2,1/5] net: lwip: call sys_check_timeouts and schedule on rx", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/459049/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2092512/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2092512/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=gateworks.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=gateworks.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=tharvey@gateworks.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4b86pL1CBvz1yFb\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 31 May 2025 01:38:34 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2D5668334D;\n\tFri, 30 May 2025 17:38:35 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 91F9082991; Fri, 30 May 2025 17:38:33 +0200 (CEST)", "from finn.localdomain (finn.gateworks.com [108.161.129.64])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1EEE5801BE\n for <u-boot@lists.denx.de>; Fri, 30 May 2025 17:38:30 +0200 (CEST)", "from syn-068-189-091-139.biz.spectrum.com ([68.189.91.139]\n helo=tharvey.pdc.gateworks.com)\n by finn.localdomain with esmtp (Exim 4.95)\n (envelope-from <tharvey@gateworks.com>) id 1uL1oS-007QGb-GK;\n Fri, 30 May 2025 15:38:28 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "From": "Tim Harvey <tharvey@gateworks.com>", "To": "u-boot@lists.denx.de", "Cc": "Jerome Forissier <jerome.forissier@linaro.org>,\n Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Simon Glass <sjg@chromium.org>,\n Tom Rini <trini@konsulko.com>, Tim Harvey <tharvey@gateworks.com>", "Subject": "[PATCH v2 1/5] net: lwip: call sys_check_timeouts and schedule on rx", "Date": "Fri, 30 May 2025 08:38:22 -0700", "Message-Id": "<20250530153826.1057407-1-tharvey@gateworks.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Call schedule() in net_lwip_rx() to service U-Boot tasks and\nactions during packet rx.\n\nAs a cleanup also move sys_check_timeouts() here and remove it from the\nfunctions that call net_lwip_rx().\n\nThis resolves the issue of an active watchdog resetting the board on\nlong network activities.\n\nSuggested-by: Jerome Forissier <jerome.forissier@linaro.org>\nSigned-off-by: Tim Harvey <tharvey@gateworks.com>\n---\nv2:\n - remove duplication of sys_check_timeouts() from functions that call\n net_lwip_rx()\n---\n net/lwip/dhcp.c | 1 -\n net/lwip/dns.c | 1 -\n net/lwip/net-lwip.c | 7 +++++++\n net/lwip/ping.c | 1 -\n net/lwip/tftp.c | 1 -\n net/lwip/wget.c | 1 -\n 6 files changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/net/lwip/dhcp.c b/net/lwip/dhcp.c\nindex 92bd7067a7fb..b79b746db390 100644\n--- a/net/lwip/dhcp.c\n+++ b/net/lwip/dhcp.c\n@@ -57,7 +57,6 @@ static int dhcp_loop(struct udevice *udev)\n \t/* Wait for DHCP to complete */\n \tdo {\n \t\tnet_lwip_rx(udev, netif);\n-\t\tsys_check_timeouts();\n \t\tbound = dhcp_supplied_address(netif);\n \t\tif (bound)\n \t\t\tbreak;\ndiff --git a/net/lwip/dns.c b/net/lwip/dns.c\nindex 19172ac959ac..738f8bf3196b 100644\n--- a/net/lwip/dns.c\n+++ b/net/lwip/dns.c\n@@ -91,7 +91,6 @@ static int dns_loop(struct udevice *udev, const char *name, const char *var)\n \t\t\tnet_lwip_rx(udev, netif);\n \t\t\tif (dns_cb_arg.done)\n \t\t\t\tbreak;\n-\t\t\tsys_check_timeouts();\n \t\t\tif (ctrlc()) {\n \t\t\t\tprintf(\"\\nAbort\\n\");\n \t\t\t\tbreak;\ndiff --git a/net/lwip/net-lwip.c b/net/lwip/net-lwip.c\nindex f05c4cd3f64f..e8d4cc542ed8 100644\n--- a/net/lwip/net-lwip.c\n+++ b/net/lwip/net-lwip.c\n@@ -13,8 +13,10 @@\n #include <lwip/etharp.h>\n #include <lwip/init.h>\n #include <lwip/prot/etharp.h>\n+#include <lwip/timeouts.h>\n #include <net.h>\n #include <timer.h>\n+#include <u-boot/schedule.h>\n \n /* xx:xx:xx:xx:xx:xx\\0 */\n #define MAC_ADDR_STRLEN 18\n@@ -284,6 +286,11 @@ int net_lwip_rx(struct udevice *udev, struct netif *netif)\n \tint len;\n \tint i;\n \n+\t/* lwIP timers */\n+\tsys_check_timeouts();\n+\t/* Other tasks and actions */\n+\tschedule();\n+\n \tif (!eth_is_active(udev))\n \t\treturn -EINVAL;\n \ndiff --git a/net/lwip/ping.c b/net/lwip/ping.c\nindex d8042ceecf99..1390b914f7d8 100644\n--- a/net/lwip/ping.c\n+++ b/net/lwip/ping.c\n@@ -136,7 +136,6 @@ static int ping_loop(struct udevice *udev, const ip_addr_t *addr)\n \tping_send(&ctx);\n \n \tdo {\n-\t\tsys_check_timeouts();\n \t\tnet_lwip_rx(udev, netif);\n \t\tif (ctx.alive)\n \t\t\tbreak;\ndiff --git a/net/lwip/tftp.c b/net/lwip/tftp.c\nindex fae701bad2eb..7495dc077ba5 100644\n--- a/net/lwip/tftp.c\n+++ b/net/lwip/tftp.c\n@@ -200,7 +200,6 @@ static int tftp_loop(struct udevice *udev, ulong addr, char *fname,\n \tsys_timeout(NO_RSP_TIMEOUT_MS, no_response, &ctx);\n \twhile (!ctx.done) {\n \t\tnet_lwip_rx(udev, netif);\n-\t\tsys_check_timeouts();\n \t\tif (ctrlc()) {\n \t\t\tprintf(\"\\nAbort\\n\");\n \t\t\tctx.done = ABORTED;\ndiff --git a/net/lwip/wget.c b/net/lwip/wget.c\nindex ea1113e18b11..fcaf684e61da 100644\n--- a/net/lwip/wget.c\n+++ b/net/lwip/wget.c\n@@ -525,7 +525,6 @@ int wget_do_request(ulong dst_addr, char *uri)\n \n \twhile (!ctx.done) {\n \t\tnet_lwip_rx(udev, netif);\n-\t\tsys_check_timeouts();\n \t\tif (ctrlc())\n \t\t\tbreak;\n \t}\n", "prefixes": [ "v2", "1/5" ] }