Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2086690/?format=api
{ "id": 2086690, "url": "http://patchwork.ozlabs.org/api/patches/2086690/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250516114148.3862114-2-m-shah@ti.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250516114148.3862114-2-m-shah@ti.com>", "list_archive_url": null, "date": "2025-05-16T11:41:47", "name": "[1/2,v2] tools: binman: control.py: Propagate bootph-all/bootph-some-ram properties to supernodes", "commit_ref": "d85d15fdfebd040e58bdf80e40ef09d67a8ac808", "pull_url": null, "state": "accepted", "archived": false, "hash": "ad8a3436b6103fa99b33ded262ebc05f50c75646", "submitter": { "id": 90252, "url": "http://patchwork.ozlabs.org/api/people/90252/?format=api", "name": "Moteen Shah", "email": "m-shah@ti.com" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250516114148.3862114-2-m-shah@ti.com/mbox/", "series": [ { "id": 457156, "url": "http://patchwork.ozlabs.org/api/series/457156/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=457156", "date": "2025-05-16T11:41:46", "name": "Propagate bootph-all and bootph-some-ram property to all supernodes", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/457156/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2086690/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2086690/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=ti-com-17Q1 header.b=bf3Sjc33;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"bf3Sjc33\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de; spf=pass smtp.mailfrom=m-shah@ti.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZzQCn63LKz1yYW\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 16 May 2025 21:41:57 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4F4A28294C;\n\tFri, 16 May 2025 13:42:08 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id D5FCE8294C; Fri, 16 May 2025 13:42:07 +0200 (CEST)", "from fllvem-ot03.ext.ti.com (fllvem-ot03.ext.ti.com [198.47.19.245])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B62588006D\n for <u-boot@lists.denx.de>; Fri, 16 May 2025 13:42:05 +0200 (CEST)", "from lelvem-sh01.itg.ti.com ([10.180.77.71])\n by fllvem-ot03.ext.ti.com (8.15.2/8.15.2) with ESMTP id 54GBfubv298172;\n Fri, 16 May 2025 06:41:56 -0500", "from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30])\n by lelvem-sh01.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 54GBfu0f3262521\n (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL);\n Fri, 16 May 2025 06:41:56 -0500", "from DFLE111.ent.ti.com (10.64.6.32) by DFLE109.ent.ti.com\n (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 16\n May 2025 06:41:56 -0500", "from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE111.ent.ti.com\n (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via\n Frontend Transport; Fri, 16 May 2025 06:41:55 -0500", "from moteen-ubuntu-desk.dhcp.ti.com (moteen-ubuntu-desk.dhcp.ti.com\n [172.24.227.136] (may be forged))\n by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 54GBfnh8063026;\n Fri, 16 May 2025 06:41:53 -0500" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;\n s=ti-com-17Q1; t=1747395716;\n bh=FZwYds0Yt2mvkF6zVI6Gas2E3onJKfX349MDCFIa524=;\n h=From:To:CC:Subject:Date:In-Reply-To:References;\n b=bf3Sjc33m1h+lG2pRkRAXDTwXsGFyIR9O6CXwzefUtEPQ1x1LNehE5kf7fbS8CV6T\n D1iD9KN47IyMzo7IRJ2W6AoG4cqApM3J2e3/e1CJVmXove9SCUXJUFSdSqfDPwLsg6\n jctjog3b5SccrzG9pU8dWS9OIGni+akppC3t9PnI=", "From": "Moteen Shah <m-shah@ti.com>", "To": "<u-boot@lists.denx.de>", "CC": "<trini@konsulko.com>, <sjg@chromium.org>, <alpernebiyasak@gmail.com>,\n <quentin.schulz@cherry.de>, <m-chawdhry@ti.com>, <n-francis@ti.com>,\n <vigneshr@ti.com>, <u-kumar1@ti.com>, <m-shah@ti.com>", "Subject": "[PATCH 1/2 v2] tools: binman: control.py: Propagate\n bootph-all/bootph-some-ram properties to supernodes", "Date": "Fri, 16 May 2025 17:11:47 +0530", "Message-ID": "<20250516114148.3862114-2-m-shah@ti.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20250516114148.3862114-1-m-shah@ti.com>", "References": "<20250516114148.3862114-1-m-shah@ti.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-C2ProcessedOrg": "333ef613-75bf-4e12-a4b1-8e3623f5dcea", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "As per bootph schema, bootph-* property in child node should be\nimplied in their parent, but this feature is not implemented in\nthe U-Boot proper stage (before relocation) resulting in devices\nnot being bound because of the missing bootph-all or bootph-some-ram\nproperty in the parent node.\n\nTo mitigate this issue, add a function to scan through all the nodes\nin the device-tree for bootph-all and bootph-some-ram properties. If\nfound, propagate it to all of its parent nodes up the hierarchy.\n\nSigned-off-by: Moteen Shah <m-shah@ti.com>\nSigned-off-by: Simon Glass <sjg@chromium.org>\n\nReviewed-by: Simon Glass <sjg@chromium.org>\n\n---\n tools/binman/control.py | 54 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 54 insertions(+)", "diff": "diff --git a/tools/binman/control.py b/tools/binman/control.py\nindex 81f61e3e152..dcbc028adcc 100644\n--- a/tools/binman/control.py\n+++ b/tools/binman/control.py\n@@ -530,6 +530,57 @@ def _RemoveTemplates(parent):\n for node in del_nodes:\n node.Delete()\n \n+def propagate_prop(node, prop):\n+ \"\"\"Propagate the provided property to all the parent nodes up the hierarchy\n+\n+ Args:\n+ node (fdt.Node): Node and all its parent nodes up to the root to\n+ propagate the property.\n+ prop (str): Boolean property to propagate\n+\n+ Return:\n+ True if any change was made, else False\n+ \"\"\"\n+ changed = False\n+ while node:\n+ if prop not in node.props:\n+ node.AddEmptyProp(prop, 0)\n+ changed = True\n+ node = node.parent\n+ return changed\n+\n+def scan_and_prop_bootph(node):\n+ \"\"\"Propagate bootph properties from children to parents\n+\n+ The bootph schema indicates that bootph properties in children should be\n+ implied in their parents, all the way up the hierarchy. This is expensive\n+ to implement in U-Boot before relocation at runtime, so this function\n+ explicitly propagates these bootph properties upwards during build time.\n+\n+ This is used to set the bootph-all, bootph-some-ram property in the parent\n+ node if the respective property is found in any of the parent's subnodes.\n+ The other bootph-* properties are associated with the SPL stage and hence\n+ handled by fdtgrep.c.\n+\n+ Args:\n+ node (fdt.Node): Node to scan for bootph-all and bootph-some-ram\n+ property\n+\n+ Return:\n+ True if any change was made, else False\n+\n+ \"\"\"\n+ bootph_prop = {'bootph-all', 'bootph-some-ram'}\n+\n+ changed = False\n+ for prop in bootph_prop:\n+ if prop in node.props:\n+ changed |= propagate_prop(node.parent, prop)\n+\n+ for subnode in node.subnodes:\n+ changed |= scan_and_prop_bootph(subnode)\n+ return changed\n+\n def PrepareImagesAndDtbs(dtb_fname, select_images, update_fdt, use_expanded, indir):\n \"\"\"Prepare the images to be processed and select the device tree\n \n@@ -589,6 +640,9 @@ def PrepareImagesAndDtbs(dtb_fname, select_images, update_fdt, use_expanded, ind\n fname = tools.get_output_filename('u-boot.dtb.tmpl2')\n tools.write_file(fname, dtb.GetContents())\n \n+ if scan_and_prop_bootph(dtb.GetRoot()):\n+ dtb.Sync(True)\n+\n images = _ReadImageDesc(node, use_expanded)\n \n if select_images:\n", "prefixes": [ "1/2", "v2" ] }