Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2080618/?format=api
{ "id": 2080618, "url": "http://patchwork.ozlabs.org/api/patches/2080618/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250503075858.277375-12-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250503075858.277375-12-pbonzini@redhat.com>", "list_archive_url": null, "date": "2025-05-03T07:58:56", "name": "[PULL,11/13] hw/char/serial: Remove unused prog_if compat property", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9ba8fcc0b3b5a74e766d917deedc1e08bf651f67", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250503075858.277375-12-pbonzini@redhat.com/mbox/", "series": [ { "id": 455199, "url": "http://patchwork.ozlabs.org/api/series/455199/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=455199", "date": "2025-05-03T07:58:51", "name": "[PULL,01/13] rust/vmstate: Add support for field_exists checks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/455199/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2080618/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2080618/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=MyO6sYgX;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZqKy41L83z1yMf\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 3 May 2025 18:02:04 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1uB7md-00089N-Le; Sat, 03 May 2025 03:59:39 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1uB7mc-00089B-56\n for qemu-devel@nongnu.org; Sat, 03 May 2025 03:59:38 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1uB7mY-0006hM-SN\n for qemu-devel@nongnu.org; Sat, 03 May 2025 03:59:36 -0400", "from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-302-LBBFJ-1lOLyb_Ho-TuP-jw-1; Sat, 03 May 2025 03:59:32 -0400", "by mail-wm1-f71.google.com with SMTP id\n 5b1f17b1804b1-43ceb011ea5so14463145e9.2\n for <qemu-devel@nongnu.org>; Sat, 03 May 2025 00:59:32 -0700 (PDT)", "from [192.168.10.48] ([151.95.54.106])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3a099ae0cd6sm4146454f8f.5.2025.05.03.00.59.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 03 May 2025 00:59:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1746259173;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7VuFrzB+x2Fw/uMdbdxESZXpgU/xX6NGKzdHSeZxnBg=;\n b=MyO6sYgXBrZ/PfDFEDJIMZ3iLuTBqV7IdHHSiQvPH00pT0FExXA+j4X6qfCV2s9iP6ZKhk\n 50v2H+ADJMfnPbY+tYIymEfNVG4hYp4IkT6LIRPPcaZ32AohuRaIdr3d4kv02mlwcI/8jP\n Ym0r7GmPFIq8FECAw4Hh4gWnMGctMHY=", "X-MC-Unique": "LBBFJ-1lOLyb_Ho-TuP-jw-1", "X-Mimecast-MFC-AGG-ID": "LBBFJ-1lOLyb_Ho-TuP-jw_1746259171", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1746259170; x=1746863970;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=7VuFrzB+x2Fw/uMdbdxESZXpgU/xX6NGKzdHSeZxnBg=;\n b=W5+EqNy978f8qClsw/jUaULdAVoisTR0UXglmLtAFOGXnzxn0nbrRnmlFeADNkZHFY\n /M6YOrX8uEwuhKVchM+BkcrKQ9XpIvOnZAZYeChRAnlObGkCBFAR7YToD+cXUxGHRDD2\n I7EycPR9zG+kLWA669rxf93y+KIkzqr2PEwKXmp5Nsu3fdmZCn7H5GRvgxU5hBmi6hDV\n OJmDaljo0Q8jkbQcFUckjDm+haOHLdCJQuu2aFZBpMBEamIBA4OL7/s5EgKQNJzgVojS\n jsLPfhay/zt4h2KZyqsVLPi5oWoZcCPvZuVzeEIn3Bhl77PZG8qPWd+kaJp+g2yPI774\n pIWA==", "X-Gm-Message-State": "AOJu0YzZuh5hH6n+QUbqRn3GdyEknirNR9dD2W+ePEADgHnZJdB/LrdS\n /drdi2zSwyiEamcLioWXbh1ULL65QeijKd/eQ1YnDtzEcYllz8OEb36USR56Mx3LoWxoyjF2D4I\n iaA6VLEG+2rsryXdpNSPiBuIcSw3TKumESXAEP7ENJ3B+3Deydiscoi2P/xeSyFdqNt1ujrZif0\n xHhA1im5xRlvd5HmOnX6IJ2Bu2+xG3DZVT1mFt", "X-Gm-Gg": "ASbGncupSAYLha5RPgKLlWiTeCdRGio/EXc78Jta8Kmd/VZYjfHr0uG29AAPFe2p5gH\n 1Crl/zr9afr0K0EkWRnp6mzGo+Yh6MkReA+U5CpEHVQzkaIgwdjZPAsswzrAELjYjTXQDG5PJpf\n B2+qOGRhVpMXFkb9Y4NqofHLKS2fJiCDAanZ24thCI8PVqZHMQRwu2TMRAme2VwXhadr7Na27OC\n A4Acck5yPUOo/xRHGXAe5OhI8Ub1//LynHC3XFJD6Oqsx7abynnzV6Gh1rYnmRuCDt6IPRH0r3O\n WxenCTDB4ib4O0E=", "X-Received": [ "by 2002:a5d:5985:0:b0:3a0:8298:143d with SMTP id\n ffacd0b85a97d-3a09fd77692mr233942f8f.13.1746259170549;\n Sat, 03 May 2025 00:59:30 -0700 (PDT)", "by 2002:a5d:5985:0:b0:3a0:8298:143d with SMTP id\n ffacd0b85a97d-3a09fd77692mr233930f8f.13.1746259170162;\n Sat, 03 May 2025 00:59:30 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n AGHT+IEjrp3cr7uAxwn22S4hObkqrzoxkVGxKqBFnaykHWlAtmZjwwwp30M/xCQ1gp3ZWlbWuGiGJA==", "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "BALATON Zoltan <balaton@eik.bme.hu>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>, Helge Deller <deller@gmx.de>", "Subject": "[PULL 11/13] hw/char/serial: Remove unused prog_if compat property", "Date": "Sat, 3 May 2025 09:58:56 +0200", "Message-ID": "<20250503075858.277375-12-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250503075858.277375-1-pbonzini@redhat.com>", "References": "<20250503075858.277375-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.644,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: BALATON Zoltan <balaton@eik.bme.hu>\n\nThis property was added to preserve previous value when this was fixed\nin version 2.1 but the last machine using it was already removed when\nadding diva-gsp leaving this property unused and unnecessary.\n\nSigned-off-by: BALATON Zoltan <balaton@eik.bme.hu>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Helge Deller <deller@gmx.de>\nLink: https://lore.kernel.org/r/20250502095524.DE1F355D264@zero.eik.bme.hu\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n hw/char/diva-gsp.c | 6 ++----\n hw/char/serial-pci-multi.c | 7 ++-----\n hw/char/serial-pci.c | 10 ++--------\n 3 files changed, 6 insertions(+), 17 deletions(-)", "diff": "diff --git a/hw/char/diva-gsp.c b/hw/char/diva-gsp.c\nindex 60f933191d2..e1f0713cb79 100644\n--- a/hw/char/diva-gsp.c\n+++ b/hw/char/diva-gsp.c\n@@ -51,7 +51,6 @@ typedef struct PCIDivaSerialState {\n SerialState state[PCI_SERIAL_MAX_PORTS];\n uint32_t level[PCI_SERIAL_MAX_PORTS];\n qemu_irq *irqs;\n- uint8_t prog_if;\n bool disable;\n } PCIDivaSerialState;\n \n@@ -124,8 +123,8 @@ static void diva_pci_realize(PCIDevice *dev, Error **errp)\n size_t i, offset = 0;\n size_t portmask = di.omask;\n \n- pci->dev.config[PCI_CLASS_PROG] = pci->prog_if;\n- pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;\n+ pci->dev.config[PCI_CLASS_PROG] = 2; /* 16550 compatible */\n+ pci->dev.config[PCI_INTERRUPT_PIN] = 1;\n memory_region_init(&pci->membar, OBJECT(pci), \"serial_ports\", 4096);\n pci_register_bar(&pci->dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &pci->membar);\n pci->irqs = qemu_allocate_irqs(multi_serial_irq_mux, pci, di.nports);\n@@ -178,7 +177,6 @@ static const Property diva_serial_properties[] = {\n DEFINE_PROP_CHR(\"chardev2\", PCIDivaSerialState, state[1].chr),\n DEFINE_PROP_CHR(\"chardev3\", PCIDivaSerialState, state[2].chr),\n DEFINE_PROP_CHR(\"chardev4\", PCIDivaSerialState, state[3].chr),\n- DEFINE_PROP_UINT8(\"prog_if\", PCIDivaSerialState, prog_if, 0x02),\n DEFINE_PROP_UINT32(\"subvendor\", PCIDivaSerialState, subvendor,\n PCI_DEVICE_ID_HP_DIVA_TOSCA1),\n };\ndiff --git a/hw/char/serial-pci-multi.c b/hw/char/serial-pci-multi.c\nindex fb184c2e6dc..13df272691a 100644\n--- a/hw/char/serial-pci-multi.c\n+++ b/hw/char/serial-pci-multi.c\n@@ -46,7 +46,6 @@ typedef struct PCIMultiSerialState {\n SerialState state[PCI_SERIAL_MAX_PORTS];\n uint32_t level[PCI_SERIAL_MAX_PORTS];\n IRQState irqs[PCI_SERIAL_MAX_PORTS];\n- uint8_t prog_if;\n } PCIMultiSerialState;\n \n static void multi_serial_pci_exit(PCIDevice *dev)\n@@ -97,8 +96,8 @@ static void multi_serial_pci_realize(PCIDevice *dev, Error **errp)\n SerialState *s;\n size_t i, nports = multi_serial_get_port_count(pc);\n \n- pci->dev.config[PCI_CLASS_PROG] = pci->prog_if;\n- pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;\n+ pci->dev.config[PCI_CLASS_PROG] = 2; /* 16550 compatible */\n+ pci->dev.config[PCI_INTERRUPT_PIN] = 1;\n memory_region_init(&pci->iobar, OBJECT(pci), \"multiserial\", 8 * nports);\n pci_register_bar(&pci->dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &pci->iobar);\n \n@@ -133,7 +132,6 @@ static const VMStateDescription vmstate_pci_multi_serial = {\n static const Property multi_2x_serial_pci_properties[] = {\n DEFINE_PROP_CHR(\"chardev1\", PCIMultiSerialState, state[0].chr),\n DEFINE_PROP_CHR(\"chardev2\", PCIMultiSerialState, state[1].chr),\n- DEFINE_PROP_UINT8(\"prog_if\", PCIMultiSerialState, prog_if, 0x02),\n };\n \n static const Property multi_4x_serial_pci_properties[] = {\n@@ -141,7 +139,6 @@ static const Property multi_4x_serial_pci_properties[] = {\n DEFINE_PROP_CHR(\"chardev2\", PCIMultiSerialState, state[1].chr),\n DEFINE_PROP_CHR(\"chardev3\", PCIMultiSerialState, state[2].chr),\n DEFINE_PROP_CHR(\"chardev4\", PCIMultiSerialState, state[3].chr),\n- DEFINE_PROP_UINT8(\"prog_if\", PCIMultiSerialState, prog_if, 0x02),\n };\n \n static void multi_2x_serial_pci_class_initfn(ObjectClass *klass,\ndiff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c\nindex 8707e819144..46efabc4cbe 100644\n--- a/hw/char/serial-pci.c\n+++ b/hw/char/serial-pci.c\n@@ -38,7 +38,6 @@\n struct PCISerialState {\n PCIDevice dev;\n SerialState state;\n- uint8_t prog_if;\n };\n \n #define TYPE_PCI_SERIAL \"pci-serial\"\n@@ -53,8 +52,8 @@ static void serial_pci_realize(PCIDevice *dev, Error **errp)\n return;\n }\n \n- pci->dev.config[PCI_CLASS_PROG] = pci->prog_if;\n- pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;\n+ pci->dev.config[PCI_CLASS_PROG] = 2; /* 16550 compatible */\n+ pci->dev.config[PCI_INTERRUPT_PIN] = 1;\n s->irq = pci_allocate_irq(&pci->dev);\n \n memory_region_init_io(&s->io, OBJECT(pci), &serial_io_ops, s, \"serial\", 8);\n@@ -81,10 +80,6 @@ static const VMStateDescription vmstate_pci_serial = {\n }\n };\n \n-static const Property serial_pci_properties[] = {\n- DEFINE_PROP_UINT8(\"prog_if\", PCISerialState, prog_if, 0x02),\n-};\n-\n static void serial_pci_class_initfn(ObjectClass *klass, const void *data)\n {\n DeviceClass *dc = DEVICE_CLASS(klass);\n@@ -96,7 +91,6 @@ static void serial_pci_class_initfn(ObjectClass *klass, const void *data)\n pc->revision = 1;\n pc->class_id = PCI_CLASS_COMMUNICATION_SERIAL;\n dc->vmsd = &vmstate_pci_serial;\n- device_class_set_props(dc, serial_pci_properties);\n set_bit(DEVICE_CATEGORY_INPUT, dc->categories);\n }\n \n", "prefixes": [ "PULL", "11/13" ] }