Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2080617/?format=api
{ "id": 2080617, "url": "http://patchwork.ozlabs.org/api/patches/2080617/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250503075858.277375-5-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250503075858.277375-5-pbonzini@redhat.com>", "list_archive_url": null, "date": "2025-05-03T07:58:49", "name": "[PULL,04/13] rust/vmstate_test: Test varray with num field wrapped in BqlCell", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "76c2faf6ba8ccb4a4cb2e1bef57caa8e5892e40a", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250503075858.277375-5-pbonzini@redhat.com/mbox/", "series": [ { "id": 455199, "url": "http://patchwork.ozlabs.org/api/series/455199/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=455199", "date": "2025-05-03T07:58:51", "name": "[PULL,01/13] rust/vmstate: Add support for field_exists checks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/455199/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2080617/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2080617/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=UhFdkt/e;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZqKy03XN2z1yMf\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 3 May 2025 18:02:00 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1uB7mK-00084t-Vu; Sat, 03 May 2025 03:59:21 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1uB7mI-00084H-VW\n for qemu-devel@nongnu.org; Sat, 03 May 2025 03:59:19 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1uB7mG-0006dd-Pa\n for qemu-devel@nongnu.org; Sat, 03 May 2025 03:59:18 -0400", "from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-365-sRH7vSTjNpuMYj_kDdvnMQ-1; Sat, 03 May 2025 03:59:14 -0400", "by mail-wr1-f72.google.com with SMTP id\n ffacd0b85a97d-3912a0439afso776427f8f.3\n for <qemu-devel@nongnu.org>; Sat, 03 May 2025 00:59:14 -0700 (PDT)", "from [192.168.10.48] ([151.95.54.106])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3a099b0feb3sm4170570f8f.67.2025.05.03.00.59.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 03 May 2025 00:59:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1746259155;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4wvpnyuIrOVtJPGHl3dMJz2mkTuCIwwag/C2R+cWE7g=;\n b=UhFdkt/e9otOI1R/x5jag5+8qOscAJpaSoEB9LObZoLQ+y7gYt6lRig6vtDdr/XDvubUOA\n zp3h78oPuIhRb2/40UCE6f7xtChz7dyfxbO/aZWXegDPQlxiS9A9mK8EgLO97OtJlJfkyQ\n z4y61H/VUCHn0r24uOKhpbYPyT8/JC8=", "X-MC-Unique": "sRH7vSTjNpuMYj_kDdvnMQ-1", "X-Mimecast-MFC-AGG-ID": "sRH7vSTjNpuMYj_kDdvnMQ_1746259153", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1746259152; x=1746863952;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=4wvpnyuIrOVtJPGHl3dMJz2mkTuCIwwag/C2R+cWE7g=;\n b=qZnGFiz5rmuyP1EnJ90feSguBH4tQEB/9ssgTH9gqchtTtgdDJuOBipXrE/HYUTs/q\n FLm9djT1uYstMsz7vMtVMvHSVa8bldH3XQUj5ajo5VuukCOd44rEpq/5qLBTM+l9hbri\n fXi8vlkO0gjQONvbPy5aZrenvHmNjlIk6VkuxY7x/i9QrDU2ShBjbBwW4E3DCs1t467d\n DMhxswzCxO+0+CGv375ID0E1O5H1kSINnbDu3ERHm63NO7E2QtwX8xkyHmR0xNaZXnie\n nLoB4HDFLXpofGvWqn/hYh40G2t7/tDFHRyFxk0oIyOJUJCyyuoQgK6/uH/zJxSgXjG1\n v7yA==", "X-Gm-Message-State": "AOJu0YzzjS+3RcTRbIYVKLebtWZzIsaLRqQSYppcVfMEyF5g4I5c2DJT\n QJQn34UQnAroLvoPU4ZlRkmj1J2bkA8TPId9PCZv1PSgLsFII6qPZYdS3xQcsWZ4a4KLanxUMG8\n /CyWxRBV4i6AtnepE1yySKoGfkbNdCgIdHjmi33PdTaBLI4AJ5r3H+J7rCzNBQmsHt2Inyk+asg\n uMDZVsh3JpIDf0ctJBVSifrcdOKPFj04O7VAZs", "X-Gm-Gg": "ASbGnct4zHPKr9ynSBR/DQvBoI8xZJHeNqm3EoS+yWvbykQ4BfU/o7GYIC9sosdZ7D/\n T4yviL0Q5y8j/dxtXuHkcAuJLmWlhCOdcrxIHzoEUAXUgAbvEpFNeHgVHft4aozXMhWX4HfsMYJ\n E54sE1oQBB1phOEwJnej/u25HOLen92BkM/PaWv5QbarPigbgUpHbQshxS3k/TfXQag8v7d6AFV\n F4rSgnkkiSC0YWiQTsLbDnEAeIZJrwt1D5cBk7drj4o7w3lQGgRpxdxZBswAALZbtvZvhSKYIW1\n M5Bj/6rlYybZmps=", "X-Received": [ "by 2002:a05:6000:240d:b0:3a0:7017:61f6 with SMTP id\n ffacd0b85a97d-3a09ceaff3bmr1498637f8f.14.1746259151676;\n Sat, 03 May 2025 00:59:11 -0700 (PDT)", "by 2002:a05:6000:240d:b0:3a0:7017:61f6 with SMTP id\n ffacd0b85a97d-3a09ceaff3bmr1498624f8f.14.1746259151323;\n Sat, 03 May 2025 00:59:11 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n AGHT+IFkyVIMSkTtJs9ZAGOHwOifjxovZOiEffUumdtQA5OetJkyp33qes5LTTffGOwp5WyrUg8aag==", "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Zhao Liu <zhao1.liu@intel.com>", "Subject": "[PULL 04/13] rust/vmstate_test: Test varray with num field wrapped in\n BqlCell", "Date": "Sat, 3 May 2025 09:58:49 +0200", "Message-ID": "<20250503075858.277375-5-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250503075858.277375-1-pbonzini@redhat.com>", "References": "<20250503075858.277375-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.644,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Zhao Liu <zhao1.liu@intel.com>\n\nSigned-off-by: Zhao Liu <zhao1.liu@intel.com>\nLink: https://lore.kernel.org/r/20250414144943.1112885-4-zhao1.liu@intel.com\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n rust/qemu-api/tests/vmstate_tests.rs | 41 ++++++++++++++++++++++------\n 1 file changed, 33 insertions(+), 8 deletions(-)", "diff": "diff --git a/rust/qemu-api/tests/vmstate_tests.rs b/rust/qemu-api/tests/vmstate_tests.rs\nindex 8b93492a689..f7a93117e1a 100644\n--- a/rust/qemu-api/tests/vmstate_tests.rs\n+++ b/rust/qemu-api/tests/vmstate_tests.rs\n@@ -28,7 +28,7 @@\n // - VMSTATE_VARRAY_UINT16_UNSAFE\n // - VMSTATE_VARRAY_MULTIPLY\n #[repr(C)]\n-#[derive(qemu_api_macros::offsets)]\n+#[derive(Default, qemu_api_macros::offsets)]\n struct FooA {\n arr: [u8; FOO_ARRAY_MAX],\n num: u16,\n@@ -147,8 +147,9 @@ fn test_vmstate_varray_multiply() {\n // - VMSTATE_STRUCT_VARRAY_UINT8\n // - (no C version) MULTIPLY variant of VMSTATE_STRUCT_VARRAY_UINT32\n // - VMSTATE_ARRAY\n+// - VMSTATE_STRUCT_VARRAY_UINT8 with BqlCell wrapper & test_fn\n #[repr(C)]\n-#[derive(qemu_api_macros::offsets)]\n+#[derive(Default, qemu_api_macros::offsets)]\n struct FooB {\n arr_a: [FooA; FOO_ARRAY_MAX],\n num_a: u8,\n@@ -158,6 +159,12 @@ struct FooB {\n val: bool,\n // FIXME: Use Timer array. Now we can't since it's hard to link savevm.c to test.\n arr_i64: [i64; FOO_ARRAY_MAX],\n+ arr_a_wrap: [FooA; FOO_ARRAY_MAX],\n+ num_a_wrap: BqlCell<u32>,\n+}\n+\n+fn validate_foob(_state: &FooB, _version_id: u8) -> bool {\n+ true\n }\n \n static VMSTATE_FOOB: VMStateDescription = VMStateDescription {\n@@ -170,13 +177,14 @@ struct FooB {\n vmstate_struct!(FooB, arr_a[0 .. num_a], &VMSTATE_FOOA, FooA).with_version_id(1),\n vmstate_struct!(FooB, arr_a_mul[0 .. num_a_mul * 32], &VMSTATE_FOOA, FooA).with_version_id(2),\n vmstate_of!(FooB, arr_i64),\n+ vmstate_struct!(FooB, arr_a_wrap[0 .. num_a_wrap], &VMSTATE_FOOA, FooA, validate_foob),\n },\n ..Zeroable::ZERO\n };\n \n #[test]\n fn test_vmstate_bool_v() {\n- let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 6) };\n+ let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 7) };\n \n // 1st VMStateField (\"val\") in VMSTATE_FOOB (corresponding to VMSTATE_BOOL_V)\n assert_eq!(\n@@ -196,7 +204,7 @@ fn test_vmstate_bool_v() {\n \n #[test]\n fn test_vmstate_uint64() {\n- let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 6) };\n+ let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 7) };\n \n // 2nd VMStateField (\"wrap\") in VMSTATE_FOOB (corresponding to VMSTATE_U64)\n assert_eq!(\n@@ -216,7 +224,7 @@ fn test_vmstate_uint64() {\n \n #[test]\n fn test_vmstate_struct_varray_uint8() {\n- let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 6) };\n+ let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 7) };\n \n // 3rd VMStateField (\"arr_a\") in VMSTATE_FOOB (corresponding to\n // VMSTATE_STRUCT_VARRAY_UINT8)\n@@ -240,7 +248,7 @@ fn test_vmstate_struct_varray_uint8() {\n \n #[test]\n fn test_vmstate_struct_varray_uint32_multiply() {\n- let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 6) };\n+ let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 7) };\n \n // 4th VMStateField (\"arr_a_mul\") in VMSTATE_FOOB (corresponding to\n // (no C version) MULTIPLY variant of VMSTATE_STRUCT_VARRAY_UINT32)\n@@ -266,7 +274,7 @@ fn test_vmstate_struct_varray_uint32_multiply() {\n \n #[test]\n fn test_vmstate_macro_array() {\n- let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 6) };\n+ let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 7) };\n \n // 5th VMStateField (\"arr_i64\") in VMSTATE_FOOB (corresponding to\n // VMSTATE_ARRAY)\n@@ -283,9 +291,26 @@ fn test_vmstate_macro_array() {\n assert_eq!(foo_fields[4].flags, VMStateFlags::VMS_ARRAY);\n assert!(foo_fields[4].vmsd.is_null());\n assert!(foo_fields[4].field_exists.is_none());\n+}\n+\n+#[test]\n+fn test_vmstate_struct_varray_uint8_wrapper() {\n+ let foo_fields: &[VMStateField] = unsafe { slice::from_raw_parts(VMSTATE_FOOB.fields, 7) };\n+ let mut foo_b: FooB = Default::default();\n+ let foo_b_p = std::ptr::addr_of_mut!(foo_b).cast::<c_void>();\n+\n+ // 6th VMStateField (\"arr_a_wrap\") in VMSTATE_FOOB (corresponding to\n+ // VMSTATE_STRUCT_VARRAY_UINT8). Other fields are checked in\n+ // test_vmstate_struct_varray_uint8.\n+ assert_eq!(\n+ unsafe { CStr::from_ptr(foo_fields[5].name) }.to_bytes_with_nul(),\n+ b\"arr_a_wrap\\0\"\n+ );\n+ assert_eq!(foo_fields[5].num_offset, 228);\n+ assert!(unsafe { foo_fields[5].field_exists.unwrap()(foo_b_p, 0) });\n \n // The last VMStateField in VMSTATE_FOOB.\n- assert_eq!(foo_fields[5].flags, VMStateFlags::VMS_END);\n+ assert_eq!(foo_fields[6].flags, VMStateFlags::VMS_END);\n }\n \n // =========================== Test VMSTATE_FOOC ===========================\n", "prefixes": [ "PULL", "04/13" ] }