Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2080615/?format=api
{ "id": 2080615, "url": "http://patchwork.ozlabs.org/api/patches/2080615/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250503075858.277375-14-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250503075858.277375-14-pbonzini@redhat.com>", "list_archive_url": null, "date": "2025-05-03T07:58:58", "name": "[PULL,13/13] monitor: don't wake up qmp_dispatcher_co coroutine upon cleanup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4758861f76fd4641df26bd5f17379b765022a0b3", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250503075858.277375-14-pbonzini@redhat.com/mbox/", "series": [ { "id": 455199, "url": "http://patchwork.ozlabs.org/api/series/455199/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=455199", "date": "2025-05-03T07:58:51", "name": "[PULL,01/13] rust/vmstate: Add support for field_exists checks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/455199/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2080615/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2080615/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=VwUErwuL;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZqKxX6SJcz1yMf\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 3 May 2025 18:01:36 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1uB7mg-0008AC-2C; Sat, 03 May 2025 03:59:42 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1uB7me-00089m-Ij\n for qemu-devel@nongnu.org; Sat, 03 May 2025 03:59:40 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1uB7mc-0006hn-GQ\n for qemu-devel@nongnu.org; Sat, 03 May 2025 03:59:40 -0400", "from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-655-qJtjJ2aSOuK7oqpTIT8kMg-1; Sat, 03 May 2025 03:59:36 -0400", "by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-43ceb011ea5so14463455e9.2\n for <qemu-devel@nongnu.org>; Sat, 03 May 2025 00:59:36 -0700 (PDT)", "from [192.168.10.48] ([151.95.54.106])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-441b8992b4csm68633295e9.0.2025.05.03.00.59.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 03 May 2025 00:59:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1746259177;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=naXb0LxpAG+QrW5oaLUaWLV/f+gZqRysHFdNv5h+KXw=;\n b=VwUErwuLvQfgBRAdb/4EC1xQFEagWjgM/aVLMgIBYXPCE+0e6cTsQ7J8jbwG6SErPM0j/Q\n d+lgg/GaN1TIquRlOoamzBWnsGetsPNiHF1v5XGiWj4fOxJ4518Wbr14FTKPB5rYcVCDYz\n LG5B96TbD9wHvonbgJrBp5/KXaC7MXc=", "X-MC-Unique": "qJtjJ2aSOuK7oqpTIT8kMg-1", "X-Mimecast-MFC-AGG-ID": "qJtjJ2aSOuK7oqpTIT8kMg_1746259175", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1746259175; x=1746863975;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=naXb0LxpAG+QrW5oaLUaWLV/f+gZqRysHFdNv5h+KXw=;\n b=wqOhVEYNBeC8lFcYIpCp+Fu+6EdAlLSD92Z/Jtg3mR6kvZ82wUYPhsGMPrnjJaoG2Q\n SVFRquH41OJnLJmU47BVMLMtsUNKbcKHhdOyDKwycZUUQ9IMq+AmdQUcTLqQc6gQAYxy\n WZtDmGYdlH3Zi2ceYYLJO5f0nmZQRxgA4rSCsB0u51ib5YB9jUYx1Q4UzBVXfgwR7n3o\n +C2Ogvc+fbbN1i8sjzmYSnEPoSt7rQVlKqa3uudH1/anEf3rJikOBbBIMGZHXrETRZ/7\n i6vsht7drebKqmS4Nlr8P3cMvWNSnog5WSjTr40qoNk/Oopj0e8oAcVzNrIHHOSprF/W\n +d8Q==", "X-Gm-Message-State": "AOJu0YxcPKRW7X8U/oSbn0V77A8EfGpCEhooIVvEyCP/HlaMwxARh6BV\n hOOsmLe9r/W8APLpjcy1mZ0skxh3veDJpEYmghQo1z54Czh1NqkhryhnSDNak01MxqPwZjBXXw4\n vhBS2ZKI1uw//dSbx8sTilOLxWsFMUPdxxpFWkvMRspZALpu/TzqL/WHdHEh+ECsGskAWpCssTZ\n ad8sxxTKrdzhLN7QK2Z91QX/lGMtvnIWiAv4ui", "X-Gm-Gg": "ASbGncvqfIoLMD/FSC9Jw7oGvD603V1Ba/SwuyaDBqUOezW6np6U+spWJyFFwYca0tr\n 0mJ2BiLHcfeuJzx2OxcsGkiJd0wbK/245I0zI9aFq/TsbN5v7NzgsT55qmRgI2zCqRFu7pIBzZi\n xG80VwwfOsYgqnDzGRu/eU/tj7THTQGMkIkTmsMZs5yDLRQS67JlNV9ya6HHap+1/52SkBHR69Y\n r0Ar1D/8g3ZYJK7onaxam+nhD9n0ysEtjgIvYilveAzc9KZ9kGeZtdtbUqSGBCkFEc3ZHPiIsij\n IPCBmoR6ci7OWGw=", "X-Received": [ "by 2002:a05:600c:1914:b0:43d:47e:3205 with SMTP id\n 5b1f17b1804b1-441c48bca55mr1537185e9.11.1746259174710;\n Sat, 03 May 2025 00:59:34 -0700 (PDT)", "by 2002:a05:600c:1914:b0:43d:47e:3205 with SMTP id\n 5b1f17b1804b1-441c48bca55mr1537025e9.11.1746259174297;\n Sat, 03 May 2025 00:59:34 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n AGHT+IFbR2kaVLJ42WP86DVgovbE4HJVFUgylyAcliITiAWEUx0lyh0e8gsol0p48M+Fh9S/59ah8A==", "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>", "Subject": "[PULL 13/13] monitor: don't wake up qmp_dispatcher_co coroutine upon\n cleanup", "Date": "Sat, 3 May 2025 09:58:58 +0200", "Message-ID": "<20250503075858.277375-14-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250503075858.277375-1-pbonzini@redhat.com>", "References": "<20250503075858.277375-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.644,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>\n\nSince the commit 3e6bed61 (\"monitor: cleanup detection of qmp_dispatcher_co\nshutting down\"), coroutine pointer qmp_dispatcher_co is set to NULL upon\ncleanup. If a QMP command is sent after monitor_cleanup() (e.g. after\nshutdown), this may lead to SEGFAULT on aio_co_wake(NULL).\n\nAs mentioned in the comment inside monitor_cleanup(), the intention is to\nallow incoming requests while shutting down, but simply leave them\nwithout any response. Let's do exactly that, and if qmp_dispatcher_co\ncoroutine pointer has already been set to NULL, let's simply skip the\naio_co_wake() part.\n\nSigned-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>\nLink: https://lore.kernel.org/r/20250502214729.928380-2-andrey.drobyshev@virtuozzo.com\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n monitor/qmp.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/monitor/qmp.c b/monitor/qmp.c\nindex 2f46cf9e494..cb99a12d941 100644\n--- a/monitor/qmp.c\n+++ b/monitor/qmp.c\n@@ -356,7 +356,8 @@ void qmp_dispatcher_co_wake(void)\n /* Write request before reading qmp_dispatcher_co_busy. */\n smp_mb__before_rmw();\n \n- if (!qatomic_xchg(&qmp_dispatcher_co_busy, true)) {\n+ if (!qatomic_xchg(&qmp_dispatcher_co_busy, true) &&\n+ qatomic_read(&qmp_dispatcher_co)) {\n aio_co_wake(qmp_dispatcher_co);\n }\n }\n", "prefixes": [ "PULL", "13/13" ] }