Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2080611/?format=api
{ "id": 2080611, "url": "http://patchwork.ozlabs.org/api/patches/2080611/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250503075858.277375-11-pbonzini@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250503075858.277375-11-pbonzini@redhat.com>", "list_archive_url": null, "date": "2025-05-03T07:58:55", "name": "[PULL,10/13] target/i386: do not block singlestep for STI", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7405d545282c62838949e42a203c8fc06c1a288a", "submitter": { "id": 2701, "url": "http://patchwork.ozlabs.org/api/people/2701/?format=api", "name": "Paolo Bonzini", "email": "pbonzini@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250503075858.277375-11-pbonzini@redhat.com/mbox/", "series": [ { "id": 455199, "url": "http://patchwork.ozlabs.org/api/series/455199/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=455199", "date": "2025-05-03T07:58:51", "name": "[PULL,01/13] rust/vmstate: Add support for field_exists checks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/455199/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2080611/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2080611/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=GlvJ+nBQ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZqKwZ2sn8z1yMf\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 3 May 2025 18:00:46 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1uB7mh-0008AY-0M; Sat, 03 May 2025 03:59:43 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1uB7mf-0008A0-Lu\n for qemu-devel@nongnu.org; Sat, 03 May 2025 03:59:41 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1uB7md-0006hi-8c\n for qemu-devel@nongnu.org; Sat, 03 May 2025 03:59:41 -0400", "from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-593-rblvyGGXO1Gr1Zl7Qf7Cvw-1; Sat, 03 May 2025 03:59:34 -0400", "by mail-wr1-f72.google.com with SMTP id\n ffacd0b85a97d-391492acb59so1355023f8f.3\n for <qemu-devel@nongnu.org>; Sat, 03 May 2025 00:59:34 -0700 (PDT)", "from [192.168.10.48] ([151.95.54.106])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3a099b1702dsm4087901f8f.88.2025.05.03.00.59.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 03 May 2025 00:59:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1746259176;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mq+ksrrzmRU5e3CQiDfdSG+3l9vDGDH9VPK5MruBMrk=;\n b=GlvJ+nBQYwA3OW0JDHRnm8CQfO9ER4iDmnU5iDHYMYhIMXnyy4UtcKe0CXKXMa2HdpA9Uw\n jTe+BZw8n42JcZJq4U0yH6pect1MOC0fGLpMnJWcRDqGXc1BovLFaDl+JQ0zfEiquwxeeL\n LkwrF0+WdkhDsL1ChiGeBGIqlZsJ4CM=", "X-MC-Unique": "rblvyGGXO1Gr1Zl7Qf7Cvw-1", "X-Mimecast-MFC-AGG-ID": "rblvyGGXO1Gr1Zl7Qf7Cvw_1746259169", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1746259167; x=1746863967;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=mq+ksrrzmRU5e3CQiDfdSG+3l9vDGDH9VPK5MruBMrk=;\n b=UzIybRWAZN79FqtjmbswN3pUiy/EVmDKY0iBmaVAp3K9iQrMjJ7DNI94CePMnm7i+c\n uAQ9Y7WRzw8NMjxz0QpvNE8BoWt8FOHzQR9o4IB2C4/m7H8GcJwzy5cy+x2pC2XiIHMY\n zxqNZyL/yZlnyShfN331Q3qoRi3ZyKo4Nl455tFMJb3IAotX3vtRtTrNfA0/mMWbaXBH\n k+A0gC0ob/3VBdswbrCDsai3XEa3NnLcMjTksB0m9in7Utul1FoyDQ4EunMmHUBuDv3F\n eTm9DaysvMA4Nnx9y8nZqAITUYWvNTjHcumThKW82W+NO875Y15/rdlO40HbJ+Qv5uic\n 3zUQ==", "X-Gm-Message-State": "AOJu0YyQZ38WPOr0S2+hy8elAbxIDru3F46lDBpAoeXiXUMX1gR4nP0R\n zcE34bq+RDlB7QvrKJyCRd7JYOi/oEA03rDlkTSJV/UhjaZWPeOBhlwJ3unipFzo9nA2+knf/d6\n bR57aNpPJsRYpjO+PM0i0+ts3v608XuPrsp6uDIdPcE8kusFtE/NR6Cuhcp12zJye0k9pJi9IXK\n GZ7+ouayL/PmdDvp4puN1wsf+mjt3JfPvGyCst", "X-Gm-Gg": "ASbGncu48gsaD/xJnmMKh/+5Q9z+fQCPurNrUQIMUB1U0Hekp8N3kAgycEyVtNCW5YE\n ZcGYQpnUjwbuAwyxfI2aSFSe0+VZabeYfCDhIvxoMEauL/E1RnWPzP6zrjFSYzChaxdcgFXSPNc\n +pTIbutYK8stJ72tP03bWdRLh9zjPi8BnedQOWjx6LqxBhYgTAXRFemQyaOojiMogxRxJWerJxm\n rBJyQFF4CADEhOuUzj7JGQc7/bfZid2NnK1PGEM6yx0GG96FAMi0iVKFJdTlJ4VByxKRDg6GlRS\n uj9++AneLnM438I=", "X-Received": [ "by 2002:a05:6000:290a:b0:391:ba6:c069 with SMTP id\n ffacd0b85a97d-3a09fde480fmr260791f8f.44.1746259167376;\n Sat, 03 May 2025 00:59:27 -0700 (PDT)", "by 2002:a05:6000:290a:b0:391:ba6:c069 with SMTP id\n ffacd0b85a97d-3a09fde480fmr260778f8f.44.1746259166966;\n Sat, 03 May 2025 00:59:26 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n AGHT+IF1sFtvKCqzZS9aZeWAkok5WILy7L+lUxmba8LWiHlQdnF9xgnQyAaSrA1XjEYqEdVkL1KUhQ==", "From": "Paolo Bonzini <pbonzini@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-stable@nongnu.org", "Subject": "[PULL 10/13] target/i386: do not block singlestep for STI", "Date": "Sat, 3 May 2025 09:58:55 +0200", "Message-ID": "<20250503075858.277375-11-pbonzini@redhat.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250503075858.277375-1-pbonzini@redhat.com>", "References": "<20250503075858.277375-1-pbonzini@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.644,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "STI will trigger a singlestep exception even if it has inhibit-IRQ\nbehavior. Do not suppress single-step for all IRQ-inhibiting\ninstructions, instead special case MOV SS and POP SS.\n\nCc: qemu-stable@nongnu.org\nFixes: f0f0136abba (\"target/i386: no single-step exception after MOV or POP SS\", 2024-05-25)\nSigned-off-by: Paolo Bonzini <pbonzini@redhat.com>\n---\n target/i386/tcg/translate.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c\nindex a4e935b043b..ed43c95c1d9 100644\n--- a/target/i386/tcg/translate.c\n+++ b/target/i386/tcg/translate.c\n@@ -2047,11 +2047,15 @@ static void gen_movl_seg(DisasContext *s, X86Seg seg_reg, TCGv src, bool inhibit\n * stop as a special handling must be done to disable hardware\n * interrupts for the next instruction.\n *\n+ * This is the last instruction, so it's okay to overwrite\n+ * HF_TF_MASK; the next TB will start with the flag set.\n+ *\n * DISAS_EOB_INHIBIT_IRQ is a superset of DISAS_EOB_NEXT which\n * might have been set above.\n */\n if (inhibit_irq) {\n s->base.is_jmp = DISAS_EOB_INHIBIT_IRQ;\n+ s->flags &= ~HF_TF_MASK;\n }\n }\n \n@@ -2302,7 +2306,7 @@ gen_eob(DisasContext *s, int mode)\n if (mode == DISAS_EOB_RECHECK_TF) {\n gen_helper_rechecking_single_step(tcg_env);\n tcg_gen_exit_tb(NULL, 0);\n- } else if ((s->flags & HF_TF_MASK) && mode != DISAS_EOB_INHIBIT_IRQ) {\n+ } else if (s->flags & HF_TF_MASK) {\n gen_helper_single_step(tcg_env);\n } else if (mode == DISAS_JUMP &&\n /* give irqs a chance to happen */\n", "prefixes": [ "PULL", "10/13" ] }