Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2075153/?format=api
{ "id": 2075153, "url": "http://patchwork.ozlabs.org/api/patches/2075153/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/26dfe9191154ca65dca6ef51ce768ad2a0c30d5f.1745295397.git.ktokunaga.mail@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<26dfe9191154ca65dca6ef51ce768ad2a0c30d5f.1745295397.git.ktokunaga.mail@gmail.com>", "list_archive_url": null, "date": "2025-04-22T05:27:05", "name": "[v2,01/20] hw/core/loader.c: Fix type conflict of GLib function pointers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a132fc12a66d7c101ba26d9c2cca172548dbe849", "submitter": { "id": 90637, "url": "http://patchwork.ozlabs.org/api/people/90637/?format=api", "name": "Kohei Tokunaga", "email": "ktokunaga.mail@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/26dfe9191154ca65dca6ef51ce768ad2a0c30d5f.1745295397.git.ktokunaga.mail@gmail.com/mbox/", "series": [ { "id": 453631, "url": "http://patchwork.ozlabs.org/api/series/453631/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=453631", "date": "2025-04-22T05:27:04", "name": "Enable QEMU TCI to run 32bit guests on browsers", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/453631/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2075153/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2075153/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=OKGZb1tG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhW9h6QH8z1yMZ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 22 Apr 2025 15:33:28 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1u76BA-0001FJ-6a; Tue, 22 Apr 2025 01:28:20 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ktokunaga.mail@gmail.com>)\n id 1u76B6-0001Ed-Pq; Tue, 22 Apr 2025 01:28:17 -0400", "from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <ktokunaga.mail@gmail.com>)\n id 1u76B5-0007n8-3f; Tue, 22 Apr 2025 01:28:16 -0400", "by mail-pl1-x632.google.com with SMTP id\n d9443c01a7336-223fb0f619dso52997455ad.1;\n Mon, 21 Apr 2025 22:28:12 -0700 (PDT)", "from localhost.localdomain ([240d:1a:3b6:8b00:e142:4a4f:1ebb:3ca4])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-22c50eb4483sm75692085ad.118.2025.04.21.22.28.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 21 Apr 2025 22:28:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1745299691; x=1745904491; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9NQ7+0cp0B4BZ+F+1DEhH1LfKFVn/DFHA6zpy9bi3Vg=;\n b=OKGZb1tGCjl1neV+k4kKlNonOETqQ118aBaIpxqd4qPo682z6vOFsRpzigwPnfTByP\n r3w97z2gKIA1J7D7Hyl0w5Dcsw6FGxPWIedu4/KK+LG8YaZadu8g98iDS3hYTYI8o9eF\n crPFU4OPKPPzCfNFbgiAVKZJoFu6eRlTenXAyP7KkT07qzQXUy+7NJkSNcB64NKjuTPw\n r/8s/troXnlhgoaqdNy8ZabTnnmnnALH2BRkmsF2jOu/DTFg1BmNiVhSz17OMMLFw9lm\n ZCV63p8iYW6y0U6ZTdBeFoBt9S60yH8CkqcnLtwZRbxxxyZgqANdiU3g9MT31nxWMIxU\n IKAw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745299691; x=1745904491;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=9NQ7+0cp0B4BZ+F+1DEhH1LfKFVn/DFHA6zpy9bi3Vg=;\n b=MzO6jtgGnTscYRqb0OOO2s8FHUt6v+FZ7TnyeZ/3+msm5ifdDqx1jYzNPaUc3+vEGH\n boka7uqyivYSEAY1vT+lS4+CkJmKQWwePncZCbNRHmObm7+MyLBNCTFv4Vu8EJb0XzaZ\n LT9i5yKyJQYdhvLF5dGN5CQxYWFX/ev/z1krdWZE+ssnCxW6+5Q1jKE1Zk24crG8GW7H\n /vCNSz/nZK/xQVjaRtXkW8+AsdxKZju/Iz6fE4ltiEMtGwkB8h5oDwl1j1k+hkV8/FxR\n 8Y66hEtJRMqKd7iygQouL3iiEYcJ05mfuHOvCp/sYkIIwE549v1tXMmD38fPS6WHg8A7\n T5cA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCU4RF8pBp1JZb5mDFpQ1j0GcfiKoDhrf6XeLW4CEI2z3p/5CkwypDQr79TLpV9aGP8TXKR0b/W6cg==@nongnu.org,\n AJvYcCU5GtzUSubiR/JdGsGBj6t7zGbC4KaAhF3r313ihXAGLdVJL1BwaYDIiK9zjd2QBH7MydKaaS22KXNR0w==@nongnu.org,\n AJvYcCUDYG+81o/3WruZzjZaDl7zvmDiz3QM9TmTzWFq2fQgXL6k9BDH/CyCYcgkWk8uvtTqr7DQv9UljNY=@nongnu.org,\n AJvYcCUUljhEHIWBOwSxM/csCtbgY029ccj7f8aCWWCiP2Oozs2HQC9EEmImMkbqr7jucsb5teBJMewcD5e6tQ==@nongnu.org", "X-Gm-Message-State": "AOJu0YxwgMeZkGA3tfaQWME8ARJMDh6dLriyO/E7qym47R89xPErOCwX\n sWDZP7JETuQMWj7/rwXJ70KOIJJ5k3SxBZYLnBM8Kk5FLev83BIOvNgQeHs9", "X-Gm-Gg": "ASbGncsVkqt/r+OD9LVm3PHNQcnHO6yVNnYie4LZkVybBc/JvDY53WAP2WPJzM7/rhG\n U25ruZVfM4TjPCVJqteXzqZfYDImTwddMyP4HfdBd9sNHniBmYLumuu5x0g5H/IQONz9zyeiS+B\n eh090vBgWSyQHKj2mR3NwWqs5/PSJLmzuzWITHIMpStDFlK6l9QwSsTzu050PvvvWF+nS/Wp4G5\n 9bSI+uOe8lzhxDdzvTpyH+fRHWR1U8njo2ypMudPwDblwHYaPvryw2mA/efhDw1zK2hrlYgS9RE\n kJsgH9F3w/4OEt/dugvjMhuoCHZ7WRHMgjkPEXq5QnaqHxyeAo8ThXOtmDE=", "X-Google-Smtp-Source": "\n AGHT+IFQZuSA5UEEZIfqmUdfgADL4wO5YWoqm3vdhDf1L+aFr2jGRlrpu12P1/0vzKEaAX8X39f6sA==", "X-Received": "by 2002:a17:902:d4c2:b0:224:de2:7fd0 with SMTP id\n d9443c01a7336-22c535b2b3bmr201215225ad.25.1745299691273;\n Mon, 21 Apr 2025 22:28:11 -0700 (PDT)", "From": "Kohei Tokunaga <ktokunaga.mail@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, =?utf-8?q?Philipp?=\n\t=?utf-8?q?e_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Thomas Huth <thuth@redhat.com>, Kevin Wolf <kwolf@redhat.com>,\n Hanna Reitz <hreitz@redhat.com>, Kohei Tokunaga <ktokunaga.mail@gmail.com>,\n Paolo Bonzini <pbonzini@redhat.com>, Alexandre Iooss <erdnaxe@crans.org>,\n Mahmoud Mandour <ma.mandourr@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Pavel Pisa <pisa@cmp.felk.cvut.cz>,\n Francisco Iglesias <francisco.iglesias@amd.com>,\n Vikram Garhwal <vikram.garhwal@bytedance.com>,\n Jason Wang <jasowang@redhat.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Peter Xu <peterx@redhat.com>,\n David Hildenbrand <david@redhat.com>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Nicholas Piggin <npiggin@gmail.com>,\n Daniel Henrique Barboza <danielhb413@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Ilya Leoshkevich <iii@linux.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org", "Subject": "[PATCH v2 01/20] hw/core/loader.c: Fix type conflict of GLib function\n pointers", "Date": "Tue, 22 Apr 2025 14:27:05 +0900", "Message-Id": "\n <26dfe9191154ca65dca6ef51ce768ad2a0c30d5f.1745295397.git.ktokunaga.mail@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<cover.1745295397.git.ktokunaga.mail@gmail.com>", "References": "<cover.1745295397.git.ktokunaga.mail@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::632;\n envelope-from=ktokunaga.mail@gmail.com; helo=mail-pl1-x632.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "On Emscripten, function pointer casts can result in runtime failures due to\nstrict function signature checks. This affects the use of g_list_sort and\ng_slist_sort, which internally perform function pointer casts that are not\nsupported by Emscripten. To avoid these issues, g_list_sort_with_data and\ng_slist_sort_with_data should be used instead, as they do not rely on\nfunction pointer casting.\n\nSigned-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>\n---\n hw/core/loader.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\nV2:\n- Updated the commit message to explicitly explain that function pointer\n casts are performed internally by GLib.", "diff": "diff --git a/hw/core/loader.c b/hw/core/loader.c\nindex 2e35f0aa90..93a8b45d28 100644\n--- a/hw/core/loader.c\n+++ b/hw/core/loader.c\n@@ -1410,7 +1410,7 @@ typedef struct RomSec {\n * work, but this way saves a little work later by avoiding\n * dealing with \"gaps\" of 0 length.\n */\n-static gint sort_secs(gconstpointer a, gconstpointer b)\n+static gint sort_secs(gconstpointer a, gconstpointer b, gpointer d)\n {\n RomSec *ra = (RomSec *) a;\n RomSec *rb = (RomSec *) b;\n@@ -1463,7 +1463,7 @@ RomGap rom_find_largest_gap_between(hwaddr base, size_t size)\n /* sentinel */\n secs = add_romsec_to_list(secs, base + size, 1);\n \n- secs = g_list_sort(secs, sort_secs);\n+ secs = g_list_sort_with_data(secs, sort_secs, NULL);\n \n for (it = g_list_first(secs); it; it = g_list_next(it)) {\n cand = (RomSec *) it->data;\n", "prefixes": [ "v2", "01/20" ] }