Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2075142/?format=api
{ "id": 2075142, "url": "http://patchwork.ozlabs.org/api/patches/2075142/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/4d47a75c5768c9a6dc5d8b3504e78837577ad70d.1745295397.git.ktokunaga.mail@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<4d47a75c5768c9a6dc5d8b3504e78837577ad70d.1745295397.git.ktokunaga.mail@gmail.com>", "list_archive_url": null, "date": "2025-04-22T05:27:11", "name": "[v2,07/20] hw/net/can: Fix type conflict of GLib function pointers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "04d20580e3d30fdb69b9e8c2c6ab6278c20fe96a", "submitter": { "id": 90637, "url": "http://patchwork.ozlabs.org/api/people/90637/?format=api", "name": "Kohei Tokunaga", "email": "ktokunaga.mail@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/4d47a75c5768c9a6dc5d8b3504e78837577ad70d.1745295397.git.ktokunaga.mail@gmail.com/mbox/", "series": [ { "id": 453631, "url": "http://patchwork.ozlabs.org/api/series/453631/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=453631", "date": "2025-04-22T05:27:04", "name": "Enable QEMU TCI to run 32bit guests on browsers", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/453631/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2075142/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2075142/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=JZYqWP55;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhW5k6BNXz1yMZ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 22 Apr 2025 15:30:02 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1u76Cp-0002Mh-1j; Tue, 22 Apr 2025 01:30:04 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ktokunaga.mail@gmail.com>)\n id 1u76Br-0001hW-JH; Tue, 22 Apr 2025 01:29:16 -0400", "from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <ktokunaga.mail@gmail.com>)\n id 1u76Bo-0007rF-AI; Tue, 22 Apr 2025 01:29:03 -0400", "by mail-pl1-x632.google.com with SMTP id\n d9443c01a7336-22438c356c8so49303975ad.1;\n Mon, 21 Apr 2025 22:28:58 -0700 (PDT)", "from localhost.localdomain ([240d:1a:3b6:8b00:e142:4a4f:1ebb:3ca4])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-22c50eb4483sm75692085ad.118.2025.04.21.22.28.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 21 Apr 2025 22:28:57 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1745299738; x=1745904538; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jka831lyyEn5TBrC/KjMd2fj+rwDsw1v7du1qQ7OLBI=;\n b=JZYqWP55604SsNw11vMz1qGlXZt9v1Lbk7BSOo3pUeW0i1SDUE3QC8kpGPGfUz8gy/\n qBRQWr1BZ5fJCKPEz8kqVSP6tiUHsKdm6NwkJ+29lFJ5NSYS8oq1d9NjxCjomOnwBAPn\n 1ueAUr4/or9leo8a5wv2SMNeXskrL3zKDrmYq904v9r3dh6W4+hBVouOCMqqwL4nYIGL\n aoIm7YUlK7zs3N4vY370agW+B46hQDebt8L3tGiF8WfYse9PUtCmr2O8i7U3TXODDWvD\n COs71eLVsZcoTg7qfFTNpEREHWN2DIDOpeWF6Z9SsWdSbdndHd1+jcxSkhl4MPS0dteG\n Lp7g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745299738; x=1745904538;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=jka831lyyEn5TBrC/KjMd2fj+rwDsw1v7du1qQ7OLBI=;\n b=HLxdU04r8oHAN+d+T5B/NvQy9l9A5AjJ0l3op149ORKC8V4N7YZWFEHkLheMILLT/S\n EdN2quxcCpXnuVx5yqHE8zLNBi8UL5nNgvcn3Ny5WjUHjzrzLG0YrC97L2A/tgUAWUxz\n ahK77GwKeaj5Z+/DZ3KdFnndJBAOWxTEPG8ysftuItx3RRvu+4Yv9raQgInesBFr4p4k\n YWYcpFNaVWK0ehR+wPyYpPtBtI6bEVH9s7qqGMyvcrVXDP0nCDYcEUKLOqPPW1yKByQR\n M12htfDT/fzJrZE8vO/Ue88BrwgjD7nrgszsEut+LLyuJ1C6ohi2IIBQ+KiCSsZWGH7l\n LLxw==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUHpQ/eisHP1V0VyDHerX/S1/Oqxt/fwYy7BWRNw+RTjE08clvvq173XGPKnE2POgP3zUArWad0LMcIBQ==@nongnu.org,\n AJvYcCXDL3Y3WkGk6H35fzqvl6Xm9+/AI0kl8QBGzolGrRIkBPoZXExkQ5y83SRGX6MAKSvj9IBscIjjzms=@nongnu.org,\n AJvYcCXaLFSe0CrzK1AZYbLo1U7257XoeZ17nFrOOZakpy+H+4cS4g/5gXSs6lxWRDn/xA5w9e032OufXg==@nongnu.org,\n AJvYcCXoqs4wVriehNZRReyjS8zWTQqFruJsCV1WTvsit32jTiEFfpamI2rPN1yzWSf17dv4ILwejzcr37WSFg==@nongnu.org", "X-Gm-Message-State": "AOJu0Yz3pL5hvUADxzDpxWwwPqV3WiqRdMLDrdEWa6ut3a8xCCSpx1b6\n WylcEwQGUxOkVH6t4nZ8+cI9JrpuA6cTpJHOntlrDXPhl4flt7dPdRvw4hi7", "X-Gm-Gg": "ASbGnctLglXeMQWufSpekGf5f56FB6IhI77rM6dgOSPUWEt70fXzZPOokVQHlDfiHSV\n kqxYSNaBqrdew20PnszaI/3WIwtwvQp2x83SYYkQXoI1au2DzPzo9Yzr9bdrZfKjmbji97oas94\n 0KAPk80ftPew4XoN4HPj7l3vuSTIWL60cyHyHBl/Iz/BNwTvPclZW2kf5V/RUDRvL3p7f5pU1R1\n vHDifvPZ84v/mgEAL5nH0dXljiY13lP+SB+sJOE5ciw9ZsEv6rEnLu3+v5NajAsVCBVMFTVJpKj\n 5zKVZoEndBeP66PR99VVBCCqQyFz39rWtF+/jzVqIl25UCaAhyrYeZ1BhSg=", "X-Google-Smtp-Source": "\n AGHT+IGaXHMDzxoqNDfNho02Zs6s6BdUjSAFaf5W8QD0EenDq6q0h00TKwY1MjsG5jasjF+nnumjcQ==", "X-Received": "by 2002:a17:903:298d:b0:220:e392:c73 with SMTP id\n d9443c01a7336-22c535be3a0mr241851615ad.22.1745299737701;\n Mon, 21 Apr 2025 22:28:57 -0700 (PDT)", "From": "Kohei Tokunaga <ktokunaga.mail@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, =?utf-8?q?Philipp?=\n\t=?utf-8?q?e_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Thomas Huth <thuth@redhat.com>, Kevin Wolf <kwolf@redhat.com>,\n Hanna Reitz <hreitz@redhat.com>, Kohei Tokunaga <ktokunaga.mail@gmail.com>,\n Paolo Bonzini <pbonzini@redhat.com>, Alexandre Iooss <erdnaxe@crans.org>,\n Mahmoud Mandour <ma.mandourr@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Pavel Pisa <pisa@cmp.felk.cvut.cz>,\n Francisco Iglesias <francisco.iglesias@amd.com>,\n Vikram Garhwal <vikram.garhwal@bytedance.com>,\n Jason Wang <jasowang@redhat.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Peter Xu <peterx@redhat.com>,\n David Hildenbrand <david@redhat.com>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Nicholas Piggin <npiggin@gmail.com>,\n Daniel Henrique Barboza <danielhb413@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Ilya Leoshkevich <iii@linux.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org", "Subject": "[PATCH v2 07/20] hw/net/can: Fix type conflict of GLib function\n pointers", "Date": "Tue, 22 Apr 2025 14:27:11 +0900", "Message-Id": "\n <4d47a75c5768c9a6dc5d8b3504e78837577ad70d.1745295397.git.ktokunaga.mail@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<cover.1745295397.git.ktokunaga.mail@gmail.com>", "References": "<cover.1745295397.git.ktokunaga.mail@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::632;\n envelope-from=ktokunaga.mail@gmail.com; helo=mail-pl1-x632.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "On Emscripten, function pointer casts can result in runtime failures due to\nstrict function signature checks. This affects the use of g_list_sort and\ng_slist_sort, which internally perform function pointer casts that are not\nsupported by Emscripten. To avoid these issues, g_list_sort_with_data and\ng_slist_sort_with_data should be used instead, as they do not rely on\nfunction pointer casting.\n\nSigned-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>\n---\n hw/net/can/xlnx-versal-canfd.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\nV2:\n- Updated the commit message to explicitly explain that function pointer\n casts are performed internally by GLib.", "diff": "diff --git a/hw/net/can/xlnx-versal-canfd.c b/hw/net/can/xlnx-versal-canfd.c\nindex dc242e9215..013ebc10dc 100644\n--- a/hw/net/can/xlnx-versal-canfd.c\n+++ b/hw/net/can/xlnx-versal-canfd.c\n@@ -1278,7 +1278,7 @@ static void tx_fifo_stamp(XlnxVersalCANFDState *s, uint32_t tb0_regid)\n }\n }\n \n-static gint g_cmp_ids(gconstpointer data1, gconstpointer data2)\n+static gint g_cmp_ids(gconstpointer data1, gconstpointer data2, gpointer d)\n {\n tx_ready_reg_info *tx_reg_1 = (tx_ready_reg_info *) data1;\n tx_ready_reg_info *tx_reg_2 = (tx_ready_reg_info *) data2;\n@@ -1318,7 +1318,7 @@ static GSList *prepare_tx_data(XlnxVersalCANFDState *s)\n temp->can_id = s->regs[reg_num];\n temp->reg_num = reg_num;\n list = g_slist_prepend(list, temp);\n- list = g_slist_sort(list, g_cmp_ids);\n+ list = g_slist_sort_with_data(list, g_cmp_ids, NULL);\n }\n \n reg_ready >>= 1;\n", "prefixes": [ "v2", "07/20" ] }