Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2075139/?format=api
{ "id": 2075139, "url": "http://patchwork.ozlabs.org/api/patches/2075139/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/98cee904084f66762b6ef9fca4248f1c8c995d3b.1745295397.git.ktokunaga.mail@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<98cee904084f66762b6ef9fca4248f1c8c995d3b.1745295397.git.ktokunaga.mail@gmail.com>", "list_archive_url": null, "date": "2025-04-22T05:27:09", "name": "[v2,05/20] target/i386/cpu.c: Fix type conflict of GLib function pointers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8215d62eeca56489001a811b32f9ea201dea1c0b", "submitter": { "id": 90637, "url": "http://patchwork.ozlabs.org/api/people/90637/?format=api", "name": "Kohei Tokunaga", "email": "ktokunaga.mail@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/98cee904084f66762b6ef9fca4248f1c8c995d3b.1745295397.git.ktokunaga.mail@gmail.com/mbox/", "series": [ { "id": 453631, "url": "http://patchwork.ozlabs.org/api/series/453631/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=453631", "date": "2025-04-22T05:27:04", "name": "Enable QEMU TCI to run 32bit guests on browsers", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/453631/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2075139/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2075139/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=dIq7Mrwk;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhW4k6q0pz1yMy\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 22 Apr 2025 15:29:10 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1u76Bc-0001S8-M1; Tue, 22 Apr 2025 01:28:48 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ktokunaga.mail@gmail.com>)\n id 1u76Ba-0001RE-VO; Tue, 22 Apr 2025 01:28:46 -0400", "from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <ktokunaga.mail@gmail.com>)\n id 1u76BZ-0007pr-8Q; Tue, 22 Apr 2025 01:28:46 -0400", "by mail-pl1-x62c.google.com with SMTP id\n d9443c01a7336-22409077c06so64333465ad.1;\n Mon, 21 Apr 2025 22:28:43 -0700 (PDT)", "from localhost.localdomain ([240d:1a:3b6:8b00:e142:4a4f:1ebb:3ca4])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-22c50eb4483sm75692085ad.118.2025.04.21.22.28.34\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 21 Apr 2025 22:28:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1745299722; x=1745904522; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=hr9XXQB6Zuvd+iKttpiqSUP78igtxru6uVhXXPY7Q/k=;\n b=dIq7MrwkWCfUkjKd5XEk8Zywlaky8lKU1Bi2Iv4BiAb4A3OrzbovLt+iFq6Himz28l\n 6uthAEW6b18y04McXB3TSdraAu+Mo/vE5lPnMvcuePN2EpS6PkwehjyF01zBXM+nFuMG\n 9aOuFO45Vt3BY0Ayq7a33WOiLuXHCuk7I4DsqT1TWhTR+jZ0Ud/rpDmXLOFLtKZaYePx\n 98kNKSTGUhkiDXeozaqI1NAvFzicUl0ira7i1mjTbFwqUd+ivciMU3BDK3McJKjXCceC\n W5J/aBuFU7HV3DN0bLXMk7FH27XTeXdxrWuETVN7rRgTy7hc91nmlQ6eXLop0uZItSEa\n 9Ivg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745299722; x=1745904522;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=hr9XXQB6Zuvd+iKttpiqSUP78igtxru6uVhXXPY7Q/k=;\n b=PCfsxM/7aKcISqwM9F1hTVgoHfxZgvNMy60q2y6jAICz6hW9tc7j4MjX3SAWWdZC7r\n LjbiLknXWqj7ZO9NQG07kkc73J5aevd/6CaRmwSEy0bJVa6aTyFrgZo656fDAeC8CHQq\n /CIhZlmaJovdPoQmMpH1IWXT3qRmnpva1Gebc4EVudAhB+AQhtsbmbk1Bd0/VQqCitUJ\n HmpYxRq8hPw+UaWTOSsaWSml8s7bW0xU+MvDyjA0L6iYzO4rluIS+tEdIJ7q4tlKOqwD\n kxN0aybPzrzvoiS7zmSgdoG4RC/DH+4yaAekIq9wXge8dTSfBSjtR4sVdFoIldyIitDa\n EcRQ==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUuaPN46O36Ia+mzKYLGcOJc18D/ZYU7rIt4unYN7w/OQ5d1EeDSnhPSowy5gW4BDiqBvfNUfp5kU9j5A==@nongnu.org,\n AJvYcCVHW+6KyiOi8jjqj3X/tz+MmpCJy77EOu6itR/PnuG3O08vWa3CibE6TiAFZdeeHtZ740St+kOwqiCYkA==@nongnu.org,\n AJvYcCXSgpL8DfzfvhmPrA1JbzRCFZU0TuUBVZz/tGHoY2/OQy4mNazk8rCNByewoS7BxzXQ2kh8OdtHYgE=@nongnu.org,\n AJvYcCXTTnGEv7Lygudal/yROBJ08xl5oRejSrvmEKrJA7YpviUZWqEhKFjCRv4ae1WED0vpl/KBgtg3JA==@nongnu.org", "X-Gm-Message-State": "AOJu0YwERcWinFSo/s9TlOSFXp72Xdshwy/+hMJvOhLSBUpqLbXe/NGK\n 0ojAK73yU5DxDYFaCj875EWfmc9kO9gsfUoFP+skXQa5JSwdQ4pqBaIMTIqd", "X-Gm-Gg": "ASbGncvfH/H+a3bHaR6Cb3CZe3gqm3FHiGkqKlXto3l/4z2hJ8p0U2Yduh0gwCU+k9H\n gQB0tsYsggYuArUHTkHYqtMoipKVf379xkkETXIRVJg9t0ukTUCdUipuMYI4YCB6UliaTz5YQjm\n eyWs/DFH4OfVdpvLaPDMaip07MO+Jydw/b/LOCjFLiOScwcEAhQ4izJ0xn0F5O0IBoUoe5mxB/A\n HV+LoNfUvAPFuy/8GL3VaPL+cvS9CxTf3V1nInwOwIfI6LRU3NjwUki4ZznE4g0lQLSpo8yPLt9\n Ko/vCgXkNT4voTUYAvO5rtZC2h3Z6aqOeCE/jPDV/WLn4caIk55CRI1g11DEWQHxr27KMA==", "X-Google-Smtp-Source": "\n AGHT+IFEW2NT+cAzggJEpQL3dt6BcmbrJbdC6ZiC0A9EVoOH3QZflzMIs4u+eWmxfq5VVr0igUgIOg==", "X-Received": "by 2002:a17:903:1b67:b0:223:377f:9795 with SMTP id\n d9443c01a7336-22c530bbe9emr210573765ad.0.1745299722329;\n Mon, 21 Apr 2025 22:28:42 -0700 (PDT)", "From": "Kohei Tokunaga <ktokunaga.mail@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, =?utf-8?q?Philipp?=\n\t=?utf-8?q?e_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Thomas Huth <thuth@redhat.com>, Kevin Wolf <kwolf@redhat.com>,\n Hanna Reitz <hreitz@redhat.com>, Kohei Tokunaga <ktokunaga.mail@gmail.com>,\n Paolo Bonzini <pbonzini@redhat.com>, Alexandre Iooss <erdnaxe@crans.org>,\n Mahmoud Mandour <ma.mandourr@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Pavel Pisa <pisa@cmp.felk.cvut.cz>,\n Francisco Iglesias <francisco.iglesias@amd.com>,\n Vikram Garhwal <vikram.garhwal@bytedance.com>,\n Jason Wang <jasowang@redhat.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Peter Xu <peterx@redhat.com>,\n David Hildenbrand <david@redhat.com>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Nicholas Piggin <npiggin@gmail.com>,\n Daniel Henrique Barboza <danielhb413@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Ilya Leoshkevich <iii@linux.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org", "Subject": "[PATCH v2 05/20] target/i386/cpu.c: Fix type conflict of GLib\n function pointers", "Date": "Tue, 22 Apr 2025 14:27:09 +0900", "Message-Id": "\n <98cee904084f66762b6ef9fca4248f1c8c995d3b.1745295397.git.ktokunaga.mail@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<cover.1745295397.git.ktokunaga.mail@gmail.com>", "References": "<cover.1745295397.git.ktokunaga.mail@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::62c;\n envelope-from=ktokunaga.mail@gmail.com; helo=mail-pl1-x62c.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "On Emscripten, function pointer casts can result in runtime failures due to\nstrict function signature checks. This affects the use of g_list_sort and\ng_slist_sort, which internally perform function pointer casts that are not\nsupported by Emscripten. To avoid these issues, g_list_sort_with_data and\ng_slist_sort_with_data should be used instead, as they do not rely on\nfunction pointer casting.\n\nSigned-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>\n---\n target/i386/cpu.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)\n\nV2:\n- Updated the commit message to explicitly explain that function pointer\n casts are performed internally by GLib.", "diff": "diff --git a/target/i386/cpu.c b/target/i386/cpu.c\nindex 1b64ceaaba..2c494e4b0b 100644\n--- a/target/i386/cpu.c\n+++ b/target/i386/cpu.c\n@@ -6226,7 +6226,7 @@ static void listflags(GList *features)\n }\n \n /* Sort alphabetically by type name, respecting X86CPUClass::ordering. */\n-static gint x86_cpu_list_compare(gconstpointer a, gconstpointer b)\n+static gint x86_cpu_list_compare(gconstpointer a, gconstpointer b, gpointer d)\n {\n ObjectClass *class_a = (ObjectClass *)a;\n ObjectClass *class_b = (ObjectClass *)b;\n@@ -6247,7 +6247,7 @@ static gint x86_cpu_list_compare(gconstpointer a, gconstpointer b)\n static GSList *get_sorted_cpu_model_list(void)\n {\n GSList *list = object_class_get_list(TYPE_X86_CPU, false);\n- list = g_slist_sort(list, x86_cpu_list_compare);\n+ list = g_slist_sort_with_data(list, x86_cpu_list_compare, NULL);\n return list;\n }\n \n@@ -6304,6 +6304,11 @@ static void x86_cpu_list_entry(gpointer data, gpointer user_data)\n qemu_printf(\" %-20s %s\\n\", name, desc);\n }\n \n+static gint strcmp_wrap(gconstpointer a, gconstpointer b, gpointer d)\n+{\n+ return strcmp(a, b);\n+}\n+\n /* list available CPU models and flags */\n void x86_cpu_list(void)\n {\n@@ -6326,7 +6331,7 @@ void x86_cpu_list(void)\n }\n }\n \n- names = g_list_sort(names, (GCompareFunc)strcmp);\n+ names = g_list_sort_with_data(names, strcmp_wrap, NULL);\n \n qemu_printf(\"\\nRecognized CPUID flags:\\n\");\n listflags(names);\n", "prefixes": [ "v2", "05/20" ] }