Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2070368/?format=api
{ "id": 2070368, "url": "http://patchwork.ozlabs.org/api/patches/2070368/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250409023711.2960618-8-maobibo@loongson.cn/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250409023711.2960618-8-maobibo@loongson.cn>", "list_archive_url": null, "date": "2025-04-09T02:37:02", "name": "[v3,07/16] hw/intc/loongarch_pch: Use generic read callback for iomem32_low region", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e63e9baa3839fa25ebf30a3f707447064f533d66", "submitter": { "id": 78914, "url": "http://patchwork.ozlabs.org/api/people/78914/?format=api", "name": "Bibo Mao", "email": "maobibo@loongson.cn" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250409023711.2960618-8-maobibo@loongson.cn/mbox/", "series": [ { "id": 451861, "url": "http://patchwork.ozlabs.org/api/series/451861/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=451861", "date": "2025-04-09T02:37:00", "name": "hw/intc/loongarch_pch: Cleanup with memory region ops", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/451861/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2070368/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2070368/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZXRw12QP7z1yHS\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 9 Apr 2025 12:38:41 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1u2LJi-0006Vj-Vp; Tue, 08 Apr 2025 22:37:31 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <maobibo@loongson.cn>)\n id 1u2LJg-0006Th-5n\n for qemu-devel@nongnu.org; Tue, 08 Apr 2025 22:37:28 -0400", "from mail.loongson.cn ([114.242.206.163])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from <maobibo@loongson.cn>) id 1u2LJc-0007nI-CA\n for qemu-devel@nongnu.org; Tue, 08 Apr 2025 22:37:27 -0400", "from loongson.cn (unknown [10.2.10.34])\n by gateway (Coremail) with SMTP id _____8AxquBd3fVnHK+1AA--.63889S3;\n Wed, 09 Apr 2025 10:37:17 +0800 (CST)", "from localhost.localdomain (unknown [10.2.10.34])\n by front1 (Coremail) with SMTP id qMiowMBxLsdY3fVnnsR1AA--.28294S9;\n Wed, 09 Apr 2025 10:37:16 +0800 (CST)" ], "From": "Bibo Mao <maobibo@loongson.cn>", "To": "Song Gao <gaosong@loongson.cn>", "Cc": "Jiaxun Yang <jiaxun.yang@flygoat.com>,\n\tqemu-devel@nongnu.org", "Subject": "[PATCH v3 07/16] hw/intc/loongarch_pch: Use generic read callback for\n iomem32_low region", "Date": "Wed, 9 Apr 2025 10:37:02 +0800", "Message-Id": "<20250409023711.2960618-8-maobibo@loongson.cn>", "X-Mailer": "git-send-email 2.39.3", "In-Reply-To": "<20250409023711.2960618-1-maobibo@loongson.cn>", "References": "<20250409023711.2960618-1-maobibo@loongson.cn>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "qMiowMBxLsdY3fVnnsR1AA--.28294S9", "X-CM-SenderInfo": "xpdruxter6z05rqj20fqof0/", "X-Coremail-Antispam": "1Uk129KBj93XoWxWr17Gw4rGFWUZrWxuw47KFX_yoW5WrW5pr\n W3Ar93AF4DJF17WFs7A343Arn7J3Z7Wryaga9Ivry09F95Jrn5Wryvq347WF1jk3srJryU\n WrZxuFsI9a17X3XCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa\n sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU\n 0xBIdaVrnRJUUUk0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2\n IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v\n e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI\n 0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v2\n 6rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I\n 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1q6rW5McIj6I8E87Iv67AK\n xVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2Ij64\n vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8G\n jcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1Y6r17MIIYrxkI7VAKI48JMIIF0xvE2I\n x0cI8IcVAFwI0_Gr0_Xr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK\n 8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I\n 0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUcHUqUUUUU", "Received-SPF": "pass client-ip=114.242.206.163;\n envelope-from=maobibo@loongson.cn;\n helo=mail.loongson.cn", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "For memory region iomem32_low, generic read callback is used.\n\nSigned-off-by: Bibo Mao <maobibo@loongson.cn>\n---\n hw/intc/loongarch_pch_pic.c | 67 ++++++++++++++++++++++++++-----------\n 1 file changed, 47 insertions(+), 20 deletions(-)", "diff": "diff --git a/hw/intc/loongarch_pch_pic.c b/hw/intc/loongarch_pch_pic.c\nindex 421ede7bee..d303ce0667 100644\n--- a/hw/intc/loongarch_pch_pic.c\n+++ b/hw/intc/loongarch_pch_pic.c\n@@ -7,6 +7,7 @@\n \n #include \"qemu/osdep.h\"\n #include \"qemu/bitops.h\"\n+#include \"qemu/log.h\"\n #include \"hw/irq.h\"\n #include \"hw/intc/loongarch_pch_pic.h\"\n #include \"trace.h\"\n@@ -71,47 +72,73 @@ static void pch_pic_irq_handler(void *opaque, int irq, int level)\n pch_pic_update_irq(s, mask, level);\n }\n \n-static uint64_t loongarch_pch_pic_low_readw(void *opaque, hwaddr addr,\n- unsigned size)\n+static uint64_t pch_pic_read(void *opaque, hwaddr addr, uint64_t field_mask)\n {\n LoongArchPICCommonState *s = LOONGARCH_PIC_COMMON(opaque);\n uint64_t val = 0;\n+ uint32_t offset;\n \n+ offset = addr & 7;\n+ addr -= offset;\n switch (addr) {\n case PCH_PIC_INT_ID:\n- val = s->id.data & UINT_MAX;\n- break;\n- case PCH_PIC_INT_ID + 4:\n- val = s->id.data >> 32;\n+ val = s->id.data;\n break;\n case PCH_PIC_INT_MASK:\n- val = (uint32_t)s->int_mask;\n- break;\n- case PCH_PIC_INT_MASK + 4:\n- val = s->int_mask >> 32;\n+ val = s->int_mask;\n break;\n case PCH_PIC_INT_EDGE:\n- val = (uint32_t)s->intedge;\n- break;\n- case PCH_PIC_INT_EDGE + 4:\n- val = s->intedge >> 32;\n+ val = s->intedge;\n break;\n case PCH_PIC_HTMSI_EN:\n- val = (uint32_t)s->htmsi_en;\n- break;\n- case PCH_PIC_HTMSI_EN + 4:\n- val = s->htmsi_en >> 32;\n+ val = s->htmsi_en;\n break;\n case PCH_PIC_AUTO_CTRL0:\n- case PCH_PIC_AUTO_CTRL0 + 4:\n case PCH_PIC_AUTO_CTRL1:\n- case PCH_PIC_AUTO_CTRL1 + 4:\n /* PCH PIC connect to EXTIOI always, discard auto_ctrl access */\n break;\n default:\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"pch_pic_read: Bad address 0x%\"PRIx64\"\\n\", addr);\n+ break;\n+ }\n+\n+ return (val >> (offset * 8)) & field_mask;\n+}\n+\n+static uint64_t loongarch_pch_pic_read(void *opaque, hwaddr addr,\n+ unsigned size)\n+{\n+ uint64_t val = 0;\n+\n+ switch (size) {\n+ case 1:\n+ val = pch_pic_read(opaque, addr, UCHAR_MAX);\n+ break;\n+ case 2:\n+ val = pch_pic_read(opaque, addr, USHRT_MAX);\n+ break;\n+ case 4:\n+ val = pch_pic_read(opaque, addr, UINT_MAX);\n+ break;\n+ case 8:\n+ val = pch_pic_read(opaque, addr, UINT64_MAX);\n+ break;\n+ default:\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"loongarch_pch_pic_read: Bad size %d\\n\", size);\n break;\n }\n \n+ return val;\n+}\n+\n+static uint64_t loongarch_pch_pic_low_readw(void *opaque, hwaddr addr,\n+ unsigned size)\n+{\n+ uint64_t val;\n+\n+ val = loongarch_pch_pic_read(opaque, addr, size);\n trace_loongarch_pch_pic_low_readw(size, addr, val);\n return val;\n }\n", "prefixes": [ "v3", "07/16" ] }