Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2070360/?format=api
{ "id": 2070360, "url": "http://patchwork.ozlabs.org/api/patches/2070360/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250409023711.2960618-4-maobibo@loongson.cn/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250409023711.2960618-4-maobibo@loongson.cn>", "list_archive_url": null, "date": "2025-04-09T02:36:58", "name": "[v3,03/16] hw/intc/loongarch_pch: Remove some duplicate macro", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1ce6a753958655dcdce2872ab49232d12e8f6c9b", "submitter": { "id": 78914, "url": "http://patchwork.ozlabs.org/api/people/78914/?format=api", "name": "Bibo Mao", "email": "maobibo@loongson.cn" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20250409023711.2960618-4-maobibo@loongson.cn/mbox/", "series": [ { "id": 451861, "url": "http://patchwork.ozlabs.org/api/series/451861/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=451861", "date": "2025-04-09T02:37:00", "name": "hw/intc/loongarch_pch: Cleanup with memory region ops", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/451861/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2070360/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2070360/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZXRvl4Ytkz1yHS\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 9 Apr 2025 12:38:27 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1u2LJj-0006Vt-PJ; Tue, 08 Apr 2025 22:37:31 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <maobibo@loongson.cn>)\n id 1u2LJh-0006Ui-FR\n for qemu-devel@nongnu.org; Tue, 08 Apr 2025 22:37:29 -0400", "from mail.loongson.cn ([114.242.206.163])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from <maobibo@loongson.cn>) id 1u2LJc-0007nB-KS\n for qemu-devel@nongnu.org; Tue, 08 Apr 2025 22:37:29 -0400", "from loongson.cn (unknown [10.2.10.34])\n by gateway (Coremail) with SMTP id _____8AxTWta3fVnE6+1AA--.39486S3;\n Wed, 09 Apr 2025 10:37:14 +0800 (CST)", "from localhost.localdomain (unknown [10.2.10.34])\n by front1 (Coremail) with SMTP id qMiowMBxLsdY3fVnnsR1AA--.28294S5;\n Wed, 09 Apr 2025 10:37:14 +0800 (CST)" ], "From": "Bibo Mao <maobibo@loongson.cn>", "To": "Song Gao <gaosong@loongson.cn>", "Cc": "Jiaxun Yang <jiaxun.yang@flygoat.com>,\n\tqemu-devel@nongnu.org", "Subject": "[PATCH v3 03/16] hw/intc/loongarch_pch: Remove some duplicate macro", "Date": "Wed, 9 Apr 2025 10:36:58 +0800", "Message-Id": "<20250409023711.2960618-4-maobibo@loongson.cn>", "X-Mailer": "git-send-email 2.39.3", "In-Reply-To": "<20250409023711.2960618-1-maobibo@loongson.cn>", "References": "<20250409023711.2960618-1-maobibo@loongson.cn>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "qMiowMBxLsdY3fVnnsR1AA--.28294S5", "X-CM-SenderInfo": "xpdruxter6z05rqj20fqof0/", "X-Coremail-Antispam": "1Uk129KBj93XoWxCr48Cw15Cw18Xw4kGF4fCrX_yoW5Wr4fpF\n 9xAFsIgrsrGry7XFn2ya45Zr1DJFnrur9F9anIkryF9Fs8Zry8X3WkJ3y5WF1UK3y5Jryq\n grsxua1av3WUWrcCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa\n sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU\n 0xBIdaVrnRJUUUyEb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2\n IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v\n e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI\n 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_\n GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4\n xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JF0_Jw1lYx0Ex4A2jsIE14v2\n 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI\n xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480\n Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIxkGc2Ij64vIr41lIxAIcVC0I7\n IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k2\n 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV\n AFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU82g43UUUUU==", "Received-SPF": "pass client-ip=114.242.206.163;\n envelope-from=maobibo@loongson.cn;\n helo=mail.loongson.cn", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The meaning of macro definition STATUS_LO_START is simliar with\nPCH_PIC_INT_STATUS, only that offset is different, the same for\nmacro POL_LO_START. Now remove these duplicated macro definitions.\n\nSigned-off-by: Bibo Mao <maobibo@loongson.cn>\n---\n hw/intc/loongarch_pch_pic.c | 20 ++++++++++----------\n include/hw/intc/loongarch_pic_common.h | 5 -----\n 2 files changed, 10 insertions(+), 15 deletions(-)", "diff": "diff --git a/hw/intc/loongarch_pch_pic.c b/hw/intc/loongarch_pch_pic.c\nindex 4c845ba5e9..a2d9930ac9 100644\n--- a/hw/intc/loongarch_pch_pic.c\n+++ b/hw/intc/loongarch_pch_pic.c\n@@ -208,19 +208,19 @@ static uint64_t loongarch_pch_pic_high_readw(void *opaque, hwaddr addr,\n {\n LoongArchPICCommonState *s = LOONGARCH_PIC_COMMON(opaque);\n uint64_t val = 0;\n- uint32_t offset = addr & 0xfff;\n+ uint32_t offset = addr + PCH_PIC_INT_STATUS;\n \n switch (offset) {\n- case STATUS_LO_START:\n+ case PCH_PIC_INT_STATUS:\n val = (uint32_t)(s->intisr & (~s->int_mask));\n break;\n- case STATUS_HI_START:\n+ case PCH_PIC_INT_STATUS + 4:\n val = (s->intisr & (~s->int_mask)) >> 32;\n break;\n- case POL_LO_START:\n+ case PCH_PIC_INT_POL:\n val = (uint32_t)s->int_polarity;\n break;\n- case POL_HI_START:\n+ case PCH_PIC_INT_POL + 4:\n val = s->int_polarity >> 32;\n break;\n default:\n@@ -236,21 +236,21 @@ static void loongarch_pch_pic_high_writew(void *opaque, hwaddr addr,\n {\n LoongArchPICCommonState *s = LOONGARCH_PIC_COMMON(opaque);\n uint32_t offset, data = (uint32_t)value;\n- offset = addr & 0xfff;\n+ offset = addr + PCH_PIC_INT_STATUS;\n \n trace_loongarch_pch_pic_high_writew(size, addr, data);\n \n switch (offset) {\n- case STATUS_LO_START:\n+ case PCH_PIC_INT_STATUS:\n s->intisr = get_writew_val(s->intisr, data, 0);\n break;\n- case STATUS_HI_START:\n+ case PCH_PIC_INT_STATUS + 4:\n s->intisr = get_writew_val(s->intisr, data, 1);\n break;\n- case POL_LO_START:\n+ case PCH_PIC_INT_POL:\n s->int_polarity = get_writew_val(s->int_polarity, data, 0);\n break;\n- case POL_HI_START:\n+ case PCH_PIC_INT_POL + 4:\n s->int_polarity = get_writew_val(s->int_polarity, data, 1);\n break;\n default:\ndiff --git a/include/hw/intc/loongarch_pic_common.h b/include/hw/intc/loongarch_pic_common.h\nindex b33bebb129..ef6edc15bf 100644\n--- a/include/hw/intc/loongarch_pic_common.h\n+++ b/include/hw/intc/loongarch_pic_common.h\n@@ -26,11 +26,6 @@\n #define PCH_PIC_INT_STATUS 0x3a0\n #define PCH_PIC_INT_POL 0x3e0\n \n-#define STATUS_LO_START 0\n-#define STATUS_HI_START 0x4\n-#define POL_LO_START 0x40\n-#define POL_HI_START 0x44\n-\n #define TYPE_LOONGARCH_PIC_COMMON \"loongarch_pic_common\"\n OBJECT_DECLARE_TYPE(LoongArchPICCommonState,\n LoongArchPICCommonClass, LOONGARCH_PIC_COMMON)\n", "prefixes": [ "v3", "03/16" ] }