Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2069328/?format=api
{ "id": 2069328, "url": "http://patchwork.ozlabs.org/api/patches/2069328/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250407-fdt-chosen-v1-1-3dda83c48c07@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250407-fdt-chosen-v1-1-3dda83c48c07@gmail.com>", "list_archive_url": null, "date": "2025-04-07T06:43:44", "name": "[RFC] fdt.c: fdt chosen cmd had off-by-one issue", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0e996ca63b1b81c0800097973ca20c78c879cb81", "submitter": { "id": 88776, "url": "http://patchwork.ozlabs.org/api/people/88776/?format=api", "name": "George Chan via B4 Relay", "email": "devnull+gchan9527.gmail.com@kernel.org" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250407-fdt-chosen-v1-1-3dda83c48c07@gmail.com/mbox/", "series": [ { "id": 451535, "url": "http://patchwork.ozlabs.org/api/series/451535/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=451535", "date": "2025-04-07T06:43:44", "name": "[RFC] fdt.c: fdt chosen cmd had off-by-one issue", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/451535/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2069328/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2069328/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ohpFsjM1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"ohpFsjM1\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org", "phobos.denx.de; spf=pass\n smtp.mailfrom=devnull+gchan9527.gmail.com@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZWTKD5q57z1yHb\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 7 Apr 2025 22:38:40 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E1CF882E38;\n\tMon, 7 Apr 2025 14:38:57 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 033CA82CA4; Mon, 7 Apr 2025 08:44:05 +0200 (CEST)", "from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A4EED82C55\n for <u-boot@lists.denx.de>; Mon, 7 Apr 2025 08:44:02 +0200 (CEST)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id E9AFC61129;\n Mon, 7 Apr 2025 06:43:52 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPS id 156D9C4CEDD;\n Mon, 7 Apr 2025 06:44:01 +0000 (UTC)", "from aws-us-west-2-korg-lkml-1.web.codeaurora.org\n (localhost.localdomain [127.0.0.1])\n by smtp.lore.kernel.org (Postfix) with ESMTP id F1C35C36010;\n Mon, 7 Apr 2025 06:44:00 +0000 (UTC)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_REPLYTO,\n FREEMAIL_REPLYTO_END_DIGIT,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,\n SPF_PASS autolearn=no autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1744008241;\n bh=dIEnWBb3/vJ80+VQYxjPTn/FNs2QxMf8vpt/0QKgMrU=;\n h=From:Date:Subject:To:Cc:Reply-To:From;\n b=ohpFsjM1D4mYcIBzKOPWz5RArfpWDoULqEPEmkfh1gz/3DqvrpRCRGHw/iqOLs1mQ\n rWEXOKtolhEmJRRpTJDczEmgRsoq1oaAhhA5Bl1iADXa/1H0LO6CpcYVDGmEGN/fqj\n 58ibGd2nV8ojk7BYaDE/nnUv604VLRLAmJQfdi3RVvszYyRNoLE71VYzcfrXztKIoE\n Z4gFnS88m4svILilym1Rr/cKhVzpGyGC5FSZMRdJI/gB3a+fIpse1oi99ikZDxHl+v\n ziY0KypSvc6RjMYtEyxZCWft3OoqPaKuTt+6QQlxd/D+5ZYb/pdEMECDRII4CgZVaA\n hYkiDoDnCvOuA==", "From": "George Chan via B4 Relay <devnull+gchan9527.gmail.com@kernel.org>", "Date": "Mon, 07 Apr 2025 14:43:44 +0800", "Subject": "[PATCH RFC] fdt.c: fdt chosen cmd had off-by-one issue", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250407-fdt-chosen-v1-1-3dda83c48c07@gmail.com>", "X-B4-Tracking": "v=1; b=H4sIAB9082cC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE\n vPSU3UzU4B8JSMDI1MDEwNz3bSUEt3kjPzi1DzdZAtzAxPTNKNUw1RLJaCGgqLUtMwKsGHRsbW\n 1AB149+5cAAAA", "To": "Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de, George Chan <gchan9527@gmail.com>", "X-Mailer": "b4 0.13.0", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1744008239; l=1586;\n i=gchan9527@gmail.com; s=20241015; h=from:subject:message-id;\n bh=KXpDs9FaMUuw/TaF08xplmfD+9pguJkYrpcltFm/Q3U=;\n b=osa2720q9l0fvEKXeaUD32d5ZTJdZDmOSmCBCLhO1f3Xwl8tEHcRqspJjfzx2FBLa1FRmDnhK\n IP4mf1Z2qE5A184Epo8XgNBDx9En6YJHMn2LCB1RzHSbW8bdP5YKXR9", "X-Developer-Key": "i=gchan9527@gmail.com; a=ed25519;\n pk=dscYWhT+BiQOBMpPE19NFQAjBBmcpipc6zdf2MTze/U=", "X-Endpoint-Received": "by B4 Relay for gchan9527@gmail.com/20241015 with\n auth_id=248", "X-Original-From": "George Chan <gchan9527@gmail.com>", "X-Mailman-Approved-At": "Mon, 07 Apr 2025 14:38:56 +0200", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Reply-To": "gchan9527@gmail.com", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "From: George Chan <gchan9527@gmail.com>\n\nThe kernel searching bootconfig will be off-by-1 and never match\nthus always not found in this case.\n\nSigned-off-by: George Chan <gchan9527@gmail.com>\n---\nThe searching will shift-by-1 and never match the bootconfig thus\nalways not found bootconfig this case.\n\nKernel:\n data = (char *)initrd_end - BOOTCONFIG_MAGIC_LEN;\n for (i = 0; i < 4; i++) {\n if (!memcmp(data, BOOTCONFIG_MAGIC, BOOTCONFIG_MAGIC_LEN))\n goto found;\n data--;\n }\nu-boot:\n initrd_end = initrd_start + hextoul(argv[3], NULL) - 1;\n\nThat would be off-by-one apprently and matching fail for bootconfig.\nBoth u-boot and kernel worth a fix.\n\nAn out-of-tree patch for kernel to relax the searching is available\nbut not ready for submit.\nhttps://github.com/99degree/linux/commit/9d9ea454fe857a9f550d7e60957253e176e8e123\n---\n cmd/fdt.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\n---\nbase-commit: 848f7ffc64aa7c4cc2229095812625c12343c8c1\nchange-id: 20250407-fdt-chosen-c87045f2e1e9\n\nBest regards,", "diff": "diff --git a/cmd/fdt.c b/cmd/fdt.c\nindex d16b141ce32..13ffe929f8b 100644\n--- a/cmd/fdt.c\n+++ b/cmd/fdt.c\n@@ -705,7 +705,7 @@ static int do_fdt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])\n \n \t\tif (argc == 4) {\n \t\t\tinitrd_start = hextoul(argv[2], NULL);\n-\t\t\tinitrd_end = initrd_start + hextoul(argv[3], NULL) - 1;\n+\t\t\tinitrd_end = initrd_start + hextoul(argv[3], NULL);\n \t\t}\n \n \t\tfdt_chosen(working_fdt);\n", "prefixes": [ "RFC" ] }