Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2065590/?format=api
{ "id": 2065590, "url": "http://patchwork.ozlabs.org/api/patches/2065590/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250326082900.870861-1-ilias.apalodimas@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250326082900.870861-1-ilias.apalodimas@linaro.org>", "list_archive_url": null, "date": "2025-03-26T08:28:58", "name": "net: lwip: Remove error print on failed tx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "496f756fc1898b11a4fe239cd015fb8a843b6f2f", "submitter": { "id": 74147, "url": "http://patchwork.ozlabs.org/api/people/74147/?format=api", "name": "Ilias Apalodimas", "email": "ilias.apalodimas@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250326082900.870861-1-ilias.apalodimas@linaro.org/mbox/", "series": [ { "id": 450049, "url": "http://patchwork.ozlabs.org/api/series/450049/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=450049", "date": "2025-03-26T08:28:58", "name": "net: lwip: Remove error print on failed tx", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/450049/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2065590/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2065590/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ybPoyjRf;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"ybPoyjRf\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZN0Lx5dqzz1yG0\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 26 Mar 2025 19:29:13 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3CFF280756;\n\tWed, 26 Mar 2025 09:29:13 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 507FC808B6; Wed, 26 Mar 2025 09:29:12 +0100 (CET)", "from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n [IPv6:2a00:1450:4864:20::62f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id F2DFB8070C\n for <u-boot@lists.denx.de>; Wed, 26 Mar 2025 09:29:09 +0100 (CET)", "by mail-ej1-x62f.google.com with SMTP id\n a640c23a62f3a-ac29fd22163so1101144366b.3\n for <u-boot@lists.denx.de>; Wed, 26 Mar 2025 01:29:09 -0700 (PDT)", "from localhost.localdomain (ppp089210242125.access.hol.gr.\n [89.210.242.125]) by smtp.gmail.com with ESMTPSA id\n a640c23a62f3a-ac3efd23c7bsm1000140366b.150.2025.03.26.01.29.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 26 Mar 2025 01:29:08 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1742977749; x=1743582549; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=y8hiHCkxq5NHxn0NGFD7/BPoVtNE3UGSlwZhwLR3f0Q=;\n b=ybPoyjRfw2PoxSc2x82Vcy1QfZvjBT5oIdhqc+ePsBA4Dvqd+3XozI4qHbHMpyYO3A\n 8iztZaqhKQADDbgHRKEygFCId7csSzAgPAirUzEmqE3ZOm5PFRwGIjaLPp0WswVs6KPx\n uYPhACKhGkoIOC2PVs5UU5tUPXClPTVspkflzODLZQsLf8vQPB9mYpfy/cDbRwzd+tja\n FogPKguo6mKlvWDjYSPakXLdLE1HnT/phYl8ZwuwKlcG2vhz2x7+H8l6carJsDYvI+/7\n tedqfthfBvP+wnGdy3dRYx4TLiNbHCEwA80PDucImM+ZXAn+Zu0FFzupOcZSiJClO+LU\n HvUw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1742977749; x=1743582549;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=y8hiHCkxq5NHxn0NGFD7/BPoVtNE3UGSlwZhwLR3f0Q=;\n b=hLMSrhk1cKECPbbSgh5wnNP7iL3N3xLhbCFiU69dq6ABrPeg+I2JocM6twh3IIfOPM\n m6NN3ahlFpsRuyvEKLMSMwkuSBeInNSzC2zkvPftRk8BnJL4nfvU9Kx6G7jqMfjL3PH5\n k9MFchqkINbVOJZTlEL7znBpceDZTIdq0GIUmd8QSBidsbgPvipG+V24NnY1aMRoDovc\n YUlJDBDsrr+776oGWdsetbsNe2rI3xw78J5mUfPvv9XFd70S9/LD0Jz7y3c6z/82U4eX\n N7Fz6s3l/ZJHJuL+tqz7Wph4sdJ/ZXVnKHpQOs1nAqjKoP6ozRZ1FqQCTM2N6p9V7Q1q\n 7odg==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCVlwnfeZ6vZ8sDDFeTr79vp5qUkeSGwWRM+v84hsHbAsFrEYDJa4FW+Wo5Z+Afhs49Ap3en/Lk=@lists.denx.de", "X-Gm-Message-State": "AOJu0YzMWLdQJyVeCog0628UkKFCUKy8j8eZ4/SOwaqCmEaCulrVmCXy\n CP3RBu3EmJmRp0HgZ9ZUtcbHcMq4yP5rXzCyjhU1WS3/ZSMEgKMc8YJ4TN6K0uw=", "X-Gm-Gg": "ASbGnctY6MhEuqS04b2bvFNqjhNGHn2g2EpDhwOusaQwRk3Y7zBjPFFzE638ohozo5z\n E3gnhkIKAhU+cXxGTx+fHsZpBvsySZwKQ7ve/oC/62n/Xf5Lk1IV6sjVVJIrk51Bepx4gWWpo8K\n eLZhNeKcPwm3cDJvUca+0x4tcUDUucNeVrC04124L42z6j7iPnmEJFPvoou2aSPt7RgObMxwQfl\n eR54+u1zdc4LhruYP6Y0EqLvqIvMNL6LuPXAoWwFWTWG/1Unb4JHqYtrTlQB+7BOwWMfh8dJUKI\n cknCecGh+33ykblA5wZeZBbGJKYfrxUvCFFz0elJcrnX9GhtHedg1SBQQvXMF2Y1yt+1b7uTmRS\n ydnl4jhXUgZ7lWwc8qMeBCs0=", "X-Google-Smtp-Source": "\n AGHT+IFL3K3OKmGuGewcwRdOgTAUoFdbIvjk9qHe7OAhDNVbqMjiCchHNmLK73orcWUn2NAalRrxTg==", "X-Received": "by 2002:a17:906:d7cb:b0:ac2:cdcb:6a85 with SMTP id\n a640c23a62f3a-ac3f2110c2cmr1914404566b.22.1742977749306;\n Wed, 26 Mar 2025 01:29:09 -0700 (PDT)", "From": "Ilias Apalodimas <ilias.apalodimas@linaro.org>", "To": "jerome.forissier@linaro.org", "Cc": "Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>,\n u-boot@lists.denx.de", "Subject": "[PATCH] net: lwip: Remove error print on failed tx", "Date": "Wed, 26 Mar 2025 10:28:58 +0200", "Message-ID": "<20250326082900.870861-1-ilias.apalodimas@linaro.org>", "X-Mailer": "git-send-email 2.47.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "When an ethernet driver fails to send a frame we print an error in lwIP.\nBut depending on how often that error is it might significantly delay\ntransmissions.\n\nFor example downloading a big file with the rpi4 spams the console with\n'send error: -101', but removing the print makes the file download with\nan average speed of ~8.5MiB/s since the packets are retransmitted.\n\nSo let's move it to a 'debug' in lwIP and expect ethernet drivers to handle\nthe failure if it's severe.\n\nSigned-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>\n---\n net/lwip/net-lwip.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.47.2", "diff": "diff --git a/net/lwip/net-lwip.c b/net/lwip/net-lwip.c\nindex c00a7fe97cd6..6b7b696dbf0f 100644\n--- a/net/lwip/net-lwip.c\n+++ b/net/lwip/net-lwip.c\n@@ -57,7 +57,7 @@ static err_t net_lwip_tx(struct netif *netif, struct pbuf *p)\n \terr = eth_get_ops(udev)->send(udev, pp ? pp : p->payload, p->len);\n \tfree(pp);\n \tif (err) {\n-\t\tlog_err(\"send error %d\\n\", err);\n+\t\tdebug(\"send error %d\\n\", err);\n \t\treturn ERR_ABRT;\n \t}\n\n", "prefixes": [] }