Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2060210/?format=api
{ "id": 2060210, "url": "http://patchwork.ozlabs.org/api/patches/2060210/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250314084411.4165751-1-jerome.forissier@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250314084411.4165751-1-jerome.forissier@linaro.org>", "list_archive_url": null, "date": "2025-03-14T08:44:10", "name": "net: lwip: do_ping() should return CMD_RET_FAILURE when no device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "91c24c558f230c38d6c287915256cd348743a46f", "submitter": { "id": 69192, "url": "http://patchwork.ozlabs.org/api/people/69192/?format=api", "name": "Jerome Forissier", "email": "jerome.forissier@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250314084411.4165751-1-jerome.forissier@linaro.org/mbox/", "series": [ { "id": 448425, "url": "http://patchwork.ozlabs.org/api/series/448425/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=448425", "date": "2025-03-14T08:44:10", "name": "net: lwip: do_ping() should return CMD_RET_FAILURE when no device", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/448425/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2060210/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2060210/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=gMopR9PW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"gMopR9PW\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=jerome.forissier@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZDdGL2CMxz1yVR\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 14 Mar 2025 19:44:42 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DF31E8186D;\n\tFri, 14 Mar 2025 09:44:36 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 4A11A81951; Fri, 14 Mar 2025 09:44:35 +0100 (CET)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n [IPv6:2a00:1450:4864:20::335])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BDCDB81760\n for <u-boot@lists.denx.de>; Fri, 14 Mar 2025 09:44:32 +0100 (CET)", "by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-43cef035a3bso12440925e9.1\n for <u-boot@lists.denx.de>; Fri, 14 Mar 2025 01:44:32 -0700 (PDT)", "from builder.. ([2a01:e0a:3cb:7bb0:74e6:8b31:6e12:36a6])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-43d1fd6b2acsm10691675e9.0.2025.03.14.01.44.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 14 Mar 2025 01:44:30 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1741941872; x=1742546672; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=Pw9X+Y5X/erdPczz6VGYcNjee8wP/w0c60tn2vgGJY8=;\n b=gMopR9PW5q1Mr0mPiuu8BHaF2h4/fjZsekHlqulc85niWd3ZhIoIZeQfYd9iliQU/x\n wjutWsSKOcD5fJbrv83MyQP9IBhMRQshHL/9aLsv1U+RxHPd7Av9+WOfJ5OXvlzf52WB\n iGlaQkdiNLvTIzpv/nOC+27eIdXa7RtOYuyj9/DqQBql/VyeSTxB0odI+WrbP9U75rHN\n CXQqGF/g6moZaPYJfECuKj6Kxp0T9JdNGw46mW+YP3Nny8H9rrReE7tVIXxdMZkMC1Ja\n b93WwpkBHg80BKzr5ZpqIooTPUThYCKNr0d8zuaT1BYPjO8mW4+G2EESUtcwXNVEJd8v\n Zo2g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1741941872; x=1742546672;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Pw9X+Y5X/erdPczz6VGYcNjee8wP/w0c60tn2vgGJY8=;\n b=A/bs/y70zsOJib3CVIgwlo1Ilaav+6JSPiw196cVYkzoEwJ4cUCvSl/fOUDR34y3mA\n CfJfEtJe2lrkCydmo50NApyLvrmY7hIJ58ng6UCFPjCPNpJpxyKzNqAp4dvsbuDFxr0y\n uWeOEgUUsJOSD25bi0d9LWHOoqQwvhekeZ7tqhQN9P+nCRXyGxFkYCV3+xPqRNxhoGUu\n cLk2g0476DcrnjkQuy4AM7fktGIcBEYlPOgjHDmt1xG4sCgMbuzh1F6zzXEeDLbobzfh\n V/ma70Xa8JeSxTbsftl1yWHgUYlyz96fZdPlX3MXcYb0mVZ/RJaJ2y4twM1LUe9PNLWZ\n wofg==", "X-Gm-Message-State": "AOJu0Yw4ck5HZkePGX+qH5eOmHQbvzvaR/E5K+FY2J/fyLKl2pZZUdtg\n GDEhI2ztRtMyfc/J2ALvPRmzAj5FdV2VfzD3NQaEsqpWnANPb3DOfFJjZatJIBeijt2oKd+3m9R\n KE6E=", "X-Gm-Gg": "ASbGncsLYJ0YGY4mS/TXvafV+3AAg4MM/88CR7dG4CGi/dgKoCDkvpRC4Bn5fGl7s49\n flkbD6SiCYyN5GEk4KVUoWJmDzeu6NxcNZhPt7rwPgrvWTme4ZzECNsvUKYjxxwN6rKTlQabBjg\n FkO46pLZb675+xmq+zehxmOpf43uZ1CdXB+mzYQsRsLBkalE0zcTXksZBS8BST0Trf9V9SkUbs1\n CGW7in6qVffxwZeCi8MlM6VcYC4UkzAW/e9hsvtcrqS9ZzzLtrhGARHJkHFCVJdnzHa44X6NjvU\n GpktFW+upFnVungwtxNLYDLc+ooqvQw1E6jnkGV9pkSt0y3Z5A4k4Q==", "X-Google-Smtp-Source": "\n AGHT+IFgE1iiIjRieTCtNsmL1aBJR73pqsUyc6DthbIjdOPFBlUM9dQky+H71AZ3253PUjMQOvhIOw==", "X-Received": "by 2002:a05:600c:154c:b0:43c:fd27:a216 with SMTP id\n 5b1f17b1804b1-43d1ecff43amr18227455e9.23.1741941870422;\n Fri, 14 Mar 2025 01:44:30 -0700 (PDT)", "From": "Jerome Forissier <jerome.forissier@linaro.org>", "To": "u-boot@lists.denx.de", "Cc": "Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Jerome Forissier <jerome.forissier@linaro.org>,\n Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>", "Subject": "[PATCH] net: lwip: do_ping() should return CMD_RET_FAILURE when no\n device", "Date": "Fri, 14 Mar 2025 09:44:10 +0100", "Message-ID": "<20250314084411.4165751-1-jerome.forissier@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "do_ping() expects ping_loop() to return a negative value on error, so\nthat it can propagate it to the caller as CMD_RET_FAILURE. This is not\nthe case when no ethernet device is found, so fix that.\n\nSigned-off-by: Jerome Forissier <jerome.forissier@linaro.org>\n---\n net/lwip/ping.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/net/lwip/ping.c b/net/lwip/ping.c\nindex 200a702bbb5..c586a96806d 100644\n--- a/net/lwip/ping.c\n+++ b/net/lwip/ping.c\n@@ -121,7 +121,7 @@ static int ping_loop(struct udevice *udev, const ip_addr_t *addr)\n \n \tnetif = net_lwip_new_netif(udev);\n \tif (!netif)\n-\t\treturn CMD_RET_FAILURE;\n+\t\treturn -ENODEV;\n \n \tprintf(\"Using %s device\\n\", udev->name);\n \n", "prefixes": [] }