Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2059123/?format=api
{ "id": 2059123, "url": "http://patchwork.ozlabs.org/api/patches/2059123/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250312073655.2281377-1-mwalle@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250312073655.2281377-1-mwalle@kernel.org>", "list_archive_url": null, "date": "2025-03-12T07:36:55", "name": "[1/3] fastboot: lift restrictions on !NET_LWIP for USB", "commit_ref": "d3c9f810f2b317ba376b4d9556e63a043b210355", "pull_url": null, "state": "accepted", "archived": false, "hash": "1a1c3c10f3ad33d7c67ea86d542f9f2ce5321814", "submitter": { "id": 86646, "url": "http://patchwork.ozlabs.org/api/people/86646/?format=api", "name": "Michael Walle", "email": "mwalle@kernel.org" }, "delegate": { "id": 117687, "url": "http://patchwork.ozlabs.org/api/users/117687/?format=api", "username": "mkorpershoek", "first_name": "Mattijs", "last_name": "Korpershoek", "email": "mkorpershoek@baylibre.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250312073655.2281377-1-mwalle@kernel.org/mbox/", "series": [ { "id": 448076, "url": "http://patchwork.ozlabs.org/api/series/448076/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=448076", "date": "2025-03-12T07:36:55", "name": "[1/3] fastboot: lift restrictions on !NET_LWIP for USB", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/448076/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2059123/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2059123/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=XWvh3UW3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"XWvh3UW3\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=mwalle@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZCMsh4DBmz1yX8\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 12 Mar 2025 18:37:28 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E1DCA807D7;\n\tWed, 12 Mar 2025 08:37:20 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 21B9580756; Wed, 12 Mar 2025 08:37:19 +0100 (CET)", "from nyc.source.kernel.org (nyc.source.kernel.org\n [IPv6:2604:1380:45d1:ec00::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BA3BC801BE\n for <u-boot@lists.denx.de>; Wed, 12 Mar 2025 08:37:16 +0100 (CET)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by nyc.source.kernel.org (Postfix) with ESMTP id BC44FA46D3A;\n Wed, 12 Mar 2025 07:31:45 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 3561FC4CEE3;\n Wed, 12 Mar 2025 07:37:14 +0000 (UTC)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1741765035;\n bh=UkRo1OFNuoco3YdcfEhdDEXa8rxv/Jr0QFSi+U+MKLM=;\n h=From:To:Cc:Subject:Date:From;\n b=XWvh3UW3IguLMTOgtESOHzXPMiYR3PBK+6wq32bMBI/BzwLKDiRCYsEc/ASsNhm31\n dc7MWkO7dRkXbthKeO/PdzS3XVepO5nPExkdxue7NliiyZVYSJEVIRsOJcZLMXoLrS\n WrNSh6g1IzIktYvdqEUqxruF+h6cAyBz3N4/os6GZzBjuwZKSVU6/neub/HTDIoZjA\n x8LHmifV9P91tpIHyRgLrdWubl26YkD2sHMUPDzFSsxsTSrZhaG9srwDBcPPcF+GfC\n U1FVW/7FAn0aI6pFL6c3aZpN0sX785oJ8/91YrJYD7vGRJMKFyDJr6Pgjk4xXxrFjE\n HcXGMsrGl53UA==", "From": "Michael Walle <mwalle@kernel.org>", "To": "Mattijs Korpershoek <mkorpershoek@baylibre.com>,\n Tom Rini <trini@konsulko.com>,\n Jerome Forissier <jerome.forissier@linaro.org>", "Cc": "u-boot@lists.denx.de,\n\tMichael Walle <mwalle@kernel.org>", "Subject": "[PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB", "Date": "Wed, 12 Mar 2025 08:36:55 +0100", "Message-Id": "<20250312073655.2281377-1-mwalle@kernel.org>", "X-Mailer": "git-send-email 2.39.5", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Fastboot works either over TCP, UDP or USB. The latter doesn't have\nanything to do with networking, thus should work just fine with\nregardless which network stack is selected. In practice, header symbols\nare used inside common code paths. Add some ifdeffery to guard against\nthat.\n\nThis will make fastboot over USB work with the new LWIP stack.\n\nSigned-off-by: Michael Walle <mwalle@kernel.org>\n---\nAlternatively, we could add the defines and stub functions to the lwip\nheader.\n---\n cmd/fastboot.c | 4 ++++\n drivers/fastboot/Kconfig | 1 -\n drivers/fastboot/fb_common.c | 4 ++++\n 3 files changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/cmd/fastboot.c b/cmd/fastboot.c\nindex d4cfc0c7a28..be84a482b81 100644\n--- a/cmd/fastboot.c\n+++ b/cmd/fastboot.c\n@@ -16,6 +16,7 @@\n #include <linux/printk.h>\n #include <linux/stringify.h>\n \n+#if CONFIG_IS_ENABLED(NET)\n static int do_fastboot_udp(int argc, char *const argv[],\n \t\t\t uintptr_t buf_addr, size_t buf_size)\n {\n@@ -55,6 +56,7 @@ static int do_fastboot_tcp(int argc, char *const argv[],\n \n \treturn CMD_RET_SUCCESS;\n }\n+#endif\n \n static int do_fastboot_usb(int argc, char *const argv[],\n \t\t\t uintptr_t buf_addr, size_t buf_size)\n@@ -160,10 +162,12 @@ NXTARG:\n \n \tfastboot_init((void *)buf_addr, buf_size);\n \n+#if CONFIG_IS_ENABLED(NET)\n \tif (!strcmp(argv[1], \"udp\"))\n \t\treturn do_fastboot_udp(argc, argv, buf_addr, buf_size);\n \tif (!strcmp(argv[1], \"tcp\"))\n \t\treturn do_fastboot_tcp(argc, argv, buf_addr, buf_size);\n+#endif\n \tif (!strcmp(argv[1], \"usb\")) {\n \t\targv++;\n \t\targc--;\ndiff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig\nindex 1eb460f5a02..70207573de2 100644\n--- a/drivers/fastboot/Kconfig\n+++ b/drivers/fastboot/Kconfig\n@@ -1,6 +1,5 @@\n menu \"Fastboot support\"\n \tdepends on CMDLINE\n-\tdepends on !NET_LWIP\n \n config FASTBOOT\n \tbool\ndiff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c\nindex 12ffb463deb..68f92c4b887 100644\n--- a/drivers/fastboot/fb_common.c\n+++ b/drivers/fastboot/fb_common.c\n@@ -183,11 +183,15 @@ void fastboot_handle_boot(int command, bool success)\n \tswitch (command) {\n \tcase FASTBOOT_COMMAND_BOOT:\n \t\tfastboot_boot();\n+#if CONFIG_IS_ENABLED(NET)\n \t\tnet_set_state(NETLOOP_SUCCESS);\n+#endif\n \t\tbreak;\n \n \tcase FASTBOOT_COMMAND_CONTINUE:\n+#if CONFIG_IS_ENABLED(NET)\n \t\tnet_set_state(NETLOOP_SUCCESS);\n+#endif\n \t\tbreak;\n \n \tcase FASTBOOT_COMMAND_REBOOT:\n", "prefixes": [ "1/3" ] }