Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2056778/?format=api
{ "id": 2056778, "url": "http://patchwork.ozlabs.org/api/patches/2056778/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250307151531.12092-1-paul.barker.ct@bp.renesas.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250307151531.12092-1-paul.barker.ct@bp.renesas.com>", "list_archive_url": null, "date": "2025-03-07T15:15:29", "name": "cmd: Kconfig: Fix submenu for network commands", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fef015564fac5df9c5b243aa4fa164fa398aa637", "submitter": { "id": 86781, "url": "http://patchwork.ozlabs.org/api/people/86781/?format=api", "name": "Paul Barker", "email": "paul.barker.ct@bp.renesas.com" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250307151531.12092-1-paul.barker.ct@bp.renesas.com/mbox/", "series": [ { "id": 447514, "url": "http://patchwork.ozlabs.org/api/series/447514/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=447514", "date": "2025-03-07T15:15:29", "name": "cmd: Kconfig: Fix submenu for network commands", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/447514/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2056778/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2056778/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=bp.renesas.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=bp.renesas.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=paul.barker.ct@bp.renesas.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Z8VHK3575z1yKp\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 Mar 2025 02:16:13 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id ED2078122F;\n\tFri, 7 Mar 2025 16:16:11 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 931DE81276; Fri, 7 Mar 2025 16:16:09 +0100 (CET)", "from relmlie5.idc.renesas.com (relmlor1.renesas.com\n [210.160.252.171])\n by phobos.denx.de (Postfix) with ESMTP id 29A9A80540\n for <u-boot@lists.denx.de>; Fri, 7 Mar 2025 16:16:04 +0100 (CET)", "from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152])\n by relmlie5.idc.renesas.com with ESMTP; 08 Mar 2025 00:15:59 +0900", "from rz-ub2404.betafive.net (unknown [10.226.94.91])\n by relmlir6.idc.renesas.com (Postfix) with ESMTP id A3F074006A99;\n Sat, 8 Mar 2025 00:15:57 +0900 (JST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.6 required=5.0 tests=AC_FROM_MANY_DOTS,BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED,\n RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2", "X-CSE-ConnectionGUID": "tmG8GKxpTkWhBBC8aYOf7Q==", "X-CSE-MsgGUID": "c7w/jFtcQimV37BHyJFN6g==", "From": "Paul Barker <paul.barker.ct@bp.renesas.com>", "To": "Tom Rini <trini@konsulko.com>,\n Jerome Forissier <jerome.forissier@linaro.org>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>", "Cc": "Paul Barker <paul.barker.ct@bp.renesas.com>,\n\tu-boot@lists.denx.de", "Subject": "[PATCH] cmd: Kconfig: Fix submenu for network commands", "Date": "Fri, 7 Mar 2025 15:15:29 +0000", "Message-ID": "<20250307151531.12092-1-paul.barker.ct@bp.renesas.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The Kconfig parser seems to get confused by the current if conditions\nfollowing CMD_NET and displays all network command options directly in\nthe \"Command line interface\" menu instead of in a \"Network commands\"\nsubmenu.\n\nTo help out Kconfig we can simplify the if conditions, so that the\ndefinition of CMD_NET is followed immediately by an if/endif block that\ncontains all network command options. We can also remove nested checks\nfor CMD_NET or (NET || NET_LWIP).\n\nFixes: 98ad145db61a (\"net: lwip: add DHCP support and dhcp commmand\")\nSigned-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>\n---\n cmd/Kconfig | 15 ++++-----------\n 1 file changed, 4 insertions(+), 11 deletions(-)", "diff": "diff --git a/cmd/Kconfig b/cmd/Kconfig\nindex 8dd42571abce..f4c1a084330d 100644\n--- a/cmd/Kconfig\n+++ b/cmd/Kconfig\n@@ -1834,12 +1834,10 @@ menuconfig CMD_NET\n \tbool \"Network commands\"\n \tdefault y\n \n-endif\n+if CMD_NET\n \n if NET\n \n-if CMD_NET\n-\n config CMD_BOOTP\n \tbool \"bootp\"\n \tdefault y\n@@ -2080,7 +2078,6 @@ config IPV6_ROUTER_DISCOVERY\n \thelp\n \t Will automatically perform router solicitation on first IPv6\n \t network operation\n-endif # if CMD_NET\n \n config CMD_ETHSW\n \tbool \"ethsw\"\n@@ -2097,10 +2094,6 @@ config CMD_WOL\n \n endif # if NET\n \n-if NET || NET_LWIP\n-\n-if CMD_NET\n-\n config CMD_DHCP\n \tbool \"dhcp\"\n \tselect PROT_DHCP_LWIP if NET_LWIP\n@@ -2177,8 +2170,6 @@ config WGET_HTTPS\n \thelp\n \t Enable TLS over http for wget.\n \n-endif # if CMD_NET\n-\n config CMD_PXE\n \tbool \"pxe\"\n \tselect PXE_UTILS\n@@ -2186,7 +2177,9 @@ config CMD_PXE\n \thelp\n \t Boot image via network using PXE protocol\n \n-endif # if NET || NET_LWIP\n+endif # if CMD_NET\n+\n+endif # NET || NET_LWIP\n \n menu \"Misc commands\"\n \n", "prefixes": [] }