Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2042104/?format=api
{ "id": 2042104, "url": "http://patchwork.ozlabs.org/api/patches/2042104/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20250204160051.3055038-1-jerome.forissier@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250204160051.3055038-1-jerome.forissier@linaro.org>", "list_archive_url": null, "date": "2025-02-04T16:00:49", "name": "[v2] net: Kconfig: depend on DM_RNG for WGET_HTTPS", "commit_ref": "a091d173e32b98fe372b5b02d4e25c81f1bc9dc1", "pull_url": null, "state": "accepted", "archived": false, "hash": "a3cea0267eb99c7c19a071a8b9166042d141e5f2", "submitter": { "id": 69192, "url": "http://patchwork.ozlabs.org/api/people/69192/?format=api", "name": "Jerome Forissier", "email": "jerome.forissier@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20250204160051.3055038-1-jerome.forissier@linaro.org/mbox/", "series": [ { "id": 442808, "url": "http://patchwork.ozlabs.org/api/series/442808/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=442808", "date": "2025-02-04T16:00:49", "name": "[v2] net: Kconfig: depend on DM_RNG for WGET_HTTPS", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/442808/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2042104/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2042104/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=PPBwCU/0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"PPBwCU/0\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=jerome.forissier@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4YnSlg1Hflz1yhq\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 5 Feb 2025 03:01:19 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 87ADD800B3;\n\tTue, 4 Feb 2025 17:01:17 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 20CC3801BE; Tue, 4 Feb 2025 17:01:16 +0100 (CET)", "from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n [IPv6:2a00:1450:4864:20::329])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1FAAC80040\n for <u-boot@lists.denx.de>; Tue, 4 Feb 2025 17:01:14 +0100 (CET)", "by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-4368a293339so66748935e9.3\n for <u-boot@lists.denx.de>; Tue, 04 Feb 2025 08:01:14 -0800 (PST)", "from builder.. ([2a01:e0a:3cb:7bb0:43d5:b1e2:1df9:edcc])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-438dcc6de2dsm230933245e9.26.2025.02.04.08.01.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 04 Feb 2025 08:01:12 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1738684873; x=1739289673; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=7jMRRunng2OcOEIGW14xnD3tcjDijGkJj7ls2qvjd/o=;\n b=PPBwCU/0MJt2j6dhAiCOmzZwWF3cm8dCfZL5fodgZFvRkMOgq8/ZS6Uya/o2mQAisn\n 6pG0DMkdds+PklK3yqMGmMJbTXhJYH9I8yZ+iTdjDvJzmlu8hPuTo+i9UZT8xolTr3k1\n lypNgO+oBZSSa6icAL9MVvrYOEbvt+V9IKyqPE2L62vpQ9J6LVzSESBUQ/zpPfJixvPh\n nB4dZram4qhb30bxmV2LP6q0lFEAhxD9XmtIwo6BLOVu7vuI6ZB80upErz1GQIktMEIV\n ihAR0rKXzOCdq0PVb3sHI/AHAlQ40Irx0faUtKKebmR3eBex/rGvP+L0StCjQ0J+WFtS\n mzSg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1738684873; x=1739289673;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=7jMRRunng2OcOEIGW14xnD3tcjDijGkJj7ls2qvjd/o=;\n b=wqAWeY1ryYOOiXRypeUiAggTumSWBQqtc5rfuLOIwMYglSI4u2RC984b5HSuOva9uQ\n 047v7Pwc4DRh4NcBkbepLw+Zr3ADPs4x0QcuRacdjFvcgOn7fjQy0/YyYLdxh0RoF0+A\n NRh0C6sDFyQJejsrLM0oMlOfCii6Tmak0YKOoluEwRolXaHFnhDYigC73Rl+lRI1wsyZ\n Qw+xjfUhuGaPygwpQ5/DGJeihu3N93akxcYjiF4jr7oJ75Bu/THNtsMCsqiVywha672A\n RehhaNlZnAa3ren4k0rX3ZhH1X8bQSua0RuEqfc0lLC1IhTmjXSNUwCd3VWCYXij1uLI\n PSgg==", "X-Gm-Message-State": "AOJu0YwYngl0QJo1AvQqfvWz25Mc/SHmmQiDE5PM6tgMbN78mb2OvWwX\n BLypDAdS7MHK2juX0D0A8kszvikGrdPQMsZhSR3KE7WegPQMJOkwZas/Ky69U1Edwz7rgWIzdfQ\n Zc0ob/OKC", "X-Gm-Gg": "ASbGncuKdV/t+HU0F5ureTUcAYC4xZxJ5G0eGu+s+icfkkBcxskMhgAoDC7diBEJs/4\n PkzG2q9uk0S1YGEzYnYMd0oF6bt1QNtzP0ocrslFJ8XH9bDDK/NPf/t5QHv2sS62PVUu1E5kyC3\n 0Co/65P9RtqHFloSJLm51xQt14jL+jLeEwkw2GXn50R5GR/98mGJtAEdrbCOkO7vjFkhIsvhtMv\n 1Bxgh9tQXiPeI2R4ppa0jilYSxBDgGdkHQR++H9jPmvA+WrfT9wVB0Fh3y3s0SrXYv4Xu7co9SE\n d9lzHMETjLt8oNbv6kPb9LmW", "X-Google-Smtp-Source": "\n AGHT+IEq2ZjdoH/NzRcjWcwULY2uIlTAliRWE3eLT5Ms2jNUeVNcocGXVod8ZTt8Syd9Nv1wAs91pg==", "X-Received": "by 2002:a05:600c:1e20:b0:438:a1f4:3e9d with SMTP id\n 5b1f17b1804b1-438dc3c405dmr208118055e9.9.1738684873010;\n Tue, 04 Feb 2025 08:01:13 -0800 (PST)", "From": "Jerome Forissier <jerome.forissier@linaro.org>", "To": "u-boot@lists.denx.de", "Cc": "Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Michal Simek <michal.simek@amd.com>,\n Jerome Forissier <jerome.forissier@linaro.org>,\n Tom Rini <trini@konsulko.com>, Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Simon Glass <sjg@chromium.org>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Mattijs Korpershoek <mkorpershoek@baylibre.com>,\n Dmitry Rokosov <ddrokosov@salutedevices.com>,\n Adriano Cordova <adrianox@gmail.com>", "Subject": "[PATCH v2] net: Kconfig: depend on DM_RNG for WGET_HTTPS", "Date": "Tue, 4 Feb 2025 17:00:49 +0100", "Message-ID": "<20250204160051.3055038-1-jerome.forissier@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "net/lwip/wget.c/mbedtls_hardware_poll() is calling dm_rng_read() but\ndependency is not recorded anywhere that's why depend on DM_RNG\nwhen WGET_HTTPS is used.\n\nSuggested-by: Michal Simek <michal.simek@amd.com>\nCo-developed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>\nSigned-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>\nSigned-off-by: Jerome Forissier <jerome.forissier@linaro.org>\n---\n cmd/Kconfig | 1 +\n net/lwip/wget.c | 11 ++++++++---\n 2 files changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/cmd/Kconfig b/cmd/Kconfig\nindex e62817bd977..e3fbb7538ee 100644\n--- a/cmd/Kconfig\n+++ b/cmd/Kconfig\n@@ -2154,6 +2154,7 @@ config WGET_HTTPS\n \tdepends on CMD_WGET\n \tdepends on PROT_TCP_LWIP\n \tdepends on MBEDTLS_LIB\n+\tdepends on DM_RNG\n \tselect SHA256\n \tselect RSA\n \tselect ASYMMETRIC_KEY_TYPE\ndiff --git a/net/lwip/wget.c b/net/lwip/wget.c\nindex b76f6c0f1d9..de688641dd7 100644\n--- a/net/lwip/wget.c\n+++ b/net/lwip/wget.c\n@@ -433,10 +433,15 @@ bool wget_validate_uri(char *uri)\n \n \tif (!strncmp(uri, \"http://\", strlen(\"http://\"))) {\n \t\tprefix_len = strlen(\"http://\");\n-\t} else if (!strncmp(uri, \"https://\", strlen(\"https://\"))) {\n-\t\tprefix_len = strlen(\"https://\");\n+\t} else if (CONFIG_IS_ENABLED(WGET_HTTPS)) {\n+\t\tif (!strncmp(uri, \"https://\", strlen(\"https://\"))) {\n+\t\t\tprefix_len = strlen(\"https://\");\n+\t\t} else {\n+\t\t\tlog_err(\"only http(s):// is supported\\n\");\n+\t\t\treturn false;\n+\t\t}\n \t} else {\n-\t\tlog_err(\"only http(s):// is supported\\n\");\n+\t\tlog_err(\"only http:// is supported\\n\");\n \t\treturn false;\n \t}\n \n", "prefixes": [ "v2" ] }