Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2026292/?format=api
{ "id": 2026292, "url": "http://patchwork.ozlabs.org/api/patches/2026292/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20241220104220.2007786-13-npiggin@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20241220104220.2007786-13-npiggin@gmail.com>", "list_archive_url": null, "date": "2024-12-20T10:42:14", "name": "[12/17] hw/ide: Fix record-replay and convert to new bh API", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d7633e8dcb9651c1a5dc842816e1671a9c9a2adb", "submitter": { "id": 69518, "url": "http://patchwork.ozlabs.org/api/people/69518/?format=api", "name": "Nicholas Piggin", "email": "npiggin@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20241220104220.2007786-13-npiggin@gmail.com/mbox/", "series": [ { "id": 437728, "url": "http://patchwork.ozlabs.org/api/series/437728/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=437728", "date": "2024-12-20T10:42:02", "name": "replay: Fixes and avocado test updates", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/437728/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2026292/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2026292/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=A9J3o0jV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4YF3vF3xVVz1ySC\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 20 Dec 2024 21:44:25 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1tOaUQ-0006jF-C2; Fri, 20 Dec 2024 05:44:14 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <npiggin@gmail.com>)\n id 1tOaUN-0006Ua-Gf; Fri, 20 Dec 2024 05:44:11 -0500", "from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <npiggin@gmail.com>)\n id 1tOaUM-0005QP-5C; Fri, 20 Dec 2024 05:44:11 -0500", "by mail-pl1-x62f.google.com with SMTP id\n d9443c01a7336-21654fdd5daso16183195ad.1;\n Fri, 20 Dec 2024 02:44:08 -0800 (PST)", "from wheely.local0.net (14-200-18-130.tpgi.com.au. [14.200.18.130])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-2f2ee06dfd3sm5376942a91.32.2024.12.20.02.43.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 20 Dec 2024 02:44:06 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1734691447; x=1735296247; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6iYuLZgbonS1IR/x+IP4SM/fqY76/CEG9s7cHCYyGpU=;\n b=A9J3o0jVwZN8Ch2KrnAq5ukWGssEAru3VnCLLGlxR4a0rdfi2Ew9fWrYLicFmvVCG5\n qBCazDK7jghAc1zfhkcxy36/NycMCFJMLOGhm6HRnTs/gyKhUO0TZIxTPLtXhsnYnVMt\n Jy/xU5yWx8WTxeEb0DsTuOBxm5Gumw2xHbLS8sQ4TUWDntuDT2YIEBbMgt1yLa1Eejiv\n zn8Bu5dkIXc//DOHQ9n9VSQQwfBLXJ6QGwYvCzobArJYA2Xc6G/zkrQJnNZ9thQg5Kid\n UnFCtWvLAiPluD6DGXZDKR1T6l+jR2TTqTI0aFO8XtrvrpaJDwEIOe6AD8JmtTaV+o5o\n 0+LA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1734691447; x=1735296247;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=6iYuLZgbonS1IR/x+IP4SM/fqY76/CEG9s7cHCYyGpU=;\n b=OAzhTuotXekheJZDDI7GIR3K6pIQsacafYOB52pdMhAxHhZk8l29wvVhBFo1AgxTfJ\n 3x6PFdzbGapijmvNs36AgvHFUwsZ3wqawv/b0fFOAt6MA9LhfYzxgGG1iu+28g6+r5xA\n omc3/dNA6DSpq+TvifWQN3F66jjQ1RPXK5R4/kMzpDp+Hxr4osjSAMs4omtdFna8R+sQ\n B7vK76LPwfFL6c8NB0wr7bpaBzCl0veP5b8rD2fLlYOMm+DxMFvddBEAG0EJ8i6yohYo\n O2Y0fHiDC6K5wAEYiLArMEOvJi80xPFPwZTQw6w96pBrZfzn469Sf+lP8zPh1cTPtOJo\n nm5A==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCXD3KwIlJSxAEUkUuG5oAjuNU77fGkWdldUNINeyxvTc+X/4xTee1l7odlx+2+o/z7hpPtjVXn34dS1@nongnu.org", "X-Gm-Message-State": "AOJu0YzSRqgFjwSA7HeWEWOz/OyH/0i2UF+ZpmMSSb8J4W5QpWU2F/Yw\n vciAb+mVi8mXVhQxYQnw9trJ2n7lnI24nLJB8lf6ciEhkNH4o/HHWRcGrg==", "X-Gm-Gg": "ASbGncsKh85AAoKmbHM1V55lPgZsTcO1qZ+9BVSvn+kDgUD7i3OeBd+LgSLyMHPlerO\n p9hxAoxVF9+SzHhu2Vi0ujvSMJreWkq0NE1B8JKsZ/TEpIPaTcgcwMz87dDx4QK+dW4YaUH6mCh\n XDrWUL4pox01nBBmY5Y2S6os9nEfQN/yP3p6eDdzf00/hqEnnSgB62+6P6uHbJjoaDWfXa1HcVV\n ymcR4AYjgkoiETctfyK8Y53P29i2ts5XCM8oio35N6tck8WgOH/rTlCPNV1xiijl5CizoefMUCU\n cT/yjsNfrg==", "X-Google-Smtp-Source": "\n AGHT+IG3aaxYwAaHxmCsiQXVE89K6qWiw4Q2poUWePsa42NqcKFrbxoScOGi5DQ8TIshqinb/y/L0g==", "X-Received": "by 2002:a17:90b:2652:b0:2f2:ab09:c256 with SMTP id\n 98e67ed59e1d1-2f452f01cd4mr3873285a91.33.1734691447161;\n Fri, 20 Dec 2024 02:44:07 -0800 (PST)", "From": "Nicholas Piggin <npiggin@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "Nicholas Piggin <npiggin@gmail.com>, qemu-block@nongnu.org, =?utf-8?q?Al?=\n\t=?utf-8?q?ex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,\n Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>,\n Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>,\n Fam Zheng <fam@euphon.net>, Ronnie Sahlberg <ronniesahlberg@gmail.com>,\n John Snow <jsnow@redhat.com>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Jason Wang <jasowang@redhat.com>,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,\n Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,\n \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>,\n Wainer dos Santos Moschetta <wainersm@redhat.com>", "Subject": "[PATCH 12/17] hw/ide: Fix record-replay and convert to new bh API", "Date": "Fri, 20 Dec 2024 20:42:14 +1000", "Message-ID": "<20241220104220.2007786-13-npiggin@gmail.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241220104220.2007786-1-npiggin@gmail.com>", "References": "<20241220104220.2007786-1-npiggin@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::62f;\n envelope-from=npiggin@gmail.com; helo=mail-pl1-x62f.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Convert qemu_bh_schedule() to qemu_bh_schedule_event(), which can\nspecify the clock type, making it compatible with record-replay.\n\nRestarting the IDE device does affect target machine state, so it should\nuse QEMU_CLOCK_VIRTUAL to recorded and replay the bh.\n\nThis fixes hangs in record/replay when using IDE devices.\n\nSigned-off-by: Nicholas Piggin <npiggin@gmail.com>\n---\n hw/ide/core.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/hw/ide/core.c b/hw/ide/core.c\nindex c527caf3d69..500ea73c8be 100644\n--- a/hw/ide/core.c\n+++ b/hw/ide/core.c\n@@ -2780,7 +2780,7 @@ static void ide_restart_cb(void *opaque, bool running, RunState state)\n \n if (!bus->bh) {\n bus->bh = qemu_bh_new(ide_restart_bh, bus);\n- qemu_bh_schedule(bus->bh);\n+ qemu_bh_schedule_event(bus->bh, QEMU_CLOCK_VIRTUAL);\n }\n }\n \n", "prefixes": [ "12/17" ] }