Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2013903/?format=api
{ "id": 2013903, "url": "http://patchwork.ozlabs.org/api/patches/2013903/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20241121154218.1423005-17-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20241121154218.1423005-17-berrange@redhat.com>", "list_archive_url": null, "date": "2024-11-21T15:42:16", "name": "[v2,16/18] tests/functional: remove time.sleep usage from tuxrun tests", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e9d971bc04f7032768f76b847a4906549f240125", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20241121154218.1423005-17-berrange@redhat.com/mbox/", "series": [ { "id": 433720, "url": "http://patchwork.ozlabs.org/api/series/433720/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=433720", "date": "2024-11-21T15:42:05", "name": "test/functional: improve functional test debugging & fix tuxrun", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/433720/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2013903/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2013903/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Q20Ffo9b;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XvN1L3q6lz1yRq\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 22 Nov 2024 02:48:22 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1tE9Ls-0002A5-Op; Thu, 21 Nov 2024 10:44:17 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1tE9Lq-0001z2-4T\n for qemu-devel@nongnu.org; Thu, 21 Nov 2024 10:44:14 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1tE9Lo-00014p-7d\n for qemu-devel@nongnu.org; Thu, 21 Nov 2024 10:44:13 -0500", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-29-Jkmg4TtxPEOiAuzL-TH5tQ-1; Thu,\n 21 Nov 2024 10:44:08 -0500", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 354211956064; Thu, 21 Nov 2024 15:44:07 +0000 (UTC)", "from toolbox.redhat.com (unknown [10.42.28.5])\n by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 48ABD1956086; Thu, 21 Nov 2024 15:44:04 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1732203851;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=yyFkxmEDProtwTBUvdEdXCOHx7kjYPBJU+JzezPkC9M=;\n b=Q20Ffo9bhzIjSUU/TI04gGq/g22LF50bnTlNFPrCNq4EkfpIk7Hqn8vg6L6FGEru2cCMTV\n vQzWJTvaxh8u1GLHQSf5GYHPEtnga/SpkjKuB1pR7D82ivgO30UciAt/DeFq5nqF/uRr9A\n ElwYf8RaihqdUt3NhRnckx1GhP9tja4=", "X-MC-Unique": "Jkmg4TtxPEOiAuzL-TH5tQ-1", "X-Mimecast-MFC-AGG-ID": "Jkmg4TtxPEOiAuzL-TH5tQ", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Thomas Huth <thuth@redhat.com>, Ani Sinha <anisinha@redhat.com>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "Subject": "[PATCH v2 16/18] tests/functional: remove time.sleep usage from\n tuxrun tests", "Date": "Thu, 21 Nov 2024 15:42:16 +0000", "Message-ID": "<20241121154218.1423005-17-berrange@redhat.com>", "In-Reply-To": "<20241121154218.1423005-1-berrange@redhat.com>", "References": "<20241121154218.1423005-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-21", "X-Spam_score": "-2.2", "X-Spam_bar": "--", "X-Spam_report": "(-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.14,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The tuxrun tests send a series of strings to the guest to login\nand then run commands. Since we have been unable to match on\nconsole output that isn't followed by a newline, the test used\nmany time.sleep() statements to pretend to synchronize with\nthe guest.\n\nThis has proved to be unreliable for the aarch64be instance of\nthe tuxrun tests, with the test often hanging. The hang is a\nvery subtle timing problem, and it is suspected that some\n(otherwise apparently harmless) I/O error messages could be\nresulting in full FIFO buffers, stalling interaction with\nthe guest.\n\nWith the newly rewritten console interaction able to match\nstrings that don't have a following newline, the tux run\ntests can now match directly on the login prompt, and/or\nshell PS1 prompt.\n\nResolves: https://gitlab.com/qemu-project/qemu/-/issues/2689\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n tests/functional/qemu_test/tuxruntest.py | 16 ++++++----------\n 1 file changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/tests/functional/qemu_test/tuxruntest.py b/tests/functional/qemu_test/tuxruntest.py\nindex ed2b238c92..ab3b27da43 100644\n--- a/tests/functional/qemu_test/tuxruntest.py\n+++ b/tests/functional/qemu_test/tuxruntest.py\n@@ -124,16 +124,12 @@ def run_tuxtest_tests(self, haltmsg):\n then do a few things on the console. Trigger a shutdown and\n wait to exit cleanly.\n \"\"\"\n- self.wait_for_console_pattern(\"Welcome to TuxTest\")\n- time.sleep(0.2)\n- exec_command(self, 'root')\n- time.sleep(0.2)\n- exec_command(self, 'cat /proc/interrupts')\n- time.sleep(0.1)\n- exec_command(self, 'cat /proc/self/maps')\n- time.sleep(0.1)\n- exec_command(self, 'uname -a')\n- time.sleep(0.1)\n+ ps1='root@tuxtest:~#'\n+ self.wait_for_console_pattern('tuxtest login:')\n+ exec_command_and_wait_for_pattern(self, 'root', ps1)\n+ exec_command_and_wait_for_pattern(self, 'cat /proc/interrupts', ps1)\n+ exec_command_and_wait_for_pattern(self, 'cat /proc/self/maps', ps1)\n+ exec_command_and_wait_for_pattern(self, 'uname -a', ps1)\n exec_command_and_wait_for_pattern(self, 'halt', haltmsg)\n \n # Wait for VM to shut down gracefully if it can\n", "prefixes": [ "v2", "16/18" ] }