Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/201/?format=api
{ "id": 201, "url": "http://patchwork.ozlabs.org/api/patches/201/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/1220856321-22712-1-git-send-email-gerickson@nuovations.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1220856321-22712-1-git-send-email-gerickson@nuovations.com>", "list_archive_url": null, "date": "2008-09-08T06:45:21", "name": "nanddump: Qualifier Clean-up", "commit_ref": "b16c1b630491a461b3ebb55d714d7bb0cd122737", "pull_url": null, "state": "accepted", "archived": false, "hash": "4795525320fcd090add1c5f3e6f977ab8dc533f8", "submitter": { "id": 115, "url": "http://patchwork.ozlabs.org/api/people/115/?format=api", "name": "Grant Erickson", "email": "gerickson@nuovations.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/1220856321-22712-1-git-send-email-gerickson@nuovations.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/201/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/201/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org>", "X-Original-To": "patchwork@ozlabs.org", "Delivered-To": "patchwork@ozlabs.org", "Received": [ "from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 111F4DDE1D\n\tfor <patchwork@ozlabs.org>; Mon, 8 Sep 2008 16:45:43 +1000 (EST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KcaV4-0003Ui-D9; Mon, 08 Sep 2008 06:45:26 +0000", "from relay02.pair.com ([209.68.5.16])\n\tby bombadil.infradead.org with smtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KcaV2-0003Ij-DW\n\tfor linux-mtd@lists.infradead.org; Mon, 08 Sep 2008 06:45:24 +0000", "(qmail 89151 invoked by uid 0); 8 Sep 2008 06:45:22 -0000", "from unknown (HELO localhost.localdomain) (unknown)\n\tby unknown with SMTP; 8 Sep 2008 06:45:22 -0000" ], "X-pair-Authenticated": "66.134.71.115", "From": "Grant Erickson <gerickson@nuovations.com>", "To": "linux-mtd@lists.infradead.org", "Subject": "[PATCH 1/6] [MTD-UTILS] nanddump: Qualifier Clean-up", "Date": "Sun, 7 Sep 2008 23:45:21 -0700", "Message-Id": "<1220856321-22712-1-git-send-email-gerickson@nuovations.com>", "X-Mailer": "git-send-email 1.6.0.1", "Organization": "Nuovation System Designs, LLC", "X-Spam-Score": "0.0 (/)", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.9", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "linux-mtd-bounces@lists.infradead.org", "Errors-To": "linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org" }, "content": "Static-qualified all globals except 'main' because they have no use\nbeyond file scope.\nConstant-qualified MTD device and input positional parameter globals.\nConstant-qualified argv array.\n\nSigned-off-by: Grant Erickson <gerickson@nuovations.com>", "diff": "diff --git a/nanddump.c b/nanddump.c\nindex be40287..e35caf8 100644\n--- a/nanddump.c\n+++ b/nanddump.c\n@@ -32,11 +32,11 @@\n #define PROGRAM \"nanddump\"\n #define VERSION \"$Revision: 1.29 $\"\n \n-struct nand_oobinfo none_oobinfo = {\n+static struct nand_oobinfo none_oobinfo = {\n \t.useecc = MTD_NANDECC_OFF,\n };\n \n-void display_help (void)\n+static void display_help (void)\n {\n \tprintf(\"Usage: nanddump [OPTIONS] MTD-device\\n\"\n \t\t\t\"Dumps the contents of a nand mtd partition.\\n\"\n@@ -54,7 +54,7 @@ void display_help (void)\n \texit(0);\n }\n \n-void display_version (void)\n+static void display_version (void)\n {\n \tprintf(PROGRAM \" \" VERSION \"\\n\"\n \t\t\t\"\\n\"\n@@ -69,17 +69,17 @@ void display_version (void)\n \n // Option variables\n \n-int\tignoreerrors;\t\t// ignore errors\n-int\tpretty_print;\t\t// print nice in ascii\n-int\tnoecc;\t\t\t// don't error correct\n-int\tomitoob;\t\t// omit oob data\n-unsigned long\tstart_addr;\t// start address\n-unsigned long\tlength;\t\t// dump length\n-char *mtddev;\t\t// mtd device name\n-char *dumpfile;\t\t// dump file name\n-int\tomitbad;\n-\n-void process_options (int argc, char *argv[])\n+static int\t\tignoreerrors;\t// ignore errors\n+static int\t\tpretty_print;\t// print nice in ascii\n+static int\t\tnoecc;\t\t// don't error correct\n+static int\t\tomitoob;\t// omit oob data\n+static unsigned long\tstart_addr;\t// start address\n+static unsigned long\tlength;\t\t// dump length\n+static const char\t*mtddev;\t// mtd device name\n+static const char\t*dumpfile;\t// dump file name\n+static int\t\tomitbad;\n+\n+static void process_options (int argc, char * const argv[])\n {\n \tint error = 0;\n \n@@ -159,13 +159,13 @@ void process_options (int argc, char *argv[])\n /*\n * Buffers for reading data from flash\n */\n-unsigned char readbuf[4096];\n-unsigned char oobbuf[128];\n+static unsigned char readbuf[4096];\n+static unsigned char oobbuf[128];\n \n /*\n * Main program\n */\n-int main(int argc, char **argv)\n+int main(int argc, char * const argv[])\n {\n \tunsigned long ofs, end_addr = 0;\n \tunsigned long long blockstart = 1;\n", "prefixes": [] }