Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1992919/?format=api
{ "id": 1992919, "url": "http://patchwork.ozlabs.org/api/patches/1992919/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-19-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20241004163042.85922-19-philmd@linaro.org>", "list_archive_url": null, "date": "2024-10-04T16:30:34", "name": "[v2,18/25] target/m68k: Use explicit big-endian LD/ST API", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "062ec366b74702b2b702e6a2f7273ba8f9789d90", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-19-philmd@linaro.org/mbox/", "series": [ { "id": 426623, "url": "http://patchwork.ozlabs.org/api/series/426623/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=426623", "date": "2024-10-04T16:30:18", "name": "misc: Use explicit endian LD/ST API", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/426623/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1992919/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1992919/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ZuB0jU4K;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XKvT22Dgfz1xt7\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 5 Oct 2024 02:41:42 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1swlJB-0004yU-L9; Fri, 04 Oct 2024 12:37:37 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1swlH1-0008M7-PA\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:35:23 -0400", "from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1swlGz-0006Sb-0u\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:35:23 -0400", "by mail-lj1-x22a.google.com with SMTP id\n 38308e7fff4ca-2facf00b0c7so30477241fa.1\n for <qemu-devel@nongnu.org>; Fri, 04 Oct 2024 09:35:20 -0700 (PDT)", "from localhost.localdomain ([91.223.100.150])\n by smtp.gmail.com with ESMTPSA id\n 38308e7fff4ca-2faf9b24991sm201001fa.83.2024.10.04.09.35.14\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 04 Oct 2024 09:35:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728059719; x=1728664519; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=0hTPF2P0wkzOAl3QcmMS55AC0dIObjOQe3WnAgnhe+k=;\n b=ZuB0jU4K88OVDQVNrOJZ8HeMX1m0z8jd4vIL4a/dgxfoaGJOSJqkl/3aQO/s9eOlhy\n Kb2wCgRnEmDJ+PiQio03iDUpj1jsOOakdt06e4YSjxzcZ6E3Xb7DC4jqWSgGyKzxsxoN\n 09BepvsgLUw63Xpdy6wPeUoDO4njTCovkRb6WyqRCPJHnVGFdskZ/58+CaiBokkA/pVf\n nGPb4fdtBBS6hHn0nuClei+fhxjL8AQ3pTNs3uJkMRXZEEylwf2gD9Wql0Ee6LPJ5XjG\n XL5z3l3qO+eeQIfPj3SfGwEeFQRxqEIRG5PvwIaECEAxiDCc3l/4Z0o6xYWfdk/S2nF5\n 28wQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728059719; x=1728664519;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=0hTPF2P0wkzOAl3QcmMS55AC0dIObjOQe3WnAgnhe+k=;\n b=QWWO26xAxTEo+RG6jo7+AZlZE78QcXxSpEcJHkICq7bQckhYGfXnl0wFEhWRfvOd53\n cNQRsTDjVnE/drzcxyhBjrAfmGTHNTMlOuTKuFhuX7ERN3+X9Ms6rhLChenyfSj7lc19\n lF3kYsTxzbDxT148al2jWGxgrT8vTp51qXTETPG552iD4bxcySnP+4W6Auw9Oh7qWvSR\n rUVPNBMr2AgVaW+gut40r6VS9KyGirE1KQ4/T1UxmHZtfZ/SYoPhzMhxOgTqHn+bBOob\n xNZnh6FKkFVoYoF1ki39kdYVV3h/fkuffuiw0Xo/AeCiDRMqxt7bywe3HMENw0NCrdZL\n CCsg==", "X-Gm-Message-State": "AOJu0YwAic126m9e1+HPJbpb0uukaqPY9x1g5wKomL2OEytb30ihbMRZ\n NnP6V4EqqLFaqjUh32ZGVY6zNbpmfGLGSNLOFZLaVLKeEACVFxDrSeGj1BQKdCqaKokufmKPBbj\n 463sWvQ==", "X-Google-Smtp-Source": "\n AGHT+IExeF/RRjZ4znjlHEqqCOKoSzJRoizTQ9lnK9GLXbUykc0LJXovMIo8HQLADJGkSBH+NqnoMA==", "X-Received": "by 2002:a05:651c:1989:b0:2fa:cfba:fb65 with SMTP id\n 38308e7fff4ca-2faea1b7d1dmr26392521fa.3.1728059718985;\n Fri, 04 Oct 2024 09:35:18 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth <thuth@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-ppc@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH v2 18/25] target/m68k: Use explicit big-endian LD/ST API", "Date": "Fri, 4 Oct 2024 13:30:34 -0300", "Message-ID": "<20241004163042.85922-19-philmd@linaro.org>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241004163042.85922-1-philmd@linaro.org>", "References": "<20241004163042.85922-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::22a;\n envelope-from=philmd@linaro.org; helo=mail-lj1-x22a.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The M68K architecture uses big endianness. Directly use\nthe big-endian LD/ST API.\n\nMechanical change using:\n\n $ end=be; \\\n for acc in uw w l q tul; do \\\n sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n $(git grep -wlE '(ld|st)t?u?[wlq]_p' target/m68k/); \\\n done\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n target/m68k/gdbstub.c | 2 +-\n target/m68k/helper.c | 10 +++++-----\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/target/m68k/gdbstub.c b/target/m68k/gdbstub.c\nindex 15547e2313c..136159f98f2 100644\n--- a/target/m68k/gdbstub.c\n+++ b/target/m68k/gdbstub.c\n@@ -52,7 +52,7 @@ int m68k_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n CPUM68KState *env = cpu_env(cs);\n uint32_t tmp;\n \n- tmp = ldl_p(mem_buf);\n+ tmp = ldl_be_p(mem_buf);\n \n if (n < 8) {\n /* D0-D7 */\ndiff --git a/target/m68k/helper.c b/target/m68k/helper.c\nindex 4c85badd5d3..9d3db8419de 100644\n--- a/target/m68k/helper.c\n+++ b/target/m68k/helper.c\n@@ -57,15 +57,15 @@ static int cf_fpu_gdb_set_reg(CPUState *cs, uint8_t *mem_buf, int n)\n \n if (n < 8) {\n float_status s;\n- env->fregs[n].d = float64_to_floatx80(ldq_p(mem_buf), &s);\n+ env->fregs[n].d = float64_to_floatx80(ldq_be_p(mem_buf), &s);\n return 8;\n }\n switch (n) {\n case 8: /* fpcontrol */\n- cpu_m68k_set_fpcr(env, ldl_p(mem_buf));\n+ cpu_m68k_set_fpcr(env, ldl_be_p(mem_buf));\n return 4;\n case 9: /* fpstatus */\n- env->fpsr = ldl_p(mem_buf);\n+ env->fpsr = ldl_be_p(mem_buf);\n return 4;\n case 10: /* fpiar, not implemented */\n return 4;\n@@ -107,10 +107,10 @@ static int m68k_fpu_gdb_set_reg(CPUState *cs, uint8_t *mem_buf, int n)\n }\n switch (n) {\n case 8: /* fpcontrol */\n- cpu_m68k_set_fpcr(env, ldl_p(mem_buf));\n+ cpu_m68k_set_fpcr(env, ldl_be_p(mem_buf));\n return 4;\n case 9: /* fpstatus */\n- cpu_m68k_set_fpsr(env, ldl_p(mem_buf));\n+ cpu_m68k_set_fpsr(env, ldl_be_p(mem_buf));\n return 4;\n case 10: /* fpiar, not implemented */\n return 4;\n", "prefixes": [ "v2", "18/25" ] }