Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1992917/?format=api
{ "id": 1992917, "url": "http://patchwork.ozlabs.org/api/patches/1992917/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-20-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20241004163042.85922-20-philmd@linaro.org>", "list_archive_url": null, "date": "2024-10-04T16:30:35", "name": "[v2,19/25] hw/sparc: Use explicit big-endian LD/ST API", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1135c07e42b1c70dfcaf08c7a673aba27826a78f", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-20-philmd@linaro.org/mbox/", "series": [ { "id": 426623, "url": "http://patchwork.ozlabs.org/api/series/426623/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=426623", "date": "2024-10-04T16:30:18", "name": "misc: Use explicit endian LD/ST API", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/426623/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1992917/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1992917/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ZYz+7t0T;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XKvSk2gJbz1xt7\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 5 Oct 2024 02:41:26 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1swlJH-0005lp-U4; Fri, 04 Oct 2024 12:37:44 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1swlHN-00012F-N6\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:35:49 -0400", "from mail-lf1-x132.google.com ([2a00:1450:4864:20::132])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1swlHE-0006XK-D4\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:35:39 -0400", "by mail-lf1-x132.google.com with SMTP id\n 2adb3069b0e04-5398e7dda5fso2436446e87.0\n for <qemu-devel@nongnu.org>; Fri, 04 Oct 2024 09:35:34 -0700 (PDT)", "from localhost.localdomain ([91.223.100.150])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-539aff23e0bsm1307e87.243.2024.10.04.09.35.26\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 04 Oct 2024 09:35:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728059733; x=1728664533; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6M7F9MlipNOYzrQaom9GAgFYoDMLlj7tvvuZZcP6m74=;\n b=ZYz+7t0TtaAPsYKGt8H5gHvKwveX6NZfEZcJ6CoTN2XjjBAEVW0dbDdjVtJVM9tBvV\n 1s4d/0gDwgYrY/3ObyVbCpuOSw0hHN74XeHcezXNRg81KqkL1m4MAjzugw2kMEsRrIUo\n 5FNqAuIkbZKIzQE/SN6FOxdcQ2M57zNE6mgtYMUQjFLFWSR/MtobeRWtv9K+PL+gHPdX\n ALGiA+QjQaRsXAJ58mbdEPerSo6Z3Ar79/LMMzv9jHSr93x+L4WdwUpPGyCaK1qet6vW\n mCpq1KKzu0Cuddb17ZQtox93HgIWcquQqjEuRa/882NwM9IiieYu/mHQ/zHL91z0frnB\n BJ8A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728059733; x=1728664533;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=6M7F9MlipNOYzrQaom9GAgFYoDMLlj7tvvuZZcP6m74=;\n b=J1jVMBGKTP09vSVmjPq7H5OhKg9wghMyx83Seg+Q2TuNOXyO2206ft10Kh/T+IbvLe\n iXuqmkDX/+56lJzZGS8PBbAt5VtuLuSE/hWhnbixrGtEfvgm5+pL2KLW2Ow83Ta71DUN\n 8tZ/njeBWQwK/SU0pjNEHMfv2kixvMQMk7cl16Cin4z1IYup2foY9Ie/MzKlMFEazrQe\n bzM/M98BeTU77eb5mmvamp8bI3BpnwUw9S1Ii9pALL5g7FRv0VeKU3pfBJWqGS4Ebyiy\n H+JdhgqiB2hGLilxTOUOQpZRnfTFgxF0XitFKVcIbhkyVr1oaABbTfpvI3iCXa5iGA8c\n JVnQ==", "X-Gm-Message-State": "AOJu0YxLNSqwiGwEP2ZUHptOoUJs63sxaVXyUh1kchn0iVP+AugIJEKH\n dGR9mYLGkoYBxbM83CpQXllHcHAy6QlEnNRkEjV0xU9zurSDqSWK3XVV6DlGE/22CPZcYQE+5fL\n 6QBoIQQ==", "X-Google-Smtp-Source": "\n AGHT+IE75adEi58xxY+eb+s/8/wYi+gBrnWmrL7GuordUIripl+cJqkS9CGThpKCYM4+XMTAlK1Wdg==", "X-Received": "by 2002:a05:6512:1387:b0:539:955b:43d0 with SMTP id\n 2adb3069b0e04-539ab9d0ad2mr2091898e87.47.1728059733102;\n Fri, 04 Oct 2024 09:35:33 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth <thuth@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-ppc@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH v2 19/25] hw/sparc: Use explicit big-endian LD/ST API", "Date": "Fri, 4 Oct 2024 13:30:35 -0300", "Message-ID": "<20241004163042.85922-20-philmd@linaro.org>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20241004163042.85922-1-philmd@linaro.org>", "References": "<20241004163042.85922-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::132;\n envelope-from=philmd@linaro.org; helo=mail-lf1-x132.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The SPARC architecture uses big endianness. Directly use\nthe big-endian LD/ST API.\n\nfor a in uw w l q;do sed -i -e \"s/ld${a}_p(/ld${a}_be_p(/\" $(git grep -wlE '(ld|st)u?[wlq]_p' hw/sparc/);done\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n hw/sparc/leon3.c | 42 +++++++++++++++++++++---------------------\n hw/sparc/sun4m.c | 6 +++---\n hw/sparc64/sun4u.c | 6 +++---\n 3 files changed, 27 insertions(+), 27 deletions(-)", "diff": "diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c\nindex 6aaa04cb191..021b5070128 100644\n--- a/hw/sparc/leon3.c\n+++ b/hw/sparc/leon3.c\n@@ -78,21 +78,21 @@ typedef struct ResetData {\n \n static uint32_t *gen_store_u32(uint32_t *code, hwaddr addr, uint32_t val)\n {\n- stl_p(code++, 0x82100000); /* mov %g0, %g1 */\n- stl_p(code++, 0x84100000); /* mov %g0, %g2 */\n- stl_p(code++, 0x03000000 +\n+ stl_be_p(code++, 0x82100000); /* mov %g0, %g1 */\n+ stl_be_p(code++, 0x84100000); /* mov %g0, %g2 */\n+ stl_be_p(code++, 0x03000000 +\n extract32(addr, 10, 22));\n /* sethi %hi(addr), %g1 */\n- stl_p(code++, 0x82106000 +\n+ stl_be_p(code++, 0x82106000 +\n extract32(addr, 0, 10));\n /* or %g1, addr, %g1 */\n- stl_p(code++, 0x05000000 +\n+ stl_be_p(code++, 0x05000000 +\n extract32(val, 10, 22));\n /* sethi %hi(val), %g2 */\n- stl_p(code++, 0x8410a000 +\n+ stl_be_p(code++, 0x8410a000 +\n extract32(val, 0, 10));\n /* or %g2, val, %g2 */\n- stl_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */\n+ stl_be_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */\n \n return code;\n }\n@@ -112,13 +112,13 @@ static void write_bootloader(void *ptr, hwaddr kernel_addr)\n \n /* If we are running on a secondary CPU, jump directly to the kernel. */\n \n- stl_p(p++, 0x85444000); /* rd %asr17, %g2 */\n- stl_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */\n- stl_p(p++, 0x80908000); /* tst %g2 */\n+ stl_be_p(p++, 0x85444000); /* rd %asr17, %g2 */\n+ stl_be_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */\n+ stl_be_p(p++, 0x80908000); /* tst %g2 */\n /* Filled below. */\n sec_cpu_branch_p = p;\n- stl_p(p++, 0x0BADC0DE); /* bne xxx */\n- stl_p(p++, 0x01000000); /* nop */\n+ stl_be_p(p++, 0x0BADC0DE); /* bne xxx */\n+ stl_be_p(p++, 0x01000000); /* nop */\n \n /* Initialize the UARTs */\n /* *UART_CONTROL = UART_RECEIVE_ENABLE | UART_TRANSMIT_ENABLE; */\n@@ -133,17 +133,17 @@ static void write_bootloader(void *ptr, hwaddr kernel_addr)\n p = gen_store_u32(p, 0x80000318, 3);\n \n /* Now, the relative branch above can be computed. */\n- stl_p(sec_cpu_branch_p, 0x12800000\n- + (p - sec_cpu_branch_p));\n+ stl_be_p(sec_cpu_branch_p, 0x12800000\n+ + (p - sec_cpu_branch_p));\n \n /* JUMP to the entry point */\n- stl_p(p++, 0x82100000); /* mov %g0, %g1 */\n- stl_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22));\n- /* sethi %hi(kernel_addr), %g1 */\n- stl_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10));\n- /* or kernel_addr, %g1 */\n- stl_p(p++, 0x81c04000); /* jmp %g1 */\n- stl_p(p++, 0x01000000); /* nop */\n+ stl_be_p(p++, 0x82100000); /* mov %g0, %g1 */\n+ stl_be_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22));\n+ /* sethi %hi(kernel_addr), %g1 */\n+ stl_be_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10));\n+ /* or kernel_addr, %g1 */\n+ stl_be_p(p++, 0x81c04000); /* jmp %g1 */\n+ stl_be_p(p++, 0x01000000); /* nop */\n }\n \n static void leon3_cpu_reset(void *opaque)\ndiff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c\nindex d52e6a7213f..f375f0d389b 100644\n--- a/hw/sparc/sun4m.c\n+++ b/hw/sparc/sun4m.c\n@@ -271,9 +271,9 @@ static unsigned long sun4m_load_kernel(const char *kernel_filename,\n if (*initrd_size > 0) {\n for (i = 0; i < 64 * TARGET_PAGE_SIZE; i += TARGET_PAGE_SIZE) {\n ptr = rom_ptr(KERNEL_LOAD_ADDR + i, 24);\n- if (ptr && ldl_p(ptr) == 0x48647253) { /* HdrS */\n- stl_p(ptr + 16, INITRD_LOAD_ADDR);\n- stl_p(ptr + 20, *initrd_size);\n+ if (ptr && ldl_be_p(ptr) == 0x48647253) { /* HdrS */\n+ stl_be_p(ptr + 16, INITRD_LOAD_ADDR);\n+ stl_be_p(ptr + 20, *initrd_size);\n break;\n }\n }\ndiff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c\nindex 4ece1ac1ffc..e591e5a741a 100644\n--- a/hw/sparc64/sun4u.c\n+++ b/hw/sparc64/sun4u.c\n@@ -210,9 +210,9 @@ static uint64_t sun4u_load_kernel(const char *kernel_filename,\n if (*initrd_size > 0) {\n for (i = 0; i < 64 * TARGET_PAGE_SIZE; i += TARGET_PAGE_SIZE) {\n ptr = rom_ptr(*kernel_addr + i, 32);\n- if (ptr && ldl_p(ptr + 8) == 0x48647253) { /* HdrS */\n- stl_p(ptr + 24, *initrd_addr + *kernel_addr);\n- stl_p(ptr + 28, *initrd_size);\n+ if (ptr && ldl_be_p(ptr + 8) == 0x48647253) { /* HdrS */\n+ stl_be_p(ptr + 24, *initrd_addr + *kernel_addr);\n+ stl_be_p(ptr + 28, *initrd_size);\n break;\n }\n }\n", "prefixes": [ "v2", "19/25" ] }