Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/197/?format=api
{ "id": 197, "url": "http://patchwork.ozlabs.org/api/patches/197/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/1220848136-22314-1-git-send-email-gerickson@nuovations.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1220848136-22314-1-git-send-email-gerickson@nuovations.com>", "list_archive_url": null, "date": "2008-09-08T04:28:56", "name": "nandwrite: Pass Real Names as Arguments to perror", "commit_ref": "ada3a5a5c96b434cd9b9a58928c792466527fc74", "pull_url": null, "state": "accepted", "archived": false, "hash": "41ccbeff6295a4646c803e745f0905f4d9eff6c4", "submitter": { "id": 115, "url": "http://patchwork.ozlabs.org/api/people/115/?format=api", "name": "Grant Erickson", "email": "gerickson@nuovations.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/1220848136-22314-1-git-send-email-gerickson@nuovations.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/197/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/197/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org>", "X-Original-To": "patchwork@ozlabs.org", "Delivered-To": "patchwork@ozlabs.org", "Received": [ "from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id EAA54DDDED\n\tfor <patchwork@ozlabs.org>; Mon, 8 Sep 2008 14:29:05 +1000 (EST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KcYN2-0002Ud-DF; Mon, 08 Sep 2008 04:29:00 +0000", "from relay01.pair.com ([209.68.5.15])\n\tby bombadil.infradead.org with smtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KcYN0-0002UK-IG\n\tfor linux-mtd@lists.infradead.org; Mon, 08 Sep 2008 04:28:58 +0000", "(qmail 85796 invoked by uid 0); 8 Sep 2008 04:28:57 -0000", "from unknown (HELO localhost.localdomain) (unknown)\n\tby unknown with SMTP; 8 Sep 2008 04:28:57 -0000" ], "X-pair-Authenticated": "66.134.71.115", "From": "Grant Erickson <gerickson@nuovations.com>", "To": "linux-mtd@lists.infradead.org", "Subject": "[PATCH 3/6] [MTD-UTILS] nandwrite: Pass Real Names as Arguments to\n\tperror", "Date": "Sun, 7 Sep 2008 21:28:56 -0700", "Message-Id": "<1220848136-22314-1-git-send-email-gerickson@nuovations.com>", "X-Mailer": "git-send-email 1.6.0.1", "Organization": "Nuovation System Designs, LLC", "X-Spam-Score": "-1.0 (-)", "X-Spam-Report": "SpamAssassin version 3.2.5 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.0 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [209.68.5.15 listed in list.dnswl.org]", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.9", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "linux-mtd-bounces@lists.infradead.org", "Errors-To": "linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org" }, "content": "Pass the MTD device node and input file name as arguments to perror\nrather than more ambigous, static messages on open failures.\n\nSigned-off-by: Grant Erickson <gerickson@nuovations.com>", "diff": "diff --git a/nandwrite.c b/nandwrite.c\nindex b1a4307..e5de140 100644\n--- a/nandwrite.c\n+++ b/nandwrite.c\n@@ -230,7 +230,7 @@ int main(int argc, char * const argv[])\n \n \t/* Open the device */\n \tif ((fd = open(mtd_device, O_RDWR)) == -1) {\n-\t\tperror(\"open flash\");\n+\t\tperror(mtd_device);\n \t\texit (EXIT_FAILURE);\n \t}\n \n@@ -337,7 +337,7 @@ int main(int argc, char * const argv[])\n \n \t/* Open the input file */\n \tif ((ifd = open(img, O_RDONLY)) == -1) {\n-\t\tperror(\"open input file\");\n+\t\tperror(img);\n \t\tgoto restoreoob;\n \t}\n \n", "prefixes": [] }