Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1936152/?format=api
{ "id": 1936152, "url": "http://patchwork.ozlabs.org/api/patches/1936152/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-aspeed/patch/20240516181907.3468796-29-eajames@linux.ibm.com/", "project": { "id": 57, "url": "http://patchwork.ozlabs.org/api/projects/57/?format=api", "name": "Linux ASPEED SoC development", "link_name": "linux-aspeed", "list_id": "linux-aspeed.lists.ozlabs.org", "list_email": "linux-aspeed@lists.ozlabs.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20240516181907.3468796-29-eajames@linux.ibm.com>", "list_archive_url": null, "date": "2024-05-16T18:18:55", "name": "[v3,28/40] i2c: fsi: Change fsi_i2c_write_reg to accept data instead of a pointer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e4044179cbc5d73087a6feaa586ccaf5b583e35b", "submitter": { "id": 74989, "url": "http://patchwork.ozlabs.org/api/people/74989/?format=api", "name": "Eddie James", "email": "eajames@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-aspeed/patch/20240516181907.3468796-29-eajames@linux.ibm.com/mbox/", "series": [ { "id": 407101, "url": "http://patchwork.ozlabs.org/api/series/407101/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-aspeed/list/?series=407101", "date": "2024-05-16T18:18:31", "name": "fsi: Add interrupt support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/407101/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1936152/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1936152/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-aspeed@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "linux-aspeed@lists.ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=StbiDGmK;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=StbiDGmK;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=StbiDGmK;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=eajames@linux.ibm.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4VgJML4FnLz20dQ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 May 2024 04:21:34 +1000 (AEST)", "from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4VgJML24CKz3fq8\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 May 2024 04:21:34 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4VgJK05knmz3fsR;\n\tFri, 17 May 2024 04:19:32 +1000 (AEST)", "from pps.filterd (m0353727.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 44GGl3JN022073;\n\tThu, 16 May 2024 18:19:20 GMT", "from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y5nycr8db-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 16 May 2024 18:19:20 +0000", "from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id\n 44GHDDSY020388;\n\tThu, 16 May 2024 18:19:18 GMT", "from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9])\n\tby ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3y2kd0bmcr-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 16 May 2024 18:19:18 +0000", "from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n\tby smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 44GIJGpc30671258\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tThu, 16 May 2024 18:19:18 GMT", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id EB3D658068;\n\tThu, 16 May 2024 18:19:15 +0000 (GMT)", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id AD84758077;\n\tThu, 16 May 2024 18:19:15 +0000 (GMT)", "from slate16.aus.stglabs.ibm.com (unknown [9.61.107.19])\n\tby smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n\tThu, 16 May 2024 18:19:15 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com;\n h=from : to : cc : subject\n : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding; s=pp1;\n bh=/RkWhEH9F+VLK6oub9BZ8DLGrII8B8mgaOhr5sMt70k=;\n b=StbiDGmKe+dF285YW2BXbGFh3IsKhOKYm+eW0hlJToG3Z3qR+omZRC1wxbVroooDdp9A\n 8/LbqadTz5tJ4PWEAxVIF7ZtC9JQka0HQiYZNBCp1C5mUI6BgZJ1WW1xVYbgs2dhOpVf\n J3nrMI3KboaN+wYYa0YfmNVkcnzm5uwuXrp0wu+lG5eqN1Bf+ELmjRCuEziLbS7kQ8Vh\n LOthBkNjNSNKxVoJVZevEifFSoh5vKHo4T9bS37gMXS4Ae1cbBrJER/92gI6UiWCbglb\n 5qmPN5JQDPbetAk6gZ5YoqYKhh55xrDXgLUJ2NQWkmEAwOAosx1U5JgPUIAAr4XE8PWE 6A==", "From": "Eddie James <eajames@linux.ibm.com>", "To": "linux-fsi@lists.ozlabs.org", "Subject": "[PATCH v3 28/40] i2c: fsi: Change fsi_i2c_write_reg to accept data\n instead of a pointer", "Date": "Thu, 16 May 2024 13:18:55 -0500", "Message-Id": "<20240516181907.3468796-29-eajames@linux.ibm.com>", "X-Mailer": "git-send-email 2.39.3", "In-Reply-To": "<20240516181907.3468796-1-eajames@linux.ibm.com>", "References": "<20240516181907.3468796-1-eajames@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-GUID": "mVqAi05pgxiMUe3FvWuCenV37qoi83Lj", "X-Proofpoint-ORIG-GUID": "mVqAi05pgxiMUe3FvWuCenV37qoi83Lj", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26\n definitions=2024-05-16_07,2024-05-15_01,2023-05-22_02", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n clxscore=1015 bulkscore=0\n malwarescore=0 priorityscore=1501 mlxscore=0 phishscore=0 suspectscore=0\n mlxlogscore=971 adultscore=0 lowpriorityscore=0 impostorscore=0\n spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2405010000 definitions=main-2405160132", "X-BeenThere": "linux-aspeed@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux ASPEED SoC development <linux-aspeed.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linux-aspeed>,\n <mailto:linux-aspeed-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linux-aspeed/>", "List-Post": "<mailto:linux-aspeed@lists.ozlabs.org>", "List-Help": "<mailto:linux-aspeed-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linux-aspeed>,\n <mailto:linux-aspeed-request@lists.ozlabs.org?subject=subscribe>", "Cc": "andi.shyti@kernel.org, linux-aspeed@lists.ozlabs.org, jk@ozlabs.org,\n alistair@popple.id.au, linux-kernel@vger.kernel.org,\n linux-spi@vger.kernel.org, broonie@kernel.org, andrew@codeconstruct.com.au,\n linux-i2c@vger.kernel.org", "Errors-To": "linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Linux-aspeed\"\n <linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "There's no use passing a pointer here.\n\nSigned-off-by: Eddie James <eajames@linux.ibm.com>\n---\n drivers/i2c/busses/i2c-fsi.c | 47 +++++++++++++++---------------------\n 1 file changed, 20 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c\nindex 8fb5b51b74a4d..44aa750278100 100644\n--- a/drivers/i2c/busses/i2c-fsi.c\n+++ b/drivers/i2c/busses/i2c-fsi.c\n@@ -177,9 +177,9 @@ static int fsi_i2c_read_reg(struct fsi_device *fsi, unsigned int reg,\n }\n \n static int fsi_i2c_write_reg(struct fsi_device *fsi, unsigned int reg,\n-\t\t\t u32 *data)\n+\t\t\t u32 data)\n {\n-\t__be32 data_be = cpu_to_be32p(data);\n+\t__be32 data_be = cpu_to_be32(data);\n \n \treturn fsi_device_write(fsi, reg, &data_be, sizeof(data_be));\n }\n@@ -188,17 +188,16 @@ static int fsi_i2c_dev_init(struct fsi_i2c_master *i2c)\n {\n \tu32 mode = I2C_MODE_ENHANCED;\n \tu32 extended_status;\n-\tu32 interrupt = 0;\n \tu32 watermark;\n \tint rc;\n \n \t/* since we use polling, disable interrupts */\n-\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_INT_MASK, &interrupt);\n+\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_INT_MASK, 0);\n \tif (rc)\n \t\treturn rc;\n \n \tmode |= FIELD_PREP(I2C_MODE_CLKDIV, i2c->clock_div);\n-\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_MODE, &mode);\n+\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_MODE, mode);\n \tif (rc)\n \t\treturn rc;\n \n@@ -211,13 +210,12 @@ static int fsi_i2c_dev_init(struct fsi_i2c_master *i2c)\n \t\t\t i2c->fifo_size - I2C_FIFO_HI_LVL);\n \twatermark |= FIELD_PREP(I2C_WATERMARK_LO, I2C_FIFO_LO_LVL);\n \n-\treturn fsi_i2c_write_reg(i2c->fsi, I2C_FSI_WATER_MARK, &watermark);\n+\treturn fsi_i2c_write_reg(i2c->fsi, I2C_FSI_WATER_MARK, watermark);\n }\n \n static int fsi_i2c_set_port(struct fsi_i2c_port *port)\n {\n \tstruct fsi_device *fsi = port->master->fsi;\n-\tu32 dummy = 0;\n \tu32 mode;\n \tint rc;\n \n@@ -229,12 +227,12 @@ static int fsi_i2c_set_port(struct fsi_i2c_port *port)\n \t\treturn 0;\n \n \tmode = (mode & ~I2C_MODE_PORT) | FIELD_PREP(I2C_MODE_PORT, port->port);\n-\trc = fsi_i2c_write_reg(fsi, I2C_FSI_MODE, &mode);\n+\trc = fsi_i2c_write_reg(fsi, I2C_FSI_MODE, mode);\n \tif (rc)\n \t\treturn rc;\n \n \t/* reset engine when port is changed */\n-\treturn fsi_i2c_write_reg(fsi, I2C_FSI_RESET_ERR, &dummy);\n+\treturn fsi_i2c_write_reg(fsi, I2C_FSI_RESET_ERR, 0);\n }\n \n static int fsi_i2c_start(struct fsi_i2c_port *port, struct i2c_msg *msg,\n@@ -253,7 +251,7 @@ static int fsi_i2c_start(struct fsi_i2c_port *port, struct i2c_msg *msg,\n \tcmd |= FIELD_PREP(I2C_CMD_ADDR, msg->addr);\n \tcmd |= FIELD_PREP(I2C_CMD_LEN, msg->len);\n \n-\treturn fsi_i2c_write_reg(port->master->fsi, I2C_FSI_CMD, &cmd);\n+\treturn fsi_i2c_write_reg(port->master->fsi, I2C_FSI_CMD, cmd);\n }\n \n static int fsi_i2c_get_op_bytes(int op_bytes)\n@@ -340,12 +338,11 @@ static int fsi_i2c_get_scl(struct i2c_adapter *adap)\n static void fsi_i2c_set_scl(struct i2c_adapter *adap, int val)\n {\n \tstruct fsi_i2c_port *port = adap->algo_data;\n-\tu32 dummy = 0;\n \n \tif (val)\n-\t\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_SET_SCL, &dummy);\n+\t\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_SET_SCL, 0);\n \telse\n-\t\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_RESET_SCL, &dummy);\n+\t\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_RESET_SCL, 0);\n }\n \n static int fsi_i2c_get_sda(struct i2c_adapter *adap)\n@@ -361,12 +358,11 @@ static int fsi_i2c_get_sda(struct i2c_adapter *adap)\n static void fsi_i2c_set_sda(struct i2c_adapter *adap, int val)\n {\n \tstruct fsi_i2c_port *port = adap->algo_data;\n-\tu32 dummy = 0;\n \n \tif (val)\n-\t\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_SET_SDA, &dummy);\n+\t\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_SET_SDA, 0);\n \telse\n-\t\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_RESET_SDA, &dummy);\n+\t\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_RESET_SDA, 0);\n }\n \n static void fsi_i2c_prepare_recovery(struct i2c_adapter *adap)\n@@ -380,7 +376,7 @@ static void fsi_i2c_prepare_recovery(struct i2c_adapter *adap)\n \t\treturn;\n \n \tmode |= I2C_MODE_DIAG;\n-\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_MODE, &mode);\n+\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_MODE, mode);\n }\n \n static void fsi_i2c_unprepare_recovery(struct i2c_adapter *adap)\n@@ -394,13 +390,12 @@ static void fsi_i2c_unprepare_recovery(struct i2c_adapter *adap)\n \t\treturn;\n \n \tmode &= ~I2C_MODE_DIAG;\n-\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_MODE, &mode);\n+\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_MODE, mode);\n }\n \n static int fsi_i2c_reset_bus(struct fsi_i2c_master *i2c,\n \t\t\t struct fsi_i2c_port *port)\n {\n-\tu32 dummy = 0;\n \tu32 stat;\n \tint rc;\n \n@@ -408,7 +403,7 @@ static int fsi_i2c_reset_bus(struct fsi_i2c_master *i2c,\n \ti2c_recover_bus(&port->adapter);\n \n \t/* reset errors */\n-\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_RESET_ERR, &dummy);\n+\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_RESET_ERR, 0);\n \tif (rc)\n \t\treturn rc;\n \n@@ -423,7 +418,7 @@ static int fsi_i2c_reset_bus(struct fsi_i2c_master *i2c,\n \t\treturn 0;\n \n \t/* failed to get command complete; reset engine again */\n-\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_RESET_I2C, &dummy);\n+\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_RESET_I2C, 0);\n \tif (rc)\n \t\treturn rc;\n \n@@ -433,12 +428,11 @@ static int fsi_i2c_reset_bus(struct fsi_i2c_master *i2c,\n \n static int fsi_i2c_reset_engine(struct fsi_i2c_master *i2c, u16 port)\n {\n-\tu32 dummy = 0;\n \tu32 mode;\n \tint rc;\n \n \t/* reset engine */\n-\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_RESET_I2C, &dummy);\n+\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_RESET_I2C, 0);\n \tif (rc)\n \t\treturn rc;\n \n@@ -455,14 +449,13 @@ static int fsi_i2c_reset_engine(struct fsi_i2c_master *i2c, u16 port)\n \tif (port) {\n \t\tmode &= ~I2C_MODE_PORT;\n \t\tmode |= FIELD_PREP(I2C_MODE_PORT, port);\n-\t\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_MODE, &mode);\n+\t\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_MODE, mode);\n \t\tif (rc)\n \t\t\treturn rc;\n \t}\n \n \t/* reset busy register; hw workaround */\n-\tdummy = I2C_PORT_BUSY_RESET;\n-\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_PORT_BUSY, &dummy);\n+\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_PORT_BUSY, I2C_PORT_BUSY_RESET);\n \tif (rc)\n \t\treturn rc;\n \n@@ -497,7 +490,7 @@ static int fsi_i2c_abort(struct fsi_i2c_port *port, u32 status)\n \t\treturn 0;\n \n \t/* write stop command */\n-\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_CMD, &cmd);\n+\trc = fsi_i2c_write_reg(i2c->fsi, I2C_FSI_CMD, cmd);\n \tif (rc)\n \t\treturn rc;\n \n", "prefixes": [ "v3", "28/40" ] }