Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1936122/?format=api
{ "id": 1936122, "url": "http://patchwork.ozlabs.org/api/patches/1936122/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-aspeed/patch/20240516181907.3468796-30-eajames@linux.ibm.com/", "project": { "id": 57, "url": "http://patchwork.ozlabs.org/api/projects/57/?format=api", "name": "Linux ASPEED SoC development", "link_name": "linux-aspeed", "list_id": "linux-aspeed.lists.ozlabs.org", "list_email": "linux-aspeed@lists.ozlabs.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20240516181907.3468796-30-eajames@linux.ibm.com>", "list_archive_url": null, "date": "2024-05-16T18:18:56", "name": "[v3,29/40] i2c: fsi: Remove list structure of ports", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f3fa56d6c5ad084043bdd75be09484d5ff210fb2", "submitter": { "id": 74989, "url": "http://patchwork.ozlabs.org/api/people/74989/?format=api", "name": "Eddie James", "email": "eajames@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-aspeed/patch/20240516181907.3468796-30-eajames@linux.ibm.com/mbox/", "series": [ { "id": 407101, "url": "http://patchwork.ozlabs.org/api/series/407101/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-aspeed/list/?series=407101", "date": "2024-05-16T18:18:31", "name": "fsi: Add interrupt support", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/407101/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1936122/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1936122/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-aspeed@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "linux-aspeed@lists.ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Zxb1b574;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Zxb1b574;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Zxb1b574;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=eajames@linux.ibm.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4VgJLC0mz5z1yfq\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 May 2024 04:20:35 +1000 (AEST)", "from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4VgJLB5hbmz3frK\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 May 2024 04:20:34 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4VgJJw0nS0z3fq2;\n\tFri, 17 May 2024 04:19:27 +1000 (AEST)", "from pps.filterd (m0353729.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 44GIAVoW020127;\n\tThu, 16 May 2024 18:19:19 GMT", "from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y5p6gg5n5-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 16 May 2024 18:19:19 +0000", "from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id\n 44GHFiN2018766;\n\tThu, 16 May 2024 18:19:18 GMT", "from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3y2k0tuqed-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 16 May 2024 18:19:18 +0000", "from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n\tby smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 44GIJG7M49218076\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tThu, 16 May 2024 18:19:18 GMT", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3CF255806D;\n\tThu, 16 May 2024 18:19:16 +0000 (GMT)", "from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id F34FC58070;\n\tThu, 16 May 2024 18:19:15 +0000 (GMT)", "from slate16.aus.stglabs.ibm.com (unknown [9.61.107.19])\n\tby smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n\tThu, 16 May 2024 18:19:15 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com;\n h=from : to : cc : subject\n : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding; s=pp1;\n bh=6pwGrpGa/9FUM1RJLI4c4OWS/mHbmuo48TsghubX0+s=;\n b=Zxb1b574n8I2x9p6vQUA29tjzUbxcrlwBCCMwKzbv5vn5s4j6PLo3o0Gqr18N3X9zx6m\n PfI7B3K6c4/Zhh4yy3A4W3TjrlK9FGQPa68ixa6E3jgEb2vFoTa9JjyywX5xWtnS0pEW\n 8SFYuhHUOIw4r1bGnQn5rVdUkQ0kT+aeS21+HzzN6T8S+8XVYGyv0UdO7sGFALzrwkE3\n y7+J+LOtpGdA3kw8VMwWm+FOZluion4W+WLaxT+bcQnYNO81inS/Yjyk2/j+foYv8Zv3\n ETfSP3lQUDOrhkFjgovGsBNjUU4ChBcwjkL1RrGfpdY5ESxkZ0XRlPwIkBeINysP9Enq 9Q==", "From": "Eddie James <eajames@linux.ibm.com>", "To": "linux-fsi@lists.ozlabs.org", "Subject": "[PATCH v3 29/40] i2c: fsi: Remove list structure of ports", "Date": "Thu, 16 May 2024 13:18:56 -0500", "Message-Id": "<20240516181907.3468796-30-eajames@linux.ibm.com>", "X-Mailer": "git-send-email 2.39.3", "In-Reply-To": "<20240516181907.3468796-1-eajames@linux.ibm.com>", "References": "<20240516181907.3468796-1-eajames@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-GUID": "ZZjglmFtzoOlff8a-TI-jak3p52l_MXE", "X-Proofpoint-ORIG-GUID": "ZZjglmFtzoOlff8a-TI-jak3p52l_MXE", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26\n definitions=2024-05-16_07,2024-05-15_01,2023-05-22_02", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0\n adultscore=0 clxscore=1015 impostorscore=0 mlxscore=0 malwarescore=0\n mlxlogscore=999 spamscore=0 bulkscore=0 priorityscore=1501 suspectscore=0\n phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2405010000 definitions=main-2405160132", "X-BeenThere": "linux-aspeed@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux ASPEED SoC development <linux-aspeed.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linux-aspeed>,\n <mailto:linux-aspeed-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linux-aspeed/>", "List-Post": "<mailto:linux-aspeed@lists.ozlabs.org>", "List-Help": "<mailto:linux-aspeed-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linux-aspeed>,\n <mailto:linux-aspeed-request@lists.ozlabs.org?subject=subscribe>", "Cc": "andi.shyti@kernel.org, linux-aspeed@lists.ozlabs.org, jk@ozlabs.org,\n alistair@popple.id.au, linux-kernel@vger.kernel.org,\n linux-spi@vger.kernel.org, broonie@kernel.org, andrew@codeconstruct.com.au,\n linux-i2c@vger.kernel.org", "Errors-To": "linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Linux-aspeed\"\n <linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Maintaining a list of ports is unnecessary since they can be managed\nwith the device resource framework.\n\nSigned-off-by: Eddie James <eajames@linux.ibm.com>\n---\n drivers/i2c/busses/i2c-fsi.c | 44 +++++++++---------------------------\n 1 file changed, 11 insertions(+), 33 deletions(-)", "diff": "diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c\nindex 44aa750278100..f3b97bf88d0f9 100644\n--- a/drivers/i2c/busses/i2c-fsi.c\n+++ b/drivers/i2c/busses/i2c-fsi.c\n@@ -19,7 +19,6 @@\n #include <linux/i2c.h>\n #include <linux/jiffies.h>\n #include <linux/kernel.h>\n-#include <linux/list.h>\n #include <linux/module.h>\n #include <linux/mutex.h>\n #include <linux/of.h>\n@@ -148,14 +147,12 @@\n \n struct fsi_i2c_master {\n \tstruct fsi_device\t*fsi;\n-\tstruct list_head\tports;\n \tstruct mutex\t\tlock;\n \tu32\t\t\tclock_div;\n \tu8\t\t\tfifo_size;\n };\n \n struct fsi_i2c_port {\n-\tstruct list_head\tlist;\n \tstruct i2c_adapter\tadapter;\n \tstruct fsi_i2c_master\t*master;\n \tu16\t\t\tport;\n@@ -327,7 +324,7 @@ static int fsi_i2c_read_fifo(struct fsi_i2c_port *port, struct i2c_msg *msg,\n \n static int fsi_i2c_get_scl(struct i2c_adapter *adap)\n {\n-\tstruct fsi_i2c_port *port = adap->algo_data;\n+\tstruct fsi_i2c_port *port = i2c_get_adapdata(adap);\n \tu32 stat;\n \n \tfsi_i2c_read_reg(port->master->fsi, I2C_FSI_STAT, &stat);\n@@ -337,7 +334,7 @@ static int fsi_i2c_get_scl(struct i2c_adapter *adap)\n \n static void fsi_i2c_set_scl(struct i2c_adapter *adap, int val)\n {\n-\tstruct fsi_i2c_port *port = adap->algo_data;\n+\tstruct fsi_i2c_port *port = i2c_get_adapdata(adap);\n \n \tif (val)\n \t\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_SET_SCL, 0);\n@@ -347,7 +344,7 @@ static void fsi_i2c_set_scl(struct i2c_adapter *adap, int val)\n \n static int fsi_i2c_get_sda(struct i2c_adapter *adap)\n {\n-\tstruct fsi_i2c_port *port = adap->algo_data;\n+\tstruct fsi_i2c_port *port = i2c_get_adapdata(adap);\n \tu32 stat;\n \n \tfsi_i2c_read_reg(port->master->fsi, I2C_FSI_STAT, &stat);\n@@ -357,7 +354,7 @@ static int fsi_i2c_get_sda(struct i2c_adapter *adap)\n \n static void fsi_i2c_set_sda(struct i2c_adapter *adap, int val)\n {\n-\tstruct fsi_i2c_port *port = adap->algo_data;\n+\tstruct fsi_i2c_port *port = i2c_get_adapdata(adap);\n \n \tif (val)\n \t\tfsi_i2c_write_reg(port->master->fsi, I2C_FSI_SET_SDA, 0);\n@@ -367,7 +364,7 @@ static void fsi_i2c_set_sda(struct i2c_adapter *adap, int val)\n \n static void fsi_i2c_prepare_recovery(struct i2c_adapter *adap)\n {\n-\tstruct fsi_i2c_port *port = adap->algo_data;\n+\tstruct fsi_i2c_port *port = i2c_get_adapdata(adap);\n \tu32 mode;\n \tint rc;\n \n@@ -381,7 +378,7 @@ static void fsi_i2c_prepare_recovery(struct i2c_adapter *adap)\n \n static void fsi_i2c_unprepare_recovery(struct i2c_adapter *adap)\n {\n-\tstruct fsi_i2c_port *port = adap->algo_data;\n+\tstruct fsi_i2c_port *port = i2c_get_adapdata(adap);\n \tu32 mode;\n \tint rc;\n \n@@ -594,7 +591,7 @@ static int fsi_i2c_wait(struct fsi_i2c_port *port, struct i2c_msg *msg,\n static int fsi_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,\n \t\t\tint num)\n {\n-\tstruct fsi_i2c_port *port = adap->algo_data;\n+\tstruct fsi_i2c_port *port = i2c_get_adapdata(adap);\n \tunsigned long start_time;\n \tstruct i2c_msg *msg;\n \tint rc;\n@@ -679,7 +676,6 @@ static int fsi_i2c_probe(struct device *dev)\n \n \tmutex_init(&i2c->lock);\n \ti2c->fsi = to_fsi_dev(dev);\n-\tINIT_LIST_HEAD(&i2c->ports);\n \ti2c->clock_div = I2C_DEFAULT_CLK_DIV;\n \n \tlbus = fsi_device_local_bus_frequency(i2c->fsi);\n@@ -705,38 +701,30 @@ static int fsi_i2c_probe(struct device *dev)\n \tports = FIELD_GET(I2C_STAT_MAX_PORT, stat) + 1;\n \tdev_dbg(dev, \"I2C master has %d ports\\n\", ports);\n \n-\tfor (port_no = 0; port_no < ports; port_no++) {\n+\tport = devm_kzalloc(dev, sizeof(*port) * ports, GFP_KERNEL);\n+\tfor (port_no = 0; port_no < ports; port_no++, port++) {\n \t\tnp = fsi_i2c_find_port_of_node(dev->of_node, port_no);\n \t\tif (!of_device_is_available(np))\n \t\t\tcontinue;\n \n-\t\tport = kzalloc(sizeof(*port), GFP_KERNEL);\n-\t\tif (!port) {\n-\t\t\tof_node_put(np);\n-\t\t\tbreak;\n-\t\t}\n-\n \t\tport->master = i2c;\n \t\tport->port = port_no;\n \n+\t\ti2c_set_adapdata(&port->adapter, port);\n \t\tport->adapter.owner = THIS_MODULE;\n \t\tport->adapter.dev.of_node = np;\n \t\tport->adapter.dev.parent = dev;\n \t\tport->adapter.algo = &fsi_i2c_algorithm;\n \t\tport->adapter.bus_recovery_info = &fsi_i2c_bus_recovery_info;\n-\t\tport->adapter.algo_data = port;\n \n \t\tsnprintf(port->adapter.name, sizeof(port->adapter.name),\n \t\t\t \"i2c_bus-%u\", port_no);\n \n-\t\trc = i2c_add_adapter(&port->adapter);\n+\t\trc = devm_i2c_add_adapter(dev, &port->adapter);\n \t\tif (rc < 0) {\n \t\t\tdev_err(dev, \"Failed to register adapter: %d\\n\", rc);\n-\t\t\tkfree(port);\n \t\t\tcontinue;\n \t\t}\n-\n-\t\tlist_add(&port->list, &i2c->ports);\n \t}\n \n \tdev_set_drvdata(dev, i2c);\n@@ -745,16 +733,6 @@ static int fsi_i2c_probe(struct device *dev)\n \n static int fsi_i2c_remove(struct device *dev)\n {\n-\tstruct fsi_i2c_master *i2c = dev_get_drvdata(dev);\n-\tstruct fsi_i2c_port *port;\n-\tstruct fsi_i2c_port *tmp;\n-\n-\tlist_for_each_entry_safe(port, tmp, &i2c->ports, list) {\n-\t\tlist_del(&port->list);\n-\t\ti2c_del_adapter(&port->adapter);\n-\t\tkfree(port);\n-\t}\n-\n \treturn 0;\n }\n \n", "prefixes": [ "v3", "29/40" ] }