Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1933410/?format=api
{ "id": 1933410, "url": "http://patchwork.ozlabs.org/api/patches/1933410/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20240509115755.519982-4-hbathini@linux.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20240509115755.519982-4-hbathini@linux.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20240509115755.519982-4-hbathini@linux.ibm.com/", "date": "2024-05-09T11:57:55", "name": "[v2,3/3] powerpc/fadump: pass additional parameters when fadump is active", "commit_ref": "3416c9daa6b13c0e2a656d4e2dee8de95f9a38cf", "pull_url": null, "state": "accepted", "archived": false, "hash": "c18bbc0eb4a47f511b009dbb6012f372a254c31f", "submitter": { "id": 74073, "url": "http://patchwork.ozlabs.org/api/people/74073/?format=api", "name": "Hari Bathini", "email": "hbathini@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20240509115755.519982-4-hbathini@linux.ibm.com/mbox/", "series": [ { "id": 406156, "url": "http://patchwork.ozlabs.org/api/series/406156/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=406156", "date": "2024-05-09T11:57:52", "name": "powerpc/fadump: pass additional args to dump capture kernel", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/406156/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1933410/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/1933410/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=UvVNYjGG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=UvVNYjGG;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=UvVNYjGG;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=hbathini@linux.ibm.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4VZrDq70CRz20fZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 9 May 2024 22:00:27 +1000 (AEST)", "from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4VZrDq5N1Vz3dCm\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 9 May 2024 22:00:27 +1000 (AEST)", "from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4VZrBF6SvHz3cTh\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 9 May 2024 21:58:13 +1000 (AEST)", "from pps.filterd (m0353723.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 449BaDYl029303;\n\tThu, 9 May 2024 11:58:09 GMT", "from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y0wdtg2d2-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 09 May 2024 11:58:08 +0000", "from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id\n 449BnQ8H009781;\n\tThu, 9 May 2024 11:58:08 GMT", "from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xyshutmsk-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 09 May 2024 11:58:08 +0000", "from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com\n [10.20.54.101])\n\tby smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 449Bw33Y49742120\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tThu, 9 May 2024 11:58:05 GMT", "from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id EB0EB2004E;\n\tThu, 9 May 2024 11:58:02 +0000 (GMT)", "from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 9A53720040;\n\tThu, 9 May 2024 11:58:01 +0000 (GMT)", "from li-bd3f974c-2712-11b2-a85c-df1cec4d728e.in.ibm.com (unknown\n [9.203.115.195])\n\tby smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tThu, 9 May 2024 11:58:01 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com;\n h=from : to : cc : subject\n : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding; s=pp1;\n bh=DTCorESddXM/KPd/FdeTUQjRKEenNnY9wvqIhrQjMV0=;\n b=UvVNYjGGtjR1R3cuSZe1wNCBeaoYHtv/Av4nXbJT7m49gym18vO1EzeLrhmaiE8/JyaE\n q8vhSxgYcDHshPV4ofzTRFO8OkJWqo/3fuFynWIstDxJb5Vsx/OWy65+1l8EkDiD9v6c\n iALLzA8jkKaST3drnpGyAQVd/TvDgfbvVYFqpLBy/nt8rEBmC1wW82Ev8kQghCnx/eXc\n W1jjsv0XhzQdXC0gCP9gggEMn8MUrm1/U8sumdVZRgtgglmSdguWH4dCpItA8IGOpYyJ\n VqvafCGpbBo+KPJMzev6f3eHfVaCJdZUgdxs+zl9pIwmoZGewFJiMcPDTLI0KiIU613L jQ==", "From": "Hari Bathini <hbathini@linux.ibm.com>", "To": "Michael Ellerman <mpe@ellerman.id.au>", "Subject": "[PATCH v2 3/3] powerpc/fadump: pass additional parameters when fadump\n is active", "Date": "Thu, 9 May 2024 17:27:55 +0530", "Message-ID": "<20240509115755.519982-4-hbathini@linux.ibm.com>", "X-Mailer": "git-send-email 2.45.0", "In-Reply-To": "<20240509115755.519982-1-hbathini@linux.ibm.com>", "References": "<20240509115755.519982-1-hbathini@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-GUID": "LrGBUZEE2CK93ryvdCr4tWhubBRgCsuf", "X-Proofpoint-ORIG-GUID": "LrGBUZEE2CK93ryvdCr4tWhubBRgCsuf", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26\n definitions=2024-05-09_06,2024-05-09_01,2023-05-22_02", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n impostorscore=0\n malwarescore=0 phishscore=0 adultscore=0 clxscore=1015 bulkscore=0\n spamscore=0 suspectscore=0 priorityscore=1501 mlxlogscore=999 mlxscore=0\n lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2405010000 definitions=main-2405090079", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,\n Mahesh J Salgaonkar <mahesh@linux.ibm.com>,\n Sourabh Jain <sourabhjain@linux.ibm.com>", "Errors-To": "linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n <linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Append the additional parameters passed/set in the dedicated parameter\narea (RTAS_FADUMP_PARAM_AREA) to bootargs in fadump capture kernel.\n\nSigned-off-by: Hari Bathini <hbathini@linux.ibm.com>\n---\n arch/powerpc/include/asm/fadump.h | 2 ++\n arch/powerpc/kernel/fadump.c | 35 +++++++++++++++++++++++++++++++\n arch/powerpc/kernel/prom.c | 3 +++\n 3 files changed, 40 insertions(+)", "diff": "diff --git a/arch/powerpc/include/asm/fadump.h b/arch/powerpc/include/asm/fadump.h\nindex 526a6a647312..ef40c9b6972a 100644\n--- a/arch/powerpc/include/asm/fadump.h\n+++ b/arch/powerpc/include/asm/fadump.h\n@@ -19,12 +19,14 @@ extern int is_fadump_active(void);\n extern int should_fadump_crash(void);\n extern void crash_fadump(struct pt_regs *, const char *);\n extern void fadump_cleanup(void);\n+extern void fadump_append_bootargs(void);\n \n #else\t/* CONFIG_FA_DUMP */\n static inline int is_fadump_active(void) { return 0; }\n static inline int should_fadump_crash(void) { return 0; }\n static inline void crash_fadump(struct pt_regs *regs, const char *str) { }\n static inline void fadump_cleanup(void) { }\n+static inline void fadump_append_bootargs(void) { }\n #endif /* !CONFIG_FA_DUMP */\n \n #if defined(CONFIG_FA_DUMP) || defined(CONFIG_PRESERVE_FA_DUMP)\ndiff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c\nindex 6d35b09d6f3a..2276bacc4170 100644\n--- a/arch/powerpc/kernel/fadump.c\n+++ b/arch/powerpc/kernel/fadump.c\n@@ -131,6 +131,41 @@ static int __init fadump_cma_init(void)\n static int __init fadump_cma_init(void) { return 1; }\n #endif /* CONFIG_CMA */\n \n+/*\n+ * Additional parameters meant for capture kernel are placed in a dedicated area.\n+ * If this is capture kernel boot, append these parameters to bootargs.\n+ */\n+void __init fadump_append_bootargs(void)\n+{\n+\tchar *append_args;\n+\tsize_t len;\n+\n+\tif (!fw_dump.dump_active || !fw_dump.param_area_supported || !fw_dump.param_area)\n+\t\treturn;\n+\n+\tif (fw_dump.param_area >= fw_dump.boot_mem_top) {\n+\t\tif (memblock_reserve(fw_dump.param_area, COMMAND_LINE_SIZE)) {\n+\t\t\tpr_warn(\"WARNING: Can't use additional parameters area!\\n\");\n+\t\t\tfw_dump.param_area = 0;\n+\t\t\treturn;\n+\t\t}\n+\t}\n+\n+\tappend_args = (char *)fw_dump.param_area;\n+\tlen = strlen(boot_command_line);\n+\n+\t/*\n+\t * Too late to fail even if cmdline size exceeds. Truncate additional parameters\n+\t * to cmdline size and proceed anyway.\n+\t */\n+\tif (len + strlen(append_args) >= COMMAND_LINE_SIZE - 1)\n+\t\tpr_warn(\"WARNING: Appending parameters exceeds cmdline size. Truncating!\\n\");\n+\n+\tpr_debug(\"Cmdline: %s\\n\", boot_command_line);\n+\tsnprintf(boot_command_line + len, COMMAND_LINE_SIZE - len, \" %s\", append_args);\n+\tpr_info(\"Updated cmdline: %s\\n\", boot_command_line);\n+}\n+\n /* Scan the Firmware Assisted dump configuration details. */\n int __init early_init_dt_scan_fw_dump(unsigned long node, const char *uname,\n \t\t\t\t int depth, void *data)\ndiff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c\nindex eb140ea6b6ff..60819751e55e 100644\n--- a/arch/powerpc/kernel/prom.c\n+++ b/arch/powerpc/kernel/prom.c\n@@ -813,6 +813,9 @@ void __init early_init_devtree(void *params)\n \t */\n \tof_scan_flat_dt(early_init_dt_scan_chosen_ppc, boot_command_line);\n \n+\t/* Append additional parameters passed for fadump capture kernel */\n+\tfadump_append_bootargs();\n+\n \t/* Scan memory nodes and rebuild MEMBLOCKs */\n \tearly_init_dt_scan_root();\n \tearly_init_dt_scan_memory_ppc();\n", "prefixes": [ "v2", "3/3" ] }