Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1933409/?format=api
{ "id": 1933409, "url": "http://patchwork.ozlabs.org/api/patches/1933409/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20240509115755.519982-3-hbathini@linux.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20240509115755.519982-3-hbathini@linux.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20240509115755.519982-3-hbathini@linux.ibm.com/", "date": "2024-05-09T11:57:54", "name": "[v2,2/3] powerpc/fadump: setup additional parameters for dump capture kernel", "commit_ref": "683eab94da75bcf55a9c65e0c31d0529edebe86d", "pull_url": null, "state": "accepted", "archived": false, "hash": "3293b87ec955de5f813aee1cdea8ffeb0c18585e", "submitter": { "id": 74073, "url": "http://patchwork.ozlabs.org/api/people/74073/?format=api", "name": "Hari Bathini", "email": "hbathini@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20240509115755.519982-3-hbathini@linux.ibm.com/mbox/", "series": [ { "id": 406156, "url": "http://patchwork.ozlabs.org/api/series/406156/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=406156", "date": "2024-05-09T11:57:52", "name": "powerpc/fadump: pass additional args to dump capture kernel", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/406156/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1933409/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1933409/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=MhNHZD1T;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=MhNHZD1T;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=MhNHZD1T;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=hbathini@linux.ibm.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4VZrD31XGjz20fc\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 9 May 2024 21:59:47 +1000 (AEST)", "from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4VZrD25ZRxz3cbH\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 9 May 2024 21:59:46 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4VZrBD5SSQz3cQq\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 9 May 2024 21:58:12 +1000 (AEST)", "from pps.filterd (m0353729.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 449BgFku016242;\n\tThu, 9 May 2024 11:58:08 GMT", "from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y0wug811r-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 09 May 2024 11:58:07 +0000", "from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id\n 449BXR7p009268;\n\tThu, 9 May 2024 11:58:06 GMT", "from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224])\n\tby ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xyshtamp6-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 09 May 2024 11:58:06 +0000", "from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com\n [10.20.54.101])\n\tby smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 449Bw17l52691224\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tThu, 9 May 2024 11:58:03 GMT", "from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 362E420043;\n\tThu, 9 May 2024 11:58:01 +0000 (GMT)", "from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id E7B5620040;\n\tThu, 9 May 2024 11:57:59 +0000 (GMT)", "from li-bd3f974c-2712-11b2-a85c-df1cec4d728e.in.ibm.com (unknown\n [9.203.115.195])\n\tby smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tThu, 9 May 2024 11:57:59 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com;\n h=from : to : cc : subject\n : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding; s=pp1;\n bh=cZ2gUxtU8hT9E3We2QPtH4/qhGoRlI7P8NvNpMxldO0=;\n b=MhNHZD1T5WDjrcSt8PrnihWRVyBUab/Av8G2IifAE52jIiZEUQOCPaFX54gybd07s9vh\n FjRbmXCpk6gmKLABoRoqvKwW8QH04Kb5DCQdjGQ0QeKMlvB3/V/fUJkgOfaCMpqtzuWh\n R79DuVUIzkeZZx+5BDf3KkknfSoqttItoSYvdLIQqjeq26ky80nZfHnYijWRM3XStpfH\n 7jL7k8PcuOEo8apAxtvKUdItmfTVQTfD2fi/+3F8S6lX46q3cuCZD9UXoOBz7LOCLdAP\n fwqZUpNbmqAhFod6225B7GNtoJsEhmF6m82HqAWeFowlUqd8+5P9ufafkREz9cOD3519 /A==", "From": "Hari Bathini <hbathini@linux.ibm.com>", "To": "Michael Ellerman <mpe@ellerman.id.au>", "Subject": "[PATCH v2 2/3] powerpc/fadump: setup additional parameters for dump\n capture kernel", "Date": "Thu, 9 May 2024 17:27:54 +0530", "Message-ID": "<20240509115755.519982-3-hbathini@linux.ibm.com>", "X-Mailer": "git-send-email 2.45.0", "In-Reply-To": "<20240509115755.519982-1-hbathini@linux.ibm.com>", "References": "<20240509115755.519982-1-hbathini@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-ORIG-GUID": "ngnrehCWR4q1JJo0mVCvtcyhW4gfYXWj", "X-Proofpoint-GUID": "ngnrehCWR4q1JJo0mVCvtcyhW4gfYXWj", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26\n definitions=2024-05-09_06,2024-05-09_01,2023-05-22_02", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 mlxscore=0\n phishscore=0 mlxlogscore=999 bulkscore=0 clxscore=1015 adultscore=0\n malwarescore=0 lowpriorityscore=0 spamscore=0 impostorscore=0\n suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2405010000 definitions=main-2405090079", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,\n Mahesh J Salgaonkar <mahesh@linux.ibm.com>,\n Sourabh Jain <sourabhjain@linux.ibm.com>", "Errors-To": "linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n <linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "For fadump case, passing additional parameters to dump capture kernel\nhelps in minimizing the memory footprint for it and also provides the\nflexibility to disable components/modules, like hugepages, that are\nhindering the boot process of the special dump capture environment.\n\nSet up a dedicated parameter area to be passed to the capture kernel.\nThis area type is defined as RTAS_FADUMP_PARAM_AREA. Sysfs attribute\n'/sys/kernel/fadump/bootargs_append' is exported to the userspace to\nspecify the additional parameters to be passed to the capture kernel\n\nSigned-off-by: Hari Bathini <hbathini@linux.ibm.com>\n---\n arch/powerpc/include/asm/fadump-internal.h | 3 +\n arch/powerpc/kernel/fadump.c | 87 ++++++++++++++++++++\n arch/powerpc/platforms/powernv/opal-fadump.c | 6 +-\n arch/powerpc/platforms/pseries/rtas-fadump.c | 35 +++++++-\n arch/powerpc/platforms/pseries/rtas-fadump.h | 11 ++-\n 5 files changed, 133 insertions(+), 9 deletions(-)", "diff": "diff --git a/arch/powerpc/include/asm/fadump-internal.h b/arch/powerpc/include/asm/fadump-internal.h\nindex 35787fa1ac60..e83869a4eb6a 100644\n--- a/arch/powerpc/include/asm/fadump-internal.h\n+++ b/arch/powerpc/include/asm/fadump-internal.h\n@@ -124,6 +124,8 @@ struct fw_dump {\n \tunsigned long\tcpu_notes_buf_vaddr;\n \tunsigned long\tcpu_notes_buf_size;\n \n+\tunsigned long\tparam_area;\n+\n \t/*\n \t * Maximum size supported by firmware to copy from source to\n \t * destination address per entry.\n@@ -138,6 +140,7 @@ struct fw_dump {\n \tunsigned long\tdump_active:1;\n \tunsigned long\tdump_registered:1;\n \tunsigned long\tnocma:1;\n+\tunsigned long\tparam_area_supported:1;\n \n \tstruct fadump_ops\t*ops;\n };\ndiff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c\nindex fe6be00451b9..6d35b09d6f3a 100644\n--- a/arch/powerpc/kernel/fadump.c\n+++ b/arch/powerpc/kernel/fadump.c\n@@ -1431,6 +1431,43 @@ static ssize_t registered_show(struct kobject *kobj,\n \treturn sprintf(buf, \"%d\\n\", fw_dump.dump_registered);\n }\n \n+static ssize_t bootargs_append_show(struct kobject *kobj,\n+\t\t\t\t struct kobj_attribute *attr,\n+\t\t\t\t char *buf)\n+{\n+\treturn sprintf(buf, \"%s\\n\", (char *)__va(fw_dump.param_area));\n+}\n+\n+static ssize_t bootargs_append_store(struct kobject *kobj,\n+\t\t\t\t struct kobj_attribute *attr,\n+\t\t\t\t const char *buf, size_t count)\n+{\n+\tchar *params;\n+\n+\tif (!fw_dump.fadump_enabled || fw_dump.dump_active)\n+\t\treturn -EPERM;\n+\n+\tif (count >= COMMAND_LINE_SIZE)\n+\t\treturn -EINVAL;\n+\n+\t/*\n+\t * Fail here instead of handling this scenario with\n+\t * some silly workaround in capture kernel.\n+\t */\n+\tif (saved_command_line_len + count >= COMMAND_LINE_SIZE) {\n+\t\tpr_err(\"Appending parameters exceeds cmdline size!\\n\");\n+\t\treturn -ENOSPC;\n+\t}\n+\n+\tparams = __va(fw_dump.param_area);\n+\tstrscpy_pad(params, buf, COMMAND_LINE_SIZE);\n+\t/* Remove newline character at the end. */\n+\tif (params[count-1] == '\\n')\n+\t\tparams[count-1] = '\\0';\n+\n+\treturn count;\n+}\n+\n static ssize_t registered_store(struct kobject *kobj,\n \t\t\t\tstruct kobj_attribute *attr,\n \t\t\t\tconst char *buf, size_t count)\n@@ -1490,6 +1527,7 @@ static struct kobj_attribute enable_attr = __ATTR_RO(enabled);\n static struct kobj_attribute register_attr = __ATTR_RW(registered);\n static struct kobj_attribute mem_reserved_attr = __ATTR_RO(mem_reserved);\n static struct kobj_attribute hotplug_ready_attr = __ATTR_RO(hotplug_ready);\n+static struct kobj_attribute bootargs_append_attr = __ATTR_RW(bootargs_append);\n \n static struct attribute *fadump_attrs[] = {\n \t&enable_attr.attr,\n@@ -1663,6 +1701,54 @@ static void __init fadump_process(void)\n \tfadump_invalidate_release_mem();\n }\n \n+/*\n+ * Reserve memory to store additional parameters to be passed\n+ * for fadump/capture kernel.\n+ */\n+static void fadump_setup_param_area(void)\n+{\n+\tphys_addr_t range_start, range_end;\n+\n+\tif (!fw_dump.param_area_supported || fw_dump.dump_active)\n+\t\treturn;\n+\n+\t/* This memory can't be used by PFW or bootloader as it is shared across kernels */\n+\tif (radix_enabled()) {\n+\t\t/*\n+\t\t * Anywhere in the upper half should be good enough as all memory\n+\t\t * is accessible in real mode.\n+\t\t */\n+\t\trange_start = memblock_end_of_DRAM() / 2;\n+\t\trange_end = memblock_end_of_DRAM();\n+\t} else {\n+\t\t/*\n+\t\t * Passing additional parameters is supported for hash MMU only\n+\t\t * if the first memory block size is 768MB or higher.\n+\t\t */\n+\t\tif (ppc64_rma_size < 0x30000000)\n+\t\t\treturn;\n+\n+\t\t/*\n+\t\t * 640 MB to 768 MB is not used by PFW/bootloader. So, try reserving\n+\t\t * memory for passing additional parameters in this range to avoid\n+\t\t * being stomped on by PFW/bootloader.\n+\t\t */\n+\t\trange_start = 0x2A000000;\n+\t\trange_end = range_start + 0x4000000;\n+\t}\n+\n+\tfw_dump.param_area = memblock_phys_alloc_range(COMMAND_LINE_SIZE,\n+\t\t\t\t\t\t COMMAND_LINE_SIZE,\n+\t\t\t\t\t\t range_start,\n+\t\t\t\t\t\t range_end);\n+\tif (!fw_dump.param_area || sysfs_create_file(fadump_kobj, &bootargs_append_attr.attr)) {\n+\t\tpr_warn(\"WARNING: Could not setup area to pass additional parameters!\\n\");\n+\t\treturn;\n+\t}\n+\n+\tmemset(phys_to_virt(fw_dump.param_area), 0, COMMAND_LINE_SIZE);\n+}\n+\n /*\n * Prepare for firmware-assisted dump.\n */\n@@ -1686,6 +1772,7 @@ int __init setup_fadump(void)\n \t}\n \t/* Initialize the kernel dump memory structure and register with f/w */\n \telse if (fw_dump.reserve_dump_area_size) {\n+\t\tfadump_setup_param_area();\n \t\tfw_dump.ops->fadump_init_mem_struct(&fw_dump);\n \t\tregister_fadump();\n \t}\ndiff --git a/arch/powerpc/platforms/powernv/opal-fadump.c b/arch/powerpc/platforms/powernv/opal-fadump.c\nindex 5a88d7efb48a..c9c1dfb35464 100644\n--- a/arch/powerpc/platforms/powernv/opal-fadump.c\n+++ b/arch/powerpc/platforms/powernv/opal-fadump.c\n@@ -665,8 +665,10 @@ void __init opal_fadump_dt_scan(struct fw_dump *fadump_conf, u64 node)\n \t\t}\n \t}\n \n-\tfadump_conf->ops\t\t= &opal_fadump_ops;\n-\tfadump_conf->fadump_supported\t= 1;\n+\tfadump_conf->ops\t\t\t= &opal_fadump_ops;\n+\tfadump_conf->fadump_supported\t\t= 1;\n+\t/* TODO: Add support to pass additional parameters */\n+\tfadump_conf->param_area_supported\t= 0;\n \n \t/*\n \t * Firmware supports 32-bit field for size. Align it to PAGE_SIZE\ndiff --git a/arch/powerpc/platforms/pseries/rtas-fadump.c b/arch/powerpc/platforms/pseries/rtas-fadump.c\nindex 4db78b2bb2a8..eceb3289383e 100644\n--- a/arch/powerpc/platforms/pseries/rtas-fadump.c\n+++ b/arch/powerpc/platforms/pseries/rtas-fadump.c\n@@ -18,6 +18,7 @@\n \n #include <asm/page.h>\n #include <asm/rtas.h>\n+#include <asm/setup.h>\n #include <asm/fadump.h>\n #include <asm/fadump-internal.h>\n \n@@ -81,6 +82,9 @@ static void __init rtas_fadump_get_config(struct fw_dump *fadump_conf,\n \t\t\tlast_end = base + size;\n \t\t\tfadump_conf->boot_mem_regs_cnt++;\n \t\t\tbreak;\n+\t\tcase RTAS_FADUMP_PARAM_AREA:\n+\t\t\tfadump_conf->param_area = be64_to_cpu(fdm->rgn[i].destination_address);\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\tpr_warn(\"Section type %d unsupported on this kernel. Ignoring!\\n\", type);\n \t\t\tbreak;\n@@ -154,7 +158,17 @@ static u64 rtas_fadump_init_mem_struct(struct fw_dump *fadump_conf)\n \t\tsec_cnt++;\n \t}\n \n+\t/* Parameters area */\n+\tif (fadump_conf->param_area) {\n+\t\tfdm.rgn[sec_cnt].request_flag = cpu_to_be32(RTAS_FADUMP_REQUEST_FLAG);\n+\t\tfdm.rgn[sec_cnt].source_data_type = cpu_to_be16(RTAS_FADUMP_PARAM_AREA);\n+\t\tfdm.rgn[sec_cnt].source_address = cpu_to_be64(fadump_conf->param_area);\n+\t\tfdm.rgn[sec_cnt].source_len = cpu_to_be64(COMMAND_LINE_SIZE);\n+\t\tfdm.rgn[sec_cnt].destination_address = cpu_to_be64(fadump_conf->param_area);\n+\t\tsec_cnt++;\n+\t}\n \tfdm.header.dump_num_sections = cpu_to_be16(sec_cnt);\n+\n \trtas_fadump_update_config(fadump_conf, &fdm);\n \n \treturn addr;\n@@ -453,6 +467,13 @@ static int __init rtas_fadump_process(struct fw_dump *fadump_conf)\n \t\t\t\treturn rc;\n \t\t\t}\n \t\t\tbreak;\n+\t\tcase RTAS_FADUMP_PARAM_AREA:\n+\t\t\tif (fdm_active->rgn[i].bytes_dumped != fdm_active->rgn[i].source_len ||\n+\t\t\t fdm_active->rgn[i].error_flags != 0) {\n+\t\t\t\tpr_warn(\"Failed to process additional parameters! Proceeding anyway..\\n\");\n+\t\t\t\tfadump_conf->param_area = 0;\n+\t\t\t}\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\t/*\n \t\t\t * If the first/crashed kernel added a new region type that the\n@@ -509,6 +530,13 @@ static void rtas_fadump_region_show(struct fw_dump *fadump_conf,\n \t\t\t\t be64_to_cpu(fdm_ptr->rgn[i].source_len),\n \t\t\t\t be64_to_cpu(fdm_ptr->rgn[i].bytes_dumped));\n \t\t\tbreak;\n+\t\tcase RTAS_FADUMP_PARAM_AREA:\n+\t\t\tseq_printf(m, \"\\n[%#016llx-%#016llx]: cmdline append: '%s'\\n\",\n+\t\t\t\t be64_to_cpu(fdm_ptr->rgn[i].destination_address),\n+\t\t\t\t be64_to_cpu(fdm_ptr->rgn[i].destination_address) +\n+\t\t\t\t be64_to_cpu(fdm_ptr->rgn[i].source_len) - 1,\n+\t\t\t\t (char *)__va(be64_to_cpu(fdm_ptr->rgn[i].destination_address)));\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\tseq_printf(m, \"Unknown region type %d : Src: %#016llx, Dest: %#016llx, \",\n \t\t\t\t type, be64_to_cpu(fdm_ptr->rgn[i].source_address),\n@@ -571,9 +599,10 @@ void __init rtas_fadump_dt_scan(struct fw_dump *fadump_conf, u64 node)\n \tif (!token)\n \t\treturn;\n \n-\tfadump_conf->ibm_configure_kernel_dump = be32_to_cpu(*token);\n-\tfadump_conf->ops\t\t= &rtas_fadump_ops;\n-\tfadump_conf->fadump_supported\t= 1;\n+\tfadump_conf->ibm_configure_kernel_dump\t= be32_to_cpu(*token);\n+\tfadump_conf->ops\t\t\t= &rtas_fadump_ops;\n+\tfadump_conf->fadump_supported\t\t= 1;\n+\tfadump_conf->param_area_supported\t= 1;\n \n \t/* Firmware supports 64-bit value for size, align it to pagesize. */\n \tfadump_conf->max_copy_size = ALIGN_DOWN(U64_MAX, PAGE_SIZE);\ndiff --git a/arch/powerpc/platforms/pseries/rtas-fadump.h b/arch/powerpc/platforms/pseries/rtas-fadump.h\nindex 6740f4981bb8..c109abf6befd 100644\n--- a/arch/powerpc/platforms/pseries/rtas-fadump.h\n+++ b/arch/powerpc/platforms/pseries/rtas-fadump.h\n@@ -23,6 +23,9 @@\n #define RTAS_FADUMP_HPTE_REGION\t\t0x0002\n #define RTAS_FADUMP_REAL_MODE_REGION\t0x0011\n \n+/* OS defined sections */\n+#define RTAS_FADUMP_PARAM_AREA\t\t0x0100\n+\n /* Dump request flag */\n #define RTAS_FADUMP_REQUEST_FLAG\t0x00000001\n \n@@ -31,12 +34,12 @@\n \n /*\n * The Firmware Assisted Dump Memory structure supports a maximum of 10 sections\n- * in the dump memory structure. Presently, first two sections are used for\n- * CPU and HPTE data, while the remaining eight sections can be used for\n- * boot memory regions.\n+ * in the dump memory structure. Presently, three sections are used for\n+ * CPU state data, HPTE & Parameters area, while the remaining seven sections\n+ * can be used for boot memory regions.\n */\n #define MAX_SECTIONS\t\t\t\t10\n-#define RTAS_FADUMP_MAX_BOOT_MEM_REGS\t\t8\n+#define RTAS_FADUMP_MAX_BOOT_MEM_REGS\t\t7\n \n /* Kernel Dump section info */\n struct rtas_fadump_section {\n", "prefixes": [ "v2", "2/3" ] }