Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1902589/?format=api
{ "id": 1902589, "url": "http://patchwork.ozlabs.org/api/patches/1902589/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20240222072417.3773131-3-hch@lst.de/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20240222072417.3773131-3-hch@lst.de>", "list_archive_url": null, "date": "2024-02-22T07:24:12", "name": "[2/7] ubd: remove ubd_disk_register", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "701e13a6ce13eaf4bf6ec25f0a73ee1aff42637f", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20240222072417.3773131-3-hch@lst.de/mbox/", "series": [ { "id": 396078, "url": "http://patchwork.ozlabs.org/api/series/396078/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=396078", "date": "2024-02-22T07:24:13", "name": "[1/7] ubd: remove the ubd_gendisk array", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/396078/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1902589/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1902589/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=RF+jr7qn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4TgPm106rdz23d2\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 22 Feb 2024 18:24:28 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux))\n\tid 1rd3RS-00000003ne8-1Ja3;\n\tThu, 22 Feb 2024 07:24:26 +0000", "from [2001:4bb8:19a:62b2:c70:4a89:bc61:3] (helo=localhost)\n\tby bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux))\n\tid 1rd3RQ-00000003nd1-0gxi;\n\tThu, 22 Feb 2024 07:24:24 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help\n\t:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding:\n\tMIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:\n\tReply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=cTy5ByRm6yl9copb54tFACKFS8S5cRwyQfPP7IgncdE=; b=RF+jr7qn2ojVk9dor1xu2S6gbP\n\trGbs8u9dRqBHe8z4P65jKN/3EfSuDmPNZm3x9Da20UNnLGotZm0viYLSm/pLsuirYqRoioNPtkgbk\n\tehWs+m8mfQIoK35MXhB5ndbX1VOv82ID5DPChlxEAc9N0qsmwhTfdIooGeT1cKWXm5/KBRjYKXp/S\n\t59mxuaz+dFHa2FLmg2yGAQJ+6AWwpBd715xKD79jhX0huupJjNnebVwHnvXQhYdEyvDwFnIcU3KqW\n\t4Dyw1NQSabCMmMXoTFbDPdb3X1N/J6kP/1swgvDiGkFk0GMiIqcxg0gOH1TR5wvts0sWAZ0S1A3GM\n\tJ2uEwKWw==;", "From": "Christoph Hellwig <hch@lst.de>", "To": "Richard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tJens Axboe <axboe@kernel.dk>", "Cc": "linux-um@lists.infradead.org,\n\tlinux-block@vger.kernel.org", "Subject": "[PATCH 2/7] ubd: remove ubd_disk_register", "Date": "Thu, 22 Feb 2024 08:24:12 +0100", "Message-Id": "<20240222072417.3773131-3-hch@lst.de>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240222072417.3773131-1-hch@lst.de>", "References": "<20240222072417.3773131-1-hch@lst.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Fold it into the only caller to remove lots of references to the\nglobal ubd_devs array.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\n---\n arch/um/drivers/ubd_kern.c | 37 +++++++++++++++----------------------\n 1 file changed, 15 insertions(+), 22 deletions(-)", "diff": "diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c\nindex b203ebb1785125..ef05157acd6b02 100644\n--- a/arch/um/drivers/ubd_kern.c\n+++ b/arch/um/drivers/ubd_kern.c\n@@ -849,27 +849,6 @@ static const struct attribute_group *ubd_attr_groups[] = {\n \tNULL,\n };\n \n-static int ubd_disk_register(int major, u64 size, int unit,\n-\t\t\t struct gendisk *disk)\n-{\n-\tdisk->major = major;\n-\tdisk->first_minor = unit << UBD_SHIFT;\n-\tdisk->minors = 1 << UBD_SHIFT;\n-\tdisk->fops = &ubd_blops;\n-\tset_capacity(disk, size / 512);\n-\tsprintf(disk->disk_name, \"ubd%c\", 'a' + unit);\n-\n-\tubd_devs[unit].pdev.id = unit;\n-\tubd_devs[unit].pdev.name = DRIVER_NAME;\n-\tubd_devs[unit].pdev.dev.release = ubd_device_release;\n-\tdev_set_drvdata(&ubd_devs[unit].pdev.dev, &ubd_devs[unit]);\n-\tplatform_device_register(&ubd_devs[unit].pdev);\n-\n-\tdisk->private_data = &ubd_devs[unit];\n-\tdisk->queue = ubd_devs[unit].queue;\n-\treturn device_add_disk(&ubd_devs[unit].pdev.dev, disk, ubd_attr_groups);\n-}\n-\n #define ROUND_BLOCK(n) ((n + (SECTOR_SIZE - 1)) & (-SECTOR_SIZE))\n \n static const struct blk_mq_ops ubd_mq_ops = {\n@@ -916,7 +895,21 @@ static int ubd_add(int n, char **error_out)\n \tubd_dev->queue = disk->queue;\n \n \tblk_queue_write_cache(ubd_dev->queue, true, false);\n-\terr = ubd_disk_register(UBD_MAJOR, ubd_dev->size, n, disk);\n+\tdisk->major = UBD_MAJOR;\n+\tdisk->first_minor = n << UBD_SHIFT;\n+\tdisk->minors = 1 << UBD_SHIFT;\n+\tdisk->fops = &ubd_blops;\n+\tset_capacity(disk, ubd_dev->size / 512);\n+\tsprintf(disk->disk_name, \"ubd%c\", 'a' + n);\n+\tdisk->private_data = ubd_dev;\n+\n+\tubd_dev->pdev.id = n;\n+\tubd_dev->pdev.name = DRIVER_NAME;\n+\tubd_dev->pdev.dev.release = ubd_device_release;\n+\tdev_set_drvdata(&ubd_dev->pdev.dev, ubd_dev);\n+\tplatform_device_register(&ubd_dev->pdev);\n+\n+\terr = device_add_disk(&ubd_dev->pdev.dev, disk, ubd_attr_groups);\n \tif (err)\n \t\tgoto out_cleanup_disk;\n \n", "prefixes": [ "2/7" ] }