Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/189475/?format=api
{ "id": 189475, "url": "http://patchwork.ozlabs.org/api/patches/189475/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1349441933-22840-3-git-send-email-monstr@monstr.eu/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1349441933-22840-3-git-send-email-monstr@monstr.eu>", "list_archive_url": null, "date": "2012-10-05T12:58:52", "name": "[U-Boot,3/4] microblaze: Flush caches before enabling them", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "52aa1c4fd1d042326caca07f2b304b0bc1004c1f", "submitter": { "id": 2237, "url": "http://patchwork.ozlabs.org/api/people/2237/?format=api", "name": "Michal Simek", "email": "monstr@monstr.eu" }, "delegate": { "id": 1692, "url": "http://patchwork.ozlabs.org/api/users/1692/?format=api", "username": "monstr", "first_name": "Michal", "last_name": "Simek", "email": "monstr@monstr.eu" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1349441933-22840-3-git-send-email-monstr@monstr.eu/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/189475/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/189475/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from theia.denx.de (theia.denx.de [85.214.87.163])\n\tby ozlabs.org (Postfix) with ESMTP id CB3352C00BF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 5 Oct 2012 22:59:47 +1000 (EST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id C0D1C280E6;\n\tFri, 5 Oct 2012 14:59:28 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id htZlckbX+cQd; Fri, 5 Oct 2012 14:59:28 +0200 (CEST)", "from theia.denx.de (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 201C4280B4;\n\tFri, 5 Oct 2012 14:59:11 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 80D2B2808D\n\tfor <u-boot@lists.denx.de>; Fri, 5 Oct 2012 14:59:01 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VZylwCCiCJ8W for <u-boot@lists.denx.de>;\n\tFri, 5 Oct 2012 14:59:00 +0200 (CEST)", "from mail-we0-f172.google.com (mail-we0-f172.google.com\n\t[74.125.82.172]) by theia.denx.de (Postfix) with ESMTPS id 993F72808C\n\tfor <u-boot@lists.denx.de>; Fri, 5 Oct 2012 14:58:58 +0200 (CEST)", "by mail-we0-f172.google.com with SMTP id u46so1035549wey.3\n\tfor <u-boot@lists.denx.de>; Fri, 05 Oct 2012 05:58:58 -0700 (PDT)", "by 10.180.107.163 with SMTP id hd3mr3246638wib.19.1349441938078;\n\tFri, 05 Oct 2012 05:58:58 -0700 (PDT)", "from localhost (nat-2.starnet.cz. [92.62.224.2])\n\tby mx.google.com with ESMTPS id bn7sm2552439wib.8.2012.10.05.05.58.57\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 05 Oct 2012 05:58:57 -0700 (PDT)" ], "X-Virus-Scanned": [ "Debian amavisd-new at theia.denx.de", "Debian amavisd-new at theia.denx.de" ], "X-policyd-weight": "NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5\n\tNOT_IN_BL_NJABL=-1.5 (only DNSBL check requested)", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20120113;\n\th=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references\n\t:x-gm-message-state;\n\tbh=eeeK6BKLUw8/jqiYfbAk5TuFixklINwJ0SVGfIDYrto=;\n\tb=X9V1DNkuDxAO9uj9ntMOr3QGy36uzI378JOaqbVP2JvBhWOLCTz0wmutAGtrf9oJfY\n\t8947odfG3InHwV/pEC+yGh2vj6HeJD9INGyTYnjILhK8MqWLj11009Ux21T3fqO0QnB2\n\tJriMRWC3Bv8dLLUQvHVcsvk2AV8a6tsCcjZoLPK7dPB8nk7k4/3grD33UGxFqe0G8aLY\n\t5UAgxBGTuocQ7SxGGTujNnCjsA+J7iXM4xxEVci7MWYjm853JqZNagsU1tDOZvFfmX3+\n\tO7kfg7X+fkUkcrag5Xa0W9+IViDc2hPTHQQVCMwfiYZjikzlq4WpuLHJtlJhyckFWqvV\n\teNzA==", "From": "Michal Simek <monstr@monstr.eu>", "To": "u-boot@lists.denx.de", "Date": "Fri, 5 Oct 2012 14:58:52 +0200", "Message-Id": "<1349441933-22840-3-git-send-email-monstr@monstr.eu>", "X-Mailer": "git-send-email 1.7.0.4", "In-Reply-To": "<1349441933-22840-1-git-send-email-monstr@monstr.eu>", "References": "<1349441933-22840-1-git-send-email-monstr@monstr.eu>", "X-Gm-Message-State": "ALoCoQntcz0yOxcqPxumNei0Yzy8mVG6K0jBXCTR5DKQE/IDs2ecyixOsi5sy+5lv0KeKFSU2Q1R", "Subject": "[U-Boot] [PATCH 3/4] microblaze: Flush caches before enabling them", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.11", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<http://lists.denx.de/mailman/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<http://lists.denx.de/mailman/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "u-boot-bounces@lists.denx.de", "Errors-To": "u-boot-bounces@lists.denx.de" }, "content": "Flushing caches is necessary because of soft reset\nwhich doesn't clear caches.\n\nSigned-off-by: Michal Simek <monstr@monstr.eu>\n---\n arch/microblaze/cpu/cache.c | 5 -----\n arch/microblaze/cpu/start.S | 6 ++++++\n arch/microblaze/lib/bootm.c | 5 -----\n include/configs/microblaze-generic.h | 4 ++++\n 4 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/arch/microblaze/cpu/cache.c b/arch/microblaze/cpu/cache.c\nindex d258a69..ce066b9 100644\n--- a/arch/microblaze/cpu/cache.c\n+++ b/arch/microblaze/cpu/cache.c\n@@ -61,12 +61,7 @@ void\tdcache_enable (void) {\n \n void\tdcache_disable(void) {\n #ifdef XILINX_USE_DCACHE\n-#ifdef XILINX_DCACHE_BYTE_SIZE\n \tflush_cache(0, XILINX_DCACHE_BYTE_SIZE);\n-#else\n-#warning please rebuild BSPs and update configuration\n-\tflush_cache(0, 32768);\n-#endif\n #endif\n \tMSRCLR(0x80);\n }\ndiff --git a/arch/microblaze/cpu/start.S b/arch/microblaze/cpu/start.S\nindex 8564c4e..3da711d 100644\n--- a/arch/microblaze/cpu/start.S\n+++ b/arch/microblaze/cpu/start.S\n@@ -132,6 +132,12 @@ _start:\n \trsubi\tr8, r10, 0x26\n \tsh\tr6, r0, r8\n \n+\t/* Flush cache before enable cache */\n+\taddik\tr5, r0, 0\n+\taddik\tr6, r0, XILINX_DCACHE_BYTE_SIZE\n+flush:\tbralid r15, flush_cache\n+\tnop\n+\n \t/* enable instruction and data cache */\n \tmfs\tr12, rmsr\n \tori\tr12, r12, 0xa0\ndiff --git a/arch/microblaze/lib/bootm.c b/arch/microblaze/lib/bootm.c\nindex 95cee50..66d21f4 100644\n--- a/arch/microblaze/lib/bootm.c\n+++ b/arch/microblaze/lib/bootm.c\n@@ -70,12 +70,7 @@ int do_bootm_linux(int flag, int argc, char * const argv[], bootm_headers_t *ima\n #endif\n \n #ifdef XILINX_USE_DCACHE\n-#ifdef XILINX_DCACHE_BYTE_SIZE\n \tflush_cache(0, XILINX_DCACHE_BYTE_SIZE);\n-#else\n-#warning please rebuild BSPs and update configuration\n-\tflush_cache(0, 32768);\n-#endif\n #endif\n \t/*\n \t * Linux Kernel Parameters (passing device tree):\ndiff --git a/include/configs/microblaze-generic.h b/include/configs/microblaze-generic.h\nindex 721cd90..eed38c1 100644\n--- a/include/configs/microblaze-generic.h\n+++ b/include/configs/microblaze-generic.h\n@@ -287,6 +287,10 @@\n # undef CONFIG_DCACHE\n #endif\n \n+#ifndef XILINX_DCACHE_BYTE_SIZE\n+#define XILINX_DCACHE_BYTE_SIZE\t32768\n+#endif\n+\n /*\n * BOOTP options\n */\n", "prefixes": [ "U-Boot", "3/4" ] }