Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1869539/?format=api
{ "id": 1869539, "url": "http://patchwork.ozlabs.org/api/patches/1869539/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-arc/patch/2-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com/", "project": { "id": 48, "url": "http://patchwork.ozlabs.org/api/projects/48/?format=api", "name": "Linux ARC development", "link_name": "linux-arc", "list_id": "linux-snps-arc.lists.infradead.org", "list_email": "linux-snps-arc@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<2-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com>", "list_archive_url": null, "date": "2023-11-29T00:47:58", "name": "[02/10] iommmu/of: Do not return struct iommu_ops from of_iommu_configure()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dc53ba5436d268e97cb46c059e186bf69a1241bc", "submitter": { "id": 79424, "url": "http://patchwork.ozlabs.org/api/people/79424/?format=api", "name": "Jason Gunthorpe", "email": "jgg@nvidia.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-arc/patch/2-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com/mbox/", "series": [ { "id": 384302, "url": "http://patchwork.ozlabs.org/api/series/384302/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-arc/list/?series=384302", "date": "2023-11-29T00:47:56", "name": "IOMMU related FW parsing cleanup", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/384302/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1869539/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1869539/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=U5yXP9Lj;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=ZJQi99M4;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Sg10r4Wcqz23nk\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Nov 2023 11:49:00 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux))\n\tid 1r88l7-006iYa-2F;\n\tWed, 29 Nov 2023 00:48:57 +0000", "from mail-bn7nam10on20622.outbound.protection.outlook.com\n ([2a01:111:f400:7e8a::622]\n helo=NAM10-BN7-obe.outbound.protection.outlook.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux))\n\tid 1r88kg-006hyx-0c;\n\tWed, 29 Nov 2023 00:48:33 +0000", "from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16)\n by MW5PR12MB5649.namprd12.prod.outlook.com (2603:10b6:303:19d::13) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.22; Wed, 29 Nov\n 2023 00:48:13 +0000", "from LV2PR12MB5869.namprd12.prod.outlook.com\n ([fe80::60d4:c1e3:e1aa:8f93]) by LV2PR12MB5869.namprd12.prod.outlook.com\n ([fe80::60d4:c1e3:e1aa:8f93%4]) with mapi id 15.20.7025.022; Wed, 29 Nov 2023\n 00:48:13 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=GbLb5MyvEGDjGOGPnE1uBu/NK114DjCxWIMMHTt7aa8=; b=U5yXP9LjJfsOZ3\n\t43QBzV9x9Vp2mbTHNcTY6OcaeIRVv4NH/M13uqprD6nRdWsQ/2CwGnwAQTwZvwI7n3xmvTVzvlSSx\n\tznViyuCOB+brYK9dx/bl3bsWVQcVtTspcxTQRZs9GUslOZ0fTcroLVggNUbNoZkKs9sh426WaJugt\n\tGy5Wewux/WUJb3bXUzEXAfJuDLAZfPTKgXngRMLABqjHNc9dvCmdC4NPp31MkUDI3SJODDbExmBsw\n\trX5DS3E6b6RZsKc7+MS1hUb7o7gOTQLy5kQGdRx9BnsA0X+9MGwSpOqX4/x7Rdq+paE1tePV7okJD\n\t3FEQ3cyeu+ChL7PpM5AQ==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=CEH2NAQP0Rp8Qva78ZZohlMQPFWgOfDuspF0jY5yoiU=;\n b=ZJQi99M4THw4F1RGtkOAbNPg1H096/9FUqGzcT4PukVWc6kfs0ntEZdozG7FbkXgA/v3oT0nfUH4c10CF0NBYmANt4rAunCWyPtnGPKMhmyDDlHezk4bG/C570NiI1s0jSMFCleb5rb0ci4fY+rGUbl4g7g+iXmAVnRGebfanITk3uzf92kOsWB3bYGSs77WxBXsz0SIMuvV1TnW7m8G1+X3Jr8Cxu8B8DVNrKW06EphF9BIRXGsDnXkEsFfR7LzJ41VfZHG8/+6WHIrD8hfMWrtKMIAkv4yzb/Wn+LYlfgA3KVCESaV/XQYtJftVFHuHNL3LOBBv6848U5L/rJ9/Q==" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ITJDgSFTkAI9hcHtFHza18oL0hFkfGkYLrsMK/+/S7N8lraCPdVaNRsJd+mrhNyxeFMdEBcZqO+SD5epwhnivdaasrh4YnCtg+vAmdq/qYbwZ+5nEpJFgSWk0AQJV+eA+I179KTd9RYCYHw8Ni1bLFQmmr8zNZkqarwgUnSCxxKX+fT1l1J7xXyV7wyJ8sUYBqq9pLf4E+qG0kVFrmMoiDXBHUfWAQiiyZTA9KQswLe/SCYJ9r3WiQtbag3yqmXIRk4QLDJEwflQS21NeFdDevwuYWZ4S6TV9T9VlKhebt3yRD1ief0xjvK9QYZh/WLEb3li6+dVawKT9JxZRAfWHQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=CEH2NAQP0Rp8Qva78ZZohlMQPFWgOfDuspF0jY5yoiU=;\n b=XrKPb0Yv3bmGFn3rbUEuVkyQEPIlEO+plJqDmvEfULrKfkuTQ6W+a/MUo3wgq1DRibKX+hvj7fxfbmR7CKVnlpDiq2QV8mpNEShAFII9W9rdBsMHt3ftpPYMrIibfmBahqqTCImnGZRJ3bp1716ZlIhY7UCJ+V4e6f/jqOfK7ryVCt5FyWDyfjpmu1hGePR33vVGNtLhlJomNWd4/A2Y5j9eYMPcD08Ty1sFwld2RoLR8P8KXORt1o2tMpZf68fX+URvuV/3IfsZuzaGr+Ko4XljD7PD7wneOADBSwLBmQNQs9rWgu3TLKTnrAp1MU7+ZcF3iWNEgVNJYt+vA2i/1w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none", "From": "Jason Gunthorpe <jgg@nvidia.com>", "To": "David Airlie <airlied@gmail.com>,\n\tAlyssa Rosenzweig <alyssa@rosenzweig.io>,\n\tAlbert Ou <aou@eecs.berkeley.edu>,\n\tasahi@lists.linux.dev,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tDanilo Krummrich <dakr@redhat.com>,\n\tDaniel Vetter <daniel@ffwll.ch>,\n\tDexuan Cui <decui@microsoft.com>,\n\tdevicetree@vger.kernel.org,\n\tdmaengine@vger.kernel.org,\n\tdri-devel@lists.freedesktop.org,\n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tFrank Rowand <frowand.list@gmail.com>,\n\tHanjun Guo <guohanjun@huawei.com>,\n\tHaiyang Zhang <haiyangz@microsoft.com>,\n\tiommu@lists.linux.dev,\n\tJon Hunter <jonathanh@nvidia.com>,\n\tJoerg Roedel <joro@8bytes.org>,\n\tKarol Herbst <kherbst@redhat.com>,\n\tKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,\n\t\"K. Y. Srinivasan\" <kys@microsoft.com>,\n\tLaxman Dewangan <ldewangan@nvidia.com>,\n\tLen Brown <lenb@kernel.org>,\n\tlinux-acpi@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-hyperv@vger.kernel.org,\n\tlinux-mips@vger.kernel.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-snps-arc@lists.infradead.org,\n\tlinux-tegra@vger.kernel.org,\n\tRussell King <linux@armlinux.org.uk>,\n\tLorenzo Pieralisi <lpieralisi@kernel.org>,\n\tLyude Paul <lyude@redhat.com>,\n\tMarek Szyprowski <m.szyprowski@samsung.com>,\n\tnouveau@lists.freedesktop.org,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tPaul Walmsley <paul.walmsley@sifive.com>,\n\t\"Rafael J. Wysocki\" <rafael@kernel.org>,\n\tRob Herring <robh+dt@kernel.org>,\n\tRobin Murphy <robin.murphy@arm.com>,\n\tSudeep Holla <sudeep.holla@arm.com>,\n\tSuravee Suthikulpanit <suravee.suthikulpanit@amd.com>,\n\tSven Peter <sven@svenpeter.dev>,\n\tThomas Bogendoerfer <tsbogend@alpha.franken.de>,\n\tVineet Gupta <vgupta@kernel.org>,\n\tVinod Koul <vkoul@kernel.org>,\n\tWei Liu <wei.liu@kernel.org>,\n\tWill Deacon <will@kernel.org>", "Cc": "Lu Baolu <baolu.lu@linux.intel.com>,\n\tChristoph Hellwig <hch@lst.de>,\n\tJerry Snitselaar <jsnitsel@redhat.com>,\n\tHector Martin <marcan@marcan.st>,\n\tMoritz Fischer <mdf@kernel.org>,\n\tpatches@lists.linux.dev,\n\t\"Rafael J. Wysocki\" <rafael.j.wysocki@intel.com>,\n\tRob Herring <robh@kernel.org>,\n\tThierry Reding <thierry.reding@gmail.com>", "Subject": "[PATCH 02/10] iommmu/of: Do not return struct iommu_ops from\n of_iommu_configure()", "Date": "Tue, 28 Nov 2023 20:47:58 -0400", "Message-ID": "<2-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com>", "In-Reply-To": "<0-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com>", "References": "", "X-ClientProxiedBy": "SN6PR05CA0011.namprd05.prod.outlook.com\n (2603:10b6:805:de::24) To LV2PR12MB5869.namprd12.prod.outlook.com\n (2603:10b6:408:176::16)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "LV2PR12MB5869:EE_|MW5PR12MB5649:EE_", "X-MS-Office365-Filtering-Correlation-Id": "f92f5945-2a58-42a8-3f7e-08dbf074dba1", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n TNU9Nc56M2GNSx5gMKa29y+BfTLeDaly8sgITbBvzSpGEBDJe5eq8lzPCfHyXxcq6NJDqe65T9ORTGJk2YqZ6yftHOEUxf1VfnpIY+zlcqQQrfh21WZoYQUN8WnsaMyxT8fZ78CoxlZSQfTGf4rhnJbpOwLqhfXYWL3v+r/uY/+iuCzPFDNUh425G9VbCmy2exEdVmSvwIK6u1206aJohk8j5CB3hAPrvdzaT2enZiSAUfhFKyZhGLTSwil9YNPN4vZSzHqjP6PJs+sCFRxsUD6qaaC1okRY8GhsUXgjR20J6vAPf7MwQXcpVWZVc78JJLazleeq2UYakWciUkfE2QwCZ6mKxsp+IL2OE+zW66FZTQoZ34g6tMeDIUo1Xn8fv8idQajNfI/MDlMmUHAw96Tp7LKAGZBInxkEuBm/IfXtJQZXgwnlHOZjN9FxAN8qyw2wwJyBZZG0DICuJI+RppHGp6MvJZkrpReY2Fg+xqu8QO9T29oD9dr/RTdYje9GOVldRy1WP68nJKvo5JSiSOokusrVGegR+DxFUR8Vvn3G4S5ImwPGAKjNCxACqYeSkat7mVS49GsNfce0gBAkkCg9NvWXj42KzEQFddiVekIzqxF5ZHQoLnBO6deFXa5Y", "X-Forefront-Antispam-Report": "\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(39860400002)(396003)(366004)(376002)(346002)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(5660300002)(7416002)(7366002)(7406005)(41300700001)(4326008)(8936002)(8676002)(2906002)(110136005)(316002)(66556008)(66476007)(54906003)(66946007)(2616005)(921008)(6486002)(478600001)(36756003)(6512007)(6506007)(26005)(6666004)(83380400001)(86362001)(38100700002)(4216001);DIR:OUT;SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n QoXaJEos8zrhw+/KQMgsmJKOnnICyEY91C1GucNa0r6H1Jhsg3+YfO7wgaISu1H9/I516jNBl9qtJ/SrhfUh+kVf1HVn3FI8yrIwqdMSZLjFAkKZI5Xzub21E/DEFZlyq99Me+LFQtD23UHwnMxFEYQMD2FyJLey7esF8XYYazr98KIwBpsMrHFO8pAVXiWmJKANNvkPoUUITODp1tZXej9unuEFZs7WlZUZI0wHan1hZZB+Y1VyTua1K+FmiMygWhlvvWqeDC2k3KjvJEqBjsZmUDgI2QNB1Qdx7veUChTOYh4RxwYdFxvVyouB3I5YO29D4/R06OhH/SQkpq1FI2FiRorXlBQNcG/+Di8hIxDfBNjpUyGr8OZOXx6oiEq04OzNP4juNWiXDVy70Ii0Tytxza5fX/oOfDdkGG/GXtEfFJpEkkdoxZJZvcN5ZKlsTxtG0rrSnUP0P9x3WYKdlNPXosbTqKz9zrZ6rhC+nkvYiys7Zygb+NRMTe6u9cl8iCd8ZlXjcHMfa4w/kCihj6eyOkNTYWwF0I5+9nl12sOAxhm/Hzyo31jGYhY4H+VPKZuLfXmP1yOBiUh2XTe5rfOIWNsmbTml7kEMJdGVH9v16QoPGmOp2k8+MiDtPH2qvctYQtKOElsu5W9N0jCdBeocZNEV6P6RTXjLRRVLVQPP14qDZ8uJVXep7bv3iyuFawG4Bs5rxHootK61nNC2qE17yXVVk/AewIGGWS2YvsaLMvjU9o9tmuNBL8SBWQ29ui1jeJCWc0TgDAmYVA3fLX+NgqyRftlo+3dC24h0H/Sp/uG+TYjwqnn3LgkFQRzkT+Jrn3zJ5oYk3OldORi/+X4f8lOpSe7DR/Jn7Yp/dAaXisMMRpTTrLuGOwCCx7Fti7pgoludFMPYGKDsHanqCkqD6nRiYTzrM3000vLzhw8gWG183Yalt2r0aotUhG9WRbA8qDckrrDNSmuSbS/vphIWS2DsQAJBPygAg2nQuvE8kGbAbn8ZI4rr/53TKcJjne9zBIcee+H1spt3G4KIGjRdfEjQ0E33giSfuTgKXsEfm+MTnnq+To157aCvp7qtYS0xdunvcGCPWaYQH5bWhKVvRA3UW3OUKabwDplgG9Nk3hJF+xPQy7HBAA8ac8hfGGXeh7Unx+AggXMLX8cpbIKLRyKT3sfgmAewealgZRqscn7lF2A1ez9aKJTe5OAOhgucMFhL8UmxaipZmnVyiFRilyx/jkQhRvGXWIJgNPnn3SbeiKKZZA+XXKOe8c1lqa6cOM3sfm19y6/hqTHLccHIWPMPJuv+rPY3d3olqgTJBKw2yc1OJeXVohsHyAyEA1ynB+ivdNV0YrDebzcjO0lPLsF+G8RbNoxxyacQZIK0pZY3whlVXlwlYHIXxq472Gm6Je3iWKUz+daILd+F25QtUN5z2gQomMFJwSMCENEbGg/CgC7aUQrr5Z+95mhbIN05hvPqlv0/R05XdNS2/jUr3KR06M+51JhRB2569kQtSqwz/cvYL+ikokBgC6YBwWQMcrQ5NoElSVcFyyNGPk26uAHlJEU7MUZEwkNYS1MQcpyxbA2iGbFDoiSi4uaZ", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n f92f5945-2a58-42a8-3f7e-08dbf074dba1", "X-MS-Exchange-CrossTenant-AuthSource": "LV2PR12MB5869.namprd12.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "29 Nov 2023 00:48:09.6197\n (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n dyh/uRIgbBig3OtDbjljalNXcPjxXk2zIhbwrInbAOFSs91usD860fVYGvBVSsdo", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW5PR12MB5649", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20231128_164830_271682_DE597EED ", "X-CRM114-Status": "GOOD ( 20.69 )", "X-Spam-Score": "0.6 (/)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Nothing needs this pointer. Return a normal error code with\n the usual IOMMU semantic that ENODEV means 'there is no IOMMU driver'.\n Reviewed-by:\n Jerry Snitselaar <jsnitsel@redhat.com> Acked-by: Rob Herring\n <robh@kernel.org>\n Tested-by: Hector Martin <marcan@marcan.st> Signed-off-by: Jason Gunthorpe\n <jgg@nvidia.com> --- drivers/iomm [...]\n Content analysis details: (0.6 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 SPF_NONE SPF: sender does not publish an SPF Record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily\n valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 1.0 FORGED_SPF_HELO No description available.\n -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "linux-snps-arc@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux on Synopsys ARC Processors <linux-snps-arc.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-snps-arc>,\n <mailto:linux-snps-arc-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-snps-arc/>", "List-Post": "<mailto:linux-snps-arc@lists.infradead.org>", "List-Help": "<mailto:linux-snps-arc-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-snps-arc>,\n <mailto:linux-snps-arc-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-snps-arc\" <linux-snps-arc-bounces@lists.infradead.org>", "Errors-To": "\n linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Nothing needs this pointer. Return a normal error code with the usual\nIOMMU semantic that ENODEV means 'there is no IOMMU driver'.\n\nReviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>\nAcked-by: Rob Herring <robh@kernel.org>\nTested-by: Hector Martin <marcan@marcan.st>\nSigned-off-by: Jason Gunthorpe <jgg@nvidia.com>\n---\n drivers/iommu/of_iommu.c | 31 +++++++++++++++++++------------\n drivers/of/device.c | 22 +++++++++++++++-------\n include/linux/of_iommu.h | 13 ++++++-------\n 3 files changed, 40 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c\nindex 5ecca53847d325..c6510d7e7b241b 100644\n--- a/drivers/iommu/of_iommu.c\n+++ b/drivers/iommu/of_iommu.c\n@@ -107,16 +107,22 @@ static int of_iommu_configure_device(struct device_node *master_np,\n \t\t of_iommu_configure_dev(master_np, dev);\n }\n \n-const struct iommu_ops *of_iommu_configure(struct device *dev,\n-\t\t\t\t\t struct device_node *master_np,\n-\t\t\t\t\t const u32 *id)\n+/*\n+ * Returns:\n+ * 0 on success, an iommu was configured\n+ * -ENODEV if the device does not have any IOMMU\n+ * -EPROBEDEFER if probing should be tried again\n+ * -errno fatal errors\n+ */\n+int of_iommu_configure(struct device *dev, struct device_node *master_np,\n+\t\t const u32 *id)\n {\n \tconst struct iommu_ops *ops = NULL;\n \tstruct iommu_fwspec *fwspec;\n \tint err = NO_IOMMU;\n \n \tif (!master_np)\n-\t\treturn NULL;\n+\t\treturn -ENODEV;\n \n \t/* Serialise to make dev->iommu stable under our potential fwspec */\n \tmutex_lock(&iommu_probe_device_lock);\n@@ -124,7 +130,7 @@ const struct iommu_ops *of_iommu_configure(struct device *dev,\n \tif (fwspec) {\n \t\tif (fwspec->ops) {\n \t\t\tmutex_unlock(&iommu_probe_device_lock);\n-\t\t\treturn fwspec->ops;\n+\t\t\treturn 0;\n \t\t}\n \t\t/* In the deferred case, start again from scratch */\n \t\tiommu_fwspec_free(dev);\n@@ -169,14 +175,15 @@ const struct iommu_ops *of_iommu_configure(struct device *dev,\n \t\terr = iommu_probe_device(dev);\n \n \t/* Ignore all other errors apart from EPROBE_DEFER */\n-\tif (err == -EPROBE_DEFER) {\n-\t\tops = ERR_PTR(err);\n-\t} else if (err < 0) {\n-\t\tdev_dbg(dev, \"Adding to IOMMU failed: %d\\n\", err);\n-\t\tops = NULL;\n+\tif (err < 0) {\n+\t\tif (err == -EPROBE_DEFER)\n+\t\t\treturn err;\n+\t\tdev_dbg(dev, \"Adding to IOMMU failed: %pe\\n\", ERR_PTR(err));\n+\t\treturn err;\n \t}\n-\n-\treturn ops;\n+\tif (!ops)\n+\t\treturn -ENODEV;\n+\treturn 0;\n }\n \n static enum iommu_resv_type __maybe_unused\ndiff --git a/drivers/of/device.c b/drivers/of/device.c\nindex 65c71be71a8d45..873d933e8e6d1d 100644\n--- a/drivers/of/device.c\n+++ b/drivers/of/device.c\n@@ -93,12 +93,12 @@ of_dma_set_restricted_buffer(struct device *dev, struct device_node *np)\n int of_dma_configure_id(struct device *dev, struct device_node *np,\n \t\t\tbool force_dma, const u32 *id)\n {\n-\tconst struct iommu_ops *iommu;\n \tconst struct bus_dma_region *map = NULL;\n \tstruct device_node *bus_np;\n \tu64 dma_start = 0;\n \tu64 mask, end, size = 0;\n \tbool coherent;\n+\tint iommu_ret;\n \tint ret;\n \n \tif (np == dev->of_node)\n@@ -181,21 +181,29 @@ int of_dma_configure_id(struct device *dev, struct device_node *np,\n \tdev_dbg(dev, \"device is%sdma coherent\\n\",\n \t\tcoherent ? \" \" : \" not \");\n \n-\tiommu = of_iommu_configure(dev, np, id);\n-\tif (PTR_ERR(iommu) == -EPROBE_DEFER) {\n+\tiommu_ret = of_iommu_configure(dev, np, id);\n+\tif (iommu_ret == -EPROBE_DEFER) {\n \t\t/* Don't touch range map if it wasn't set from a valid dma-ranges */\n \t\tif (!ret)\n \t\t\tdev->dma_range_map = NULL;\n \t\tkfree(map);\n \t\treturn -EPROBE_DEFER;\n-\t}\n+\t} else if (iommu_ret == -ENODEV) {\n+\t\tdev_dbg(dev, \"device is not behind an iommu\\n\");\n+\t} else if (iommu_ret) {\n+\t\tdev_err(dev, \"iommu configuration for device failed with %pe\\n\",\n+\t\t\tERR_PTR(iommu_ret));\n \n-\tdev_dbg(dev, \"device is%sbehind an iommu\\n\",\n-\t\tiommu ? \" \" : \" not \");\n+\t\t/*\n+\t\t * Historically this routine doesn't fail driver probing\n+\t\t * due to errors in of_iommu_configure()\n+\t\t */\n+\t} else\n+\t\tdev_dbg(dev, \"device is behind an iommu\\n\");\n \n \tarch_setup_dma_ops(dev, dma_start, size, coherent);\n \n-\tif (!iommu)\n+\tif (iommu_ret)\n \t\tof_dma_set_restricted_buffer(dev, np);\n \n \treturn 0;\ndiff --git a/include/linux/of_iommu.h b/include/linux/of_iommu.h\nindex 9a5e6b410dd2fb..e61cbbe12dac6f 100644\n--- a/include/linux/of_iommu.h\n+++ b/include/linux/of_iommu.h\n@@ -8,20 +8,19 @@ struct iommu_ops;\n \n #ifdef CONFIG_OF_IOMMU\n \n-extern const struct iommu_ops *of_iommu_configure(struct device *dev,\n-\t\t\t\t\tstruct device_node *master_np,\n-\t\t\t\t\tconst u32 *id);\n+extern int of_iommu_configure(struct device *dev, struct device_node *master_np,\n+\t\t\t const u32 *id);\n \n extern void of_iommu_get_resv_regions(struct device *dev,\n \t\t\t\t struct list_head *list);\n \n #else\n \n-static inline const struct iommu_ops *of_iommu_configure(struct device *dev,\n-\t\t\t\t\t struct device_node *master_np,\n-\t\t\t\t\t const u32 *id)\n+static inline int of_iommu_configure(struct device *dev,\n+\t\t\t\t struct device_node *master_np,\n+\t\t\t\t const u32 *id)\n {\n-\treturn NULL;\n+\treturn -ENODEV;\n }\n \n static inline void of_iommu_get_resv_regions(struct device *dev,\n", "prefixes": [ "02/10" ] }