Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1869530/?format=api
{ "id": 1869530, "url": "http://patchwork.ozlabs.org/api/patches/1869530/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-arc/patch/5-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com/", "project": { "id": 48, "url": "http://patchwork.ozlabs.org/api/projects/48/?format=api", "name": "Linux ARC development", "link_name": "linux-arc", "list_id": "linux-snps-arc.lists.infradead.org", "list_email": "linux-snps-arc@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<5-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com>", "list_archive_url": null, "date": "2023-11-29T00:48:01", "name": "[05/10] iommu: Mark dev_iommu_priv_set() with a lockdep", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e5e522d1f1f995b28b59d51860cb7a2e860d494b", "submitter": { "id": 79424, "url": "http://patchwork.ozlabs.org/api/people/79424/?format=api", "name": "Jason Gunthorpe", "email": "jgg@nvidia.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-arc/patch/5-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com/mbox/", "series": [ { "id": 384302, "url": "http://patchwork.ozlabs.org/api/series/384302/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-arc/list/?series=384302", "date": "2023-11-29T00:47:56", "name": "IOMMU related FW parsing cleanup", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/384302/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1869530/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1869530/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=vcL46VRB;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=Ag0rU854;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Sg10L3gCpz1ySY\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Nov 2023 11:48:34 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux))\n\tid 1r88kh-006i7T-2K;\n\tWed, 29 Nov 2023 00:48:31 +0000", "from mail-bn7nam10on20614.outbound.protection.outlook.com\n ([2a01:111:f400:7e8a::614]\n helo=NAM10-BN7-obe.outbound.protection.outlook.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux))\n\tid 1r88kW-006hsr-0t;\n\tWed, 29 Nov 2023 00:48:22 +0000", "from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16)\n by MW5PR12MB5649.namprd12.prod.outlook.com (2603:10b6:303:19d::13) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.22; Wed, 29 Nov\n 2023 00:48:10 +0000", "from LV2PR12MB5869.namprd12.prod.outlook.com\n ([fe80::60d4:c1e3:e1aa:8f93]) by LV2PR12MB5869.namprd12.prod.outlook.com\n ([fe80::60d4:c1e3:e1aa:8f93%4]) with mapi id 15.20.7025.022; Wed, 29 Nov 2023\n 00:48:10 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=jpodW08LgvMjPJOw22iYXzbGvmVdHfNKGc0JQl0t/3k=; b=vcL46VRBKMsWwE\n\tEN9PhzGYosL1cbZcJ8+0ApUTWtU/BZtqISQO7S4KkKskS1GVnfibtVqTOhT+zoTYNOctUMlaaoHs5\n\t8gyZnIEwf1WHXDEt6c+ZNWsgRBQgM3XVjrAp7h77aCGFusxXQprXeYtF9rQq0urlzeb1rM7I6E99z\n\t60lcFPfmxOPtnSRAKQuOT/iDTKsn6GTDF/LqMxgo671/Z2NraO7fBKs4bNOpMrdHlTMZd2+epfWIA\n\tRA3vi8ANAlZuTUYML4VjuBnIj/5oZ4ClQ48VwoqwQEW3pAF2jeCpwlrwKZLus6Idpb87Yc0NmFHGz\n\tX78dFo5Sw8NiX/JOpasw==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=GPakWZHYvHors5WFXL2bapVjFF3wl8GrN0XWXN4rPVI=;\n b=Ag0rU854tJH60xOPDaD/u5zg9CfPodJc4i5mTPa5gBLmnYjeJlhMPF+mTTtgrQAG23NbPDE9oAXIqsU40xoQx9HOcGQGsNO7M2l2MJgP/E+LdEiI0tbStUdOrL82AJPtfA717QBwbIe6TlnCvqt6F5L0p0TazbQko9kZ3MOZ3RsCV1mfBVejksBgYtUPIqfr2nqIzUbA6rrIxyEI2gaMkRfycVLg3X6eDPjkUfQ/lrM3p5abYb06S0daViUsWjRumaAPFB0xzSMNS00ZgXqmW2z0f27dRFq4wF7xroYgSg10/Uwb3YKpWH9Fi+L05kyZyzbOPMuzSMiNoCIx/4HZmw==" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=epFQZzGvPg20YK61GY/0NW1+KQ+3x4jg5XKP2mEQpMkCxpbyKutrvaeeT0U3nfr975MCPuVDIfxMgBTKl1ZmtTqifkU5drUFNFTljzLATJgakhwyE9HMBH7LWLLsoOcXmIz9OJLh+kQbHbbBSptWPxX8g3b/u2Z/5/k7urxV1Ov2cl2Ie7U6IVGwZRh1AJtR1Oq5ocPHvIjR355/2/skKDOBZm09ltiv0w9X752dIrfkc3jxzenFm0tWerOaNVkliExtqLeZWB66SQrMh2CTK7AYlYzAHsDeGqKsOJvLVUHWhHDn37YMaHQKVKH0V/VGT2UtO82n+7nUYv3Bq2f4ag==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=GPakWZHYvHors5WFXL2bapVjFF3wl8GrN0XWXN4rPVI=;\n b=aALj6puZVU5xzPw6otZHvyUs9JNxdMLzTcHc3FSaEmUCKi5yHZLKrp6aG8EfKMev9XftiSye5FnXZU2PTkalIZtP6ig6EOsuhFFe/70DwMdJTo6jijYuhDC3AKAWQq4jviN64Uz+wMg96L7L/pgjashsDgV1nKj9dhZ1a56J0C1PcdHSsiRaXo6BJlb2MYGtlsJdS9kimNf2Stb3gaZcQasFztIDbNNodRgrK9lit4w6+pze3Ob1NdXG6y3zP9e60QlmzgEG10LGX4ithFdq4qIr8VoPa3c2SEh/jE/Ep1DbQNqV8ukEDOgtpzaJFtZGxoOE1HskXy06ZcuPmePamw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none", "From": "Jason Gunthorpe <jgg@nvidia.com>", "To": "David Airlie <airlied@gmail.com>,\n\tAlyssa Rosenzweig <alyssa@rosenzweig.io>,\n\tAlbert Ou <aou@eecs.berkeley.edu>,\n\tasahi@lists.linux.dev,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tDanilo Krummrich <dakr@redhat.com>,\n\tDaniel Vetter <daniel@ffwll.ch>,\n\tDexuan Cui <decui@microsoft.com>,\n\tdevicetree@vger.kernel.org,\n\tdmaengine@vger.kernel.org,\n\tdri-devel@lists.freedesktop.org,\n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tFrank Rowand <frowand.list@gmail.com>,\n\tHanjun Guo <guohanjun@huawei.com>,\n\tHaiyang Zhang <haiyangz@microsoft.com>,\n\tiommu@lists.linux.dev,\n\tJon Hunter <jonathanh@nvidia.com>,\n\tJoerg Roedel <joro@8bytes.org>,\n\tKarol Herbst <kherbst@redhat.com>,\n\tKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,\n\t\"K. Y. Srinivasan\" <kys@microsoft.com>,\n\tLaxman Dewangan <ldewangan@nvidia.com>,\n\tLen Brown <lenb@kernel.org>,\n\tlinux-acpi@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-hyperv@vger.kernel.org,\n\tlinux-mips@vger.kernel.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-snps-arc@lists.infradead.org,\n\tlinux-tegra@vger.kernel.org,\n\tRussell King <linux@armlinux.org.uk>,\n\tLorenzo Pieralisi <lpieralisi@kernel.org>,\n\tLyude Paul <lyude@redhat.com>,\n\tMarek Szyprowski <m.szyprowski@samsung.com>,\n\tnouveau@lists.freedesktop.org,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tPaul Walmsley <paul.walmsley@sifive.com>,\n\t\"Rafael J. Wysocki\" <rafael@kernel.org>,\n\tRob Herring <robh+dt@kernel.org>,\n\tRobin Murphy <robin.murphy@arm.com>,\n\tSudeep Holla <sudeep.holla@arm.com>,\n\tSuravee Suthikulpanit <suravee.suthikulpanit@amd.com>,\n\tSven Peter <sven@svenpeter.dev>,\n\tThomas Bogendoerfer <tsbogend@alpha.franken.de>,\n\tVineet Gupta <vgupta@kernel.org>,\n\tVinod Koul <vkoul@kernel.org>,\n\tWei Liu <wei.liu@kernel.org>,\n\tWill Deacon <will@kernel.org>", "Cc": "Lu Baolu <baolu.lu@linux.intel.com>,\n\tChristoph Hellwig <hch@lst.de>,\n\tJerry Snitselaar <jsnitsel@redhat.com>,\n\tHector Martin <marcan@marcan.st>,\n\tMoritz Fischer <mdf@kernel.org>,\n\tpatches@lists.linux.dev,\n\t\"Rafael J. Wysocki\" <rafael.j.wysocki@intel.com>,\n\tRob Herring <robh@kernel.org>,\n\tThierry Reding <thierry.reding@gmail.com>", "Subject": "[PATCH 05/10] iommu: Mark dev_iommu_priv_set() with a lockdep", "Date": "Tue, 28 Nov 2023 20:48:01 -0400", "Message-ID": "<5-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com>", "In-Reply-To": "<0-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com>", "References": "", "X-ClientProxiedBy": "SA9P223CA0008.NAMP223.PROD.OUTLOOK.COM\n (2603:10b6:806:26::13) To LV2PR12MB5869.namprd12.prod.outlook.com\n (2603:10b6:408:176::16)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "LV2PR12MB5869:EE_|MW5PR12MB5649:EE_", "X-MS-Office365-Filtering-Correlation-Id": "e88e5898-d817-4847-c6f3-08dbf074da91", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n rgANoarTBWKnyjqZqIYXEl2mPTVN+nMaMwCAU1TyUvtAj1jv6+jBXL1mJK1VcTwp5KhZsUCdmaBY+Tzo7S64zoTwsOKhRs9qwfiS5LDCTL522D/7IFCgy2SYIqC+2SfCzmXDltCHaikpWh/9EHiMQY7wZ8D4EjIcWraeyxIVPiSjJWLjj1JKjjyAsFoKiZ9imoR35JzlNujG1eZfhc5c2N13iuNyBUiGugNkw9KWKcMEZMx1LTM83FUVWe6NgUFMXEkQzfeEKGs4uBujftG+kki3i+N7LObsANvyZe91c8q0CDt4ebS6bRmNFC29JznHovWHfhdR78RNypvGcx3wWiHgbMsA0/Umz5zi1R/hl50XgNFFdossmRmz47OU48KdW+HXWaKK0xbl7IJ13SJIspNzkLHMNI3+V01XLnkC6T70lPWT4lfrCDpdJOGUVHyhR7KCfchXHGQA4XNVMIaHl5IkGoX4x1nvEvuXdtAAF/3pAKewIvk/8zp8GCCjQFyei9ms966aOqn5oEwpsIR2dTvmX/z2QKJKfWBjOla/Mw0bhPu/AOugxKTR37AFP4yunhb7JOvMdmme9VDJIHh39fgmzH32oAiDvFNZtds/Vc3RD2KSOWldv7XbqiuyI2yS", "X-Forefront-Antispam-Report": "\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(39860400002)(396003)(366004)(376002)(346002)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(5660300002)(7416002)(7366002)(7406005)(41300700001)(4326008)(8936002)(8676002)(2906002)(110136005)(316002)(66556008)(66476007)(54906003)(66946007)(2616005)(921008)(6486002)(478600001)(36756003)(6512007)(6506007)(26005)(6666004)(83380400001)(86362001)(38100700002)(4216001);DIR:OUT;SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n OPVIl6+Au+z4F37cddz/VvvSeyIpE8y1PwNznFfquIdqbCyBGLElTq9XlzXphqQiLa5jZz8as0mKlle0zqRdAtiMZD/7GK571yeTzwLmaPToVECPC6tBbIXIOJPOZYJcIHxjx089BswJUoUgI9/kkRgX1SDCg0ca1b1ElxYajE1WGQjYvt0UkRQRS/5eJZvhE66Wi4akv+DryqYPp9vWghx/YbuAC1G5DJSWJmdh93lFqfxRjMH+xU4NQ70cm+WytpS5+3M5+Rh1KQZOwQ3tCbtlAA0PrdPTBDYX+8sWzPGUnygIvA2UK3Ny1fRjgaCyJ2lGSZ2SvxHUDMZEKnMX33zXIA90y/GcVJjFt76XVkjZqRBZCL53b0z3xGu3CFtqA1v1s4r7hoQJXPS6+39c2Hj4hMdAD1j7vj7aMTBuYfHBjBiZpN1j0V3XUTaQthyH35n167qFkHjShYFO+vyz/K1g4KclAEUKOCVJQGsbkLGI1NhXvDXRgQg7buM9c7bsK/5K2qT1jdOE7nKnavuAuOTJJAw+QAJ22nifjE2McOKRdajBQA16GBn57eEfEKz9plV4TloPSZFhc8f1ZeTHdae0fU2IAMPY9sbWV8MBb6HdFj/cBBYWNzIrBmPOMByD8fO0fyrj7kvR1N25oxp9+/id6MDYvgEkdOXOCWIBUFdi1iL2i2BtMHidNC8H7h+H7QPSlV9APNlvqRvxPyjPZaKVPIFfpuumj2RA4FBpc6ON5fllQsV0pBW/2lF+CIGDn4Zi9nHOr/zwqSUB7xw+yT2q2tioBruXQGkPGhs95g0OkPgxsIom0C9g0PIUP9Xa2TcQrNILZRFODl0d0KyoBJ3UgB5bKWhk3ZYnvYUMw+UX39AmKi6BXYipq/ltVsliZ8+JfkX0UFXRgWQTYPZUUwFY9jW6wxS1+hbg0lIposKnhBsr8g+HYvJayUxpRP737hxIApajsx/5FbEpcd7dFpOm96TwNvjqVTlz2ijwO1B3jZa98zMmVLAwPHOcD9j8VGxpuwXobuGSdContI0WsSD0ieK1C/pBDU/a+q/wMYN2ZQhqNZXC3ZGAFEKfVOOuOkZPO7Tq+nGD/V9OSrv29j6Dlmhx/2RhcHmmvLNIn+2O7Ea+T3KqhmjS52EZkVPi5XJA4ogriXcke49GD0/Qf2l2yobXtX1D5xSfKdESO7ZK/Mlng/ER1BT2XYTfZDmlC2FYx4SmJeYwioONjUbTK7lE7zbhxf7RAA4vgKC3++KavVeLh9y4AjP/EjH3Bcy0QONJrMqGxYsnUzlrMTpuCSXhlDe2MoarJr0QHzftZTSnLEIDLu36TShF8CGp+3yoUp0h7DhauVoPECAWDX35FrHJTT75EHWej/Yus+WxfhiIcQZYKe1b032ivpPp5HDiX0bqWKwMYgUVeyUlHJN6zXiyUlWV5zYgM06Pvu0NghhAVediQUr6UZSbhri7GJn8/i7GhiU9yssG1TAuQlyjNp764fcrTLWeyXrNTSlpK+H8uV5Aqfi6+MbNcp8bb/GV4SYZ178WTtJuxf7AeoSrSldEsf3D2L8Qr1Y1VRBQQz2YGF6jnYrMjGq1aD0XtrjT", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n e88e5898-d817-4847-c6f3-08dbf074da91", "X-MS-Exchange-CrossTenant-AuthSource": "LV2PR12MB5869.namprd12.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "29 Nov 2023 00:48:07.8059\n (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n wCLxYnh0Nz04x6MvAHftLs2Aq4/fyuwGZWn/kVmvb8d2fHv5lLYPqJ8YE50aJedN", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW5PR12MB5649", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20231128_164820_322695_4D035654 ", "X-CRM114-Status": "GOOD ( 17.51 )", "X-Spam-Score": "0.6 (/)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: A perfect driver would only call dev_iommu_priv_set() from\n its probe callback. We've made it functionally correct to call it from the\n of_xlate by adding a lock around that call. lockdep assert that\n iommu_probe_device_lock\n is held to discourage misuse.\n Content analysis details: (0.6 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 SPF_NONE SPF: sender does not publish an SPF Record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily\n valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 1.0 FORGED_SPF_HELO No description available.\n -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "linux-snps-arc@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux on Synopsys ARC Processors <linux-snps-arc.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-snps-arc>,\n <mailto:linux-snps-arc-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-snps-arc/>", "List-Post": "<mailto:linux-snps-arc@lists.infradead.org>", "List-Help": "<mailto:linux-snps-arc-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-snps-arc>,\n <mailto:linux-snps-arc-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-snps-arc\" <linux-snps-arc-bounces@lists.infradead.org>", "Errors-To": "\n linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "A perfect driver would only call dev_iommu_priv_set() from its probe\ncallback. We've made it functionally correct to call it from the of_xlate\nby adding a lock around that call.\n\nlockdep assert that iommu_probe_device_lock is held to discourage misuse.\n\nExclude PPC kernels with CONFIG_FSL_PAMU turned on because FSL_PAMU uses a\nglobal static for its priv and abuses priv for its domain.\n\nRemove the pointless stores of NULL, all these are on paths where the core\ncode will free dev->iommu after the op returns.\n\nReviewed-by: Lu Baolu <baolu.lu@linux.intel.com>\nReviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>\nTested-by: Hector Martin <marcan@marcan.st>\nSigned-off-by: Jason Gunthorpe <jgg@nvidia.com>\n---\n drivers/iommu/amd/iommu.c | 2 --\n drivers/iommu/apple-dart.c | 1 -\n drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 -\n drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 -\n drivers/iommu/intel/iommu.c | 2 --\n drivers/iommu/iommu.c | 9 +++++++++\n drivers/iommu/omap-iommu.c | 1 -\n include/linux/iommu.h | 5 +----\n 8 files changed, 10 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c\nindex 9f706436082833..be58644a6fa518 100644\n--- a/drivers/iommu/amd/iommu.c\n+++ b/drivers/iommu/amd/iommu.c\n@@ -551,8 +551,6 @@ static void amd_iommu_uninit_device(struct device *dev)\n \tif (dev_data->domain)\n \t\tdetach_device(dev);\n \n-\tdev_iommu_priv_set(dev, NULL);\n-\n \t/*\n \t * We keep dev_data around for unplugged devices and reuse it when the\n \t * device is re-plugged - not doing so would introduce a ton of races.\ndiff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c\nindex 7438e9c82ba982..25135440b5dd54 100644\n--- a/drivers/iommu/apple-dart.c\n+++ b/drivers/iommu/apple-dart.c\n@@ -743,7 +743,6 @@ static void apple_dart_release_device(struct device *dev)\n {\n \tstruct apple_dart_master_cfg *cfg = dev_iommu_priv_get(dev);\n \n-\tdev_iommu_priv_set(dev, NULL);\n \tkfree(cfg);\n }\n \ndiff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c\nindex fc4317c25b6d53..1855d3892b15f8 100644\n--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c\n+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c\n@@ -2695,7 +2695,6 @@ static struct iommu_device *arm_smmu_probe_device(struct device *dev)\n \n err_free_master:\n \tkfree(master);\n-\tdev_iommu_priv_set(dev, NULL);\n \treturn ERR_PTR(ret);\n }\n \ndiff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c\nindex 4d09c004789274..adc7937fd8a3a3 100644\n--- a/drivers/iommu/arm/arm-smmu/arm-smmu.c\n+++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c\n@@ -1420,7 +1420,6 @@ static void arm_smmu_release_device(struct device *dev)\n \n \tarm_smmu_rpm_put(cfg->smmu);\n \n-\tdev_iommu_priv_set(dev, NULL);\n \tkfree(cfg);\n }\n \ndiff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c\nindex 897159dba47de4..511589341074f0 100644\n--- a/drivers/iommu/intel/iommu.c\n+++ b/drivers/iommu/intel/iommu.c\n@@ -4461,7 +4461,6 @@ static struct iommu_device *intel_iommu_probe_device(struct device *dev)\n \t\tret = intel_pasid_alloc_table(dev);\n \t\tif (ret) {\n \t\t\tdev_err(dev, \"PASID table allocation failed\\n\");\n-\t\t\tdev_iommu_priv_set(dev, NULL);\n \t\t\tkfree(info);\n \t\t\treturn ERR_PTR(ret);\n \t\t}\n@@ -4479,7 +4478,6 @@ static void intel_iommu_release_device(struct device *dev)\n \tdmar_remove_one_dev_info(dev);\n \tintel_pasid_free_table(dev);\n \tintel_iommu_debugfs_remove_dev(info);\n-\tdev_iommu_priv_set(dev, NULL);\n \tkfree(info);\n \tset_dma_ops(dev, NULL);\n }\ndiff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c\nindex 4323b6276e977f..08f29a1dfcd5f8 100644\n--- a/drivers/iommu/iommu.c\n+++ b/drivers/iommu/iommu.c\n@@ -387,6 +387,15 @@ static u32 dev_iommu_get_max_pasids(struct device *dev)\n \treturn min_t(u32, max_pasids, dev->iommu->iommu_dev->max_pasids);\n }\n \n+void dev_iommu_priv_set(struct device *dev, void *priv)\n+{\n+\t/* FSL_PAMU does something weird */\n+\tif (!IS_ENABLED(CONFIG_FSL_PAMU))\n+\t\tlockdep_assert_held(&iommu_probe_device_lock);\n+\tdev->iommu->priv = priv;\n+}\n+EXPORT_SYMBOL_GPL(dev_iommu_priv_set);\n+\n /*\n * Init the dev->iommu and dev->iommu_group in the struct device and get the\n * driver probed\ndiff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c\nindex c66b070841dd41..c9528065a59afa 100644\n--- a/drivers/iommu/omap-iommu.c\n+++ b/drivers/iommu/omap-iommu.c\n@@ -1719,7 +1719,6 @@ static void omap_iommu_release_device(struct device *dev)\n \tif (!dev->of_node || !arch_data)\n \t\treturn;\n \n-\tdev_iommu_priv_set(dev, NULL);\n \tkfree(arch_data);\n \n }\ndiff --git a/include/linux/iommu.h b/include/linux/iommu.h\nindex c7394b39599c84..c24933a1d0d643 100644\n--- a/include/linux/iommu.h\n+++ b/include/linux/iommu.h\n@@ -840,10 +840,7 @@ static inline void *dev_iommu_priv_get(struct device *dev)\n \t\treturn NULL;\n }\n \n-static inline void dev_iommu_priv_set(struct device *dev, void *priv)\n-{\n-\tdev->iommu->priv = priv;\n-}\n+void dev_iommu_priv_set(struct device *dev, void *priv);\n \n extern struct mutex iommu_probe_device_lock;\n int iommu_probe_device(struct device *dev);\n", "prefixes": [ "05/10" ] }