Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1861460/?format=api
{ "id": 1861460, "url": "http://patchwork.ozlabs.org/api/patches/1861460/?format=api", "web_url": "http://patchwork.ozlabs.org/project/rtc-linux/patch/20231108104343.24192-12-krzysztof.kozlowski@linaro.org/", "project": { "id": 9, "url": "http://patchwork.ozlabs.org/api/projects/9/?format=api", "name": "Linux RTC development", "link_name": "rtc-linux", "list_id": "linux-rtc.vger.kernel.org", "list_email": "linux-rtc@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20231108104343.24192-12-krzysztof.kozlowski@linaro.org>", "list_archive_url": null, "date": "2023-11-08T10:43:37", "name": "[11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "1370879d8f5ccfa7a3479574c75b94d3e5d668bf", "submitter": { "id": 83726, "url": "http://patchwork.ozlabs.org/api/people/83726/?format=api", "name": "Krzysztof Kozlowski", "email": "krzysztof.kozlowski@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/rtc-linux/patch/20231108104343.24192-12-krzysztof.kozlowski@linaro.org/mbox/", "series": [ { "id": 381299, "url": "http://patchwork.ozlabs.org/api/series/381299/?format=api", "web_url": "http://patchwork.ozlabs.org/project/rtc-linux/list/?series=381299", "date": "2023-11-08T10:43:27", "name": "dt-bindings: samsung: add specific compatibles for existing SoC", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/381299/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1861460/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1861460/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-rtc+bounces-232-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-rtc@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Psapt02Z;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=147.75.199.223; helo=ny.mirrors.kernel.org;\n envelope-from=linux-rtc+bounces-232-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=\"Psapt02Z\"" ], "Received": [ "from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4SQMCw165tz1yRP\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 8 Nov 2023 21:44:44 +1100 (AEDT)", "from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ny.mirrors.kernel.org (Postfix) with ESMTPS id 4B2031C20D9B\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 8 Nov 2023 10:44:42 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5273512E78;\n\tWed, 8 Nov 2023 10:44:40 +0000 (UTC)", "from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net\n [23.128.96.19])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CE97512E60\n\tfor <linux-rtc@vger.kernel.org>; Wed, 8 Nov 2023 10:44:38 +0000 (UTC)", "from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n [IPv6:2a00:1450:4864:20::435])\n\tby lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB32C26A3\n\tfor <linux-rtc@vger.kernel.org>; Wed, 8 Nov 2023 02:44:37 -0800 (PST)", "by mail-wr1-x435.google.com with SMTP id\n ffacd0b85a97d-32faea0fa1fso375364f8f.1\n for <linux-rtc@vger.kernel.org>; Wed, 08 Nov 2023 02:44:37 -0800 (PST)", "from krzk-bin.. ([178.197.218.126])\n by smtp.gmail.com with ESMTPSA id\n fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Nov 2023 02:44:35 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1699440276; x=1700045076;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fGiEI+OsEJo1M0u1Cd6qitBsDMBm2mmYId37rcw3fhE=;\n b=Psapt02ZaVLYsotjjTD3flBAqRFY0KEBdrfcegaOovtOOXrzFO+KY8ERw1j9pOotqA\n FiqBSylaG1c3YrVAhmtRcDO/jNV3aDi8brvU053zkAUutA6JjFmXbNKOLhmJZdNHF0hp\n a0uzHxZjXSywAjad6U0RSLJIvuI4FXbiN5OYGVrfnkXGyqTvfOhEhUKZPcUhDxCor82q\n Vq9L+XnHYKeZwAZeTBnM9oI3wqfLhn/ER/0Cias06jSUMDSJcsdvDWOwJeuRMgr80wDh\n WH3QP2IkbtlJhcjB8sxFZVSfJbIt2vIcPkPWjtelwWizbj7igEJgYCAxAYKEMgS5ZuKy\n cXvg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1699440276; x=1700045076;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=fGiEI+OsEJo1M0u1Cd6qitBsDMBm2mmYId37rcw3fhE=;\n b=HRpe4lndWIc7NQaSJzELXOwzttq4jmigakDQpNTr8F+/tAK+xqsF65kX2EUePjZudV\n gQq/gGjVngSVgQ75oIU3dnkFLCjHQIGB4Ex6FhL5H5NA27C0uB59VJeyBwhMrEe0gm68\n z4jTxoTamHxNALr4GaWcgJVgOgTyjj/F64q+dKL4kCQTnxsnmhkGGtNNpZ/W4MYHLiw9\n Ry+xbra0e8vbsHkZab3aybAO1X9+YXak62ZqBrO0O7NMi5Q9VAUmfZpDWQO0/fJbOvNB\n CbUMvyqtUrtTo5IJGlycs3KaG8mmzF/EqpcGZOVIrH+d3FPJWtCNn6F8ZjayabsZly7Y\n GTJA==", "X-Gm-Message-State": "AOJu0Yx3VD33tXUdg3vsEpbY0O5S6uWfKXF3SGXAGhyRWkU1LJLa+AtD\n\t7zt24/JNJQs1kkA/ZLLOGcxzMA==", "X-Google-Smtp-Source": "\n AGHT+IH7MQXw4E1mPFEKg813JtQdA84Wn0PvEKQEX8huqjOTZRExGYnzsA13byMaAL83CD1YOh5HLg==", "X-Received": "by 2002:adf:fd09:0:b0:32f:7beb:d009 with SMTP id\n e9-20020adffd09000000b0032f7bebd009mr1610826wrr.17.1699440276267;\n Wed, 08 Nov 2023 02:44:36 -0800 (PST)", "From": "Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>", "To": "David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,\n Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,\n Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,\n Rob Herring <robh+dt@kernel.org>,\n Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,\n Conor Dooley <conor+dt@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>,\n Andi Shyti <andi.shyti@kernel.org>, Jonathan Cameron <jic23@kernel.org>,\n Lars-Peter Clausen <lars@metafoo.de>, Lee Jones <lee@kernel.org>,\n Ulf Hansson <ulf.hansson@linaro.org>, Tomasz Figa <tomasz.figa@gmail.com>,\n Sylwester Nawrocki <s.nawrocki@samsung.com>,\n Linus Walleij <linus.walleij@linaro.org>,\n Thierry Reding <thierry.reding@gmail.com>,\n =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,\n Alessandro Zummo <a.zummo@towertech.it>,\n Alexandre Belloni <alexandre.belloni@bootlin.com>,\n Greg Kroah-Hartman <gregkh@linuxfoundation.org>,\n Jiri Slaby <jirislaby@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,\n Mark Brown <broonie@kernel.org>, Jaehoon Chung <jh80.chung@samsung.com>,\n Sam Protsenko <semen.protsenko@linaro.org>, dri-devel@lists.freedesktop.org,\n devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org,\n linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org,\n linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org,\n linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org,\n linux-serial@vger.kernel.org, alsa-devel@alsa-project.org,\n linux-sound@vger.kernel.org", "Cc": "Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>", "Subject": "[PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific\n compatibles for existing SoC", "Date": "Wed, 8 Nov 2023 11:43:37 +0100", "Message-Id": "<20231108104343.24192-12-krzysztof.kozlowski@linaro.org>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231108104343.24192-1-krzysztof.kozlowski@linaro.org>", "References": "<20231108104343.24192-1-krzysztof.kozlowski@linaro.org>", "Precedence": "bulk", "X-Mailing-List": "linux-rtc@vger.kernel.org", "List-Id": "<linux-rtc.vger.kernel.org>", "List-Subscribe": "<mailto:linux-rtc+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-rtc+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Samsung Exynos SoC reuses several devices from older designs, thus\nhistorically we kept the old (block's) compatible only. This works fine\nand there is no bug here, however guidelines expressed in\nDocumentation/devicetree/bindings/writing-bindings.rst state that:\n1. Compatibles should be specific.\n2. We should add new compatibles in case of bugs or features.\n\nAdd compatibles specific to each SoC in front of all old-SoC-like\ncompatibles.\n\nSigned-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>\n\n---\n\nI propose to take the patch through Samsung SoC (me). See cover letter\nfor explanation.\n---\n .../mfd/samsung,exynos5433-lpass.yaml | 2 +-\n .../bindings/sound/samsung-i2s.yaml | 19 ++++++++++++-------\n 2 files changed, 13 insertions(+), 8 deletions(-)", "diff": "diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml\nindex b97b06848729..f154103f32cc 100644\n--- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml\n+++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml\n@@ -85,7 +85,7 @@ examples:\n };\n \n i2s@11440000 {\n- compatible = \"samsung,exynos7-i2s\";\n+ compatible = \"samsung,exynos5433-i2s\", \"samsung,exynos7-i2s\";\n reg = <0x11440000 0x100>;\n dmas = <&adma 0>, <&adma 2>;\n dma-names = \"tx\", \"rx\";\ndiff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml\nindex 30b3b6e9824b..f45f73b5056d 100644\n--- a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml\n+++ b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml\n@@ -44,13 +44,18 @@ properties:\n frequencies supported by Exynos7 I2S and 7.1 channel TDM support\n for playback and capture TDM (Time division multiplexing) to allow\n transfer of multiple channel audio data on single data line.\n- enum:\n- - samsung,s3c6410-i2s\n- - samsung,s5pv210-i2s\n- - samsung,exynos5420-i2s\n- - samsung,exynos7-i2s\n- - samsung,exynos7-i2s1\n- - tesla,fsd-i2s\n+ oneOf:\n+ - enum:\n+ - samsung,s3c6410-i2s\n+ - samsung,s5pv210-i2s\n+ - samsung,exynos5420-i2s\n+ - samsung,exynos7-i2s\n+ - samsung,exynos7-i2s1\n+ - tesla,fsd-i2s\n+ - items:\n+ - enum:\n+ - samsung,exynos5433-i2s\n+ - const: samsung,exynos7-i2s\n \n '#address-cells':\n const: 1\n", "prefixes": [ "11/17" ] }