Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1861449/?format=api
{ "id": 1861449, "url": "http://patchwork.ozlabs.org/api/patches/1861449/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/patch/20231108104343.24192-4-krzysztof.kozlowski@linaro.org/", "project": { "id": 38, "url": "http://patchwork.ozlabs.org/api/projects/38/?format=api", "name": "Linux PWM development", "link_name": "linux-pwm", "list_id": "linux-pwm.vger.kernel.org", "list_email": "linux-pwm@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20231108104343.24192-4-krzysztof.kozlowski@linaro.org>", "list_archive_url": null, "date": "2023-11-08T10:43:29", "name": "[03/17] dt-bindings: i2c: samsung,s3c2410-i2c: add specific compatibles for existing SoC", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "3ae1e1ac17d7d273e501fce0b4477f0a369ea43d", "submitter": { "id": 83726, "url": "http://patchwork.ozlabs.org/api/people/83726/?format=api", "name": "Krzysztof Kozlowski", "email": "krzysztof.kozlowski@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pwm/patch/20231108104343.24192-4-krzysztof.kozlowski@linaro.org/mbox/", "series": [ { "id": 381296, "url": "http://patchwork.ozlabs.org/api/series/381296/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/list/?series=381296", "date": "2023-11-08T10:43:26", "name": "dt-bindings: samsung: add specific compatibles for existing SoC", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/381296/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1861449/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1861449/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-pwm-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=EOetgq+E;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-pwm-owner@vger.kernel.org; receiver=patchwork.ozlabs.org)" ], "Received": [ "from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby legolas.ozlabs.org (Postfix) with ESMTP id 4SQMCc2X3qz1yRP\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 8 Nov 2023 21:44:28 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1344386AbjKHKo3 (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n Wed, 8 Nov 2023 05:44:29 -0500", "from lindbergh.monkeyblade.net ([23.128.96.19]:59796 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S1344485AbjKHKoN (ORCPT\n <rfc822;linux-pwm@vger.kernel.org>); Wed, 8 Nov 2023 05:44:13 -0500", "from mail-lj1-x235.google.com (mail-lj1-x235.google.com\n [IPv6:2a00:1450:4864:20::235])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FF6A1FCE\n for <linux-pwm@vger.kernel.org>; Wed, 8 Nov 2023 02:44:08 -0800 (PST)", "by mail-lj1-x235.google.com with SMTP id\n 38308e7fff4ca-2c6ef6c1ec2so82458071fa.2\n for <linux-pwm@vger.kernel.org>; Wed, 08 Nov 2023 02:44:08 -0800 (PST)", "from krzk-bin.. ([178.197.218.126])\n by smtp.gmail.com with ESMTPSA id\n fj12-20020a05600c0c8c00b004094c5d92bdsm19377377wmb.31.2023.11.08.02.44.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Nov 2023 02:44:06 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1699440246; x=1700045046;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rrZs4emLFc9OjGPQr8NhVrDcx8agcy43Q5wHxC/jdF8=;\n b=EOetgq+EAIJ05W+ev4Wve0IkHGcFdIgWzLuewJbfEdOGqJjFEFe8kcgNE0SuvRUuaQ\n dO/nz8qBrD/EzIaTI59GRsQJdwxl5RvMzWrWOpHF4Z78GkC6qPhNXbCvl/D/YVY7Y3IC\n 8Eibq8xaXG7jcEEz5Ry2H13xyrJC8IjBaxTxbS6+0oS7l15n8Xp92jSMOrmktjluwXRp\n o/oRde/0wfDPvjSaVmFeDqrxIlb5wtt8SWBJ55/7nDv8DF7YwxXhvuPvo8ItTGdaWPxJ\n NvJGHqUqwz8unWRDPSNe+2tT6fONv1FsSyN5tVyOnoh13ULf8z1LNIjCObfDuAliGtSI\n P8zw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1699440246; x=1700045046;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=rrZs4emLFc9OjGPQr8NhVrDcx8agcy43Q5wHxC/jdF8=;\n b=EvH7Irjx0XxEIeeE04TmnFBVTZYv53O2qwvbJVru4z0WeVfCwKtawm3u1S/aaQzEJZ\n Ur7evMMxI8yj3oTgVRth3RdJC9S/vPiJlST49FqArh5xhPK34dcqU1r69zPSrzWaTdHW\n Dp2WvBMrmXAoNRnbE9TWMl1Fy8Nlw9Qac5vSoBwOdHufeh211vibyS2tYgU4hxkOeUiM\n XFwvf3IzRHTxe9NeNZaWRPdO7Kz/ueH56L6AedDO8VVmc5NCy7vKAcztWL4gFFS0WoA+\n 1xc1FwomqdPl2EbeIIZhpTYlXH/6Heys+qJGvIaeeepqRJhsXvmZiLXj3B/Vpbw5VmaI\n hcpw==", "X-Gm-Message-State": "AOJu0YxPl8zL58fnR9/GGU3tP7/eq9jh1GNgJ3lx+G75o9r+Ih/No3kb\n PY+vr0jrxGfAd+uymyeCpNeHFg==", "X-Google-Smtp-Source": "\n AGHT+IGa+2sMFPnXDCg+/Kp94WpmPGqJxAqZSoI9EBPYbrrl77NmQH95hc0MBEym2E6Wk3ngRYzA3Q==", "X-Received": "by 2002:a05:651c:19ab:b0:2b6:fa3f:9230 with SMTP id\n bx43-20020a05651c19ab00b002b6fa3f9230mr1578553ljb.46.1699440246534;\n Wed, 08 Nov 2023 02:44:06 -0800 (PST)", "From": "Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>", "To": "David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,\n Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,\n Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,\n Rob Herring <robh+dt@kernel.org>,\n Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,\n Conor Dooley <conor+dt@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>,\n Andi Shyti <andi.shyti@kernel.org>, Jonathan Cameron <jic23@kernel.org>,\n Lars-Peter Clausen <lars@metafoo.de>, Lee Jones <lee@kernel.org>,\n Ulf Hansson <ulf.hansson@linaro.org>, Tomasz Figa <tomasz.figa@gmail.com>,\n Sylwester Nawrocki <s.nawrocki@samsung.com>,\n Linus Walleij <linus.walleij@linaro.org>,\n Thierry Reding <thierry.reding@gmail.com>,\n =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,\n Alessandro Zummo <a.zummo@towertech.it>,\n Alexandre Belloni <alexandre.belloni@bootlin.com>,\n Greg Kroah-Hartman <gregkh@linuxfoundation.org>,\n Jiri Slaby <jirislaby@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,\n Mark Brown <broonie@kernel.org>, Jaehoon Chung <jh80.chung@samsung.com>,\n Sam Protsenko <semen.protsenko@linaro.org>, dri-devel@lists.freedesktop.org,\n devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org,\n linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org,\n linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org,\n linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org,\n linux-serial@vger.kernel.org, alsa-devel@alsa-project.org,\n linux-sound@vger.kernel.org", "Cc": "Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>", "Subject": "[PATCH 03/17] dt-bindings: i2c: samsung,s3c2410-i2c: add specific\n compatibles for existing SoC", "Date": "Wed, 8 Nov 2023 11:43:29 +0100", "Message-Id": "<20231108104343.24192-4-krzysztof.kozlowski@linaro.org>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231108104343.24192-1-krzysztof.kozlowski@linaro.org>", "References": "<20231108104343.24192-1-krzysztof.kozlowski@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Precedence": "bulk", "List-ID": "<linux-pwm.vger.kernel.org>", "X-Mailing-List": "linux-pwm@vger.kernel.org" }, "content": "Samsung Exynos SoC reuses several devices from older designs, thus\nhistorically we kept the old (block's) compatible only. This works fine\nand there is no bug here, however guidelines expressed in\nDocumentation/devicetree/bindings/writing-bindings.rst state that:\n1. Compatibles should be specific.\n2. We should add new compatibles in case of bugs or features.\n\nAdd compatibles specific to each SoC in front of all old-SoC-like\ncompatibles.\n\nSigned-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>\n\n---\n\nI propose to take the patch through Samsung SoC (me). See cover letter\nfor explanation.\n---\n .../bindings/i2c/samsung,s3c2410-i2c.yaml | 22 ++++++++++++-------\n 1 file changed, 14 insertions(+), 8 deletions(-)", "diff": "diff --git a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml\nindex b204e35e4f8d..1303502cf265 100644\n--- a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml\n+++ b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml\n@@ -11,14 +11,20 @@ maintainers:\n \n properties:\n compatible:\n- enum:\n- - samsung,s3c2410-i2c\n- - samsung,s3c2440-i2c\n- # For s3c2440-like I2C used inside HDMIPHY block found on several SoCs:\n- - samsung,s3c2440-hdmiphy-i2c\n- # For s3c2440-like I2C used as a host to SATA PHY controller on an\n- # internal bus:\n- - samsung,exynos5-sata-phy-i2c\n+ oneOf:\n+ - enum:\n+ - samsung,s3c2410-i2c\n+ - samsung,s3c2440-i2c\n+ # For s3c2440-like I2C used inside HDMIPHY block found on several SoCs:\n+ - samsung,s3c2440-hdmiphy-i2c\n+ # For s3c2440-like I2C used as a host to SATA PHY controller on an\n+ # internal bus:\n+ - samsung,exynos5-sata-phy-i2c\n+ - items:\n+ - enum:\n+ - samsung,exynos7885-i2c\n+ - samsung,exynos850-i2c\n+ - const: samsung,s3c2440-i2c\n \n '#address-cells':\n const: 1\n", "prefixes": [ "03/17" ] }